This is an archive of the discontinued LLVM Phabricator instance.

Differential D82012

[llvm-objcopy] Merging tool-help-text tests
ClosedPublic

Authored by sameerarora101 on Jun 17 2020, 7:01 AM.

Details

Reviewers
alexander-shaposhnikov
jhenderson
smeenai
Ktwu
• espindola
rupprecht
MaskRay
Commits
rG395920a61493: [llvm-objcopy] Update help message tests
Summary

Merges the help message test for strip, objcopy and install-name-tool
under tool-help-message.test. Depends on D81907

Diff Detail

Event Timeline

sameerarora101 created this revision.Jun 17 2020, 7:01 AM
Herald added a reviewer: • espindola. · View Herald TranscriptJun 17 2020, 7:01 AM
Herald added a reviewer: rupprecht. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: llvm-commits, abrachet, MaskRay, emaste. · View Herald Transcript
jhenderson accepted this revision.Jun 17 2020, 8:08 AM

LGTM, thanks!

This revision is now accepted and ready to land.Jun 17 2020, 8:08 AM
Harbormaster completed remote builds in B60633: Diff 271364.Jun 17 2020, 9:09 AM
sameerarora101 updated this revision to Diff 272752.Jun 23 2020, 9:18 AM

Rebasing again

Harbormaster completed remote builds in B61416: Diff 272752.Jun 23 2020, 10:43 AM
sameerarora101 updated this revision to Diff 272799.Jun 23 2020, 12:36 PM

Rebase

Harbormaster completed remote builds in B61440: Diff 272799.Jun 23 2020, 1:59 PM
MaskRay accepted this revision.Jun 23 2020, 3:35 PM

Looks great!

alexander-shaposhnikov accepted this revision.Jun 24 2020, 11:22 AM

LG

Closed by commit rG395920a61493: [llvm-objcopy] Update help message tests (authored by alexander-shaposhnikov). · Explain WhyJun 24 2020, 1:02 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
test/
tools/
llvm-objcopy/
ELF/
MachO/
tool-help-message.test/
ELF/
help-message.test
10 lines

Diff 273136

llvm/test/tools/llvm-objcopy/ELF/help-message.test

  • This file was moved to llvm/test/tools/llvm-objcopy/tool-help-message.test.

llvm/test/tools/llvm-objcopy/MachO/install-name-tool-help-message.test

  • This file was deleted.
# RUN: llvm-install-name-tool -h | FileCheck --check-prefix=INSTALL-NAME-TOOL-USAGE %s --match-full-lines
# RUN: llvm-install-name-tool --help | FileCheck --check-prefix=INSTALL-NAME-TOOL-USAGE %s --match-full-lines
# RUN: not llvm-install-name-tool 2>&1 | FileCheck --check-prefix=INSTALL-NAME-TOOL-USAGE %s --match-full-lines
# RUN: not llvm-install-name-tool -abcabc 2>&1 | FileCheck --check-prefix=UNKNOWN-ARG %s
# RUN: not llvm-install-name-tool --abcabc 2>&1 | FileCheck --check-prefix=UNKNOWN-ARG %s
# INSTALL-NAME-TOOL-USAGE: USAGE: llvm-install-name-tool [options] input
# INSTALL-NAME-TOOL-USAGE: Pass @FILE as argument to read options from FILE.
# UNKNOWN-ARG: unknown argument '{{-+}}abcabc'

llvm/test/tools/llvm-objcopy/tool-help-message.test

  • This file was moved from llvm/test/tools/llvm-objcopy/ELF/help-message.test.
# RUN: llvm-objcopy -h | FileCheck --check-prefix=OBJCOPY-USAGE %s --match-full-lines # RUN: llvm-objcopy -h | FileCheck --check-prefix=OBJCOPY-USAGE %s --match-full-lines
# RUN: llvm-objcopy --help | FileCheck --check-prefix=OBJCOPY-USAGE %s --match-full-lines # RUN: llvm-objcopy --help | FileCheck --check-prefix=OBJCOPY-USAGE %s --match-full-lines
# RUN: not llvm-objcopy 2>&1 | FileCheck --check-prefix=OBJCOPY-USAGE %s --match-full-lines # RUN: not llvm-objcopy 2>&1 | FileCheck --check-prefix=OBJCOPY-USAGE %s --match-full-lines
# RUN: not llvm-objcopy -abcabc 2>&1 | FileCheck --check-prefix=UNKNOWN-ARG %s # RUN: not llvm-objcopy -abcabc 2>&1 | FileCheck --check-prefix=UNKNOWN-ARG %s
# RUN: not llvm-objcopy --abcabc 2>&1 | FileCheck --check-prefix=UNKNOWN-ARG %s # RUN: not llvm-objcopy --abcabc 2>&1 | FileCheck --check-prefix=UNKNOWN-ARG %s
# RUN: not llvm-objcopy --strip-debug 2>&1 | FileCheck %s --check-prefix=NO-INPUT-FILES # RUN: not llvm-objcopy --strip-debug 2>&1 | FileCheck %s --check-prefix=NO-INPUT-FILES
# RUN: llvm-strip -h | FileCheck --check-prefix=STRIP-USAGE %s --match-full-lines # RUN: llvm-strip -h | FileCheck --check-prefix=STRIP-USAGE %s --match-full-lines
# RUN: llvm-strip --help | FileCheck --check-prefix=STRIP-USAGE %s --match-full-lines # RUN: llvm-strip --help | FileCheck --check-prefix=STRIP-USAGE %s --match-full-lines
# RUN: not llvm-strip 2>&1 | FileCheck --check-prefix=STRIP-USAGE %s --match-full-lines # RUN: not llvm-strip 2>&1 | FileCheck --check-prefix=STRIP-USAGE %s --match-full-lines
# RUN: not llvm-strip -abcabc 2>&1 | FileCheck --check-prefix=UNKNOWN-ARG %s # RUN: not llvm-strip -abcabc 2>&1 | FileCheck --check-prefix=UNKNOWN-ARG %s
# RUN: not llvm-strip --abcabc 2>&1 | FileCheck --check-prefix=UNKNOWN-ARG %s # RUN: not llvm-strip --abcabc 2>&1 | FileCheck --check-prefix=UNKNOWN-ARG %s
# RUN: not llvm-strip --strip-debug 2>&1 | FileCheck %s --check-prefix=NO-INPUT-FILES # RUN: not llvm-strip --strip-debug 2>&1 | FileCheck %s --check-prefix=NO-INPUT-FILES
# RUN: llvm-install-name-tool -h | FileCheck --check-prefix=INSTALL-NAME-TOOL-USAGE %s --match-full-lines
# RUN: llvm-install-name-tool --help | FileCheck --check-prefix=INSTALL-NAME-TOOL-USAGE %s --match-full-lines
# RUN: not llvm-install-name-tool 2>&1 | FileCheck --check-prefix=INSTALL-NAME-TOOL-USAGE %s --match-full-lines
# RUN: not llvm-install-name-tool -abcabc 2>&1 | FileCheck --check-prefix=UNKNOWN-ARG %s
# RUN: not llvm-install-name-tool --abcabc 2>&1 | FileCheck --check-prefix=UNKNOWN-ARG %s
# RUN: not llvm-install-name-tool -add_rpath @executable 2>&1 | FileCheck %s --check-prefix=NO-INPUT-FILES
# OBJCOPY-USAGE: USAGE: llvm-objcopy [options] input [output] # OBJCOPY-USAGE: USAGE: llvm-objcopy [options] input [output]
# OBJCOPY-USAGE: Pass @FILE as argument to read options from FILE. # OBJCOPY-USAGE: Pass @FILE as argument to read options from FILE.
# STRIP-USAGE: USAGE: llvm-strip [options] inputs... # STRIP-USAGE: USAGE: llvm-strip [options] inputs...
# STRIP-USAGE: Pass @FILE as argument to read options from FILE. # STRIP-USAGE: Pass @FILE as argument to read options from FILE.
# INSTALL-NAME-TOOL-USAGE: USAGE: llvm-install-name-tool [options] input
# INSTALL-NAME-TOOL-USAGE: Pass @FILE as argument to read options from FILE.
# UNKNOWN-ARG: unknown argument '{{-+}}abcabc' # UNKNOWN-ARG: unknown argument '{{-+}}abcabc'
# NO-INPUT-FILES: no input file specified # NO-INPUT-FILES: no input file specified