Rebase.

unordered_map -> map to guarantee deterministic output across platforms.

Add 2 more tests for file not found.

Reorder architectures in test.

Rebase to resolve previous build errors.

Rebase to remove previous build errors.

Rebase.

Resolve test on windows (order in which architectures appear in test file).

Add more tests.

Use unordered_map in place of DenseMap.

Remove redundant braces.

In D84770#2214390, @smeenai wrote:

LGTM.

Let's commit this one as-is, and you can add arm64v8 to TextAPI and add the corresponding test here as a follow-up.

Add another test to check that files ending in '.o' are matched as-is.

Use lambda function.

Replace auto.

Add tests for different cpu types.

Add more tests.

Make ArchCPUType and ArchCPUSubtype part of Config.

Add Temp->dicard() error.

In D84770#2208826, @smeenai wrote:

In D84770#2204147, @sameerarora101 wrote:

I think I need to add V8 support under llvm/include/llvm/TextAPI/MachO/Architecture.def here:

///
/// ARM64 architectures sorted by cpu sub type id.
///
ARCHINFO(arm64, MachO::CPU_TYPE_ARM64, MachO::CPU_SUBTYPE_ARM64_ALL, 64)
ARCHINFO(arm64e, MachO::CPU_TYPE_ARM64, MachO::CPU_SUBTYPE_ARM64E, 64)

What should be the first element for that tuple in case of V8 (arm64_v8 or arm64v8 or maybe something else) ? Thanks.

Hmm, what necessitates the TAPI patch? arm64_v8 seems fine to me, though @ributzka and @cishida should weigh in there.

Remove extra lines.

This is how it would look online:

I think I need to add V8 support under llvm/include/llvm/TextAPI/MachO/Architecture.def here:

Rebase after adding constant V8.

Adding more tests and resolve clang-tidy

Rebase.

Rebase.

Twine(Path).str() -> static_cast<std::string>(Path)

Remove --check-prefix=FAT.

In D84858#2195417, @MaskRay wrote:

Looks good, but I think it'll help if you can upload the dependent patch (draft) so that people can see that the interface is suitable.

Closing revision as the issue has been addressed.

Removing OldArchiveBuf from writeArchiveToBuffer signature.

Update tests.

Implement writeArchiveBuffer using SmallVectorMemoryBuffer.

Add test for llvm-readobj

Invalid architecture error msg and consumeError comment.

Change name and signature of writeArchiveBuffer

yup, libtool and install_name_tool are the cctools names.

Alphabetically ordering docs.

Config C -> const Config &C

Making writeArchiveInFD static

Add documentation for -arch_only option.

Rebase

Add Config struct.