Extract subvectors and cast to the result element type before
remerging.
Details
Diff Detail
Event Timeline
LGTM with a nit
llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp | ||
---|---|---|
2214 | Remove unnecessary assignment to SrcReg |
llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp | ||
---|---|---|
2214 | This assignment is quite necessary to change the types remerged below |
llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp | ||
---|---|---|
2214 | I don't see where this is used though? You are reassigning the loop variable SrcReg and down below you use SrcRegs, not SrcReg. Sorry if I'm just blind here and am missing something obvious :) |
llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp | ||
---|---|---|
2214 | This is rewriting the elements of SrcRegs |
llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp | ||
---|---|---|
2214 | D'oh, of course. That makes a lot of sense. Thank you! |
Remove unnecessary assignment to SrcReg