Page MenuHomePhabricator

gargaroff (Dominik Montada)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 5 2019, 12:39 AM (83 w, 4 d)

Recent Activity

May 3 2021

gargaroff accepted D101227: [DOCS] Added example for G_EXTRACT and G_INSERT.

With the nit fixed, this should be good to go. Thanks!

May 3 2021, 12:35 AM · Restricted Project

Apr 30 2021

gargaroff committed rG97ed1b603607: [GISel] Teach TableGen to check predicates of immediate operands in patterns (authored by gargaroff).
[GISel] Teach TableGen to check predicates of immediate operands in patterns
Apr 30 2021, 1:19 AM
gargaroff closed D91703: [GISel] Teach TableGen to check predicates of immediate operands in patterns.
Apr 30 2021, 1:18 AM · Restricted Project

Apr 29 2021

gargaroff added inline comments to D101227: [DOCS] Added example for G_EXTRACT and G_INSERT.
Apr 29 2021, 11:44 PM · Restricted Project
gargaroff added a comment to D91703: [GISel] Teach TableGen to check predicates of immediate operands in patterns.

Ping

Apr 29 2021, 8:32 AM · Restricted Project

Apr 15 2021

gargaroff added a comment to D91703: [GISel] Teach TableGen to check predicates of immediate operands in patterns.

Ping

Apr 15 2021, 11:02 PM · Restricted Project

Apr 8 2021

gargaroff added a comment to D91703: [GISel] Teach TableGen to check predicates of immediate operands in patterns.

Ping

Apr 8 2021, 5:02 AM · Restricted Project

Apr 6 2021

gargaroff committed rGb78e883fd8b3: [CMake] Fix Python 3 lookup when building LLVM with tests (authored by gargaroff).
[CMake] Fix Python 3 lookup when building LLVM with tests
Apr 6 2021, 4:09 AM
gargaroff closed D99715: [CMake] Fix Python 3 lookup when building LLVM with tests.
Apr 6 2021, 4:09 AM · Restricted Project
gargaroff retitled D99715: [CMake] Fix Python 3 lookup when building LLVM with tests from [CMake] Respect LLVM_MINIMUM_PYTHON_VERSION in Tooling/CMakeLists.txt to [CMake] Fix Python 3 lookup when building LLVM with tests.
Apr 6 2021, 2:14 AM · Restricted Project
gargaroff updated the diff for D99715: [CMake] Fix Python 3 lookup when building LLVM with tests.

Remove find_package call from Tooling/CMakeLists.txt

Apr 6 2021, 2:13 AM · Restricted Project
gargaroff added a comment to D99833: [TableGen] generate `getRegBankFromRegClass`.

Do you plan to revive this at some point? It would be great to move more of the regbank boilerplate from C++ to TableGen

Apr 6 2021, 12:52 AM · Restricted Project

Apr 1 2021

gargaroff added a comment to D99715: [CMake] Fix Python 3 lookup when building LLVM with tests.

Did you try just removing that find_package?

Apr 1 2021, 5:47 AM · Restricted Project
gargaroff added a comment to D99715: [CMake] Fix Python 3 lookup when building LLVM with tests.

Although I find it strange that find_package is called again, even though it is already set through llvm/CMakeLists.txt, this patch does not try to refactor this in any way. The sole purpose is to make tests executable again in our downstream setup.

Apr 1 2021, 3:32 AM · Restricted Project
gargaroff added a comment to D95635: [CMake] Require python 3.6 if enabling LLVM test targets.

This still breaks for us. The find_package(Python3 ...) from Tooling/CMakeLists.txt does not look for the minimum version and overrides the version that was already found through llvm/CMakeLists.txt. I opened D99715 to fix this and added the original reviewers of this patch.

Apr 1 2021, 3:30 AM · Restricted Project, Restricted Project, Restricted Project
gargaroff requested review of D99715: [CMake] Fix Python 3 lookup when building LLVM with tests.
Apr 1 2021, 3:29 AM · Restricted Project

Mar 30 2021

gargaroff updated the diff for D91703: [GISel] Teach TableGen to check predicates of immediate operands in patterns.

Remove unintended change. Rework assertion in InstructionSelectorImpl.h

Mar 30 2021, 12:20 AM · Restricted Project
gargaroff updated the diff for D91703: [GISel] Teach TableGen to check predicates of immediate operands in patterns.

Add comment to SelectionDAGCompat.td

Mar 30 2021, 12:13 AM · Restricted Project

Mar 29 2021

gargaroff added inline comments to D91703: [GISel] Teach TableGen to check predicates of immediate operands in patterns.
Mar 29 2021, 7:29 AM · Restricted Project

Mar 23 2021

gargaroff added inline comments to D91703: [GISel] Teach TableGen to check predicates of immediate operands in patterns.
Mar 23 2021, 5:57 AM · Restricted Project

Mar 9 2021

gargaroff added a comment to D91703: [GISel] Teach TableGen to check predicates of immediate operands in patterns.

At the moment I still cannot find time to work on this, unfortunately. Unless someone has a suggestion for a simple way forward, I'm going to abandon this next week.

Mar 9 2021, 12:34 AM · Restricted Project

Jan 28 2021

gargaroff added a comment to D92902: [llvm-elfabi] Add flag to keep timestamp when output is the same.

Do you mean this patch failed on windows pre-merge checks? It didn't happen when I commit my change though. Do you have a link for that?

I also cannot reproduce the same error on my personal windows desktop using gnuwin32:

C:\Users\Zero\Downloads\GnuBin\GetGnuWin32\bin>touch.exe --help
Usage: touch.exe [OPTION]... FILE...
Update the access and modification times of each FILE to the current time.

Mandatory arguments to long options are mandatory for short options too.
  -a                     change only the access time
  -c, --no-create        do not create any files
  -d, --date=STRING      parse STRING and use it instead of current time
  -f                     (ignored)
  -m                     change only the modification time
  -r, --reference=FILE   use this file's times instead of current time
  -t STAMP               use [[CC]YY]MMDDhhmm[.ss] instead of current time
  --time=WORD            change the specified time:
                           WORD is access, atime, or use: equivalent to -a
                           WORD is modify or mtime: equivalent to -m
      --help     display this help and exit
      --version  output version information and exit

Note that the -d and -t options accept different time-date formats.

Report bugs to <bug-coreutils@gnu.org>.

C:\Users\Zero\Downloads\GnuBin\GetGnuWin32\bin>touch.exe -m -t 197001010000 wget.ini

C:\Users\Zero\Downloads\GnuBin\GetGnuWin32\bin>dir wget.ini
 Volume in drive C has no label.

 Directory of C:\Users\Zero\Downloads\GnuBin\GetGnuWin32\bin

01/01/1970  00:00             4,021 wget.ini
               1 File(s)          4,021 bytes
               0 Dir(s)  1,046,724,939,776 bytes free

C:\Users\Zero\Downloads\GnuBin\GetGnuWin32\bin>

On my machine the touch.exe has no trouble to parse the timestamp used in the unit test.

Jan 28 2021, 12:18 AM · Restricted Project

Jan 27 2021

gargaroff added a comment to D92902: [llvm-elfabi] Add flag to keep timestamp when output is the same.

Hi @haowei !
The tests are failing on Windows with GnuWin32 installed, because touch fails to parse the date string:

Jan 27 2021, 7:33 AM · Restricted Project

Jan 26 2021

gargaroff added a comment to D95375: [MC] Adding MCContext parameter to MCAsmBackend::relaxInstruction.

OK. Currently MCRelaxableFragment encodes just one MCInst. Do you intend to loose the requirement?

Jan 26 2021, 12:07 AM · Restricted Project

Jan 21 2021

gargaroff added a comment to rG71635ea5ffd6: MCDwarf: Delete uneeded parameter.

I'm getting a build error with clang 5.0 and libgcc 5.4.0 after this:

Jan 21 2021, 3:00 AM

Dec 15 2020

gargaroff added inline comments to D91703: [GISel] Teach TableGen to check predicates of immediate operands in patterns.
Dec 15 2020, 3:14 AM · Restricted Project

Dec 7 2020

gargaroff updated the diff for D91703: [GISel] Teach TableGen to check predicates of immediate operands in patterns.

Rebase. Group with GIM_CheckI64ImmPredicate. Change naming to GIM_CheckImmOperandPredicate.

Dec 7 2020, 1:11 AM · Restricted Project

Dec 2 2020

gargaroff added inline comments to D91703: [GISel] Teach TableGen to check predicates of immediate operands in patterns.
Dec 2 2020, 2:48 AM · Restricted Project
gargaroff added inline comments to D91703: [GISel] Teach TableGen to check predicates of immediate operands in patterns.
Dec 2 2020, 12:00 AM · Restricted Project

Nov 23 2020

gargaroff added a reviewer for D91703: [GISel] Teach TableGen to check predicates of immediate operands in patterns: Paul-C-Anagnostopoulos.
Nov 23 2020, 2:16 AM · Restricted Project
gargaroff added a comment to D91703: [GISel] Teach TableGen to check predicates of immediate operands in patterns.

Ping

Nov 23 2020, 1:06 AM · Restricted Project

Nov 18 2020

gargaroff added a comment to D91703: [GISel] Teach TableGen to check predicates of immediate operands in patterns.

I haven't worked that much with TableGen, so if this is already supported or if there is a better way to do this, please let me know.

Nov 18 2020, 6:01 AM · Restricted Project
gargaroff requested review of D91703: [GISel] Teach TableGen to check predicates of immediate operands in patterns.
Nov 18 2020, 6:00 AM · Restricted Project

Nov 11 2020

gargaroff accepted D91182: [libunwind] LIBUNWIND_REMEMBER_HEAP_ALLOC to cmake..

Thank you!

Nov 11 2020, 12:07 AM · Restricted Project, Restricted Project

Nov 10 2020

gargaroff added a comment to D90304: [GlobalISel] Introduce global variant of regbankselect.

I haven't had the time to test this in the new state yet, but I would love to see this integrated. However I'm not in a position to review and approve this. Someone of the GlobalISel folks should do that. As for testing, ideally you could simply leverage the existing tests of the existing GlobalISel backends by enabling this algorithm conditionally. This also requires the approval of those backend maintainers however.

Nov 10 2020, 2:08 AM · Restricted Project
gargaroff added a comment to D85005: [libunwind] Support DW_CFA_remember/restore_state without heap allocation..

Could you add a corresponding CMake option for setting _LIBUNWIND_REMEMBER_HEAP_ALLOC? I don't think it's common to having to enable macros manually when it should just be a configuration option.

Nov 10 2020, 12:30 AM · Restricted Project, Restricted Project

Oct 30 2020

gargaroff added inline comments to D90304: [GlobalISel] Introduce global variant of regbankselect.
Oct 30 2020, 2:54 AM · Restricted Project

Oct 15 2020

gargaroff added a comment to D89392: [GlobalISel] Fold unary opcodes in CSEMIRBuilder.

Let me maybe add a suggestion: in my eyes the big problem here is that the combine that is introduced here can produce potentially illegal instructions, if run during / after the legalizer. So without a check whether the combine would produce something valid, I don't think it's a good idea to implement this.
The other combines are not problematic, since they don't change the types.

Oct 15 2020, 1:16 AM · Restricted Project
gargaroff added a comment to D89392: [GlobalISel] Fold unary opcodes in CSEMIRBuilder.

I just tested the patch in our downstream implementation. While it doesn't cause any infinite loops in our regression tests, it seems to have caused our build bots to crash. I cannot attribute this 100% to this patch though. The crash reason is reported as running out of disk space, but checking all agents still have hundreds of gigs of free space, which is why I suspect that it ran out of memory due to the infinite loops instead. Especially since our nightly runs finished without any hick-ups just hours prior.

Oct 15 2020, 1:13 AM · Restricted Project

Oct 14 2020

gargaroff added a comment to D89392: [GlobalISel] Fold unary opcodes in CSEMIRBuilder.

Is there anything I need to do to use the CSEMIRBuilder?

I think it's enabled by default for some passes, unless you override TargetPassConfig::isGISelCSEEnabled to return false, and enabled in the combiner only if you pass some CSEInfo into combineMachineInstrs, which no in-tree targets do.

Oct 14 2020, 7:53 AM · Restricted Project
gargaroff added a comment to D89392: [GlobalISel] Fold unary opcodes in CSEMIRBuilder.

This looks like something that might be an issue for us downstream, as we have pretty strict legalization rules. I could try to see if it actually causes issues for us. Is there anything I need to do to use the CSEMIRBuilder?

Oct 14 2020, 7:44 AM · Restricted Project
gargaroff committed rG8c03fdf34a65: [libcxxabi,libunwind] support running tests in standalone mode (authored by gargaroff).
[libcxxabi,libunwind] support running tests in standalone mode
Oct 14 2020, 12:10 AM
gargaroff closed D86540: [libcxxabi,libunwind] support running tests in standalone mode.
Oct 14 2020, 12:10 AM · Restricted Project, Restricted Project, Restricted Project
gargaroff added a comment to D86540: [libcxxabi,libunwind] support running tests in standalone mode.

...or not. Seems like the pre-merge checks are down at the moment, so I'll just land it right away. If anything breaks, we can always revert it anyway.

Oct 14 2020, 12:08 AM · Restricted Project, Restricted Project, Restricted Project
gargaroff updated the diff for D86540: [libcxxabi,libunwind] support running tests in standalone mode.

Address final comments.

Oct 14 2020, 12:07 AM · Restricted Project, Restricted Project, Restricted Project

Oct 11 2020

gargaroff added a comment to D86540: [libcxxabi,libunwind] support running tests in standalone mode.

Ping

Oct 11 2020, 11:43 PM · Restricted Project, Restricted Project, Restricted Project

Sep 29 2020

gargaroff committed rG113114a5da60: [GlobalISel] fix widenScalarUnmerge if widen type is not a multiple of… (authored by gargaroff).
[GlobalISel] fix widenScalarUnmerge if widen type is not a multiple of…
Sep 29 2020, 6:52 AM
gargaroff closed D88422: [GlobalISel] fix widenScalarUnmerge if widen type is not a multiple of destination type.
Sep 29 2020, 6:52 AM · Restricted Project

Sep 28 2020

gargaroff updated the diff for D88422: [GlobalISel] fix widenScalarUnmerge if widen type is not a multiple of destination type.

Address review comments

Sep 28 2020, 11:18 PM · Restricted Project
gargaroff updated the diff for D88422: [GlobalISel] fix widenScalarUnmerge if widen type is not a multiple of destination type.

Fix typo

Sep 28 2020, 8:26 AM · Restricted Project
gargaroff added reviewers for D88422: [GlobalISel] fix widenScalarUnmerge if widen type is not a multiple of destination type: aditya_nandakumar, paquette.
Sep 28 2020, 8:17 AM · Restricted Project
gargaroff requested review of D88422: [GlobalISel] fix widenScalarUnmerge if widen type is not a multiple of destination type.
Sep 28 2020, 8:15 AM · Restricted Project
gargaroff added a comment to D86540: [libcxxabi,libunwind] support running tests in standalone mode.

Ping

Sep 28 2020, 7:39 AM · Restricted Project, Restricted Project, Restricted Project

Sep 22 2020

gargaroff added inline comments to D86540: [libcxxabi,libunwind] support running tests in standalone mode.
Sep 22 2020, 12:57 AM · Restricted Project, Restricted Project, Restricted Project
gargaroff added inline comments to D86540: [libcxxabi,libunwind] support running tests in standalone mode.
Sep 22 2020, 12:54 AM · Restricted Project, Restricted Project, Restricted Project
gargaroff updated the diff for D86540: [libcxxabi,libunwind] support running tests in standalone mode.

Reuse LIBUNWIND_LIBCXX_PATH.
Unify HandleOutOfTreeLLVM handling in libcxxabi and libunwind by reusing the one from libcxx.
Define {lib}_STANDALONE_BUILD outside of HandleOutOfTreeLLVM.
Define LLVM_LIT_OUTPUT_DIR outside of HandleOutOfTreeLLVM.

Sep 22 2020, 12:54 AM · Restricted Project, Restricted Project, Restricted Project

Sep 21 2020

gargaroff updated the diff for D86540: [libcxxabi,libunwind] support running tests in standalone mode.

Rebase.
Reuse HandleOutOfTreeLLVM.cmake from libcxx in libunwind.
Define LIBUNWIND_TEST_PARAMS

Sep 21 2020, 6:21 AM · Restricted Project, Restricted Project, Restricted Project

Sep 1 2020

gargaroff planned changes to D86540: [libcxxabi,libunwind] support running tests in standalone mode.

Thanks for the feedback! I'm currently busy with a release, but I'll get back to this afterwards. Don't expect anything for the next two or three weeks.

Sep 1 2020, 11:54 PM · Restricted Project, Restricted Project, Restricted Project

Aug 31 2020

gargaroff added a comment to D86540: [libcxxabi,libunwind] support running tests in standalone mode.

Ping

Aug 31 2020, 5:46 AM · Restricted Project, Restricted Project, Restricted Project

Aug 25 2020

gargaroff added a comment to D86540: [libcxxabi,libunwind] support running tests in standalone mode.

We require this patch for our downstream baremetal target to be able to run the test suites of both libraries on our target.

Aug 25 2020, 7:19 AM · Restricted Project, Restricted Project, Restricted Project
gargaroff requested review of D86540: [libcxxabi,libunwind] support running tests in standalone mode.
Aug 25 2020, 7:14 AM · Restricted Project, Restricted Project, Restricted Project

Aug 17 2020

gargaroff added a comment to D85199: GlobalISel: Add generic instructions for memory intrinsics.

Cast to minimum in IRTranslator. I decided making this a verifier requirement is too strong since some target may have an instruction that looks like memcpy with a different integer size

Aug 17 2020, 5:52 AM · Restricted Project

Aug 4 2020

gargaroff added a comment to D85199: GlobalISel: Add generic instructions for memory intrinsics.

Would it be possible to add support for clampScalar for the size_t argument of these opcodes? Since there is still the problem in the frontend where these intrinsics are created with an incorrect type for the size_t argument, I think that would be useful.
Obviously it would be best to never encounter this case in the backend, but I don't see D76283 landing any time soon, so...

Aug 4 2020, 6:01 AM · Restricted Project

Jul 15 2020

gargaroff abandoned D83390: [GlobalISel][InlineAsm] Extend input operands when register class size does not match type.

I'll abandon this patch since this was committed in https://reviews.llvm.org/rGfd85b40aee4aa4cfcecaf2bfaf86e1de4c78ab0c

Jul 15 2020, 12:28 AM · Restricted Project

Jul 9 2020

gargaroff added a comment to D83390: [GlobalISel][InlineAsm] Extend input operands when register class size does not match type.

A similar issue (for tied input operands) is handled in https://reviews.llvm.org/D83384
The function introduced there should be extended to handle the vector case.

Jul 9 2020, 1:11 AM · Restricted Project

Jul 8 2020

gargaroff updated the diff for D83390: [GlobalISel][InlineAsm] Extend input operands when register class size does not match type.

Forgot to commit final changes before diff

Jul 8 2020, 5:52 AM · Restricted Project
Herald added a project to D83390: [GlobalISel][InlineAsm] Extend input operands when register class size does not match type: Restricted Project.
Jul 8 2020, 5:51 AM · Restricted Project

Jun 30 2020

gargaroff added a comment to rG8bc62db27244: [libc++] Remove support for building through llvm-config.

Does this only discourage out-of-tree builds (e.g. libcxx at /foo/libcxx and llvm at /bar/llvm) or does this also discourage in-tree standalone builds?

Jun 30 2020, 12:30 AM

Jun 19 2020

gargaroff added a comment to D81846: [libc++] Allow specifying custom Lit config files.

Does your compiler support -fno-exceptions? If so, just use --param enable_exceptions=False when running Lit and you're golden.

Jun 19 2020, 12:29 AM · Restricted Project

Jun 18 2020

gargaroff abandoned D81824: [LIBCXX] add possibility to load an additional test configuration to CMake.

From the comments in https://reviews.llvm.org/D81846, it looks like this isn't needed anymore. Let's abandon this review to clear up the review queue.

Thanks for the discussion!

Jun 18 2020, 9:45 AM · Restricted Project

Jun 17 2020

gargaroff added a comment to D81846: [libc++] Allow specifying custom Lit config files.

Ideally we wouldn't need to copy-paste a lot of stuff. It would help me to better understand your specific setup. How do you configure the test suite? Is there some code I can see somewhere?

Jun 17 2020, 2:39 AM · Restricted Project

Jun 16 2020

gargaroff added a comment to D81824: [LIBCXX] add possibility to load an additional test configuration to CMake.

Oh, I just noticed that I forgot to put the link to this Diff in the email earlier. Sorry about that!

Jun 16 2020, 12:30 AM · Restricted Project

Jun 15 2020

gargaroff added a comment to D81846: [libc++] Allow specifying custom Lit config files.

Thanks for this patch. This definitely gets rid of one of the most annoying shortcomings we have at the moment, which is the need to run lit directly when we want to use a custom config.
So with this patch, if I want to use a custom config, I would simply copy-paste all the settings I care about from lit.site.cfg.in, add my own configuration logic and I'd be ready to go?

Jun 15 2020, 11:58 PM · Restricted Project
gargaroff committed rG046566a1d502: [NFC] Remove unnecessary require global-isel from tests (authored by gargaroff).
[NFC] Remove unnecessary require global-isel from tests
Jun 15 2020, 8:07 AM
gargaroff committed rG87e5742654fe: [NFC] Add braces to if-statement in MachineVerifier (authored by gargaroff).
[NFC] Add braces to if-statement in MachineVerifier
Jun 15 2020, 8:07 AM
gargaroff added inline comments to D81475: GlobalISel: Support lowering vector->vector G_BITCAST.
Jun 15 2020, 6:28 AM · Restricted Project
gargaroff added inline comments to D81475: GlobalISel: Support lowering vector->vector G_BITCAST.
Jun 15 2020, 5:24 AM · Restricted Project
gargaroff committed rGc87bf2914959: [MachineVerifier][GlobalISel] Check that branches have a MBB operand or are… (authored by gargaroff).
[MachineVerifier][GlobalISel] Check that branches have a MBB operand or are…
Jun 15 2020, 2:41 AM
gargaroff closed D81587: [MachineVerifier][GlobalISel] Check that branches have a MBB operand or are declared indirect. Add missing properties to G_BRJT, G_BRINDIRECT.
Jun 15 2020, 2:41 AM · Restricted Project
gargaroff added a comment to D81683: llc doesn't recognize "-debug" without asserts enabled..

@saugustine I see that this was already landed by someone. Could you abandon or close this revision?

Jun 15 2020, 2:41 AM · Restricted Project
gargaroff created D81824: [LIBCXX] add possibility to load an additional test configuration to CMake.
Jun 15 2020, 1:03 AM · Restricted Project
gargaroff updated the diff for D81587: [MachineVerifier][GlobalISel] Check that branches have a MBB operand or are declared indirect. Add missing properties to G_BRJT, G_BRINDIRECT.

Move check to verifyPreISelGenericInstruction

Jun 15 2020, 12:30 AM · Restricted Project
gargaroff accepted D81475: GlobalISel: Support lowering vector->vector G_BITCAST.

LGTM with a nit

Jun 15 2020, 12:30 AM · Restricted Project

Jun 12 2020

gargaroff added inline comments to D81587: [MachineVerifier][GlobalISel] Check that branches have a MBB operand or are declared indirect. Add missing properties to G_BRJT, G_BRINDIRECT.
Jun 12 2020, 5:53 AM · Restricted Project
gargaroff retitled D81587: [MachineVerifier][GlobalISel] Check that branches have a MBB operand or are declared indirect. Add missing properties to G_BRJT, G_BRINDIRECT from [GlobalISel] Add missing properties to G_BRINDIRECT, G_BRJT to [MachineVerifier][GlobalISel] Check that branches have a MBB operand or are declared indirect. Add missing properties to G_BRJT, G_BRINDIRECT.
Jun 12 2020, 1:35 AM · Restricted Project
gargaroff added inline comments to D81587: [MachineVerifier][GlobalISel] Check that branches have a MBB operand or are declared indirect. Add missing properties to G_BRJT, G_BRINDIRECT.
Jun 12 2020, 1:03 AM · Restricted Project
gargaroff updated the diff for D81587: [MachineVerifier][GlobalISel] Check that branches have a MBB operand or are declared indirect. Add missing properties to G_BRJT, G_BRINDIRECT.

Teach machine verifier to check branch instructions for basic block
operands, if they are not declared indirect.

Jun 12 2020, 1:03 AM · Restricted Project

Jun 11 2020

gargaroff accepted D81683: llc doesn't recognize "-debug" without asserts enabled..

LGTM if this is still required.

Jun 11 2020, 11:57 PM · Restricted Project
gargaroff added inline comments to D76934: [GlobalISel] fix crash in IRTranslator, MachineIRBuilder when translating @llvm.dbg.value intrinsic and using -debug.
Jun 11 2020, 11:57 PM · Restricted Project
gargaroff committed rGf24e2e9eebde: [GlobalISel] fix crash in IRTranslator, MachineIRBuilder when translating @llvm. (authored by gargaroff).
[GlobalISel] fix crash in IRTranslator, MachineIRBuilder when translating @llvm.
Jun 11 2020, 1:51 AM
gargaroff closed D76934: [GlobalISel] fix crash in IRTranslator, MachineIRBuilder when translating @llvm.dbg.value intrinsic and using -debug.
Jun 11 2020, 1:51 AM · Restricted Project
gargaroff added a reviewer for D81587: [MachineVerifier][GlobalISel] Check that branches have a MBB operand or are declared indirect. Add missing properties to G_BRJT, G_BRINDIRECT: arsenm.
Jun 11 2020, 1:15 AM · Restricted Project
gargaroff updated the diff for D81587: [MachineVerifier][GlobalISel] Check that branches have a MBB operand or are declared indirect. Add missing properties to G_BRJT, G_BRINDIRECT.

Add tests to test/MachineVerifier

Jun 11 2020, 1:15 AM · Restricted Project

Jun 10 2020

gargaroff added a comment to D81587: [MachineVerifier][GlobalISel] Check that branches have a MBB operand or are declared indirect. Add missing properties to G_BRJT, G_BRINDIRECT.

I noticed the missing properties when implementing analyzeBranch for our downstream target. Since the machine verifier also uses this function, all of the GMIR was passing through it and we were getting false-positives for those two instructions. Seems like an obvious fix. I guess the two tests changed because now there is no implicit fall-through, which marks the basic block as a successor.

Jun 10 2020, 10:31 AM · Restricted Project
gargaroff created D81587: [MachineVerifier][GlobalISel] Check that branches have a MBB operand or are declared indirect. Add missing properties to G_BRJT, G_BRINDIRECT.
Jun 10 2020, 10:31 AM · Restricted Project
gargaroff added a comment to D76934: [GlobalISel] fix crash in IRTranslator, MachineIRBuilder when translating @llvm.dbg.value intrinsic and using -debug.

I've updated the reviewers, since this is obviously not going forward otherwise. Hope it's ok with all of you!

Jun 10 2020, 10:00 AM · Restricted Project
gargaroff added reviewers for D76934: [GlobalISel] fix crash in IRTranslator, MachineIRBuilder when translating @llvm.dbg.value intrinsic and using -debug: aemerson, dsanders, arsenm.
Jun 10 2020, 10:00 AM · Restricted Project

Jun 8 2020

gargaroff accepted D81376: GlobalISel: Add unit tests for some utils functions.

LGTM with a nit

Jun 8 2020, 5:25 AM · Restricted Project

Jun 2 2020

gargaroff committed rG052c962ced71: [GlobalISel] Combine scalar unmerge(trunc) (authored by gargaroff).
[GlobalISel] Combine scalar unmerge(trunc)
Jun 2 2020, 12:31 AM
gargaroff committed rGb3c6a36dba56: [NFC] Move vector unmerge(trunc) combine to function (authored by gargaroff).
[NFC] Move vector unmerge(trunc) combine to function
Jun 2 2020, 12:31 AM