[clang-tidy] New util `Aliasing` factored out from `bugprone-infinite-loop`

[baloghadamsoftware]

Summary

Function hasPtrOrReferenceInfFunc() of bugprone-infinite-loop is a generic function which could be reused in another checks. This patch moves this function into a newly created utility module.

[gribozavr2]

clang-tools-extra/clang-tidy/utils/Aliasing.cpp

60

Please don't duplicate the comment from the header in the cpp file.

clang-tools-extra/clang-tidy/utils/Aliasing.h

19

Could you expand the comment? Best if you could add an example.

[baloghadamsoftware]

Thank you for the comment, @gribozavr2! Patch updated according to them.

[gribozavr2]

clang-tools-extra/clang-tidy/utils/Aliasing.h

29

Extra blank line.

[njames93]

clang-tools-extra/clang-tidy/utils/Aliasing.cpp

17

Ditto \p <Name>.

25

Ditto.

43

Ditto.

clang-tools-extra/clang-tidy/utils/Aliasing.h

18

Don't use double ticks for param names, instead use \p <Name>.

[baloghadamsoftware]

Parameters in comments changed to \p <Name>.

[njames93]

LGTM, but with one more nit

clang-tools-extra/clang-tidy/bugprone/InfiniteLoopCheck.cpp

16

This function is only used once in the file, so may as well remove this line and just qualify its call further down.

60

here.