This is an archive of the discontinued LLVM Phabricator instance.

Differential D80337

[SVE] Eliminate calls to default-false VectorType::get() from Utils
ClosedPublic

Authored by ctetreau on May 20 2020, 3:59 PM.

Details

Reviewers
efriedma
c-rhodes
sdesmalen
xbolva00
Commits
rGc8f1aca316c2: [SVE] Eliminate calls to default-false VectorType::get() from Utils

Diff Detail

Unit TestsFailed

TimeTest
180 msClang.Analysis::Unknown Unit Message ("")
490 msClang.Analysis::Unknown Unit Message ("")
50 msLLVM.CodeGen/AArch64/GlobalISel::Unknown Unit Message ("")
30 msLLVM.CodeGen/AArch64/GlobalISel::Unknown Unit Message ("")
160 msLLVM.CodeGen/AArch64/GlobalISel::Unknown Unit Message ("")
View Full Test Results (10 Failed)

Revision Contents

PathSize
llvm/
lib/
Transforms/
Utils/
2 lines

Diff 265374

llvm/lib/Transforms/Utils/SimplifyLibCalls.cpp

Show First 20 Lines • Show All 2,101 Lines • ▼ Show 20 Linesstatic void insertSinCosCall(IRBuilderBase &B, Function *OrigCallee, Value *Arg,
Triple T(OrigCallee->getParent()->getTargetTriple()); Triple T(OrigCallee->getParent()->getTargetTriple());
if (UseFloat) { if (UseFloat) {
Name = "__sincospif_stret"; Name = "__sincospif_stret";
assert(T.getArch() != Triple::x86 && "x86 messy and unsupported for now"); assert(T.getArch() != Triple::x86 && "x86 messy and unsupported for now");
// x86_64 can't use {float, float} since that would be returned in both // x86_64 can't use {float, float} since that would be returned in both
// xmm0 and xmm1, which isn't what a real struct would do. // xmm0 and xmm1, which isn't what a real struct would do.
ResTy = T.getArch() == Triple::x86_64 ResTy = T.getArch() == Triple::x86_64
? static_cast<Type *>(VectorType::get(ArgTy, 2)) ? static_cast<Type *>(FixedVectorType::get(ArgTy, 2))
: static_cast<Type *>(StructType::get(ArgTy, ArgTy)); : static_cast<Type *>(StructType::get(ArgTy, ArgTy));
} else { } else {
Name = "__sincospi_stret"; Name = "__sincospi_stret";
ResTy = StructType::get(ArgTy, ArgTy); ResTy = StructType::get(ArgTy, ArgTy);
} }
Module *M = OrigCallee->getParent(); Module *M = OrigCallee->getParent();
FunctionCallee Callee = FunctionCallee Callee =
▲ Show 20 Lines • Show All 1,359 Lines • Show Last 20 Lines