Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Unit Tests
Event Timeline
llvm/lib/CodeGen/ValueTypes.cpp | ||
---|---|---|
166 | I think I'd prefer to just let clang-format use its default formatting for this switch... as it is, the code doesn't fit into 80 columns. |
llvm/lib/CodeGen/ValueTypes.cpp | ||
---|---|---|
166 | Somebody clearly went to great lengths to format this switch nicely, I feel like this is the sort of thing clang-format on/off is for. I don't feel particularly strongly about it either way though. |
llvm/lib/CodeGen/ValueTypes.cpp | ||
---|---|---|
332–337 | I think you removed these by mistake when rebasing, causing test failures |
That switch() seems like it deserves some kind of preprocessor/stringify magic, but since it's already a mess, I guess we shouldn't hold this up. LGTM.
I think I'd prefer to just let clang-format use its default formatting for this switch... as it is, the code doesn't fit into 80 columns.