Page MenuHomePhabricator

[WebAssembly] Handle exception specifications
ClosedPublic

Authored by aheejin on May 16 2020, 3:40 AM.

Details

Summary

Wasm currently does not fully handle exception specifications. Rather
than crashing,

  • This treats throw() in the same way as noexcept.
  • This ignores and prints a warning for throw(type, ..), for a temporary measure. This warning is controlled by -Wwasm-exception-spec, which is on by default. You can suppress the warning by using -Wno-wasm-exception-spec.

Diff Detail

Event Timeline

aheejin created this revision.May 16 2020, 3:40 AM
aheejin updated this revision to Diff 264423.May 16 2020, 3:43 AM
  • rst file fix

This is an improved version of D79655. The warning now can be suppressed by -Wno-wasm-exception-spec. To do this, we needed a diagnostic group.

Harbormaster completed remote builds in B56961: Diff 264422.
aheejin updated this revision to Diff 264461.May 16 2020, 5:41 PM
  • Add missing -o
aheejin updated this revision to Diff 264466.May 16 2020, 7:37 PM
  • Add missing - after -o
dschuff accepted this revision.May 18 2020, 9:21 AM
This revision is now accepted and ready to land.May 18 2020, 9:21 AM
This revision was automatically updated to reflect the committed changes.