[Object] Remove unneeded check in ELFFile<ELFT>::dynamicEntries().

[Higuoxing]

Summary

Check for DynSecSize % sizeof(Elf_Dyn) != 0 is unneeded in this context.

1. If the .dynamic section is acquired from program headers, the .dynamic

section is "cut off" by

makeArrayRef(..., Phdr.p_filesz / sizeof(Elf_Dyn));
DynSeSize = Phdr.p_filesz;

2. If the .dynamic section is acquired from section headers, the .dynamic

section is checked in getSectionContentsAsArray<Elf_Dyn>(&Sec).

[MaskRay]

Thanks!

[abhinavgaba]

llvm/lib/Object/ELF.cpp

505

This is not being read anymore. So it's causing these warnings:
variable ‘DynSecSize’ set but not used [-Werror=unused-but-set-variable].

[Higuoxing]

llvm/lib/Object/ELF.cpp

505

Fixed in rG1171bef0209de3367ad3837745dbc19e9d0cf1ed, thanks!

llvm/lib/Object/ELF.cpp

 template <class ELFT>
 std::string ELFFile<ELFT>::getDynamicTagAsString(uint64_t Type) const {
   return getDynamicTagAsString(getHeader()->e_machine, Type);
 }
 
 template <class ELFT>
 Expected<typename ELFT::DynRange> ELFFile<ELFT>::dynamicEntries() const {
   ArrayRef<Elf_Dyn> Dyn;
   size_t DynSecSize = 0;
 
   auto ProgramHeadersOrError = program_headers();
   if (!ProgramHeadersOrError)
     return ProgramHeadersOrError.takeError();
 
   for (const Elf_Phdr &Phdr : *ProgramHeadersOrError) {
     if (Phdr.p_type == ELF::PT_DYNAMIC) {
       Dyn = makeArrayRef(
if (Dyn.empty()) {
     if (!Dyn.data())
       return ArrayRef<Elf_Dyn>();
   }
 
   if (Dyn.empty())
     // TODO: this error is untested.
     return createError("invalid empty dynamic section");
 
-  if (DynSecSize % sizeof(Elf_Dyn) != 0)
-    // TODO: this error is untested.
-    return createError("malformed dynamic section");
-
   if (Dyn.back().d_tag != ELF::DT_NULL)
     // TODO: this error is untested.
     return createError("dynamic sections must be DT_NULL terminated");
 
   return Dyn;
 }
 
 template <class ELFT>