Page MenuHomePhabricator
Differential D79077

[mlir] Simplify BranchOpInterface by using MutableOperandRange
ClosedPublic
Actions

Authored by rriddle on Apr 29 2020, 2:59 AM.

Details

Reviewers
mehdi_amini
jpienaar
mravishankar
antiagainst
ftynse
DavidTruby
Commits
rG0752d98ccf87: [mlir] Simplify BranchOpInterface by using MutableOperandRange
Summary

This range allows for performing many different operations on successor operands, including erasing/adding/setting. This removes the need for the explicit canEraseSuccessorOperand and eraseSuccessorOperand methods.

Depends On D79030

Diff Detail

Event Timeline

rriddle created this revision.Apr 29 2020, 2:59 AM
Herald added a reviewer: mravishankar. · View Herald TranscriptApr 29 2020, 2:59 AM
Herald added a reviewer: antiagainst. · View Herald Transcript
Herald added a reviewer: DavidTruby. · View Herald Transcript
Herald added a reviewer: ftynse. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: llvm-commits, Kayjukh, frgossen and 11 others. · View Herald Transcript
DavidTruby resigned from this revision.Apr 29 2020, 3:20 AM
Harbormaster failed remote builds in B55100: Diff 260872!Apr 29 2020, 4:15 AM
jpienaar accepted this revision.Apr 29 2020, 1:50 PM

Nice, thanks

This revision is now accepted and ready to land.Apr 29 2020, 1:50 PM
rriddle added a child revision: D79134: [mlir] Add support for merging identical blocks during canonicalization.Apr 29 2020, 2:57 PM
Closed by commit rG0752d98ccf87: [mlir] Simplify BranchOpInterface by using MutableOperandRange (authored by rriddle). · Explain WhyApr 29 2020, 5:18 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
flang/
include/
flang/
Optimizer/
Dialect/
1 line
lib/
Optimizer/
Dialect/
60 lines
mlir/
include/
mlir/
Dialect/
StandardOps/
IR/
4 lines
IR/
7 lines
Interfaces/
5 lines
26 lines
lib/
Dialect/
LLVMIR/
IR/
21 lines
SPIRV/
17 lines
StandardOps/
IR/
15 lines
IR/
12 lines
Interfaces/
33 lines
Transforms/
Utils/
9 lines
test/
lib/
Dialect/
Test/
7 lines
tools/
mlir-tblgen/
8 lines

Diff 261104

View Options

flang/include/flang/Optimizer/Dialect/FIROps.td

Loading...
View Options

flang/lib/Optimizer/Dialect/FIROps.cpp

Loading...
View Options

mlir/include/mlir/Dialect/StandardOps/IR/Ops.td

Loading...
View Options

mlir/include/mlir/IR/OperationSupport.h

Loading...
View Options

mlir/include/mlir/Interfaces/ControlFlowInterfaces.h

Loading...
View Options

mlir/include/mlir/Interfaces/ControlFlowInterfaces.td

Loading...
View Options

mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp

Loading...
View Options

mlir/lib/Dialect/SPIRV/SPIRVOps.cpp

Loading...
View Options

mlir/lib/Dialect/StandardOps/IR/Ops.cpp

Loading...
View Options

mlir/lib/IR/OperationSupport.cpp

Loading...
View Options

mlir/lib/Interfaces/ControlFlowInterfaces.cpp

Loading...
View Options

mlir/lib/Transforms/Utils/RegionUtils.cpp

Loading...
View Options

mlir/test/lib/Dialect/Test/TestDialect.cpp

Loading...
View Options

mlir/tools/mlir-tblgen/OpInterfacesGen.cpp

Loading...