Legalizer should respect both command-line options or SDNode-level fast-math flags.
Also, this patch propagates other flags during custom simplifying.
Paths
| Differential D79074
[PowerPC] Respect SDNodeFlags in lowering SELECT_CC ClosedPublic Authored by qiucf on Apr 29 2020, 2:09 AM.
Details
Summary Legalizer should respect both command-line options or SDNode-level fast-math flags. Also, this patch propagates other flags during custom simplifying.
Diff Detail
Event Timelineqiucf added a child revision: D78989: [NFC] [PowerPC] Narrow fast-math flags in tests.Apr 29 2020, 2:12 AM qiucf mentioned this in D78989: [NFC] [PowerPC] Narrow fast-math flags in tests.Apr 29 2020, 2:14 AM Comment Actions Can we not to remove the --enable-unsafe-fp-math in this patch ? And I think, the option --enable-unsafe-fp-math is also part of our test point. This revision is now accepted and ready to land.May 10 2020, 8:57 PM Comment Actions Keep flags and options as-is, so that we can have a clear sight of what changed. Options/flags will be updated in child revision. This revision is now accepted and ready to land.May 11 2020, 11:04 PM Comment Actions LGTM now.
Closed by commit rGe9753822b5ad: [PowerPC] Respect SDNodeFlags in lowering SELECT_CC (authored by qiucf). · Explain WhyMay 12 2020, 11:09 PM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 263353 llvm/lib/Target/PowerPC/PPCISelLowering.cpp
llvm/test/CodeGen/PowerPC/scalar-equal.ll
llvm/test/CodeGen/PowerPC/scalar-min-max.ll
llvm/test/CodeGen/PowerPC/scalar_cmp.ll
|
Deleting fast in this file looks okay to me, since we already used command-line flags. We can clear this in following patches.