Page MenuHomePhabricator

[NFC] [PowerPC] Narrow fast-math flags in tests
ClosedPublic

Authored by qiucf on Apr 28 2020, 2:44 AM.

Details

Summary

A lot of tests under PowerPC are using fast flag, while fast is just alias of 7 fast-math flags. This change makes test points clearer.

mc-instrlat.ll and sms-iterator.ll keeps unchanged since they are not testing fast-math behavior (one for machine combiner crash, one for machine pipeliner bug).

Diff Detail

Event Timeline

qiucf created this revision.Apr 28 2020, 2:44 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 28 2020, 2:44 AM
qiucf updated this revision to Diff 260576.Apr 28 2020, 2:47 AM

Remove an incorrect update_script header

Harbormaster completed remote builds in B54940: Diff 260576.
spatel accepted this revision.Apr 28 2020, 5:00 AM

More precise FMF in tests is appreciated - LGTM.

llvm/test/CodeGen/PowerPC/fma-mutate.ll
1–4

This comment does not seem to match the content of this file, so it might be better to update this independently or with a 2nd commit (and auto-generating the complete output would be nice too).

This revision is now accepted and ready to land.Apr 28 2020, 5:00 AM
steven.zhang added inline comments.Apr 28 2020, 5:19 PM
llvm/test/CodeGen/PowerPC/scalar-equal.ll
93–94

The change here is questionable. If we have the fast flag set, we shouldn't see the different instruction sequence w/o --enable-unsafe-fp-math. Please double confirm with compiler implementation to see what happens.

llvm/test/CodeGen/PowerPC/scalar-min-max.ll
129

The same as above comments.

qiucf marked 3 inline comments as done.
qiucf added inline comments.
llvm/test/CodeGen/PowerPC/scalar-equal.ll
93–94

That's not related to unsafe-fp-math. That's a bug about flag propagation. See D79074, thanks.

steven.zhang accepted this revision.Apr 29 2020, 2:57 AM

LGTM now as far as D79074 is addressed. We missed to respect the fast flags when lowering the select_cc. Thank you for doing this.

This revision was automatically updated to reflect the committed changes.