This is an archive of the discontinued LLVM Phabricator instance.

[tools][tests] - Use --check-prefixes instead of multiple --check-prefix. NFCI.
ClosedPublic

Authored by grimar on Apr 15 2020, 9:17 AM.

Details

Summary

There is no need to use --check-prefix multiple times.

This patch fixes all places in llvm/test/tools at once.

Diff Detail

Event Timeline

grimar created this revision.Apr 15 2020, 9:17 AM
MaskRay added inline comments.Apr 15 2020, 10:03 AM
llvm/test/tools/llvm-profdata/overlap.test
3

You may change -check-prefixes= to --check-prefixes= by the way if you are going to touch these lines..

jhenderson accepted this revision.Apr 16 2020, 12:29 AM

LGTM, with or without @MaskRay's comment. It might be worth updating the commit message to say the reason to make a change that otherwise looks a bit like "churn for churns sake" (e.g. improve readability/test maintainability etc).

This revision is now accepted and ready to land.Apr 16 2020, 12:29 AM
grimar marked 2 inline comments as done.Apr 16 2020, 2:44 AM
grimar added inline comments.
llvm/test/tools/llvm-profdata/overlap.test
3

Will do.

MaskRay accepted this revision.Apr 16 2020, 9:17 AM
This revision was automatically updated to reflect the committed changes.
grimar marked an inline comment as done.
Herald added a project: Restricted Project. · View Herald TranscriptApr 17 2020, 2:41 AM