There is no need to use --check-prefix multiple times.
This patch fixes all places in llvm/test/tools at once.
Paths
| Differential D78217
[tools][tests] - Use --check-prefixes instead of multiple --check-prefix. NFCI. ClosedPublic Authored by grimar on Apr 15 2020, 9:17 AM.
Details Summary There is no need to use --check-prefix multiple times. This patch fixes all places in llvm/test/tools at once.
Diff Detail
Event Timeline
Comment Actions LGTM, with or without @MaskRay's comment. It might be worth updating the commit message to say the reason to make a change that otherwise looks a bit like "churn for churns sake" (e.g. improve readability/test maintainability etc). This revision is now accepted and ready to land.Apr 16 2020, 12:29 AM Closed by commit rGb6d77e792c33: [tools][tests] - Use --check-prefixes instead of multiple --check-prefix. NFCI. (authored by grimar). · Explain WhyApr 17 2020, 2:41 AM This revision was automatically updated to reflect the committed changes. grimar marked an inline comment as done.
Revision Contents
Diff 258272 llvm/test/tools/dsymutil/X86/accelerator.test
llvm/test/tools/dsymutil/X86/basic-linking-x86.test
llvm/test/tools/dsymutil/X86/dsym-companion.test
llvm/test/tools/dsymutil/X86/multiple-inputs.test
llvm/test/tools/dsymutil/X86/odr-uniquing.cpp
llvm/test/tools/dsymutil/X86/verify.test
llvm/test/tools/dsymutil/arch-option.test
llvm/test/tools/dsymutil/basic-linking.test
llvm/test/tools/dsymutil/dump-symtab.test
llvm/test/tools/llvm-dwarfdump/X86/debug_loclists.s
llvm/test/tools/llvm-mca/X86/bextr-read-after-ld.s
llvm/test/tools/llvm-mca/X86/bzhi-read-after-ld.s
llvm/test/tools/llvm-mca/X86/cpus.s
llvm/test/tools/llvm-mca/X86/default-iterations.s
llvm/test/tools/llvm-mca/X86/dispatch_width.s
llvm/test/tools/llvm-mca/X86/fma3-read-after-ld-1.s
llvm/test/tools/llvm-mca/X86/fma3-read-after-ld-2.s
llvm/test/tools/llvm-mca/X86/option-all-stats-1.s
llvm/test/tools/llvm-mca/X86/option-all-stats-2.s
llvm/test/tools/llvm-mca/X86/option-all-views-1.s
llvm/test/tools/llvm-mca/X86/option-all-views-2.s
llvm/test/tools/llvm-mca/X86/read-after-ld-1.s
llvm/test/tools/llvm-mca/X86/read-after-ld-2.s
llvm/test/tools/llvm-mca/X86/read-after-ld-3.s
llvm/test/tools/llvm-mca/X86/sqrt-rsqrt-rcp-memop.s
llvm/test/tools/llvm-mca/X86/variable-blend-read-after-ld-1.s
llvm/test/tools/llvm-mca/X86/variable-blend-read-after-ld-2.s
llvm/test/tools/llvm-objcopy/ELF/prefix-symbols.test
llvm/test/tools/llvm-profdata/c-general.test
llvm/test/tools/llvm-profdata/cutoff.test
llvm/test/tools/llvm-profdata/hash-mismatch.proftext
llvm/test/tools/llvm-profdata/multiple-inputs.test
llvm/test/tools/llvm-profdata/overlap.test
llvm/test/tools/llvm-profdata/value-prof.proftext
llvm/test/tools/llvm-profdata/weight-instr.test
llvm/test/tools/llvm-readobj/COFF/exports.test
llvm/test/tools/llvm-symbolizer/split-dwarf.test
|
You may change -check-prefixes= to --check-prefixes= by the way if you are going to touch these lines..