This is an archive of the discontinued LLVM Phabricator instance.

Differential D77906

[SVE] Remove calls to getBitWidth from mips
ClosedPublic

Authored by ctetreau on Apr 10 2020, 1:55 PM.

Download Raw Diff

Details

Reviewers

efriedma
ahatanak
sdesmalen
c-rhodes
david-arm

Commits

rG17e1df44ec67: [SVE] Remove calls to getBitWidth from mips

Diff Detail

Repository: rG LLVM Github Monorepo

Unit TestsFailed

	Time	Test
	50 ms	MLIR.Target::Unknown Unit Message ("")

Event Timeline

ctetreau created this revision.Apr 10 2020, 1:55 PM

Herald added a reviewer: efriedma. · View Herald TranscriptApr 10 2020, 1:55 PM

Herald added a project: Restricted Project. · View Herald Transcript

Herald added subscribers: llvm-commits, psnobl, rkruppe and 6 others. · View Herald Transcript

ctetreau added a parent revision: D77587: [SVE] Add new VectorType subclasses.Apr 10 2020, 2:04 PM

ctetreau added a child revision: D77833: [SVE] Remove VectorType::getBitWidth().

Harbormaster failed remote builds in B52735: Diff 256657!Apr 10 2020, 2:32 PM

ctetreau added reviewers: ahatanak, sdesmalen.Apr 13 2020, 1:08 PM

Herald added a subscriber: dexonsmith. · View Herald TranscriptApr 13 2020, 1:08 PM

ctetreau removed a parent revision: D77587: [SVE] Add new VectorType subclasses.Apr 13 2020, 4:55 PM

rebase

Harbormaster failed remote builds in B53043: Diff 257165!Apr 13 2020, 6:05 PM

ping

ctetreau added reviewers: c-rhodes, david-arm.Apr 20 2020, 10:02 AM

LGTM

This revision is now accepted and ready to land.Apr 20 2020, 11:41 AM

Closed by commit rG17e1df44ec67: [SVE] Remove calls to getBitWidth from mips (authored by ctetreau). · Explain WhyApr 20 2020, 2:39 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

llvm/

lib/

Target/

Mips/

MipsISelLowering.cpp

2 lines

Diff 257165

llvm/lib/Target/Mips/MipsISelLowering.cpp

	Show First 20 Lines • Show All 3,942 Lines • ▼ Show 20 Lines		default:
	break;			break;
	case 'd':			case 'd':
	case 'y':			case 'y':
	if (type->isIntegerTy())			if (type->isIntegerTy())
	weight = CW_Register;			weight = CW_Register;
	break;			break;
	case 'f': // FPU or MSA register			case 'f': // FPU or MSA register
	if (Subtarget.hasMSA() && type->isVectorTy() &&			if (Subtarget.hasMSA() && type->isVectorTy() &&
	cast<VectorType>(type)->getBitWidth() == 128)			type->getPrimitiveSizeInBits().getFixedSize() == 128)
	weight = CW_Register;			weight = CW_Register;
	else if (type->isFloatTy())			else if (type->isFloatTy())
	weight = CW_Register;			weight = CW_Register;
	break;			break;
	case 'c': // $25 for indirect jumps			case 'c': // $25 for indirect jumps
	case 'l': // lo register			case 'l': // lo register
	case 'x': // hilo register pair			case 'x': // hilo register pair
	if (type->isIntegerTy())			if (type->isIntegerTy())
	▲ Show 20 Lines • Show All 1,037 Lines • Show Last 20 Lines