This is an archive of the discontinued LLVM Phabricator instance.

Differential D77900

[SVE] Remove calls to getBitWidth from PowerPC
ClosedPublic

Authored by ctetreau on Apr 10 2020, 1:40 PM.

Details

Reviewers
efriedma
sdesmalen
hfinkel
david-arm
fpetrogalli
Commits
rGa9b137f9ffba: [SVE] Remove calls to getBitWidth from PowerPC

Diff Detail

Event Timeline

ctetreau created this revision.Apr 10 2020, 1:40 PM
Herald added a reviewer: efriedma. · View Herald TranscriptApr 10 2020, 1:40 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: llvm-commits, shchenz, psnobl and 5 others. · View Herald Transcript
ctetreau added a parent revision: D77587: [SVE] Add new VectorType subclasses.Apr 10 2020, 2:02 PM
Herald added a subscriber: • wuzish. · View Herald TranscriptApr 10 2020, 2:02 PM
ctetreau added a child revision: D77833: [SVE] Remove VectorType::getBitWidth().Apr 10 2020, 2:05 PM
Harbormaster failed remote builds in B52727: Diff 256650!Apr 10 2020, 2:32 PM
ctetreau added reviewers: sdesmalen, hfinkel.Apr 13 2020, 1:10 PM
ctetreau removed a parent revision: D77587: [SVE] Add new VectorType subclasses.Apr 13 2020, 4:56 PM
ctetreau updated this revision to Diff 257160.Apr 13 2020, 5:00 PM

rebase

Harbormaster failed remote builds in B53038: Diff 257160!Apr 13 2020, 5:57 PM
ctetreau added a comment.Apr 20 2020, 10:01 AM

ping

ctetreau added reviewers: david-arm, fpetrogalli.Apr 20 2020, 10:02 AM
fpetrogalli accepted this revision.Apr 20 2020, 11:42 AM

LGTM!

Thank you for working on this.

Kind regards,

Francesco

This revision is now accepted and ready to land.Apr 20 2020, 11:42 AM
efriedma accepted this revision.Apr 20 2020, 11:42 AM

LGTM

Closed by commit rGa9b137f9ffba: [SVE] Remove calls to getBitWidth from PowerPC (authored by ctetreau). · Explain WhyApr 20 2020, 2:39 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
lib/
Target/
PowerPC/
6 lines

Diff 258846

llvm/lib/Target/PowerPC/PPCISelLowering.cpp

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 1,327 Lines • ▼ Show 20 Lines
/// getMaxByValAlign - Helper for getByValTypeAlignment to determine /// getMaxByValAlign - Helper for getByValTypeAlignment to determine
/// the desired ByVal argument alignment. /// the desired ByVal argument alignment.
static void getMaxByValAlign(Type *Ty, unsigned &MaxAlign, static void getMaxByValAlign(Type *Ty, unsigned &MaxAlign,
unsigned MaxMaxAlign) { unsigned MaxMaxAlign) {
if (MaxAlign == MaxMaxAlign) if (MaxAlign == MaxMaxAlign)
return; return;
if (VectorType *VTy = dyn_cast<VectorType>(Ty)) { if (VectorType *VTy = dyn_cast<VectorType>(Ty)) {
if (MaxMaxAlign >= 32 && VTy->getBitWidth() >= 256) if (MaxMaxAlign >= 32 &&
VTy->getPrimitiveSizeInBits().getFixedSize() >= 256)
MaxAlign = 32; MaxAlign = 32;
else if (VTy->getBitWidth() >= 128 && MaxAlign < 16) else if (VTy->getPrimitiveSizeInBits().getFixedSize() >= 128 &&
MaxAlign < 16)
MaxAlign = 16; MaxAlign = 16;
} else if (ArrayType *ATy = dyn_cast<ArrayType>(Ty)) { } else if (ArrayType *ATy = dyn_cast<ArrayType>(Ty)) {
unsigned EltAlign = 0; unsigned EltAlign = 0;
getMaxByValAlign(ATy->getElementType(), EltAlign, MaxMaxAlign); getMaxByValAlign(ATy->getElementType(), EltAlign, MaxMaxAlign);
if (EltAlign > MaxAlign) if (EltAlign > MaxAlign)
MaxAlign = EltAlign; MaxAlign = EltAlign;
} else if (StructType *STy = dyn_cast<StructType>(Ty)) { } else if (StructType *STy = dyn_cast<StructType>(Ty)) {
for (auto *EltTy : STy->elements()) { for (auto *EltTy : STy->elements()) {
▲ Show 20 Lines • Show All 14,930 Lines • Show Last 20 Lines