Page MenuHomePhabricator

[VPlan] Drop redundant private: at beginning of class defs (NFC).
ClosedPublic

Authored by fhahn on Apr 9 2020, 10:46 AM.

Details

Summary

Default visibility for classes is private, so the private: at the top of
various class definitions is redundant.

Diff Detail

Event Timeline

fhahn created this revision.Apr 9 2020, 10:46 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 9 2020, 10:46 AM
Ayal added a comment.Apr 9 2020, 3:49 PM

Thanks for cleaning this up. There are additional VPlan classes in other files with such a redundant 'private'; best keep them all consistent.

While we're at it, there are other cases with a redundant 'public', breaking the "struct should be used when all members are declared public" rule of https://llvm.org/docs/CodingStandards.html#use-of-class-and-struct-keywords

llvm/lib/Transforms/Vectorize/VPlan.h
79

Retain the 3rd slash?

fhahn updated this revision to Diff 256542.Apr 10 2020, 3:41 AM
fhahn marked an inline comment as done.

Remove redundant private: in a few more files.

Thanks for cleaning this up. There are additional VPlan classes in other files with such a redundant 'private'; best keep them all consistent.

Done.

While we're at it, there are other cases with a redundant 'public', breaking the "struct should be used when all members are declared public" rule of https://llvm.org/docs/CodingStandards.html#use-of-class-and-struct-keywords

Will do as follow-up

Ayal accepted this revision.Apr 10 2020, 3:47 AM

Thanks!

This revision is now accepted and ready to land.Apr 10 2020, 3:47 AM
This revision was automatically updated to reflect the committed changes.