Disable the 'Skip Uniform Regions' optimization in the 'Structurize CFG' pass by default since it causes several functional issues in HIP applications.
The optimization still can be turned on manually by using the "-structurizecfg-relaxed-uniform-regions" option.
The LIT tests affected by this change are updated.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
llvm/lib/Transforms/Scalar/StructurizeCFG.cpp | ||
---|---|---|
1011 | This seems to be related to opt-bisect, and should go into a different commit. I am also not sure how this will work. There wouldn't be any guarantee of producing valid ISA if the structurizer skipped entire regions during a bisect. |
llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp | ||
---|---|---|
854 | This only changes the invocation in AMDGPU, but does not change the structurizer default itself. If that is the intention, then commit message needs to reflect that correctly, and should start with the flag [AMDGPU]. |
This only changes the invocation in AMDGPU, but does not change the structurizer default itself. If that is the intention, then commit message needs to reflect that correctly, and should start with the flag [AMDGPU].