Page MenuHomePhabricator

[Analyzer][WebKit] UncountedCallArgsChecker
Needs ReviewPublic

Authored by jkorous on Mar 31 2020, 2:44 PM.

Details

Reviewers
NoQ

Diff Detail

Event Timeline

jkorous created this revision.Mar 31 2020, 2:44 PM
jkorous updated this revision to Diff 265440.Thu, May 21, 12:07 AM

reflected feedback from reviews of other related checkers

NoQ added a comment.Mon, Jun 1, 5:57 AM

*requires a bit more time to digest this whole tryToFindPtrOrigin thing*
(thx for more comments!)

clang/docs/analyzer/checkers.rst
1434

I think it's worth it to add a few examples on which the checker *will* warn.

1464

You probably meant baz(this).

jkorous marked 3 inline comments as done.Wed, Jun 3, 1:32 PM
jkorous added inline comments.
clang/docs/analyzer/checkers.rst
1434

Actually, this is spot on! It feels like I am struggling to step back and not think about this from the implementation perspective...

jkorous updated this revision to Diff 268291.Wed, Jun 3, 1:33 PM
jkorous marked an inline comment as done.
  • rebased
  • improved the docs