This is an archive of the discontinued LLVM Phabricator instance.

Differential D77096

Correct the duplicate pragma marks in CommandObjectTarget.cpp
ClosedPublic

Authored by shivammittal99 on Mar 30 2020, 2:47 PM.

Details

Reviewers
teemperor
Commits
rGd30e9ad34519: Correct the duplicate pragma marks in CommandObjectTarget.cpp
Summary

Resolve the two duplicated pragma marks in lldb/source/Commands/CommandObjectTarget.cpp

Diff Detail

Event Timeline

shivammittal99 created this revision.Mar 30 2020, 2:47 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 30 2020, 2:47 PM
Herald added a subscriber: lldb-commits. · View Herald Transcript
Harbormaster failed remote builds in B51033: Diff 253709!Mar 30 2020, 3:52 PM
teemperor accepted this revision.Mar 31 2020, 2:15 AM
teemperor added a subscriber: teemperor.

Thanks!

This revision is now accepted and ready to land.Mar 31 2020, 2:15 AM
Closed by commit rGd30e9ad34519: Correct the duplicate pragma marks in CommandObjectTarget.cpp (authored by shivammittal99, committed by teemperor). · Explain WhyMar 31 2020, 2:43 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lldb/
source/
Commands/
4 lines

Diff 253817

lldb/source/Commands/CommandObjectTarget.cpp

Show First 20 Lines • Show All 565 Lines • ▼ Show 20 Lines if (args.GetArgumentCount() == 1) {
result.AppendError( result.AppendError(
"'target select' takes a single argument: a target index\n"); "'target select' takes a single argument: a target index\n");
result.SetStatus(eReturnStatusFailed); result.SetStatus(eReturnStatusFailed);
} }
return result.Succeeded(); return result.Succeeded();
} }
}; };
#pragma mark CommandObjectTargetSelect #pragma mark CommandObjectTargetDelete
// "target delete" // "target delete"
class CommandObjectTargetDelete : public CommandObjectParsed { class CommandObjectTargetDelete : public CommandObjectParsed {
public: public:
CommandObjectTargetDelete(CommandInterpreter &interpreter) CommandObjectTargetDelete(CommandInterpreter &interpreter)
: CommandObjectParsed(interpreter, "target delete", : CommandObjectParsed(interpreter, "target delete",
"Delete one or more targets by target index.", "Delete one or more targets by target index.",
▲ Show 20 Lines • Show All 1,610 Lines • ▼ Show 20 Lines bool DoExecute(Args &command, CommandReturnObject &result) override {
else { else {
result.AppendError("no matching executable images found"); result.AppendError("no matching executable images found");
result.SetStatus(eReturnStatusFailed); result.SetStatus(eReturnStatusFailed);
} }
return result.Succeeded(); return result.Succeeded();
} }
}; };
#pragma mark CommandObjectTargetModulesDumpSections #pragma mark CommandObjectTargetModulesDumpClangAST
// Clang AST dumping command // Clang AST dumping command
class CommandObjectTargetModulesDumpClangAST class CommandObjectTargetModulesDumpClangAST
: public CommandObjectTargetModulesModuleAutoComplete { : public CommandObjectTargetModulesModuleAutoComplete {
public: public:
CommandObjectTargetModulesDumpClangAST(CommandInterpreter &interpreter) CommandObjectTargetModulesDumpClangAST(CommandInterpreter &interpreter)
: CommandObjectTargetModulesModuleAutoComplete( : CommandObjectTargetModulesModuleAutoComplete(
▲ Show 20 Lines • Show All 2,719 Lines • Show Last 20 Lines