Page MenuHomePhabricator

shivammittal99 (Shivam Mittal)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 9 2020, 3:19 AM (11 w, 2 d)

Recent Activity

Apr 6 2020

shivammittal99 added a reviewer for D77568: Return correct entry in RangeDataVector::FindEntryThatContains: labath.
Apr 6 2020, 10:52 PM · Restricted Project
shivammittal99 created D77568: Return correct entry in RangeDataVector::FindEntryThatContains.
Apr 6 2020, 10:18 AM · Restricted Project

Apr 2 2020

shivammittal99 added a comment to D76729: Convert for loops to entry-based iteration.

Can you please commit this for me? I do not have commit access.

Apr 2 2020, 5:56 AM · Restricted Project

Mar 30 2020

shivammittal99 created D77096: Correct the duplicate pragma marks in CommandObjectTarget.cpp.
Mar 30 2020, 3:16 PM · Restricted Project

Mar 26 2020

shivammittal99 added a reviewer for D76729: Convert for loops to entry-based iteration: labath.
Mar 26 2020, 4:17 AM · Restricted Project
shivammittal99 added a comment to D76569: Convert CommandObjectCommands functions to return StringRefs.

Can someone please land this patch for me? I do not have commit access.

Mar 26 2020, 2:07 AM · Restricted Project

Mar 24 2020

shivammittal99 updated the diff for D76729: Convert for loops to entry-based iteration.

Run clang-format

Mar 24 2020, 2:34 PM · Restricted Project
shivammittal99 created D76729: Convert for loops to entry-based iteration.
Mar 24 2020, 2:01 PM · Restricted Project

Mar 23 2020

shivammittal99 updated the diff for D76569: Convert CommandObjectCommands functions to return StringRefs.

Remove conditional and move raw_command_string line

Mar 23 2020, 1:06 PM · Restricted Project
shivammittal99 added a comment to D76569: Convert CommandObjectCommands functions to return StringRefs.

run by hand ASAN-built LLDB for the code modified by this patch.

How do I do that? This is my first PR to llvm, so I am not aware of the tools. Please bear with me.

Mar 23 2020, 7:03 AM · Restricted Project
shivammittal99 added a comment to D76569: Convert CommandObjectCommands functions to return StringRefs.

@jankratochvil When I use LLVM_USE_SANITIZER=Address and then run ninja check-lldb I get other errors:

Mar 23 2020, 3:15 AM · Restricted Project

Mar 22 2020

shivammittal99 added a comment to D76569: Convert CommandObjectCommands functions to return StringRefs.

I don't know why is clang-tidy failing. I haven't changed the import or any other file than CommandObjectCommands.cpp. @jingham @aprantl Could you please help?

Mar 22 2020, 1:23 PM · Restricted Project
shivammittal99 added reviewers for D76569: Convert CommandObjectCommands functions to return StringRefs: jingham, aprantl.
Mar 22 2020, 12:51 PM · Restricted Project
shivammittal99 created D76569: Convert CommandObjectCommands functions to return StringRefs.
Mar 22 2020, 10:08 AM · Restricted Project