This is an archive of the discontinued LLVM Phabricator instance.

CMake: Turn LLVM_ENABLE_ZLIB into a tri-state option
ClosedPublic

Authored by akhuang on Mar 12 2020, 4:22 PM.

Details

Summary

Add FORCE_ON option to LLVM_ENABLE_ZLIB, which causes a configuration
error if zlib is not found.
Similar to https://reviews.llvm.org/D40050.

Diff Detail

Event Timeline

akhuang created this revision.Mar 12 2020, 4:22 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 12 2020, 4:22 PM
rnk accepted this revision.Mar 12 2020, 6:27 PM

lgtm

This revision is now accepted and ready to land.Mar 12 2020, 6:27 PM
This revision was automatically updated to reflect the committed changes.
grimar added a subscriber: grimar.Mar 14 2020, 7:17 AM
grimar added inline comments.
llvm/CMakeLists.txt
350

I wonder if REQUIRE sounds better.
(For me it was not clear what FORCE_ON means from its name).

But, it is not consistent with the existent FORCE_ON used for libxml2.