This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] Use conservative defaults for XNACK/SRAM ECC
AbandonedPublic

Authored by kerbowa on Feb 23 2020, 11:03 PM.

Details

Summary

RFC. WIP. Use conservatively correct settings for XNACK and SRAM ECC for all
subtargets which may support either feature. The conservative settings
in this case are XNACK on and SRAM ECC on.

Although some additional updates must be completed outside of the
backend to facilitate this change, I'm posting this review now for
visibility.

Event Timeline

kerbowa created this revision.Feb 23 2020, 11:03 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 23 2020, 11:03 PM
asbirlea removed a subscriber: asbirlea.Feb 24 2020, 7:29 AM

Maybe extract AMDGPU.td changes into a separate patch for the time being? These seem safe.

llvm/lib/Target/AMDGPU/AMDGPUSubtarget.cpp
155

That's a right thing to do, but I suppose needs some testing and fixing at least known apps doing so before we can submit.

kerbowa edited the summary of this revision. (Show Details)Feb 28 2020, 7:16 AM
scott.linder added a subscriber: scott.linder.
scott.linder added inline comments.
llvm/lib/Target/AMDGPU/AMDGPU.td
753

Could you also include an update to processors table in llvm/docs/AMDGPUUsage.rst for all the changing defaults? It is currently wrong anyway because we forbid XNACK on some targets, but if we are fixing things it would be good to fix it as well.

arsenm added inline comments.Apr 2 2020, 9:11 AM
llvm/lib/Target/AMDGPU/AMDGPU.td
781

This feature should really be removed from all subtargets, but that's a separate change

kerbowa abandoned this revision.Oct 19 2020, 9:36 AM