[lldb] Ignore type sugar in TypeSystemClang::GetPointerType

[teemperor]

Summary

Currently having a typedef for ObjC types is breaking member access in LLDB:

typedef NSString Str;
NSString *s; s.length; // OK
Str *s; s.length; // Causes: member reference base type 'Str *' (aka 'NSString *') is not a structure or union

This works for NSString as there the type building from NSString -> NSString * will correctly
build a ObjCObjectPointerType (which is necessary to make member access with a dot possible),
but for the typedef the Str -> Str * conversion will produce an incorrect PointerType. The reason
for this is that our check in TypeSystemClang::GetPointerType is not desugaring the base type,
which causes that Str is not recognised as a type to a ObjCInterface as the check only sees the
typedef sugar that was put around it. This causes that we fall back to constructing a PointerType
instead which does not allow member access with the dot operator.

This patch just changes the check to look at the desugared type instead.

Fixes rdar://17525603

[mib]

LGTM!

[davide]

Good catch.

lldb/packages/Python/lldbsuite/test/lang/objc/objc-property/TestObjCProperty.py

def test_objc_properties(self):
         backed_value = frame.EvaluateExpression("mine.backedInt", False)
         backed_error = backed_value.GetError()
         self.assertTrue(backed_error.Success())
         backing_value = mine.GetChildMemberWithName("_backedInt")
         self.assertTrue(backing_value.IsValid())
         self.assertTrue(backed_value.GetValueAsUnsigned(12345)
                         == backing_value.GetValueAsUnsigned(23456))
 
+        value_from_typedef = frame.EvaluateExpression("typedefd.backedInt", False)
+        self.assertTrue(value_from_typedef.GetError().Success())
+        self.assertEqual(value_from_typedef.GetValueAsUnsigned(12345),
+                         backing_value.GetValueAsUnsigned(23456))
+
         unbacked_value = frame.EvaluateExpression("mine.unbackedInt", False)
         unbacked_error = unbacked_value.GetError()
         self.assertTrue(unbacked_error.Success())
 
         idWithProtocol_value = frame.EvaluateExpression(
             "mine.idWithProtocol", False)
         idWithProtocol_error = idWithProtocol_value.GetError()
         self.assertTrue(idWithProtocol_error.Success())

lldb/packages/Python/lldbsuite/test/lang/objc/objc-property/main.m

 }
 
 - (int) getAccessCount
 {
   return _access_count;
 }
 @end
 
+typedef BaseClass TypedefBaseClass;
+
 int
 main ()
 {
   BaseClass *mine = [BaseClass baseClassWithBackedInt: 10 andUnbackedInt: 20];
+  TypedefBaseClass *typedefd = mine;
   
   // Set a breakpoint here.
   int nonexistant = mine.nonexistantInt;
 
   int backedInt = mine.backedInt;
 
   int unbackedInt = mine.unbackedInt;
 

lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp

TypeSystemClang::GetPointeeType(lldb::opaque_compiler_type_t type) {
   return CompilerType();
 }
 
 CompilerType
 TypeSystemClang::GetPointerType(lldb::opaque_compiler_type_t type) {
   if (type) {
     clang::QualType qual_type(GetQualType(type));
 
-    const clang::Type::TypeClass type_class = qual_type->getTypeClass();
-    switch (type_class) {
+    switch (qual_type.getDesugaredType(getASTContext())->getTypeClass()) {
     case clang::Type::ObjCObject:
     case clang::Type::ObjCInterface:
       return GetType(getASTContext().getObjCObjectPointerType(qual_type));
 
     default:
       return GetType(getASTContext().getPointerType(qual_type));
     }
   }