The call site info was not updated correctly when deleting corresponding call instructions.
(this was split from the D73534)
Paths
| Differential D73700
[CallSiteInfo] Fix the assertions regarding updating the CallSiteInfo ClosedPublic Authored by djtodoro on Jan 30 2020, 5:57 AM.
Details Summary The call site info was not updated correctly when deleting corresponding call instructions. (this was split from the D73534)
Diff Detail Event Timelinedjtodoro mentioned this in D73534: [DebugInfo] Enable the debug entry values feature by default.Jan 30 2020, 6:02 AM djtodoro added a child revision: D73534: [DebugInfo] Enable the debug entry values feature by default.
Comment Actions @vsk Thanks for the comments!
djtodoro added inline comments.
Comment Actions LGTM, pending resolution of https://reviews.llvm.org/D74121 vs. https://reviews.llvm.org/D74159. (I believe this can easily be rebased on top of either patch.) This revision is now accepted and ready to land.Feb 6 2020, 1:26 PM Closed by commit rG3a4dc577c972: [CSInfo] Fix the assertions regarding updating the CSInfo (authored by djtodoro). · Explain WhyFeb 10 2020, 2:02 AM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 241425 llvm/lib/CodeGen/MachineLICM.cpp
llvm/lib/CodeGen/TargetLoweringBase.cpp
llvm/lib/Target/AArch64/AArch64CleanupLocalDynamicTLSPass.cpp
llvm/lib/Target/X86/X86SpeculativeLoadHardening.cpp
llvm/test/CodeGen/AArch64/arm64-anyregcc.ll
llvm/test/CodeGen/AArch64/arm64-patchpoint.ll
llvm/test/CodeGen/AArch64/arm64-tls-dynamics.ll
llvm/test/CodeGen/AArch64/stackmap-frame-setup.ll
llvm/test/CodeGen/AArch64/stackmap.ll
llvm/test/CodeGen/X86/anyregcc.ll
llvm/test/CodeGen/X86/combineIncDecVector-crash.ll
llvm/test/CodeGen/X86/deopt-bundles.ll
llvm/test/CodeGen/X86/fast-isel-gc-intrinsics.ll
llvm/test/CodeGen/X86/hoist-invariant-load.ll
llvm/test/CodeGen/X86/machine-sink-and-implicit-null-checks.ll
llvm/test/CodeGen/X86/patchpoint.ll
llvm/test/CodeGen/X86/pr33010.ll
llvm/test/CodeGen/X86/speculative-load-hardening-indirect.ll
llvm/test/CodeGen/X86/stackmap-fast-isel.ll
llvm/test/CodeGen/X86/stackmap-frame-setup.ll
llvm/test/CodeGen/X86/stackmap-large-location-size.ll
llvm/test/CodeGen/X86/stackmap.ll
llvm/test/CodeGen/X86/statepoint-allocas.ll
llvm/test/CodeGen/X86/statepoint-call-lowering.ll
llvm/test/CodeGen/X86/statepoint-forward.ll
llvm/test/CodeGen/X86/statepoint-gctransition-call-lowering.ll
llvm/test/CodeGen/X86/statepoint-invoke.ll
llvm/test/CodeGen/X86/statepoint-live-in.ll
llvm/test/CodeGen/X86/statepoint-no-realign-stack.ll
llvm/test/CodeGen/X86/statepoint-stackmap-format.ll
llvm/test/CodeGen/X86/statepoint-uniqueing.ll
llvm/test/CodeGen/X86/statepoint-vector-bad-spill.ll
llvm/test/CodeGen/X86/statepoint-vector.ll
llvm/test/CodeGen/X86/xray-custom-log.ll
llvm/test/CodeGen/X86/xray-typed-event-log.ll
|
I'm a bit confused by this one. ExtractHoistableLoad can hoist a call? What cases MI->isDereferenceableInvariantLoad(AA) and MI->isCall() to both be true?