This is an archive of the discontinued LLVM Phabricator instance.

[NFC] Fix compilation of CrashRecoveryContext.cpp on mingw
ClosedPublic

Authored by zero9178 on Jan 11 2020, 4:22 PM.

Reviewers

Commits

Summary

The method HandleCrash takes a uintptr as it's second argument. Trying to pass type PEXCEPTION_POINTERS requires a reinterpret_cast.

Would need someone to commit this for me as well

Thanks for the fix Markus! I can commit on your behalf.

This revision is now accepted and ready to land.Jan 12 2020, 9:06 AM

That would be great thanks!

This revision was automatically updated to reflect the committed changes.

Path

Size

llvm/

lib/

Support/

3 lines

Context not available.

	// Handle the crash	// Handle the crash
	const_cast<CrashRecoveryContextImpl *>(CRCI)->HandleCrash(	const_cast<CrashRecoveryContextImpl *>(CRCI)->HandleCrash(
	(int)ExceptionInfo->ExceptionRecord->ExceptionCode, ExceptionInfo);	(int)ExceptionInfo->ExceptionRecord->ExceptionCode,
		reinterpret_cast<uintptr_t>(ExceptionInfo));

	// Note that we don't actually get here because HandleCrash calls	// Note that we don't actually get here because HandleCrash calls
	// longjmp, which means the HandleCrash function never returns.	// longjmp, which means the HandleCrash function never returns.
Context not available.