Thanks! :)

@leonardchan I don't have commit access; can you land this change and D92141 for me?

Removed duplicate tests as suggested by leonardchan

(I marked this as depending on D92140 because if you apply this patch to the current HEAD directly, the tests will break.)

In D91828#2411207, @aaron.ballman wrote:

In D91828#2411203, @thejh wrote:

@aaron.ballman Can you land it for me? I don't have commit access.

Happy to do so -- are you okay with "Jann Horn <jannh@google.com>" for author attribution?

@aaron.ballman Can you land it for me? I don't have commit access.

As requested by @aaron.ballman, added tests for edgecases where
sizeof()/typeid() can cause memory access.

re-uploading to trigger a new build, since the build error looks unrelated.
maybe current trunk is flaky?

resend patch to trigger new build

resend patch to trigger new build

resend patch to trigger new build

let's see whether the build system is more happy if I just resend this...

I don't understand those latest build failures at all. I've run the regression tests, with mlir enabled. I see no failures, even when building off the exact commit in the build log. Manually running mlir/test/Dialect/Vector/vector-transforms.mlir doesn't show any errors either.

rebase to make harbormaster happy

rebase to make harbormaster happy

rebase to make harbormaster happy

rebase to make harbormaster happy

Ugh... so the build failed on this patch because actually a preceding patch no longer applies cleanly and LLVM's build infrastructure doesn't have base-commit support and therefore can't do an automatic 3-way merge?

I missed that Kostya commented a while back that it'd be better to have a flag to gate the new functionality... adding that now.

@glider Alright, I've fixed the clang-format stuff (and fixed a mistake where I put a variable declaration in the wrong patch, and another clang-tidy warning about coding conventions on variable naming). The build status is "passed" on all four patches now.

rebase onto changed preceding patches

move one declaration from patch 3 to patch 2

move one declaration from patch 3 to patch 2

fix clang-tidy complaint

fix clang-format warnings

fix clang-format warnings

fix clang-format warnings

fix clang-format warnings

ping

Ah, and I don't have commit access. (The docs say I'm supposed to point that out.)