This is an archive of the discontinued LLVM Phabricator instance.

[Dsymutil][Debuginfo][NFC] #3 Refactor dsymutil to separate DWARF optimizing part.
ClosedPublic

Authored by avl on Jan 9 2020, 12:43 PM.

Details

Summary

This is the next portion of patches for dsymutil.

Create DwarfEmitter interface to generate all debug info tables.
Put DwarfEmitter into DwarfLinker library and make tools/dsymutil/DwarfStreamer
to be child of DwarfEmitter.

It passes check-all testing. MD5 checksum for clang .dSYM bundle matches
for the dsymutil with/without that patch.

Diff Detail

Event Timeline

avl created this revision.Jan 9 2020, 12:43 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 9 2020, 12:43 PM
Herald added a subscriber: hiraditya. · View Herald Transcript

Unit tests: pass. 61681 tests passed, 0 failed and 779 were skipped.

clang-tidy: fail. Please fix clang-tidy findings.

clang-format: pass.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

avl updated this revision to Diff 237521.Jan 11 2020, 2:05 PM

apply clang-tidy findings.

Unit tests: pass. 61772 tests passed, 0 failed and 780 were skipped.

clang-tidy: fail. Please fix clang-tidy findings.

clang-format: pass.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

avl added a comment.EditedJan 12 2020, 2:59 AM

style issues reported by clang-tidy this time do not relate to my patch.

This revision is now accepted and ready to land.Jan 13 2020, 9:59 AM
This revision was automatically updated to reflect the committed changes.