Page MenuHomePhabricator

Reland "[AST] Traverse the class type loc inside the member type loc.""
ClosedPublic

Authored by hokein on Dec 9 2019, 1:40 AM.

Details

Summary

added a unittest which causes "TL.getClassTInfo" is null.

Diff Detail

Event Timeline

hokein created this revision.Dec 9 2019, 1:40 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 9 2019, 1:40 AM

Build result: pass - 60555 tests passed, 0 failed and 726 were skipped.

Log files: console-log.txt, CMakeCache.txt

ilya-biryukov accepted this revision.Dec 9 2019, 2:08 AM

LGTM

clang/unittests/Tooling/RecursiveASTVisitorTests/MemberPointerTypeLoc.cpp
51

Could you add a comment explaining what this is testing?

Is this the case that does not have TypeSourceInfo?

This revision is now accepted and ready to land.Dec 9 2019, 2:08 AM
hokein updated this revision to Diff 232782.Dec 9 2019, 2:16 AM

address the review comment.

hokein marked 2 inline comments as done.Dec 9 2019, 2:17 AM
hokein added inline comments.
clang/unittests/Tooling/RecursiveASTVisitorTests/MemberPointerTypeLoc.cpp
51

Yes, exactly.

This revision was automatically updated to reflect the committed changes.
hokein marked an inline comment as done.

Build result: pass - 60555 tests passed, 0 failed and 726 were skipped.

Log files: console-log.txt, CMakeCache.txt