This is an archive of the discontinued LLVM Phabricator instance.

llvm-symbolizer: Support loclist in FRAME.
ClosedPublic

Authored by eugenis on Nov 22 2019, 5:44 PM.

Details

Summary

Support location lists in FRAME command.
These are used for the majority of local variables in optimized code.

Event Timeline

eugenis created this revision.Nov 22 2019, 5:44 PM
Herald added a project: Restricted Project. · View Herald Transcript
pcc accepted this revision.Nov 22 2019, 6:17 PM

LGTM

Maybe also mention the DW_AT_frame_base thing in the commit message.

This revision is now accepted and ready to land.Nov 22 2019, 6:17 PM
eugenis updated this revision to Diff 230745.Nov 22 2019, 6:23 PM

updated description

This revision was automatically updated to reflect the committed changes.
dblaikie added inline comments.
llvm/test/tools/llvm-symbolizer/frame-loclist.s
7

Could you include the source in a comment here to help summarize the assembly & explain which particular things this is trying to test? (does this need three loclists to cover the patch? Or could it be covered with less?)