This is an archive of the discontinued LLVM Phabricator instance.

Add C source to two debug info tests.
ClosedPublic

Authored by eugenis on Dec 30 2019, 6:09 PM.

Diff Detail

Event Timeline

eugenis created this revision.Dec 30 2019, 6:09 PM
Herald added a project: Restricted Project. · View Herald Transcript

Unit tests: pass. 61155 tests passed, 0 failed and 728 were skipped.

clang-tidy: pass.

clang-format: pass.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

dblaikie added inline comments.Jan 2 2020, 1:03 PM
llvm/test/tools/llvm-symbolizer/frame-loclist.s
75–82

What's this DW_AT_location? The comment says the variable is optimized out, but I would take it from the presence of this location description that it isn't optimized out & that description is the one in the assembly for this location?

eugenis updated this revision to Diff 235940.Jan 2 2020, 1:40 PM

reworded the comment

eugenis marked an inline comment as done.Jan 2 2020, 1:41 PM
eugenis added inline comments.
llvm/test/tools/llvm-symbolizer/frame-loclist.s
75–82

this tests the case when there are no FP-relative locations in the list, i.e. the variable either has no stack location, or that information is lost somehow.

Unit tests: pass. 61175 tests passed, 0 failed and 729 were skipped.

clang-tidy: pass.

clang-format: pass.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

dblaikie accepted this revision.Jan 2 2020, 2:10 PM
This revision is now accepted and ready to land.Jan 2 2020, 2:10 PM
This revision was automatically updated to reflect the committed changes.

Should be fixed in 3e5eac03580

thakis added a comment.Jan 2 2020, 3:35 PM

Confirmed fixed as of http://45.33.8.238/win/4999/summary.html

Thanks for the quick fix!