Page MenuHomePhabricator

Modernize the rest of the Find.* API (NFC)
ClosedPublic

Authored by aprantl on Oct 17 2019, 10:31 AM.

Details

Summary

This patch removes the size_t return value and the append parameter from the remainder of the Fund.* functions in LLDB's internal API. As in the previous patches, this is motivated by the fact that these parameters aren't really used, and in the case of the append parameter were frequently implemented incorrectly.

Diff Detail

Event Timeline

aprantl created this revision.Oct 17 2019, 10:31 AM
JDevlieghere accepted this revision.Oct 17 2019, 11:00 AM
This revision is now accepted and ready to land.Oct 17 2019, 11:00 AM
labath accepted this revision.Oct 17 2019, 11:12 AM

yay

lldb/tools/lldb-test/lldb-test.cpp
439–448

I'm pretty sure these Clears are not needed.

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptOct 17 2019, 1:04 PM

This breaks the build due to lldb/source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp:1355:8: error: unused variable 'old_size' [-Werror,-Wunused-variable]

I will check in a fix shortly.