This is an archive of the discontinued LLVM Phabricator instance.

Differential D68781

[OpenCL] Fix address space for const method call from nonconst
ClosedPublic

Authored by svenvh on Oct 10 2019, 4:24 AM.

Details

Reviewers
Anastasia
Commits
rG82888b78d47e: [OpenCL] Fix address space for const method call from nonconst (PR43145)

Diff Detail

Event Timeline

Anastasia created this revision.Oct 10 2019, 4:24 AM
Herald added a subscriber: yaxunl. · View Herald TranscriptOct 10 2019, 4:24 AM
svenvh commandeered this revision.Nov 1 2019, 10:26 AM
svenvh updated this revision to Diff 227476.
svenvh added a reviewer: Anastasia.
svenvh retitled this revision from [OpenCL] Fix addr space conversion check in obj arg initialization to [OpenCL] Fix address space for const method call from nonconst.
svenvh set the repository for this revision to rC Clang.

Fix formatting, reduce use of auto, and add a test.

Herald added a project: Restricted Project. · View Herald TranscriptNov 1 2019, 10:27 AM
Herald added subscribers: cfe-commits, ebevhan. · View Herald Transcript
Anastasia accepted this revision.Nov 4 2019, 3:07 AM

LGTM! Thanks

This revision is now accepted and ready to land.Nov 4 2019, 3:07 AM
Closed by commit rG82888b78d47e: [OpenCL] Fix address space for const method call from nonconst (PR43145) (authored by svenvh). · Explain WhyNov 4 2019, 5:15 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
clang/
lib/
Sema/
4 lines

Diff 224311

clang/lib/Sema/SemaOverload.cpp

Context not available.
if (!Context.hasSameType(From->getType(), DestType)) { if (!Context.hasSameType(From->getType(), DestType)) {
CastKind CK; CastKind CK;
if (FromRecordType.getAddressSpace() != DestType.getAddressSpace()) auto Ptee = DestType->getPointeeType();
auto DestAS = Ptee.isNull() ? DestType.getAddressSpace() : Ptee.getAddressSpace();
if (FromRecordType.getAddressSpace() != DestAS)
CK = CK_AddressSpaceConversion; CK = CK_AddressSpaceConversion;
else else
CK = CK_NoOp; CK = CK_NoOp;
Context not available.