This is an archive of the discontinued LLVM Phabricator instance.

Revert "[AMDGPU] Run `unreachable-mbb-elimination` after isel to clean up PHIs."
ClosedPublic

Authored by foad on Oct 10 2019, 2:22 AM.

Reviewers

Commits

Summary

This has been superseded by "[AMDGPU]: PHI Elimination hooks added for custom COPY insertion."

This reverts the code changes from commit 53f967f2bdb6aa7b08596880c3689d1ecad6f0ff
but keeps the test case.

Repository

rG LLVM Github Monorepo

Build Status

Buildable 39304
Build 39320: arc lint + arc unit

LGTM

This revision is now accepted and ready to land.Oct 10 2019, 6:29 AM

This revision was automatically updated to reflect the committed changes.

Path

Size

llvm/

lib/

Target/

AMDGPU/

3 lines

	Show First 20 Lines • Show All 879 Lines • ▼ Show 20 Lines
	}			}

	bool GCNPassConfig::addInstSelector() {			bool GCNPassConfig::addInstSelector() {
	AMDGPUPassConfig::addInstSelector();			AMDGPUPassConfig::addInstSelector();
	addPass(&SIFixSGPRCopiesID);			addPass(&SIFixSGPRCopiesID);
	addPass(createSILowerI1CopiesPass());			addPass(createSILowerI1CopiesPass());
	addPass(createSIFixupVectorISelPass());			addPass(createSIFixupVectorISelPass());
	addPass(createSIAddIMGInitPass());			addPass(createSIAddIMGInitPass());
	// FIXME: Remove this once the phi on CF_END is cleaned up by either removing
	// LCSSA or other ways.
	addPass(&UnreachableMachineBlockElimID);
	return false;			return false;
	}			}

	bool GCNPassConfig::addIRTranslator() {			bool GCNPassConfig::addIRTranslator() {
	addPass(new IRTranslator());			addPass(new IRTranslator());
	return false;			return false;
	}			}

	▲ Show 20 Lines • Show All 261 Lines • Show Last 20 Lines