All other stack trace callers assume that PC contains return address.
HWAsan already use GetNextInstructionPc in similar code.
PR43339
Paths
| Differential D68313
[compiler-rt] Use GetNextInstructionPc in signal handlers ClosedPublic Authored by vitalybuka on Oct 1 2019, 6:58 PM.
Details Summary All other stack trace callers assume that PC contains return address. PR43339
Diff Detail
Event TimelineThis revision is now accepted and ready to land.Oct 2 2019, 10:44 AM This revision now requires changes to proceed.Oct 2 2019, 10:45 AM vitalybuka added inline comments.
vitalybuka added inline comments.
vitalybuka added inline comments.
This revision is now accepted and ready to land.Oct 2 2019, 11:01 AM Closed by commit rL373529: [compiler-rt] Use GetNextInstructionPc in signal handlers (authored by vitalybuka). · Explain WhyOct 2 2019, 2:24 PM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 222741 compiler-rt/lib/asan/asan_errors.cpp
compiler-rt/lib/lsan/lsan.cpp
compiler-rt/lib/msan/msan.cpp
compiler-rt/lib/tsan/rtl/tsan_rtl.cpp
compiler-rt/lib/ubsan/ubsan_signals_standalone.cpp
compiler-rt/test/sanitizer_common/TestCases/Linux/signal_line.cpp
|
Well, this is not a good symptom.
Do you know why?