Page MenuHomePhabricator

delcypher (Dan Liew)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 21 2015, 4:29 PM (187 w, 1 d)

Recent Activity

Thu, Mar 21

delcypher added inline comments to D59504: [NFC][Sanitizer] Clean up GetRealFunctionAddress.
Thu, Mar 21, 3:40 PM · Restricted Project, Restricted Project
delcypher committed rCRT356701: Enable `asan/TestCases/Posix/start-deactivated.cc` test for iOS..
Enable `asan/TestCases/Posix/start-deactivated.cc` test for iOS.
Thu, Mar 21, 12:22 PM
delcypher committed rG5988d72243bc: Enable `asan/TestCases/Posix/start-deactivated.cc` test for iOS. (authored by delcypher).
Enable `asan/TestCases/Posix/start-deactivated.cc` test for iOS.
Thu, Mar 21, 12:20 PM
delcypher committed rL356701: Enable `asan/TestCases/Posix/start-deactivated.cc` test for iOS..
Enable `asan/TestCases/Posix/start-deactivated.cc` test for iOS.
Thu, Mar 21, 12:19 PM
delcypher closed D59660: Enable `asan/TestCases/Posix/start-deactivated.cc` test for iOS..
Thu, Mar 21, 12:19 PM · Restricted Project, Restricted Project
delcypher created D59660: Enable `asan/TestCases/Posix/start-deactivated.cc` test for iOS..
Thu, Mar 21, 11:55 AM · Restricted Project, Restricted Project
delcypher removed a reviewer for D59660: Enable `asan/TestCases/Posix/start-deactivated.cc` test for iOS.: serge-sans-paille.
Thu, Mar 21, 11:55 AM · Restricted Project, Restricted Project

Mon, Mar 18

delcypher added a comment to D54978: Move the SMT API to LLVM.

Would one of you be able to file a bug against Z3 to fix this? I am no longer in a position to contribute to Z3 so I can't do this.

I've opened https://github.com/Z3Prover/z3/issues/2184 .

Mon, Mar 18, 8:41 AM · Restricted Project, Restricted Project

Sat, Mar 16

delcypher added a comment to D54978: Move the SMT API to LLVM.

Hi all,

Sorry for the massive delay, but I just updated the FindZ3 script to retrieve the version from the lib. I changed it to use try_run instead of try_compile so we can get the version number.

I tried to use @brzycki code to get the version from the header, however, it's not working for Z3 4.8.4. In Z3 4.8.3 the FULL_VERSION is a nice "Z3 4.8.3.0" but in version 4.8.4 it's "Z3 4.8.4.10272 d6df51951f4c master z3-4.8.4" and cmake fails with the following message:

-- Could NOT find Z3: Found unsuitable version "#define Z3_FULL_VERSION    "Z3 4.8.4.10272 d6df51951f4c master z3-4.8.4"", but required is at least "4.7.1" (found /home/mgadelha/z3/bin/libz3.so)
Sat, Mar 16, 6:41 AM · Restricted Project, Restricted Project
delcypher added a comment to D54978: Move the SMT API to LLVM.

The only relevant commit that I can find is https://github.com/Z3Prover/z3/commit/2cb4223979cc94e2ebc4e49a9e83adbdcd2b6979 , but it first landed in z3 4.6.0. It looks like it's specific to CMake though, so is it different if you use the python build? I haven't tried the CMake build.

Sat, Mar 16, 6:33 AM · Restricted Project, Restricted Project

Fri, Mar 15

delcypher committed rG0bb9b5b481b7: [CMake] Fix broken uses of `try_compile_only()` and improve the function. (authored by delcypher).
[CMake] Fix broken uses of `try_compile_only()` and improve the function.
Fri, Mar 15, 1:15 PM
delcypher committed rL356295: [CMake] Fix broken uses of `try_compile_only()` and improve the function..
[CMake] Fix broken uses of `try_compile_only()` and improve the function.
Fri, Mar 15, 1:15 PM
delcypher committed rCRT356295: [CMake] Fix broken uses of `try_compile_only()` and improve the function..
[CMake] Fix broken uses of `try_compile_only()` and improve the function.
Fri, Mar 15, 1:15 PM
delcypher closed D59429: [CMake] Fix broken uses of `try_compile_only()` and improve the function..
Fri, Mar 15, 1:15 PM · Restricted Project, Restricted Project
delcypher updated the diff for D59429: [CMake] Fix broken uses of `try_compile_only()` and improve the function..

Fix missing unused arguments checks.

Fri, Mar 15, 12:49 PM · Restricted Project, Restricted Project
delcypher created D59429: [CMake] Fix broken uses of `try_compile_only()` and improve the function..
Fri, Mar 15, 12:46 PM · Restricted Project, Restricted Project
delcypher added a comment to D58578: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms..

@kubamracek @yln ping.

Fri, Mar 15, 6:44 AM · Restricted Project, Restricted Project

Fri, Mar 8

delcypher created D59150: [CMake] Separate the detection Darwin platforms architectures for the built-ins from the rest of compiler-rt..
Fri, Mar 8, 12:59 PM · Restricted Project, Restricted Project

Fri, Mar 1

delcypher added inline comments to D58194: [DebugInfo] add SectionedAddress to DebugInfo interfaces..
Fri, Mar 1, 5:31 AM · debug-info, Restricted Project

Thu, Feb 28

delcypher added inline comments to D58194: [DebugInfo] add SectionedAddress to DebugInfo interfaces..
Thu, Feb 28, 2:47 PM · debug-info, Restricted Project
delcypher committed rGd14f1b26fb41: [CMake][LibFuzzer] Match symbol visibility setting between LibFuzzer object… (authored by delcypher).
[CMake][LibFuzzer] Match symbol visibility setting between LibFuzzer object…
Thu, Feb 28, 1:57 PM
delcypher committed rL355143: [CMake][LibFuzzer] Match symbol visibility setting between LibFuzzer object….
[CMake][LibFuzzer] Match symbol visibility setting between LibFuzzer object…
Thu, Feb 28, 1:57 PM
delcypher committed rCRT355143: [CMake][LibFuzzer] Match symbol visibility setting between LibFuzzer object….
[CMake][LibFuzzer] Match symbol visibility setting between LibFuzzer object…
Thu, Feb 28, 1:57 PM
delcypher closed D58055: [CMake][LibFuzzer] Match symbol visibility setting between LibFuzzer object files and unit tests..
Thu, Feb 28, 1:57 PM · Restricted Project, Restricted Project
delcypher added a comment to D58055: [CMake][LibFuzzer] Match symbol visibility setting between LibFuzzer object files and unit tests..
In D58055#1410888, @yln wrote:

LGTM. Compiling all linker inputs with the same visibility is the right approach.

Please check my understanding:
Before r336238 the kIgnoreRemaining constant got inlined, both into libFuzzer and the unit test.

Thu, Feb 28, 9:59 AM · Restricted Project, Restricted Project
delcypher added inline comments to D58194: [DebugInfo] add SectionedAddress to DebugInfo interfaces..
Thu, Feb 28, 8:26 AM · debug-info, Restricted Project

Tue, Feb 26

delcypher added a comment to D58055: [CMake][LibFuzzer] Match symbol visibility setting between LibFuzzer object files and unit tests..

@yln @kubamracek Ping.

Tue, Feb 26, 8:14 AM · Restricted Project, Restricted Project

Mon, Feb 25

delcypher added inline comments to D58578: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms..
Mon, Feb 25, 10:48 AM · Restricted Project, Restricted Project

Sat, Feb 23

delcypher created D58578: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms..
Sat, Feb 23, 5:28 AM · Restricted Project, Restricted Project

Feb 15 2019

delcypher accepted D58209: [Sanitizer] iOS: Pull up parallelism_group handling into common.lit.config.

LGTM

Feb 15 2019, 11:19 AM · Restricted Project, Restricted Project

Feb 14 2019

delcypher added inline comments to D57535: [CMake] Use LLVM_ENABLE_PROJECTS as the "single source" of truth when used..
Feb 14 2019, 4:04 PM · Restricted Project

Feb 11 2019

delcypher created D58055: [CMake][LibFuzzer] Match symbol visibility setting between LibFuzzer object files and unit tests..
Feb 11 2019, 8:43 AM · Restricted Project, Restricted Project

Feb 7 2019

delcypher added a comment to D57535: [CMake] Use LLVM_ENABLE_PROJECTS as the "single source" of truth when used..

Could we sanitize the list of LLVM_ENABLE_PROJECTS and error for unknown entries?

Feb 7 2019, 3:50 AM · Restricted Project

Feb 6 2019

delcypher added a comment to D57279: NFC: Reduce presence of "template <typename AddressSpaceView>".

@vitalybuka Thanks for working on this.

Context for those new to the patch: We are looking at ways of converting a Allocator<LocalAddressSpaceView> into a Allocator<RemoteAddressSpaceView>. With the current design on master it is not safe to do a reinterpret_cast<>() because C++ doesn't guarantee that the two different types have the same data-layout or fields (AFAIK).

Now you can reinterpret/memcpy at base class level.

Feb 6 2019, 5:38 AM

Feb 5 2019

delcypher added a comment to D57750: [CMake] Don't add `cxx` to `LLDB_TEST_DEPS` if it doesn't exist..

Wow phabricator has made a right mess of displaying this patch. It's easier to look at as.

Feb 5 2019, 6:37 AM · Restricted Project
delcypher created D57750: [CMake] Don't add `cxx` to `LLDB_TEST_DEPS` if it doesn't exist..
Feb 5 2019, 6:32 AM · Restricted Project
delcypher added a comment to D57535: [CMake] Use LLVM_ENABLE_PROJECTS as the "single source" of truth when used..

Do you have any follow-up plans here? No pressure; just didn't want to potentially duplicate any work.

Feb 5 2019, 12:50 AM · Restricted Project
delcypher committed rGde5220ed5e5a: Previously if the user configured their build but then changed… (authored by delcypher).
Previously if the user configured their build but then changed…
Feb 5 2019, 12:48 AM
delcypher committed rL353148: Previously if the user configured their build but then changed.
Previously if the user configured their build but then changed
Feb 5 2019, 12:48 AM
delcypher closed D57535: [CMake] Use LLVM_ENABLE_PROJECTS as the "single source" of truth when used..
Feb 5 2019, 12:48 AM · Restricted Project
delcypher added inline comments to D57535: [CMake] Use LLVM_ENABLE_PROJECTS as the "single source" of truth when used..
Feb 5 2019, 12:44 AM · Restricted Project
delcypher updated the diff for D57535: [CMake] Use LLVM_ENABLE_PROJECTS as the "single source" of truth when used..
  • Drop unset(PROJECT_INDEX)
Feb 5 2019, 12:43 AM · Restricted Project

Feb 4 2019

delcypher added reviewers for D57279: NFC: Reduce presence of "template <typename AddressSpaceView>": kubamracek, yln.
Feb 4 2019, 1:17 PM
delcypher updated the diff for D57535: [CMake] Use LLVM_ENABLE_PROJECTS as the "single source" of truth when used..

use if (<variable|string> IN_LIST <variable>)

Feb 4 2019, 1:14 PM · Restricted Project
delcypher added inline comments to D57535: [CMake] Use LLVM_ENABLE_PROJECTS as the "single source" of truth when used..
Feb 4 2019, 1:08 PM · Restricted Project
delcypher added a comment to D57535: [CMake] Use LLVM_ENABLE_PROJECTS as the "single source" of truth when used..

Would it be equivalent if you changed https://reviews.llvm.org/diffusion/L/browse/llvm/trunk/cmake/modules/AddLLVM.cmake;352949$1007-1009?as=source&blame=off from an option to a FORCEd cache set? The default value is computed based off the presence of the corresponding LLVM_EXTERNAL_*_SOURCE_DIR variable, which will be set for each project in LLVM_ENABLE_PROJECTS.

No it would not be equivalent.

In the case where the user is not using LLVM_ENABLE_PROJECTS, any user provided value for LLVM_TOOL_<PROJECT>_BUILD (e.g. LLVM_TOOL_CLANG_BUILD) would be ignored because it would always get overwritten with ${${canonical_full_name}_BUILD_DEFAULT}. This would break existing user workflows.

The whole point of this patch is to improve the LLVM_ENABLE_PROJECTS workflow without breaking workflows that set the LLVM_TOOL_<PROJECT>_BUILD variables. I'd like to stop LLVM_TOOL_<PROJECT>_BUILD variables from being CMake cache variables at some point so that those variables are no longer user facing. However that is going to require an RFC and is out of scope for this patch.

The branch in question is only taken when you haven't checked out the project in-tree, and I suspect most users of LLVM_TOOL_*_BUILD are using it for in-tree checkouts. Btw, that branch also checks for LLVM_EXTERNAL_*_BUILD variables, which you're also overriding in this patch, but I would hope no one was using those.

My preference would be to stop using the LLVM_TOOL_*_BUILD variables entirely for out-of-tree checkouts, and have that be completely controlled by LLVM_ENABLE_PROJECTS and LLVM_EXTERNAL_PROJECTS instead (which is effectively what this patch does for LLVM_ENABLE_PROJECTS, but in an indirect way). I think the LLVM_TOOL_*_BUILD variables still have value for in-tree checkouts (although with the impending monorepo migration, in-tree checkouts are probably not long for this world anyway, unless the read-only single project mirrors end up happening and then people check out those mirrors in-tree, for whatever reason).

I agree with all of the above but I think we need to communicate this clearly to other developers. My patch is indirect precisely because I want the support for setting the LLVM_TOOL_*_BUILD variables to still work when LLVM_ENABLE_PROJECTS is set.

I'm not completely sure what you mean, since this patch effectively makes the LLVM_TOOL_*_BUILD variables be ignored for anything in LLVM_ENABLE_PROJECTS, which is still a behavior change (though it's the right change IMO). However, this is definitely a step in the right direction, so I'm good cleaning this up incrementally and getting this change in as a first step.

Feb 4 2019, 12:59 PM · Restricted Project
delcypher added a comment to D57535: [CMake] Use LLVM_ENABLE_PROJECTS as the "single source" of truth when used..

Would it be equivalent if you changed https://reviews.llvm.org/diffusion/L/browse/llvm/trunk/cmake/modules/AddLLVM.cmake;352949$1007-1009?as=source&blame=off from an option to a FORCEd cache set? The default value is computed based off the presence of the corresponding LLVM_EXTERNAL_*_SOURCE_DIR variable, which will be set for each project in LLVM_ENABLE_PROJECTS.

No it would not be equivalent.

In the case where the user is not using LLVM_ENABLE_PROJECTS, any user provided value for LLVM_TOOL_<PROJECT>_BUILD (e.g. LLVM_TOOL_CLANG_BUILD) would be ignored because it would always get overwritten with ${${canonical_full_name}_BUILD_DEFAULT}. This would break existing user workflows.

The whole point of this patch is to improve the LLVM_ENABLE_PROJECTS workflow without breaking workflows that set the LLVM_TOOL_<PROJECT>_BUILD variables. I'd like to stop LLVM_TOOL_<PROJECT>_BUILD variables from being CMake cache variables at some point so that those variables are no longer user facing. However that is going to require an RFC and is out of scope for this patch.

The branch in question is only taken when you haven't checked out the project in-tree, and I suspect most users of LLVM_TOOL_*_BUILD are using it for in-tree checkouts. Btw, that branch also checks for LLVM_EXTERNAL_*_BUILD variables, which you're also overriding in this patch, but I would hope no one was using those.

My preference would be to stop using the LLVM_TOOL_*_BUILD variables entirely for out-of-tree checkouts, and have that be completely controlled by LLVM_ENABLE_PROJECTS and LLVM_EXTERNAL_PROJECTS instead (which is effectively what this patch does for LLVM_ENABLE_PROJECTS, but in an indirect way). I think the LLVM_TOOL_*_BUILD variables still have value for in-tree checkouts (although with the impending monorepo migration, in-tree checkouts are probably not long for this world anyway, unless the read-only single project mirrors end up happening and then people check out those mirrors in-tree, for whatever reason).

Feb 4 2019, 5:56 AM · Restricted Project
delcypher added inline comments to D57535: [CMake] Use LLVM_ENABLE_PROJECTS as the "single source" of truth when used..
Feb 4 2019, 5:53 AM · Restricted Project

Feb 2 2019

delcypher added a comment to D57535: [CMake] Use LLVM_ENABLE_PROJECTS as the "single source" of truth when used..

@rnk I've rewritten the patch so I've not added any loops. Instead I changed and existing loop and then merged my new code into it. When you have time, please take a look.

Feb 2 2019, 6:32 AM · Restricted Project
delcypher updated the diff for D57535: [CMake] Use LLVM_ENABLE_PROJECTS as the "single source" of truth when used..

Rewrite patch by rewriting the prior loop and then merging the new code into that rewritten loop. This change should behave the same as the previous patch except the message(STATUS ...) is slightly different.

Feb 2 2019, 6:30 AM · Restricted Project
delcypher added a comment to D57535: [CMake] Use LLVM_ENABLE_PROJECTS as the "single source" of truth when used..

Would it be equivalent if you changed https://reviews.llvm.org/diffusion/L/browse/llvm/trunk/cmake/modules/AddLLVM.cmake;352949$1007-1009?as=source&blame=off from an option to a FORCEd cache set? The default value is computed based off the presence of the corresponding LLVM_EXTERNAL_*_SOURCE_DIR variable, which will be set for each project in LLVM_ENABLE_PROJECTS.

Feb 2 2019, 5:14 AM · Restricted Project
delcypher added a comment to D57535: [CMake] Use LLVM_ENABLE_PROJECTS as the "single source" of truth when used..
In D57535#1381463, @rnk wrote:

lgtm

Thanks, this has annoyed me for a long time now. My first thought was, why can't this be done with a single for loop? I suppose it can, but we have to do it the way you have it written in order to make sure that we *disable* subprojects when they are removed from LLVM_ENABLE_PROJECTS in a subsequent cmake run.

Feb 2 2019, 5:05 AM · Restricted Project

Jan 31 2019

delcypher added a reviewer for D57535: [CMake] Use LLVM_ENABLE_PROJECTS as the "single source" of truth when used.: jyknight.
Jan 31 2019, 11:48 PM · Restricted Project
delcypher created D57535: [CMake] Use LLVM_ENABLE_PROJECTS as the "single source" of truth when used..
Jan 31 2019, 12:19 PM · Restricted Project

Jan 28 2019

delcypher added inline comments to D57224: [CMake] Quick-Fix FileCheck target does not exist when building against LLVM install-tree with COMPILER_RT_INCLUDE_TESTS=ON.
Jan 28 2019, 8:48 AM
delcypher updated subscribers of D57279: NFC: Reduce presence of "template <typename AddressSpaceView>".

@vitalybuka Thanks for working on this.

Jan 28 2019, 1:48 AM

Jan 27 2019

delcypher committed rCRT352335: Make more allocator methods work correctly with in an out-of-process mode..
Make more allocator methods work correctly with in an out-of-process mode.
Jan 27 2019, 2:47 PM
delcypher edited child revisions for D56207: Update allocator unit tests to test the `RemoteAddressSpaceView` template instantiation., added: 1; removed: 1.
Jan 27 2019, 2:47 PM
delcypher added a comment to D56964: Make more allocator methods work correctly with in an out-of-process mode..

@vitalybuka Thanks.

Jan 27 2019, 2:47 PM
delcypher added a parent revision for D56968: Refactor `AsanChunk` methods into code that supports both in-process and out-of-process examination of `AsanChunk`s.: D56207: Update allocator unit tests to test the `RemoteAddressSpaceView` template instantiation..
Jan 27 2019, 2:47 PM
delcypher removed a parent revision for D56964: Make more allocator methods work correctly with in an out-of-process mode.: D56207: Update allocator unit tests to test the `RemoteAddressSpaceView` template instantiation..
Jan 27 2019, 2:47 PM
delcypher committed rL352335: Make more allocator methods work correctly with in an out-of-process mode..
Make more allocator methods work correctly with in an out-of-process mode.
Jan 27 2019, 2:45 PM
delcypher closed D56964: Make more allocator methods work correctly with in an out-of-process mode..
Jan 27 2019, 2:45 PM
delcypher added a child revision for D57307: Implement `CopyFromTarget(...)` methods.: D56207: Update allocator unit tests to test the `RemoteAddressSpaceView` template instantiation..
Jan 27 2019, 1:03 PM
delcypher added a parent revision for D56207: Update allocator unit tests to test the `RemoteAddressSpaceView` template instantiation.: D57307: Implement `CopyFromTarget(...)` methods..
Jan 27 2019, 1:03 PM
delcypher added a parent revision for D57307: Implement `CopyFromTarget(...)` methods.: D57306: [NFC] Move `AddressSpaceView` out of `Params` for Size class allocators..
Jan 27 2019, 1:03 PM
delcypher added a child revision for D57306: [NFC] Move `AddressSpaceView` out of `Params` for Size class allocators.: D57307: Implement `CopyFromTarget(...)` methods..
Jan 27 2019, 1:03 PM
delcypher removed a parent revision for D56207: Update allocator unit tests to test the `RemoteAddressSpaceView` template instantiation.: D56206: Introduce `RemoteAddressSpaceView` and `VMReadContext`..
Jan 27 2019, 1:03 PM
delcypher removed a child revision for D56206: Introduce `RemoteAddressSpaceView` and `VMReadContext`.: D56207: Update allocator unit tests to test the `RemoteAddressSpaceView` template instantiation..
Jan 27 2019, 1:03 PM
delcypher added a child revision for D56206: Introduce `RemoteAddressSpaceView` and `VMReadContext`.: D57306: [NFC] Move `AddressSpaceView` out of `Params` for Size class allocators..
Jan 27 2019, 1:03 PM
delcypher added a parent revision for D57306: [NFC] Move `AddressSpaceView` out of `Params` for Size class allocators.: D56206: Introduce `RemoteAddressSpaceView` and `VMReadContext`..
Jan 27 2019, 1:03 PM
delcypher updated the diff for D56995: [ASan] Implement malloc zone enumeration for Darwin..
  • Use new CopyFromTarget(...) method.
  • Use new ThisTASVT<AddressSpaceView> template.
Jan 27 2019, 12:53 PM
delcypher updated the diff for D56207: Update allocator unit tests to test the `RemoteAddressSpaceView` template instantiation..
  • Update tests to use new CopyFromTarget(...) methods.
  • Simplify tests to use ThisTASVT<AddressSpaceView> templates.
Jan 27 2019, 12:50 PM
delcypher created D57307: Implement `CopyFromTarget(...)` methods..
Jan 27 2019, 12:48 PM
delcypher created D57306: [NFC] Move `AddressSpaceView` out of `Params` for Size class allocators..
Jan 27 2019, 12:47 PM
delcypher updated the diff for D56206: Introduce `RemoteAddressSpaceView` and `VMReadContext`..

Tweaks.

Jan 27 2019, 12:42 PM

Jan 26 2019

delcypher updated the diff for D56206: Introduce `RemoteAddressSpaceView` and `VMReadContext`..

Fix comments so the VMReadContext::Read() actually complies
in the case we are doing local reads.

Jan 26 2019, 11:58 AM
delcypher updated the diff for D56206: Introduce `RemoteAddressSpaceView` and `VMReadContext`..

Fix lint issues.

Jan 26 2019, 11:39 AM
delcypher added a comment to D56964: Make more allocator methods work correctly with in an out-of-process mode..

@vitalybuka In https://reviews.llvm.org/D57279 it looks like you're looking at performing a refactor. Could we land this first? I realise this is addressing my patch series out-of-order but this patches doesn't actually depend on the prior two patches (https://reviews.llvm.org/D56207 and https://reviews.llvm.org/D56206) in the review series.

Jan 26 2019, 7:34 AM
delcypher added inline comments to D57279: NFC: Reduce presence of "template <typename AddressSpaceView>".
Jan 26 2019, 6:57 AM
delcypher added a comment to D57279: NFC: Reduce presence of "template <typename AddressSpaceView>".

If we're going to go down this road we really need to land https://reviews.llvm.org/D56964 first. That fixes additional behaviour of the allocators.

Jan 26 2019, 6:16 AM

Jan 24 2019

delcypher added inline comments to D56207: Update allocator unit tests to test the `RemoteAddressSpaceView` template instantiation..
Jan 24 2019, 4:04 AM
delcypher added a comment to D53798: [lit] Add --show-substitutions.

@eush Also sorry for the delay. I just noticed that this patch was in my list of unreviewed patches. Please feel free to ping me on this review if I don't respond in a timely manner.

Jan 24 2019, 3:58 AM
Herald added a reviewer for D53798: [lit] Add --show-substitutions: serge-sans-paille.
Jan 24 2019, 3:57 AM

Jan 23 2019

delcypher added inline comments to D56624: [Sanitizers] UBSan unreachable incompatible with ASan in the presence of `noreturn` calls.
Jan 23 2019, 2:08 PM · Restricted Project
delcypher added inline comments to D56624: [Sanitizers] UBSan unreachable incompatible with ASan in the presence of `noreturn` calls.
Jan 23 2019, 12:39 PM · Restricted Project
delcypher added inline comments to D56206: Introduce `RemoteAddressSpaceView` and `VMReadContext`..
Jan 23 2019, 12:25 PM
delcypher updated the diff for D56206: Introduce `RemoteAddressSpaceView` and `VMReadContext`..

Fix typo.

Jan 23 2019, 12:21 PM
delcypher updated the diff for D56995: [ASan] Implement malloc zone enumeration for Darwin..

Update for changes to VMReadContext.

Jan 23 2019, 12:15 PM
delcypher updated the diff for D56206: Introduce `RemoteAddressSpaceView` and `VMReadContext`..

Add VMReadContextConfig to simplify usage of VMReadContext.

Jan 23 2019, 12:14 PM
delcypher updated the diff for D56206: Introduce `RemoteAddressSpaceView` and `VMReadContext`..
  • Add extra return in CMakeLists.txt.
  • Only allow for owning_tid_ to be set once.
  • Clean up IsLocal() darwin implementation.
Jan 23 2019, 10:37 AM
delcypher added inline comments to D56206: Introduce `RemoteAddressSpaceView` and `VMReadContext`..
Jan 23 2019, 10:04 AM

Jan 22 2019

delcypher added inline comments to D56207: Update allocator unit tests to test the `RemoteAddressSpaceView` template instantiation..
Jan 22 2019, 10:49 AM
delcypher added inline comments to D56206: Introduce `RemoteAddressSpaceView` and `VMReadContext`..
Jan 22 2019, 9:22 AM
delcypher added inline comments to D56206: Introduce `RemoteAddressSpaceView` and `VMReadContext`..
Jan 22 2019, 8:45 AM
delcypher updated the diff for D56206: Introduce `RemoteAddressSpaceView` and `VMReadContext`..
  • Remove C-style cast.
Jan 22 2019, 8:44 AM
delcypher added inline comments to D56206: Introduce `RemoteAddressSpaceView` and `VMReadContext`..
Jan 22 2019, 8:42 AM
delcypher updated the diff for D56206: Introduce `RemoteAddressSpaceView` and `VMReadContext`..
  • Revert back to plain VMReadContext*
  • Check owning_tid_ in set_context()
  • Delete more methods from VMReadContext.
Jan 22 2019, 8:39 AM
delcypher added a reviewer for D56996: [ASan] Add tests for Darwin in-process and out-of-process malloc zone enumeration.: dcoughlin.
Jan 22 2019, 8:32 AM
delcypher added a reviewer for D56995: [ASan] Implement malloc zone enumeration for Darwin.: dcoughlin.
Jan 22 2019, 8:31 AM