Page MenuHomePhabricator

delcypher (Dan Liew)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 21 2015, 4:29 PM (358 w, 4 d)

Recent Activity

Mon, Jun 6

delcypher requested changes to D126936: [compiler-rt] Handle target and sysroot flags in tests.

The change is right in "spirit" but I think the current implementation will likely break things (or will work by accident). There is a fundamental difference between how compiler-rt is built for Apple platforms and other platforms. For Apple platforms we build all platforms and targets in a single CMake configure (IIUC other platforms have a CMake configure correspond to a single platform and arch). So there is no single sysroot or target triple.

Mon, Jun 6, 3:02 PM · Restricted Project, Restricted Project
delcypher added inline comments to D126936: [compiler-rt] Handle target and sysroot flags in tests.
Mon, Jun 6, 2:38 PM · Restricted Project, Restricted Project

Jun 3 2022

delcypher added a comment to D125919: Drop qualifiers from return types in C (DR423).

@rjmccall

Sorry if these are silly questions and if I've misunderstood something, I saw n1863 say "functions return unqualified types" and I was very surprised.

Just to be clear, you understand that this is only about top-level qualifiers on the return type, right? const void *foo(); is still meaningful, it's just that const void * const foo(); isn't.

Jun 3 2022, 10:54 AM · Restricted Project, Restricted Project
delcypher added a comment to D125919: Drop qualifiers from return types in C (DR423).

@aaron.ballman

Sorry if these are silly questions and if I've misunderstood something, I saw n1863 say "functions return unqualified types" and I was very surprised.

These are not at all silly questions, so thank you for asking them!

Jun 3 2022, 10:49 AM · Restricted Project, Restricted Project

Jun 2 2022

delcypher added a comment to D125919: Drop qualifiers from return types in C (DR423).

@aaron.ballman Hey I just saw this change and had questions about it. For others looking I think the resolution to DR423 is in https://www.open-std.org/jtc1/sc22/wg14/www/docs/n1863.pdf, I found https://www.open-std.org/jtc1/sc22/wg14/www/docs/n2148.htm#dr_423 hard to parse.

Jun 2 2022, 11:49 AM · Restricted Project, Restricted Project

May 11 2022

delcypher accepted D125396: [clang] Fix KEYALL.

@yaxunl Thanks for addressing my feedback so quickly. I think the commit message should also mention that KEYCUDA is now included in KEYALL. Other than that LGTM.

May 11 2022, 8:53 AM · Restricted Project, Restricted Project
delcypher added inline comments to D124866: [CUDA][HIP] support __noinline__ as keyword.
May 11 2022, 8:50 AM · Restricted Project, Restricted Project

May 10 2022

delcypher added inline comments to D124866: [CUDA][HIP] support __noinline__ as keyword.
May 10 2022, 10:28 PM · Restricted Project, Restricted Project
delcypher added inline comments to D124866: [CUDA][HIP] support __noinline__ as keyword.
May 10 2022, 5:47 PM · Restricted Project, Restricted Project

May 9 2022

delcypher added inline comments to D125195: [asan][ARMCXXABI] Added missing asan poison array cookie hooks..
May 9 2022, 10:21 AM · Restricted Project, Restricted Project, Restricted Project
Herald added a project to D114293: [ASan] Added __asan_shadow_memory variable which points to the beginning of the shadow region using some assembly trickery.: Restricted Project.
May 9 2022, 10:16 AM · Restricted Project, Restricted Project

May 6 2022

delcypher added inline comments to D124557: [compiler-rt][Darwin] Check for arm64 support directly.
May 6 2022, 3:39 PM · Restricted Project, Restricted Project

May 3 2022

delcypher added inline comments to D124557: [compiler-rt][Darwin] Check for arm64 support directly.
May 3 2022, 9:57 AM · Restricted Project, Restricted Project

May 2 2022

delcypher added a comment to D124557: [compiler-rt][Darwin] Check for arm64 support directly.

@smeenai Thanks for the patch. I think the overall spirit of this change is good. There are just some details to work out which I've left in other comments.

May 2 2022, 7:00 PM · Restricted Project, Restricted Project
delcypher added inline comments to D124557: [compiler-rt][Darwin] Check for arm64 support directly.
May 2 2022, 6:59 PM · Restricted Project, Restricted Project
delcypher added inline comments to D124557: [compiler-rt][Darwin] Check for arm64 support directly.
May 2 2022, 6:57 PM · Restricted Project, Restricted Project
delcypher added a reviewer for D124557: [compiler-rt][Darwin] Check for arm64 support directly: arphaman.
May 2 2022, 6:40 PM · Restricted Project, Restricted Project
delcypher added a comment to D124643: [Object][DX] Initial DXContainer parsing support.

The other issue should be fixed in rGb26e44e623c75c084e865084b18541c6a1736df2.

May 2 2022, 4:59 PM · Restricted Project, Restricted Project
delcypher added a comment to D124643: [Object][DX] Initial DXContainer parsing support.

This isn't the only problem. There are also failures due to:

llvm-project/llvm/lib/Object/DXContainer.cpp:42:12: error: call to deleted constructor of 'llvm::Error'
    return Err;
           ^~~

See https://lab.llvm.org/buildbot/#/builders/21/builds/40034/steps/5/logs/stdio

May 2 2022, 4:31 PM · Restricted Project, Restricted Project

Apr 27 2022

delcypher added a comment to D124489: Deprecate LLVM_BUILD_EXTERNAL_COMPILER_RT.

I spoke to a few other engineers in Apple. They are

Apr 27 2022, 3:27 PM · Restricted Project, Restricted Project
delcypher added a reviewer for D124489: Deprecate LLVM_BUILD_EXTERNAL_COMPILER_RT: arphaman.
Apr 27 2022, 10:58 AM · Restricted Project, Restricted Project

Apr 26 2022

delcypher added a comment to D124489: Deprecate LLVM_BUILD_EXTERNAL_COMPILER_RT.

Making it an ERROR and providing an option to downgrade it to a WARNING seems reasonable to me. Thoughts?

Apr 26 2022, 6:06 PM · Restricted Project, Restricted Project
delcypher added a reviewer for D124489: Deprecate LLVM_BUILD_EXTERNAL_COMPILER_RT: azharudd.
Apr 26 2022, 6:03 PM · Restricted Project, Restricted Project
delcypher accepted D124474: Honor COMPILER_RT_INCLUDE_TESTS when using LLVM_BUILD_EXTERNAL_COMPILER_RT=ON.

Change LGTM.

Apr 26 2022, 4:52 PM · Restricted Project, Restricted Project
delcypher added a comment to D124474: Honor COMPILER_RT_INCLUDE_TESTS when using LLVM_BUILD_EXTERNAL_COMPILER_RT=ON.

I'd definitely prefer moving towards LLVM_ENABLE_RUNTIMES. We already require LLVM_ENABLE_RUNTIMES for libc++, libc++abi and libunwind and I'm going to propose doing the same for compiler-rt as well.

Apr 26 2022, 4:51 PM · Restricted Project, Restricted Project

Apr 22 2022

delcypher added a reverting change for rG3469cb14e231: Revert "[compiler-rt][Darwin] Add arm64 to simulator platforms": rGa680c212cb21: Revert "Revert "[compiler-rt][Darwin] Add arm64 to simulator platforms"".
Apr 22 2022, 6:49 PM · Restricted Project, Restricted Project
delcypher committed rGa680c212cb21: Revert "Revert "[compiler-rt][Darwin] Add arm64 to simulator platforms"" (authored by delcypher).
Revert "Revert "[compiler-rt][Darwin] Add arm64 to simulator platforms""
Apr 22 2022, 6:49 PM · Restricted Project, Restricted Project
delcypher added a comment to D119174: [compiler-rt][Darwin] Add arm64 to simulator platforms.

Patch relanded as a680c212cb213bf73be7d3e2ee919fdc743cef0c

Apr 22 2022, 6:49 PM · Restricted Project, Restricted Project
delcypher accepted D119174: [compiler-rt][Darwin] Add arm64 to simulator platforms.

Approved.

Apr 22 2022, 6:42 PM · Restricted Project, Restricted Project
delcypher reopened D119174: [compiler-rt][Darwin] Add arm64 to simulator platforms.
Apr 22 2022, 6:42 PM · Restricted Project, Restricted Project
delcypher added a reviewer for D119174: [compiler-rt][Darwin] Add arm64 to simulator platforms: delcypher.
Apr 22 2022, 6:42 PM · Restricted Project, Restricted Project
delcypher added a comment to D119174: [compiler-rt][Darwin] Add arm64 to simulator platforms.

Okay. I understand. Sorry for broke your code.

Apr 22 2022, 6:41 PM · Restricted Project, Restricted Project
delcypher updated subscribers of D119174: [compiler-rt][Darwin] Add arm64 to simulator platforms.

Reverted in 3469cb14e2316a1e3cf64db5be3738379d9daa8d

Apr 22 2022, 5:17 PM · Restricted Project, Restricted Project
delcypher added a reverting change for rG8a3afc6da5bc: [compiler-rt][Darwin] Add arm64 to simulator platforms: rG3469cb14e231: Revert "[compiler-rt][Darwin] Add arm64 to simulator platforms".
Apr 22 2022, 5:06 PM · Restricted Project, Restricted Project
delcypher committed rG3469cb14e231: Revert "[compiler-rt][Darwin] Add arm64 to simulator platforms" (authored by delcypher).
Revert "[compiler-rt][Darwin] Add arm64 to simulator platforms"
Apr 22 2022, 5:06 PM · Restricted Project, Restricted Project
delcypher added a reverting change for D119174: [compiler-rt][Darwin] Add arm64 to simulator platforms: rG3469cb14e231: Revert "[compiler-rt][Darwin] Add arm64 to simulator platforms".
Apr 22 2022, 5:06 PM · Restricted Project, Restricted Project
delcypher updated subscribers of D119174: [compiler-rt][Darwin] Add arm64 to simulator platforms.

@bc-lee This has broken some of Apple's internal builds. You didn't have a single person from Apple approve this code before landing it which is not acceptable given that it affects only Apple platforms. Please CC @yln @thetruestblue @kubamracek @rsundahl and me in the future if you want to land something like this.

Apr 22 2022, 4:49 PM · Restricted Project, Restricted Project

Apr 20 2022

delcypher added a comment to D124054: [NFC] Avoid unnecessary duplication of code generating diagnostic..

@aaron.ballman Thanks.

Apr 20 2022, 10:51 AM · Restricted Project, Restricted Project
delcypher committed rG3d612a930dce: [NFC] Avoid unnecessary duplication of code generating diagnostic. (authored by delcypher).
[NFC] Avoid unnecessary duplication of code generating diagnostic.
Apr 20 2022, 10:50 AM · Restricted Project, Restricted Project
delcypher closed D124054: [NFC] Avoid unnecessary duplication of code generating diagnostic..
Apr 20 2022, 10:50 AM · Restricted Project, Restricted Project

Apr 19 2022

delcypher requested review of D124054: [NFC] Avoid unnecessary duplication of code generating diagnostic..
Apr 19 2022, 5:31 PM · Restricted Project, Restricted Project

Apr 11 2022

delcypher added a comment to D123475: [compiler-rt] Stop explictly ad-hoc signing compiler-rt dylibs in apple builds if ld is new enough.

+ more Apple folks

Makes sense, the only thing I can think of is if someone wants to build compiler-rt with older Xcode/SDKs. Not sure if we care about that.

Apr 11 2022, 12:22 PM · Restricted Project, Restricted Project

Mar 31 2022

delcypher accepted D122751: [Darwin] Limit parallelism for sanitizer tests that use shadow memory on AS.

LGTM

Mar 31 2022, 2:37 PM · Restricted Project, Restricted Project
delcypher added a comment to D122751: [Darwin] Limit parallelism for sanitizer tests that use shadow memory on AS.

Changes seems good. I certainly like that we've simplified things. If we can resolve the question I asked then I think this will be good to go.

Mar 31 2022, 2:13 PM · Restricted Project, Restricted Project

Mar 28 2022

delcypher added a reviewer for D122569: [lit] Support %if ... %else syntax for RUN lines: yln.
Mar 28 2022, 12:15 PM · Restricted Project, Restricted Project
delcypher added a comment to D122569: [lit] Support %if ... %else syntax for RUN lines.

Have you considered the different approach of having conditional RUN lines instead? E.g.

Mar 28 2022, 12:14 PM · Restricted Project, Restricted Project
delcypher added a comment to D122569: [lit] Support %if ... %else syntax for RUN lines.
FileCheck %s --check-prefix={%if windows {W} else {NON-W}}
Mar 28 2022, 11:57 AM · Restricted Project, Restricted Project

Mar 15 2022

delcypher abandoned D116635: Add warning to detect when calls passing arguments are made to functions without prototypes..
Mar 15 2022, 2:25 PM · Restricted Project, Restricted Project

Mar 14 2022

delcypher added inline comments to D121327: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO.
Mar 14 2022, 5:20 PM · Restricted Project, Restricted Project, Restricted Project

Mar 11 2022

delcypher accepted D121327: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO.
Mar 11 2022, 1:43 PM · Restricted Project, Restricted Project, Restricted Project

Mar 9 2022

delcypher added a comment to D121327: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO.

@yln I like the approach here as it solves problem for all of LLVM, not just ASan specifically :). This is better than what I was going to do originally. I think the only missing there here are some tests.

Mar 9 2022, 2:34 PM · Restricted Project, Restricted Project, Restricted Project

Feb 14 2022

delcypher added a comment to D118855: [modules] Add a flag for TagDecl if it was a definition demoted to a declaration..

Change seems reasonable but I don't have expertise on this code. I've left a few minor nits.

Feb 14 2022, 11:05 AM · Restricted Project

Feb 8 2022

gasawayquin awarded D107412: [Compiler-rt] Fix running ASan/TSan unit tests under macOS 12.0. a Orange Medal token.
Feb 8 2022, 4:49 PM · Restricted Project

Jan 26 2022

delcypher added inline comments to D116635: Add warning to detect when calls passing arguments are made to functions without prototypes..
Jan 26 2022, 6:59 PM · Restricted Project, Restricted Project
delcypher added a comment to D117924: [compiler_rt] Add a seperate runtime for Mac Catalyst.

@bc-lee Thanks for the patch. While I get what you're trying to do I have doubts about being able to accept the patch in its current form. Apple's ASan catalyst doesn't work by building a separate dylib, instead it builds the macosx dylib in a different way to make it work with catalyst code.

Jan 26 2022, 6:22 PM · Restricted Project, Restricted Project
delcypher added 1 blocking reviewer(s) for D117924: [compiler_rt] Add a seperate runtime for Mac Catalyst: aralisza.
Jan 26 2022, 6:18 PM · Restricted Project, Restricted Project
delcypher added reviewers for D117924: [compiler_rt] Add a seperate runtime for Mac Catalyst: aralisza, kubamracek.
Jan 26 2022, 6:07 PM · Restricted Project, Restricted Project

Jan 6 2022

delcypher added inline comments to D116635: Add warning to detect when calls passing arguments are made to functions without prototypes..
Jan 6 2022, 2:07 PM · Restricted Project, Restricted Project
delcypher added inline comments to D116635: Add warning to detect when calls passing arguments are made to functions without prototypes..
Jan 6 2022, 1:39 PM · Restricted Project, Restricted Project
delcypher added inline comments to D116635: Add warning to detect when calls passing arguments are made to functions without prototypes..
Jan 6 2022, 11:31 AM · Restricted Project, Restricted Project
delcypher added inline comments to D116635: Add warning to detect when calls passing arguments are made to functions without prototypes..
Jan 6 2022, 10:54 AM · Restricted Project, Restricted Project

Jan 5 2022

delcypher added inline comments to D116635: Add warning to detect when calls passing arguments are made to functions without prototypes..
Jan 5 2022, 2:47 PM · Restricted Project, Restricted Project
delcypher added inline comments to D116635: Add warning to detect when calls passing arguments are made to functions without prototypes..
Jan 5 2022, 2:39 PM · Restricted Project, Restricted Project

Jan 4 2022

delcypher added inline comments to D116635: Add warning to detect when calls passing arguments are made to functions without prototypes..
Jan 4 2022, 6:42 PM · Restricted Project, Restricted Project
delcypher added a reviewer for D116636: [WIP] Enable `-Wstrict-calls-without-prototype` by default: jkorous.
Jan 4 2022, 5:46 PM · Restricted Project
delcypher added a reviewer for D116635: Add warning to detect when calls passing arguments are made to functions without prototypes.: jkorous.
Jan 4 2022, 5:46 PM · Restricted Project, Restricted Project
delcypher added a comment to D116635: Add warning to detect when calls passing arguments are made to functions without prototypes..

Patch https://reviews.llvm.org/D116636 demonstrates the changes needed if the warning was enabled by default:

Jan 4 2022, 5:46 PM · Restricted Project, Restricted Project
delcypher added a comment to D116636: [WIP] Enable `-Wstrict-calls-without-prototype` by default.

This change depends on https://reviews.llvm.org/D116635.

Jan 4 2022, 5:45 PM · Restricted Project
delcypher requested review of D116636: [WIP] Enable `-Wstrict-calls-without-prototype` by default.
Jan 4 2022, 5:42 PM · Restricted Project
delcypher added inline comments to D116635: Add warning to detect when calls passing arguments are made to functions without prototypes..
Jan 4 2022, 5:37 PM · Restricted Project, Restricted Project
delcypher updated the summary of D116635: Add warning to detect when calls passing arguments are made to functions without prototypes..
Jan 4 2022, 5:29 PM · Restricted Project, Restricted Project
delcypher updated the diff for D116635: Add warning to detect when calls passing arguments are made to functions without prototypes..

Add another test case for function definitions without prototypes.

Jan 4 2022, 5:28 PM · Restricted Project, Restricted Project
delcypher requested review of D116635: Add warning to detect when calls passing arguments are made to functions without prototypes..
Jan 4 2022, 5:07 PM · Restricted Project, Restricted Project

Dec 17 2021

delcypher accepted D115947: [TSan][Darwin] Make malloc_size interceptor more robust.

LGTM

Dec 17 2021, 12:00 PM · Restricted Project
delcypher accepted D115843: [TSan][Darwin] Fix shadow mapping for iOS simulator on Apple Silicon.

LGTM

Dec 17 2021, 11:59 AM · Restricted Project

Dec 16 2021

delcypher accepted D115816: [Sanitizer] Disable LSan when testing on iOS simulators.

LGTM

Dec 16 2021, 12:31 PM · Restricted Project

Dec 12 2021

delcypher accepted D100043: [lit] Fix compatibility with upstream gtest.

LGTM. Thanks for pinging.

Dec 12 2021, 8:23 PM · Restricted Project

Nov 10 2021

delcypher accepted D113444: [compiler-rt] separate lsan, ubsan, stats configuration from SANITIZER_COMMON_SUPPORTED_OS.

You probably need to mention the ubsan runtime library in your commit message. Other than that LGTM.

Nov 10 2021, 4:56 PM · Restricted Project

Oct 15 2021

delcypher committed rG2232a68b2df2: Fix another test not using the standard separator for sanitizer options. (authored by delcypher).
Fix another test not using the standard separator for sanitizer options.
Oct 15 2021, 12:22 AM

Oct 14 2021

delcypher accepted D111478: [compiler-rt] implement COMMON_INTERCEPTOR_COPY_STRING for asan.

LGTM

Oct 14 2021, 3:38 PM · Restricted Project

Oct 12 2021

delcypher added a comment to D111478: [compiler-rt] implement COMMON_INTERCEPTOR_COPY_STRING for asan.

Another way we could go about this is just implement an ASan specific implementation, e.g. we already have one for INTERCEPTOR(char *, strcpy, char *to, const char *from) in asan_interceptors.cpp.

Oct 12 2021, 12:53 PM · Restricted Project
delcypher added a comment to D111478: [compiler-rt] implement COMMON_INTERCEPTOR_COPY_STRING for asan.

Note we'll need another test case if we choose to add support for checking overlapping params.

Oct 12 2021, 12:51 PM · Restricted Project

Oct 6 2021

delcypher committed rG9ed6b1cd9760: Disable SANITIZER_CHECK_DEADLOCKS on Darwin platforms. (authored by delcypher).
Disable SANITIZER_CHECK_DEADLOCKS on Darwin platforms.
Oct 6 2021, 12:06 PM
delcypher closed D111243: Disable SANITIZER_CHECK_DEADLOCKS on Darwin platforms..
Oct 6 2021, 12:05 PM · Restricted Project
delcypher requested review of D111243: Disable SANITIZER_CHECK_DEADLOCKS on Darwin platforms..
Oct 6 2021, 9:57 AM · Restricted Project

Oct 2 2021

delcypher added a comment to D110967: Use standard separator for TSan options in `stress.cpp` test case..

It would be useful if the standard %run would detect this problem and fail.

Oct 2 2021, 9:14 PM · Restricted Project
delcypher committed rGd6a4294d1362: Use standard separator for TSan options in `stress.cpp` test case. (authored by delcypher).
Use standard separator for TSan options in `stress.cpp` test case.
Oct 2 2021, 9:11 PM
delcypher closed D110967: Use standard separator for TSan options in `stress.cpp` test case..
Oct 2 2021, 9:11 PM · Restricted Project

Oct 1 2021

delcypher requested review of D110967: Use standard separator for TSan options in `stress.cpp` test case..
Oct 1 2021, 1:12 PM · Restricted Project

Sep 29 2021

delcypher committed rGcac25e40428d: Adapt `tsan/flush_memory.cpp` to run on non-local platforms. (authored by delcypher).
Adapt `tsan/flush_memory.cpp` to run on non-local platforms.
Sep 29 2021, 10:40 AM
delcypher closed D110734: Adapt `tsan/flush_memory.cpp` to run on non-local platforms..
Sep 29 2021, 10:39 AM · Restricted Project
delcypher added a comment to D110734: Adapt `tsan/flush_memory.cpp` to run on non-local platforms..

@dvyukov Thanks for the review.

Sep 29 2021, 10:39 AM · Restricted Project
delcypher requested review of D110734: Adapt `tsan/flush_memory.cpp` to run on non-local platforms..
Sep 29 2021, 10:32 AM · Restricted Project

Sep 21 2021

delcypher added inline comments to D110162: [TSan][Darwin] Avoid crashes due to interpreting non-zero shadow content as a pointer.
Sep 21 2021, 4:47 PM · Restricted Project

Sep 15 2021

delcypher committed rGf4382d4b0972: [Compiler-RT] For arm64e test suites use the SDK version as the minimum… (authored by delcypher).
[Compiler-RT] For arm64e test suites use the SDK version as the minimum…
Sep 15 2021, 2:24 PM
delcypher abandoned D109842: [Compiler-RT] For arm64e test suites use the SDK version as the minimum deployment target..
Sep 15 2021, 2:21 PM · Restricted Project
delcypher updated the diff for D109842: [Compiler-RT] For arm64e test suites use the SDK version as the minimum deployment target..

Make not handling an Apple platform non-fatal.

Sep 15 2021, 2:13 PM · Restricted Project
delcypher updated the diff for D109842: [Compiler-RT] For arm64e test suites use the SDK version as the minimum deployment target..

Avoid use of global DARWIN_${platform}_SDK_VERSION variables.

Sep 15 2021, 12:35 PM · Restricted Project
delcypher requested review of D109842: [Compiler-RT] For arm64e test suites use the SDK version as the minimum deployment target..
Sep 15 2021, 11:28 AM · Restricted Project

Sep 14 2021

delcypher added a comment to D108859: [test] Fix asan/scudo -shared-libsan tests with -DLLVM_ENABLE_PER_TARGET_RUNTIME_DIR=on.

@delcypher If COMPILER_RT_TEST_STANDALONE_BUILD_LIBS is really a macOS thing, please give ELF users a way to proceed.

Sep 14 2021, 11:57 AM · Restricted Project