- User Since
- Aug 21 2015, 4:29 PM (178 w, 2 d)
Sat, Jan 19
Rebase on master and adopt new license headers.
Fri, Jan 18
@vitalybuka I've done another pass over the patch and fixed everything I reasonably could. Please make another pass when you have time.
- Check thread id
- Use atomic variables
Thu, Jan 17
Is it possible to write a test with a custom noreturn function that tries to touch the stack such that with the old Clang we'd get a false positive report (when building with ASan+UBSan) when we try to execute it?
@yln A few comments on the patch description.
Wed, Jan 16
@vitalybuka I've fixed what I can and I've left questions about things that aren't straightforward to fix or that I don't agree with. When you have time could you take another look?
- Remote fields/methods in VMReadContext that won't be used.
- Remove default writable=true argument.
Tue, Jan 15
@vitalybuka Sorry the delay in getting to this. Is this good to go?
- Remove SUPPORTED_TOOLS_LEGACY
Mon, Jan 14
Use new RemoteAddressSpaceView::ScopedContext.
Lots of clean-up.
Fri, Jan 11
Adding spacing above and below declarations in namespace.
Thu, Jan 10
Okay I get the idea. This is a much more invasive change however. Would it be okay to commit this (with FILECHECK_OPTS also stripped out) and do your suggestion as a follow up patch?
The reason I'd prefer to do this is because this change is intended to fix some internal build bots. Due to where we are in the release cycle the changes I make need to be simple (i.e. the smaller the patch the better) in order to be accepted by internal reviewers.
This patch does improve the situation for everyone, and it's easy to revert, so I'm fine with that. But could you fix lit's test suite too? Should be easy, right? I'm not aware of any other test suites that are sensitive to FileCheck's output in this manner.
Also unset FILECHECK_OPTS.
Wed, Jan 9
__tsan_init is external to generated TSan code (it lives in the TSan runtime), where as tsan.module_ctor() was in the same module. Perhaps dyld doesn't like calling functions external to the module directly.
- Put legacy list back but only use it for Windows and Android.
- Print warning when we use the legacy list.
- Print the generated SUPPORTED_TOOLS list.
@philip.pfaffe This patch got reverted (not by me r350719) because it broke TSan on macOS.
Tue, Jan 8
Fri, Jan 4
@msearles LGTM. Do you have commit access or would you like me to commit this on your behalf?
Thu, Jan 3
Wed, Jan 2
@greened Sorry looks like I missed your earlier pings. LGTM
Fix some comments.