delcypher (Dan Liew)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 21 2015, 4:29 PM (144 w, 54 m)

Recent Activity

Wed, May 23

delcypher updated the diff for D47210: [lit] Fix the `--max-time` flag feature which was completely broken..

Avoid use of child_lit_config where possible and add a comment explaining why we assign to the child_lit_config global.

Wed, May 23, 1:24 AM
delcypher added inline comments to D47210: [lit] Fix the `--max-time` flag feature which was completely broken..
Wed, May 23, 1:07 AM
delcypher added a comment to D47153: [Support] Avoid normalization in sys::getDefaultTargetTriple.

I'm not familiar with this code but if I'm reading the patch correctly, then the commit message omits the fact that it changes he windows target triple from having a win32 suffix to windows-msvc suffix. I'm not sure what the implications are here but the fact you've done this is probably worth mentioning in the commit message.

Done. I've also tested this change on Windows and this seems to be passing now so should be ready for re-land.

Wed, May 23, 12:39 AM

Tue, May 22

delcypher created D47210: [lit] Fix the `--max-time` flag feature which was completely broken..
Tue, May 22, 11:01 AM
delcypher committed rL332987: [lit] Try to make `shtest-timeout.py` test more reliable by using a.
[lit] Try to make `shtest-timeout.py` test more reliable by using a
Tue, May 22, 8:13 AM
delcypher committed rL332986: [lit] Don't run `slow.py` in `shtest-timeout.py` test..
[lit] Don't run `slow.py` in `shtest-timeout.py` test.
Tue, May 22, 8:13 AM
delcypher committed rL332985: [lit] Don't check output of commands used in `shtest-timeout.py` test..
[lit] Don't check output of commands used in `shtest-timeout.py` test.
Tue, May 22, 8:12 AM

Mon, May 21

delcypher added a comment to D47153: [Support] Avoid normalization in sys::getDefaultTargetTriple.

I'm not familiar with this code but if I'm reading the patch correctly, then the commit message omits the fact that it changes he windows target triple from having a win32 suffix to windows-msvc suffix. I'm not sure what the implications are here but the fact you've done this is probably worth mentioning in the commit message.

Mon, May 21, 11:08 AM

Thu, May 17

delcypher added inline comments to D46569: [libFuzzer] Generalize libFuzzer build and tests to multiple architectures.
Thu, May 17, 4:10 PM

Wed, May 16

delcypher added inline comments to D46924: [libFuzzer] add a symbolic execution puzzle (difficult for today's libFuzzer)..
Wed, May 16, 10:42 AM
delcypher added a comment to D46924: [libFuzzer] add a symbolic execution puzzle (difficult for today's libFuzzer)..

Neat. Was this generated programmatically?

Wed, May 16, 10:41 AM

Tue, May 15

delcypher added a comment to D46886: Escape ]]> in xunit xml output.

The test does not care what the return code of lit is, just that the xml output is correct.

Tue, May 15, 10:20 AM
delcypher added a comment to D46886: Escape ]]> in xunit xml output.

There is a test case that intentionally fails to provide failing output. That makes lit return an error exit value. Any way to change what lit exits with?

Tue, May 15, 10:05 AM
delcypher added inline comments to D46886: Escape ]]> in xunit xml output.
Tue, May 15, 9:54 AM

Mon, May 14

delcypher committed rL332254: Fix another case where libstdc++ is being inappropriately requested (see.
Fix another case where libstdc++ is being inappropriately requested (see
Mon, May 14, 8:53 AM
delcypher committed rCRT332254: Fix another case where libstdc++ is being inappropriately requested (see.
Fix another case where libstdc++ is being inappropriately requested (see
Mon, May 14, 8:53 AM
delcypher closed D46401: Fix another case where libstdc++ is being inappropriately requested (see r328775) for all platforms..
Mon, May 14, 8:53 AM
delcypher updated the diff for D46401: Fix another case where libstdc++ is being inappropriately requested (see r328775) for all platforms..

Fix FileCheck not being executed in test.

Mon, May 14, 3:02 AM

Fri, May 11

delcypher added inline comments to D46401: Fix another case where libstdc++ is being inappropriately requested (see r328775) for all platforms..
Fri, May 11, 8:47 AM

Thu, May 10

delcypher accepted D46661: [tsan] Add debugging API to retrieve the "external tag" from reports.

Thanks for making changes. LGTM.

Thu, May 10, 2:38 PM · Restricted Project
delcypher added a comment to D46661: [tsan] Add debugging API to retrieve the "external tag" from reports.

@delcypher @george.karpenkov added a comment. looks good now?

Thu, May 10, 2:37 PM · Restricted Project
delcypher added inline comments to D46661: [tsan] Add debugging API to retrieve the "external tag" from reports.
Thu, May 10, 2:33 PM · Restricted Project
delcypher added inline comments to D46661: [tsan] Add debugging API to retrieve the "external tag" from reports.
Thu, May 10, 2:11 PM · Restricted Project

Wed, May 9

delcypher added inline comments to D46661: [tsan] Add debugging API to retrieve the "external tag" from reports.
Wed, May 9, 2:25 PM · Restricted Project

Thu, May 3

delcypher created D46401: Fix another case where libstdc++ is being inappropriately requested (see r328775) for all platforms..
Thu, May 3, 11:56 AM

Wed, May 2

delcypher added a comment to D45762: [LibFuzzer] Add support for an optional user defined callback (`LLVMFuzzerOnExitHandler()`).

@kcc ping

Wed, May 2, 1:44 AM

Apr 24 2018

delcypher accepted D44598: [lit] Report line number for failed RUN command.

Ping.

Apr 24 2018, 9:00 AM
delcypher committed rL330728: [lit] Remove spurious `-` in invocation of lit in.
[lit] Remove spurious `-` in invocation of lit in
Apr 24 2018, 8:45 AM

Apr 23 2018

delcypher added a comment to D45762: [LibFuzzer] Add support for an optional user defined callback (`LLVMFuzzerOnExitHandler()`).
In D45762#1071308, @kcc wrote:

Why is it not enough to cal atexit() in LLVMFuzzerInitialize?

Apr 23 2018, 11:43 PM
delcypher committed rCRT330687: [LibFuzzer] Tweak `MutationDispatcher::Mutate_CopyPart` mutation..
[LibFuzzer] Tweak `MutationDispatcher::Mutate_CopyPart` mutation.
Apr 23 2018, 11:34 PM
delcypher committed rL330687: [LibFuzzer] Tweak `MutationDispatcher::Mutate_CopyPart` mutation..
[LibFuzzer] Tweak `MutationDispatcher::Mutate_CopyPart` mutation.
Apr 23 2018, 11:34 PM
delcypher closed D45693: [LibFuzzer] Tweak `MutationDispatcher::Mutate_CopyPart` mutation..
Apr 23 2018, 11:34 PM
delcypher updated the diff for D45693: [LibFuzzer] Tweak `MutationDispatcher::Mutate_CopyPart` mutation..

s/unsigned int/int/ in test case.

Apr 23 2018, 11:33 PM
delcypher added inline comments to D45693: [LibFuzzer] Tweak `MutationDispatcher::Mutate_CopyPart` mutation..
Apr 23 2018, 3:41 AM

Apr 20 2018

delcypher committed rL330409: [lit] Fix a bug where UNRESOLVED tests were not handled in the XUnit.
[lit] Fix a bug where UNRESOLVED tests were not handled in the XUnit
Apr 20 2018, 3:15 AM
delcypher closed D45567: [lit] Fix a bug where UNRESOLVED tests were not handled in the XUnit XML printer..
Apr 20 2018, 3:15 AM
delcypher updated the diff for D45693: [LibFuzzer] Tweak `MutationDispatcher::Mutate_CopyPart` mutation..

Add unit test.

Apr 20 2018, 12:10 AM
delcypher added a comment to D45693: [LibFuzzer] Tweak `MutationDispatcher::Mutate_CopyPart` mutation..
In D45693#1071306, @kcc wrote:

Ok, sounds good.
Yes, please add a test that calls Mutate_CopyPart many times and always sees it return MaxSize

Apr 20 2018, 12:10 AM

Apr 19 2018

delcypher committed rL330391: [LibFuzzer] Report when custom counters are available..
[LibFuzzer] Report when custom counters are available.
Apr 19 2018, 11:50 PM
delcypher committed rCRT330391: [LibFuzzer] Report when custom counters are available..
[LibFuzzer] Report when custom counters are available.
Apr 19 2018, 11:50 PM
delcypher closed D45675: [LibFuzzer] Report when custom counters are available..
Apr 19 2018, 11:50 PM
delcypher committed rCRT330390: [LibFuzzer] Try to unbreak the `FuzzerMutate.ShuffleBytes1` unit test..
[LibFuzzer] Try to unbreak the `FuzzerMutate.ShuffleBytes1` unit test.
Apr 19 2018, 11:49 PM
delcypher committed rCRT330389: [LibFuzzer] Unbreak the `trace-malloc-unbalanced.test` when using Python 3..
[LibFuzzer] Unbreak the `trace-malloc-unbalanced.test` when using Python 3.
Apr 19 2018, 11:49 PM
delcypher committed rL330390: [LibFuzzer] Try to unbreak the `FuzzerMutate.ShuffleBytes1` unit test..
[LibFuzzer] Try to unbreak the `FuzzerMutate.ShuffleBytes1` unit test.
Apr 19 2018, 11:49 PM
delcypher closed D45767: [LibFuzzer] Try to unbreak the `FuzzerMutate.ShuffleBytes1` unit test.
Apr 19 2018, 11:49 PM
delcypher committed rL330389: [LibFuzzer] Unbreak the `trace-malloc-unbalanced.test` when using Python 3..
[LibFuzzer] Unbreak the `trace-malloc-unbalanced.test` when using Python 3.
Apr 19 2018, 11:49 PM
delcypher closed D45765: [LibFuzzer] Unbreak the `trace-malloc-unbalanced.test` when using Python 3..
Apr 19 2018, 11:49 PM

Apr 18 2018

delcypher created D45767: [LibFuzzer] Try to unbreak the `FuzzerMutate.ShuffleBytes1` unit test.
Apr 18 2018, 5:54 AM
delcypher created D45765: [LibFuzzer] Unbreak the `trace-malloc-unbalanced.test` when using Python 3..
Apr 18 2018, 5:51 AM
delcypher created D45762: [LibFuzzer] Add support for an optional user defined callback (`LLVMFuzzerOnExitHandler()`).
Apr 18 2018, 5:30 AM
delcypher added a comment to D45693: [LibFuzzer] Tweak `MutationDispatcher::Mutate_CopyPart` mutation..
In D45693#1069081, @kcc wrote:

LGTM
I wonder how you can observe the change?
It's just a slight change in probabilities.
Or not slight?

Apr 18 2018, 1:44 AM

Apr 16 2018

delcypher created D45693: [LibFuzzer] Tweak `MutationDispatcher::Mutate_CopyPart` mutation..
Apr 16 2018, 9:39 AM
delcypher updated the diff for D45675: [LibFuzzer] Report when custom counters are available..

Don't hard code number of counters because this number is not stable.

Apr 16 2018, 9:33 AM

Apr 15 2018

delcypher created D45675: [LibFuzzer] Report when custom counters are available..
Apr 15 2018, 11:28 AM

Apr 12 2018

delcypher added inline comments to D44598: [lit] Report line number for failed RUN command.
Apr 12 2018, 2:32 PM
delcypher added inline comments to D45567: [lit] Fix a bug where UNRESOLVED tests were not handled in the XUnit XML printer..
Apr 12 2018, 12:46 PM
delcypher added inline comments to D44598: [lit] Report line number for failed RUN command.
Apr 12 2018, 9:58 AM
delcypher added a comment to D45567: [lit] Fix a bug where UNRESOLVED tests were not handled in the XUnit XML printer..

LGTM. Thanks!

Apr 12 2018, 9:48 AM
delcypher requested changes to D44598: [lit] Report line number for failed RUN command.
Apr 12 2018, 9:45 AM
delcypher created D45567: [lit] Fix a bug where UNRESOLVED tests were not handled in the XUnit XML printer..
Apr 12 2018, 6:21 AM

Apr 11 2018

delcypher accepted D45487: [tsan] Add interceptors for objc_sync_enter and objc_sync_exit.
Apr 11 2018, 9:59 AM · Restricted Project
delcypher added inline comments to D45487: [tsan] Add interceptors for objc_sync_enter and objc_sync_exit.
Apr 11 2018, 9:59 AM · Restricted Project

Apr 10 2018

delcypher added inline comments to D45337: [builtins] Prevent racing between setting supported architectures in builtin-config-ix and config-ix.
Apr 10 2018, 1:38 PM
delcypher added inline comments to D45487: [tsan] Add interceptors for objc_sync_enter and objc_sync_exit.
Apr 10 2018, 10:56 AM · Restricted Project

Apr 4 2018

delcypher added a comment to D45235: [libFuzzer] Enable multi-architecture and multi-platform build for libFuzzer .

Open question: how does %t even work for compiler-rt? In multi-arch setup, the expansion will be the same for different architectures, so two tests are quite likely to race. From what I have seen, the tests seem to be run because they are somehow run sequentially for different architectures?

Apr 4 2018, 3:16 AM

Mar 29 2018

delcypher committed rCRT328775: [asan] Split the `throw_invoke_test.cc` into a Linux specific variant.
[asan] Split the `throw_invoke_test.cc` into a Linux specific variant
Mar 29 2018, 6:57 AM
delcypher committed rL328775: [asan] Split the `throw_invoke_test.cc` into a Linux specific variant.
[asan] Split the `throw_invoke_test.cc` into a Linux specific variant
Mar 29 2018, 6:56 AM
delcypher closed D44733: Split the `throw_invoke_test.cc` test.
Mar 29 2018, 6:56 AM

Mar 28 2018

delcypher committed rL328703: Revert "[lit] Temporarily disable shtest-timeout.py on darwin".
Revert "[lit] Temporarily disable shtest-timeout.py on darwin"
Mar 28 2018, 6:58 AM
delcypher committed rL328702: [lit] Remove a timing senstive part of `shtest-timeout.py`.
[lit] Remove a timing senstive part of `shtest-timeout.py`
Mar 28 2018, 6:58 AM
delcypher added a comment to D44733: Split the `throw_invoke_test.cc` test.

@kcc @kubamracek Any thoughts? It's been a week so unless there are some objections I'd like to merge this soon.

Mar 28 2018, 5:40 AM

Mar 21 2018

delcypher added a comment to D44733: Split the `throw_invoke_test.cc` test.

Hmm, that's basically duplicating the test case. Maybe you can #include "../throw_invoke_test.cc"?

Mar 21 2018, 7:31 AM
delcypher added a comment to D40778: [DebugIR] Revive the Debug IR pass. [Added llvm-commits].

@bollu Are you still interested in working on this? I'm interested in getting this pass back into upstream LLVM. If you don't have time I'm willing to take over this if you like.

Mar 21 2018, 7:00 AM · debug-info
delcypher created D44733: Split the `throw_invoke_test.cc` test.
Mar 21 2018, 6:43 AM
delcypher added a comment to D44579: [asan] Clean up some confusing code in `test/asan/TestCases/Darwin/segv_read_write.c` .

@aizatsky Any comments on this? It appears you are the author of this test, so I'd like to make sure you're happy with the change.

Mar 21 2018, 5:06 AM

Mar 17 2018

delcypher added a comment to D44598: [lit] Report line number for failed RUN command.

Your description of needing to pass -vv doesn't look accurate, doesn't the test case just pass -v?

Mar 17 2018, 1:40 PM

Mar 16 2018

delcypher added inline comments to D44243: [asan] Make ScopedInErrorReport::current_error_ linker-initialized.
Mar 16 2018, 1:13 PM · Restricted Project
delcypher created D44579: [asan] Clean up some confusing code in `test/asan/TestCases/Darwin/segv_read_write.c` .
Mar 16 2018, 1:05 PM
delcypher updated the summary of D44579: [asan] Clean up some confusing code in `test/asan/TestCases/Darwin/segv_read_write.c` .
Mar 16 2018, 1:05 PM

Mar 12 2018

delcypher added a comment to D43704: Utility functions for checked arithmetic.
Mar 12 2018, 4:25 AM

Mar 9 2018

delcypher committed rCRT327185: [asan] Clean up the REQUIRES of `asan/TestCases/strcat-overlap.cc`.
[asan] Clean up the REQUIRES of `asan/TestCases/strcat-overlap.cc`
Mar 9 2018, 3:17 PM
delcypher committed rL327185: [asan] Clean up the REQUIRES of `asan/TestCases/strcat-overlap.cc`.
[asan] Clean up the REQUIRES of `asan/TestCases/strcat-overlap.cc`
Mar 9 2018, 3:17 PM
delcypher committed rCRT327122: [asan] Try to unbreak arm build bots by only running the test on.
[asan] Try to unbreak arm build bots by only running the test on
Mar 9 2018, 4:31 AM
delcypher committed rL327122: [asan] Try to unbreak arm build bots by only running the test on.
[asan] Try to unbreak arm build bots by only running the test on
Mar 9 2018, 4:31 AM

Mar 8 2018

delcypher committed rL327068: [asan] Fix bug where suppression of overlapping accesses was ignored on.
[asan] Fix bug where suppression of overlapping accesses was ignored on
Mar 8 2018, 1:54 PM
delcypher committed rCRT327068: [asan] Fix bug where suppression of overlapping accesses was ignored on.
[asan] Fix bug where suppression of overlapping accesses was ignored on
Mar 8 2018, 1:54 PM
delcypher closed D43702: [asan] Fix bug where suppression of overlapping accesses was ignored..
Mar 8 2018, 1:54 PM
delcypher added a comment to D43702: [asan] Fix bug where suppression of overlapping accesses was ignored..

@alekseyshl Good to go?

Mar 8 2018, 11:43 AM
delcypher updated the diff for D43702: [asan] Fix bug where suppression of overlapping accesses was ignored..

Remove superflous --check-prefix command line option.

Mar 8 2018, 11:39 AM
delcypher added a comment to D44243: [asan] Make ScopedInErrorReport::current_error_ linker-initialized.

Based on other code that uses LINKER_INITIALIZED this seems reasonable. However I have no idea how this is supposed to actually work.

Mar 8 2018, 9:35 AM · Restricted Project
delcypher accepted D44246: [sanitizer] Generalize atomic_uint8_t, atomic_uint16_t, ... into a template. NFC..

LGTM.

Mar 8 2018, 8:54 AM · Restricted Project
delcypher added a comment to D43702: [asan] Fix bug where suppression of overlapping accesses was ignored..

LGTM, thanks!

Mar 8 2018, 8:48 AM
delcypher updated the diff for D43702: [asan] Fix bug where suppression of overlapping accesses was ignored..

Add tests for strcat(), strncat(), and strcpy().

Mar 8 2018, 8:48 AM

Mar 7 2018

delcypher added inline comments to D43702: [asan] Fix bug where suppression of overlapping accesses was ignored..
Mar 7 2018, 11:12 AM
delcypher updated the diff for D43702: [asan] Fix bug where suppression of overlapping accesses was ignored..

Support interceptor_name suppression.

Mar 7 2018, 11:12 AM

Feb 26 2018

delcypher added inline comments to D43702: [asan] Fix bug where suppression of overlapping accesses was ignored..
Feb 26 2018, 10:50 AM

Feb 24 2018

delcypher committed rCRT326032: [ubsan-minimal] Fix the ubsan_minimal debug build (COMPILER_RT_DEBUG=1) on….
[ubsan-minimal] Fix the ubsan_minimal debug build (COMPILER_RT_DEBUG=1) on…
Feb 24 2018, 5:19 AM
delcypher committed rL326032: [ubsan-minimal] Fix the ubsan_minimal debug build (COMPILER_RT_DEBUG=1) on….
[ubsan-minimal] Fix the ubsan_minimal debug build (COMPILER_RT_DEBUG=1) on…
Feb 24 2018, 5:19 AM
delcypher added a comment to D43676: [ubsan-minimal] Fix the ubsan_minimal debug build (COMPILER_RT_DEBUG=1) on macOS.

Committed in r326032

Feb 24 2018, 5:19 AM
delcypher closed D43676: [ubsan-minimal] Fix the ubsan_minimal debug build (COMPILER_RT_DEBUG=1) on macOS.
Feb 24 2018, 5:19 AM