Page MenuHomePhabricator

delcypher (Dan Liew)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 21 2015, 4:29 PM (178 w, 2 d)

Recent Activity

Yesterday

delcypher added a parent revision for D56996: [ASan] Add tests for Darwin in-process and out-of-process malloc zone enumeration.: D56995: [ASan] Implement malloc zone enumeration for Darwin..
Sun, Jan 20, 6:01 PM
delcypher added a child revision for D56995: [ASan] Implement malloc zone enumeration for Darwin.: D56996: [ASan] Add tests for Darwin in-process and out-of-process malloc zone enumeration..
Sun, Jan 20, 6:01 PM
delcypher created D56996: [ASan] Add tests for Darwin in-process and out-of-process malloc zone enumeration..
Sun, Jan 20, 5:59 PM
delcypher added a parent revision for D56995: [ASan] Implement malloc zone enumeration for Darwin.: D56994: Add `LsanMetadataRemoteView` class..
Sun, Jan 20, 5:58 PM
delcypher added a child revision for D56994: Add `LsanMetadataRemoteView` class.: D56995: [ASan] Implement malloc zone enumeration for Darwin..
Sun, Jan 20, 5:58 PM
delcypher created D56995: [ASan] Implement malloc zone enumeration for Darwin..
Sun, Jan 20, 5:57 PM
delcypher added a parent revision for D56994: Add `LsanMetadataRemoteView` class.: D56993: Refactor `GetAsanChunk()` method so it can be used in an in-process and out-of-process context..
Sun, Jan 20, 5:55 PM
delcypher added a child revision for D56993: Refactor `GetAsanChunk()` method so it can be used in an in-process and out-of-process context.: D56994: Add `LsanMetadataRemoteView` class..
Sun, Jan 20, 5:55 PM
delcypher created D56994: Add `LsanMetadataRemoteView` class..
Sun, Jan 20, 5:54 PM
delcypher added a parent revision for D56993: Refactor `GetAsanChunk()` method so it can be used in an in-process and out-of-process context.: D56968: Refactor `AsanChunk` methods into code that supports both in-process and out-of-process examination of `AsanChunk`s..
Sun, Jan 20, 5:53 PM
delcypher created D56993: Refactor `GetAsanChunk()` method so it can be used in an in-process and out-of-process context..
Sun, Jan 20, 5:53 PM
delcypher added a child revision for D56968: Refactor `AsanChunk` methods into code that supports both in-process and out-of-process examination of `AsanChunk`s.: D56993: Refactor `GetAsanChunk()` method so it can be used in an in-process and out-of-process context..
Sun, Jan 20, 5:53 PM
delcypher committed rCRT351713: [ASan] On Darwin record global allocator pointer and size in introspection….
[ASan] On Darwin record global allocator pointer and size in introspection…
Sun, Jan 20, 5:41 PM
delcypher committed rCRT351712: On Darwin add allocator address and size fields to.
On Darwin add allocator address and size fields to
Sun, Jan 20, 5:41 PM
delcypher committed rL351713: [ASan] On Darwin record global allocator pointer and size in introspection….
[ASan] On Darwin record global allocator pointer and size in introspection…
Sun, Jan 20, 5:41 PM
delcypher committed rL351712: On Darwin add allocator address and size fields to.
On Darwin add allocator address and size fields to
Sun, Jan 20, 5:41 PM
delcypher committed rCRT351711: On Darwin allow for sanitizer malloc implementations to provide a zone.
On Darwin allow for sanitizer malloc implementations to provide a zone
Sun, Jan 20, 5:41 PM
delcypher committed rL351711: On Darwin allow for sanitizer malloc implementations to provide a zone.
On Darwin allow for sanitizer malloc implementations to provide a zone
Sun, Jan 20, 5:41 PM
delcypher committed rCRT351689: Fix bug in `AsanAllocatorASVT` (ASan) and `AllocatorASVT` (LSan) templated….
Fix bug in `AsanAllocatorASVT` (ASan) and `AllocatorASVT` (LSan) templated…
Sun, Jan 20, 8:59 AM
delcypher committed rL351689: Fix bug in `AsanAllocatorASVT` (ASan) and `AllocatorASVT` (LSan) templated….
Fix bug in `AsanAllocatorASVT` (ASan) and `AllocatorASVT` (LSan) templated…
Sun, Jan 20, 8:57 AM
delcypher updated the summary of D56968: Refactor `AsanChunk` methods into code that supports both in-process and out-of-process examination of `AsanChunk`s..
Sun, Jan 20, 8:25 AM
delcypher updated the summary of D56964: Make more allocator methods work correctly with in an out-of-process mode..
Sun, Jan 20, 8:25 AM
delcypher updated the diff for D56968: Refactor `AsanChunk` methods into code that supports both in-process and out-of-process examination of `AsanChunk`s..

Comment tweak.

Sun, Jan 20, 5:14 AM
delcypher updated the summary of D56968: Refactor `AsanChunk` methods into code that supports both in-process and out-of-process examination of `AsanChunk`s..
Sun, Jan 20, 5:09 AM

Sat, Jan 19

delcypher added a parent revision for D56968: Refactor `AsanChunk` methods into code that supports both in-process and out-of-process examination of `AsanChunk`s.: D56964: Make more allocator methods work correctly with in an out-of-process mode..
Sat, Jan 19, 3:52 PM
delcypher added a child revision for D56964: Make more allocator methods work correctly with in an out-of-process mode.: D56968: Refactor `AsanChunk` methods into code that supports both in-process and out-of-process examination of `AsanChunk`s..
Sat, Jan 19, 3:52 PM
delcypher created D56968: Refactor `AsanChunk` methods into code that supports both in-process and out-of-process examination of `AsanChunk`s..
Sat, Jan 19, 3:51 PM
delcypher added a parent revision for D56964: Make more allocator methods work correctly with in an out-of-process mode.: D56207: Update allocator unit tests to test the `RemoteAddressSpaceView` template instantiation..
Sat, Jan 19, 10:43 AM
delcypher added a child revision for D56207: Update allocator unit tests to test the `RemoteAddressSpaceView` template instantiation.: D56964: Make more allocator methods work correctly with in an out-of-process mode..
Sat, Jan 19, 10:43 AM
delcypher created D56964: Make more allocator methods work correctly with in an out-of-process mode..
Sat, Jan 19, 10:43 AM
delcypher updated the diff for D56206: Introduce `RemoteAddressSpaceView` and `VMReadContext`..

Rebase on master and adopt new license headers.

Sat, Jan 19, 10:39 AM

Fri, Jan 18

Herald added a reviewer for D47210: [lit] Fix the `--max-time` flag feature which was completely broken.: serge-sans-paille.
Fri, Jan 18, 10:31 AM
delcypher added inline comments to D56207: Update allocator unit tests to test the `RemoteAddressSpaceView` template instantiation..
Fri, Jan 18, 8:56 AM
delcypher added a comment to D56206: Introduce `RemoteAddressSpaceView` and `VMReadContext`..

@vitalybuka I've done another pass over the patch and fixed everything I reasonably could. Please make another pass when you have time.

Fri, Jan 18, 8:41 AM
delcypher added inline comments to D56206: Introduce `RemoteAddressSpaceView` and `VMReadContext`..
Fri, Jan 18, 8:39 AM
delcypher updated the diff for D56206: Introduce `RemoteAddressSpaceView` and `VMReadContext`..
  • Check thread id
  • Use atomic variables
Fri, Jan 18, 8:39 AM
delcypher added inline comments to D56206: Introduce `RemoteAddressSpaceView` and `VMReadContext`..
Fri, Jan 18, 7:49 AM
delcypher added inline comments to D56206: Introduce `RemoteAddressSpaceView` and `VMReadContext`..
Fri, Jan 18, 7:30 AM
delcypher added inline comments to D56206: Introduce `RemoteAddressSpaceView` and `VMReadContext`..
Fri, Jan 18, 7:24 AM
delcypher updated the diff for D56206: Introduce `RemoteAddressSpaceView` and `VMReadContext`..

Minor tweaks.

Fri, Jan 18, 7:22 AM
delcypher added inline comments to D56206: Introduce `RemoteAddressSpaceView` and `VMReadContext`..
Fri, Jan 18, 5:27 AM

Thu, Jan 17

delcypher added inline comments to D56207: Update allocator unit tests to test the `RemoteAddressSpaceView` template instantiation..
Thu, Jan 17, 11:51 AM
delcypher added a comment to D56624: [Sanitizers] UBSan unreachable incompatible with ASan in the presence of `noreturn` calls.

Is it possible to write a test with a custom noreturn function that tries to touch the stack such that with the old Clang we'd get a false positive report (when building with ASan+UBSan) when we try to execute it?

Thu, Jan 17, 5:20 AM · Restricted Project
delcypher added inline comments to D56624: [Sanitizers] UBSan unreachable incompatible with ASan in the presence of `noreturn` calls.
Thu, Jan 17, 5:17 AM · Restricted Project
delcypher added inline comments to D56624: [Sanitizers] UBSan unreachable incompatible with ASan in the presence of `noreturn` calls.
Thu, Jan 17, 5:15 AM · Restricted Project
delcypher added a comment to D56624: [Sanitizers] UBSan unreachable incompatible with ASan in the presence of `noreturn` calls.

@yln A few comments on the patch description.

Thu, Jan 17, 4:56 AM · Restricted Project

Wed, Jan 16

delcypher committed rCRT351398: Fix sanitizer tool list used to generate sanitizer_common tests to be up-to….
Fix sanitizer tool list used to generate sanitizer_common tests to be up-to…
Wed, Jan 16, 3:41 PM
delcypher committed rL351398: Fix sanitizer tool list used to generate sanitizer_common tests to be up-to….
Fix sanitizer tool list used to generate sanitizer_common tests to be up-to…
Wed, Jan 16, 3:41 PM
delcypher closed D55740: Fix sanitizer tool list used to generate sanitizer_common tests to be up-to-date..
Wed, Jan 16, 3:41 PM
delcypher added a comment to D56206: Introduce `RemoteAddressSpaceView` and `VMReadContext`..

@vitalybuka I've fixed what I can and I've left questions about things that aren't straightforward to fix or that I don't agree with. When you have time could you take another look?

Wed, Jan 16, 8:18 AM
delcypher added inline comments to D56206: Introduce `RemoteAddressSpaceView` and `VMReadContext`..
Wed, Jan 16, 8:18 AM
delcypher updated the diff for D56206: Introduce `RemoteAddressSpaceView` and `VMReadContext`..
  • Remote fields/methods in VMReadContext that won't be used.
  • Remove default writable=true argument.
Wed, Jan 16, 8:13 AM
delcypher added inline comments to rL351314: [NewPM][TSan] Reiterate the TSan port.
Wed, Jan 16, 4:05 AM
delcypher added inline comments to rL351314: [NewPM][TSan] Reiterate the TSan port.
Wed, Jan 16, 3:57 AM

Tue, Jan 15

delcypher added a comment to D55740: Fix sanitizer tool list used to generate sanitizer_common tests to be up-to-date..

@vitalybuka Sorry the delay in getting to this. Is this good to go?

Tue, Jan 15, 9:27 AM
delcypher updated the diff for D55740: Fix sanitizer tool list used to generate sanitizer_common tests to be up-to-date..
  • Remove SUPPORTED_TOOLS_LEGACY
Tue, Jan 15, 9:23 AM
delcypher committed rCRT351169: Explicitly set C++ standard for `Posix/no-fd.cc` ASan test..
Explicitly set C++ standard for `Posix/no-fd.cc` ASan test.
Tue, Jan 15, 12:58 AM
delcypher committed rL351169: Explicitly set C++ standard for `Posix/no-fd.cc` ASan test..
Explicitly set C++ standard for `Posix/no-fd.cc` ASan test.
Tue, Jan 15, 12:58 AM
delcypher closed D56667: Explicitly set C++ standard for `Posix/no-fd.cc` ASan test..
Tue, Jan 15, 12:58 AM
delcypher retitled D56667: Explicitly set C++ standard for `Posix/no-fd.cc` ASan test. from Explicitly set C++ standard fo `Posix/no-fd.cc` ASan test. to Explicitly set C++ standard for `Posix/no-fd.cc` ASan test..
Tue, Jan 15, 12:57 AM

Mon, Jan 14

delcypher added inline comments to D56207: Update allocator unit tests to test the `RemoteAddressSpaceView` template instantiation..
Mon, Jan 14, 9:00 AM
delcypher added inline comments to D56206: Introduce `RemoteAddressSpaceView` and `VMReadContext`..
Mon, Jan 14, 8:52 AM
delcypher updated the diff for D56207: Update allocator unit tests to test the `RemoteAddressSpaceView` template instantiation..

Use new RemoteAddressSpaceView::ScopedContext.

Mon, Jan 14, 8:50 AM
delcypher updated the diff for D56206: Introduce `RemoteAddressSpaceView` and `VMReadContext`..

Lots of clean-up.

Mon, Jan 14, 8:49 AM
delcypher updated the summary of D56667: Explicitly set C++ standard for `Posix/no-fd.cc` ASan test..
Mon, Jan 14, 8:40 AM
delcypher created D56667: Explicitly set C++ standard for `Posix/no-fd.cc` ASan test..
Mon, Jan 14, 8:04 AM

Fri, Jan 11

delcypher added inline comments to D56206: Introduce `RemoteAddressSpaceView` and `VMReadContext`..
Fri, Jan 11, 12:24 PM
delcypher added inline comments to D56206: Introduce `RemoteAddressSpaceView` and `VMReadContext`..
Fri, Jan 11, 11:00 AM
delcypher committed rL350940: Provide storage for `true_type::value` and `false_type::value`..
Provide storage for `true_type::value` and `false_type::value`.
Fri, Jan 11, 10:03 AM
delcypher committed rCRT350940: Provide storage for `true_type::value` and `false_type::value`..
Provide storage for `true_type::value` and `false_type::value`.
Fri, Jan 11, 10:03 AM
delcypher closed D56035: Provide storage for `true_type::value` and `false_type::value`..
Fri, Jan 11, 10:03 AM
delcypher updated the diff for D56035: Provide storage for `true_type::value` and `false_type::value`..

Adding spacing above and below declarations in namespace.

Fri, Jan 11, 10:03 AM

Thu, Jan 10

delcypher added a comment to D56541: [FileCheck] Don't propagate `FILECHECK_DUMP_INPUT_ON_FAILURE` and `FILECHECK_OPTS` into environment for FileCheck tests..

Okay I get the idea. This is a much more invasive change however. Would it be okay to commit this (with FILECHECK_OPTS also stripped out) and do your suggestion as a follow up patch?
The reason I'd prefer to do this is because this change is intended to fix some internal build bots. Due to where we are in the release cycle the changes I make need to be simple (i.e. the smaller the patch the better) in order to be accepted by internal reviewers.

This patch does improve the situation for everyone, and it's easy to revert, so I'm fine with that. But could you fix lit's test suite too? Should be easy, right? I'm not aware of any other test suites that are sensitive to FileCheck's output in this manner.

If it's straight forward I'll land it in a separate patch.

Thu, Jan 10, 9:52 AM
delcypher committed rL350854: [lit] Make it possible for the lit test suite to pass with.
[lit] Make it possible for the lit test suite to pass with
Thu, Jan 10, 9:51 AM
delcypher committed rL350850: [FileCheck] Don't propagate `FILECHECK_DUMP_INPUT_ON_FAILURE` and.
[FileCheck] Don't propagate `FILECHECK_DUMP_INPUT_ON_FAILURE` and
Thu, Jan 10, 9:27 AM
delcypher closed D56541: [FileCheck] Don't propagate `FILECHECK_DUMP_INPUT_ON_FAILURE` and `FILECHECK_OPTS` into environment for FileCheck tests..
Thu, Jan 10, 9:27 AM
delcypher added a comment to D56541: [FileCheck] Don't propagate `FILECHECK_DUMP_INPUT_ON_FAILURE` and `FILECHECK_OPTS` into environment for FileCheck tests..

Okay I get the idea. This is a much more invasive change however. Would it be okay to commit this (with FILECHECK_OPTS also stripped out) and do your suggestion as a follow up patch?
The reason I'd prefer to do this is because this change is intended to fix some internal build bots. Due to where we are in the release cycle the changes I make need to be simple (i.e. the smaller the patch the better) in order to be accepted by internal reviewers.

This patch does improve the situation for everyone, and it's easy to revert, so I'm fine with that. But could you fix lit's test suite too? Should be easy, right? I'm not aware of any other test suites that are sensitive to FileCheck's output in this manner.

Thu, Jan 10, 9:23 AM
delcypher retitled D56541: [FileCheck] Don't propagate `FILECHECK_DUMP_INPUT_ON_FAILURE` and `FILECHECK_OPTS` into environment for FileCheck tests. from Fix FileCheck tests when `FILECHECK_DUMP_INPUT_ON_FAILURE` is set in the environment that llvm-lit is executed in. to [FileCheck] Don't propagate `FILECHECK_DUMP_INPUT_ON_FAILURE` and `FILECHECK_OPTS` into environment for FileCheck tests..
Thu, Jan 10, 7:49 AM
delcypher updated the diff for D56541: [FileCheck] Don't propagate `FILECHECK_DUMP_INPUT_ON_FAILURE` and `FILECHECK_OPTS` into environment for FileCheck tests..

Also unset FILECHECK_OPTS.

Thu, Jan 10, 7:49 AM
delcypher added a comment to D56541: [FileCheck] Don't propagate `FILECHECK_DUMP_INPUT_ON_FAILURE` and `FILECHECK_OPTS` into environment for FileCheck tests..

I've been wanting to fix this too. Thanks for working on it. A few issues:

  • FILECHECK_OPTS should be cleared too.
Thu, Jan 10, 7:33 AM
delcypher updated the summary of D56541: [FileCheck] Don't propagate `FILECHECK_DUMP_INPUT_ON_FAILURE` and `FILECHECK_OPTS` into environment for FileCheck tests..
Thu, Jan 10, 5:51 AM
delcypher created D56541: [FileCheck] Don't propagate `FILECHECK_DUMP_INPUT_ON_FAILURE` and `FILECHECK_OPTS` into environment for FileCheck tests..
Thu, Jan 10, 5:42 AM

Wed, Jan 9

delcypher added a comment to D56433: [NewPM] Port tsan.

@philip.pfaffe

__tsan_init is external to generated TSan code (it lives in the TSan runtime), where as tsan.module_ctor() was in the same module. Perhaps dyld doesn't like calling functions external to the module directly.

Wed, Jan 9, 12:13 PM
delcypher added inline comments to D55740: Fix sanitizer tool list used to generate sanitizer_common tests to be up-to-date..
Wed, Jan 9, 6:54 AM
delcypher updated the diff for D55740: Fix sanitizer tool list used to generate sanitizer_common tests to be up-to-date..
  • Put legacy list back but only use it for Windows and Android.
  • Print warning when we use the legacy list.
  • Print the generated SUPPORTED_TOOLS list.
Wed, Jan 9, 6:53 AM
delcypher added a comment to D56433: [NewPM] Port tsan.

@philip.pfaffe This patch got reverted (not by me r350719) because it broke TSan on macOS.

Wed, Jan 9, 6:25 AM
delcypher added inline comments to D56206: Introduce `RemoteAddressSpaceView` and `VMReadContext`..
Wed, Jan 9, 1:22 AM
delcypher added inline comments to D56035: Provide storage for `true_type::value` and `false_type::value`..
Wed, Jan 9, 1:09 AM

Tue, Jan 8

delcypher added a comment to D56207: Update allocator unit tests to test the `RemoteAddressSpaceView` template instantiation..

@kcc @vitalybuka Ping.

Tue, Jan 8, 3:18 PM
delcypher added a comment to D56206: Introduce `RemoteAddressSpaceView` and `VMReadContext`..

@kcc @vitalybuka Ping.

Tue, Jan 8, 3:18 PM

Fri, Jan 4

delcypher added inline comments to D56295: [TSan] Use switches when dealing with enums.
Fri, Jan 4, 5:24 AM · Restricted Project
delcypher accepted D56302: Fix typo: "with he MODULE" -> "with the MODULE".

@msearles LGTM. Do you have commit access or would you like me to commit this on your behalf?

Fri, Jan 4, 5:17 AM

Thu, Jan 3

delcypher added a comment to D56207: Update allocator unit tests to test the `RemoteAddressSpaceView` template instantiation..

This needs https://reviews.llvm.org/D56206 to land first, right?

Oops. Yes. I forgot to add the dependency in Phabricator. I've done it now.

Tests suppose to pass after every patch.
Does D56206 work without D56207
If not, you should merge them.

Thu, Jan 3, 7:11 AM
delcypher added a comment to D56206: Introduce `RemoteAddressSpaceView` and `VMReadContext`..

Would it make sense to also extend this to Linux using process_vm_readv/process_vm_writev?

Thu, Jan 3, 7:06 AM

Wed, Jan 2

delcypher added a comment to D56207: Update allocator unit tests to test the `RemoteAddressSpaceView` template instantiation..

This needs https://reviews.llvm.org/D56206 to land first, right?

Wed, Jan 2, 11:46 AM
delcypher added a parent revision for D56207: Update allocator unit tests to test the `RemoteAddressSpaceView` template instantiation.: D56206: Introduce `RemoteAddressSpaceView` and `VMReadContext`..
Wed, Jan 2, 11:43 AM
delcypher added a child revision for D56206: Introduce `RemoteAddressSpaceView` and `VMReadContext`.: D56207: Update allocator unit tests to test the `RemoteAddressSpaceView` template instantiation..
Wed, Jan 2, 11:43 AM
delcypher accepted D50388: Respect PYTHONPATH.

@greened Sorry looks like I missed your earlier pings. LGTM

Wed, Jan 2, 10:49 AM
delcypher created D56207: Update allocator unit tests to test the `RemoteAddressSpaceView` template instantiation..
Wed, Jan 2, 10:42 AM
delcypher updated the diff for D56206: Introduce `RemoteAddressSpaceView` and `VMReadContext`..

Fix some comments.

Wed, Jan 2, 10:40 AM