Page MenuHomePhabricator

delcypher (Dan Liew)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 21 2015, 4:29 PM (195 w, 3 d)

Recent Activity

Sun, Apr 28

delcypher added a comment to D61242: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms. Attempt #2..

@juliehockett @phosek This is a new version of https://reviews.llvm.org/D58578 . Would you be able to test it in your set up? I'd prefer to have the confidence of knowing it doesn't break your set up before landing this.

Sun, Apr 28, 9:32 AM · Restricted Project, Restricted Project
delcypher created D61242: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms. Attempt #2..
Sun, Apr 28, 9:31 AM · Restricted Project, Restricted Project
delcypher committed rCRT359394: [CMake] Don't modify `FUZZER_SUPPORTED_ARCH` is place..
[CMake] Don't modify `FUZZER_SUPPORTED_ARCH` is place.
Sun, Apr 28, 2:45 AM
delcypher committed rG8651edf89854: [CMake] Don't modify `FUZZER_SUPPORTED_ARCH` is place. (authored by delcypher).
[CMake] Don't modify `FUZZER_SUPPORTED_ARCH` is place.
Sun, Apr 28, 2:44 AM
delcypher committed rL359394: [CMake] Don't modify `FUZZER_SUPPORTED_ARCH` is place..
[CMake] Don't modify `FUZZER_SUPPORTED_ARCH` is place.
Sun, Apr 28, 2:44 AM

Sat, Apr 27

delcypher added a comment to D58578: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms..

Sure -- to clarify, it's not a test failure, it's a build one. The error was triggered during the CMake configuration step for host runtimes, where we have OSX supported arches: x86_64 only. test/tsan/CMakeLists.txt:78 now calls into the new function on the arm64 case, which down the line triggers a CMake assert that arm64 is in the list of supported arches when it isn't.

Seems like prior to this change, the lit tests were being configured without doing any checks on that list of supported arches. I'm not as familiar with how this code is set up, so I can't really say if it's a problem with this patch or if this patch is exposing another bug. Thanks for taking a look!

Sat, Apr 27, 4:16 AM · Restricted Project, Restricted Project
delcypher added a comment to D58578: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms..

To clarify, this is failing when building runtimes for Darwin so shouldn't be Fuchsia specific, but it could be affected by some of the Clang defaults we set in our CMake build. We use lld as the default linker for Fuchsia but not for Darwin where use the system linker.

Sat, Apr 27, 4:06 AM · Restricted Project, Restricted Project

Fri, Apr 26

delcypher added a comment to D58578: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms..

Sorry about this. I'll revert the patch now and I'll take a look at re-landing it when time permits.

Fri, Apr 26, 11:01 AM · Restricted Project, Restricted Project
delcypher committed rG18bc87240545: Revert "[CMake] Fix the value of `config.target_cflags` for non-macOS Apple" (authored by delcypher).
Revert "[CMake] Fix the value of `config.target_cflags` for non-macOS Apple"
Fri, Apr 26, 10:53 AM
delcypher committed rCRT359327: Revert "[CMake] Fix the value of `config.target_cflags` for non-macOS Apple".
Revert "[CMake] Fix the value of `config.target_cflags` for non-macOS Apple"
Fri, Apr 26, 10:52 AM
delcypher committed rL359327: Revert "[CMake] Fix the value of `config.target_cflags` for non-macOS Apple".
Revert "[CMake] Fix the value of `config.target_cflags` for non-macOS Apple"
Fri, Apr 26, 10:52 AM
delcypher added a comment to D58578: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms..

This patch has broken our bots -- when it's building the osx host runtime, it's now triggering an assert on the tsan arm64 test case that wasn't being triggered before. Would you be able to take a look?

Error:

CMake Error at /b/s/w/ir/k/llvm-project/compiler-rt/cmake/config-ix.cmake:177 (message):
  Unsupported architecture: arm64
Call Stack (most recent call first):
  /b/s/w/ir/k/llvm-project/compiler-rt/cmake/config-ix.cmake:216 (get_target_flags_for_arch)
  /b/s/w/ir/k/llvm-project/compiler-rt/test/tsan/CMakeLists.txt:78 (get_test_cflags_for_apple_platform)

Full log: https://logs.chromium.org/logs/fuchsia/buildbucket/cr-buildbucket.appspot.com/8915104112618242800/+/steps/clang/0/steps/build/0/stdout

Fri, Apr 26, 10:45 AM · Restricted Project, Restricted Project
delcypher added a comment to D60533: [asan_symbolize] Teach `asan_symbolize.py` to symbolicate partially symbolicated ASan reports..

Can you make the tests Posix?

Fri, Apr 26, 10:01 AM · Restricted Project, Restricted Project
delcypher committed rG60f5df948b0d: [asan_symbolize] Teach `asan_symbolize.py` to symbolicate using a module map (authored by delcypher).
[asan_symbolize] Teach `asan_symbolize.py` to symbolicate using a module map
Fri, Apr 26, 9:53 AM
delcypher committed rCRT359322: [asan_symbolize] Teach `asan_symbolize.py` to symbolicate using a module map.
[asan_symbolize] Teach `asan_symbolize.py` to symbolicate using a module map
Fri, Apr 26, 9:53 AM
delcypher committed rL359322: [asan_symbolize] Teach `asan_symbolize.py` to symbolicate using a module map.
[asan_symbolize] Teach `asan_symbolize.py` to symbolicate using a module map
Fri, Apr 26, 9:52 AM
delcypher closed D60531: [asan_symbolize] Teach `asan_symbolize.py` to symbolicate using a module map.
Fri, Apr 26, 9:52 AM · Restricted Project, Restricted Project
delcypher added a comment to D60531: [asan_symbolize] Teach `asan_symbolize.py` to symbolicate using a module map.

Thanks for explanation

Fri, Apr 26, 9:52 AM · Restricted Project, Restricted Project
delcypher added a comment to D58578: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms..
In D58578#1475863, @yln wrote:

Overall changes: LGTM, thanks!

As already noted, I would probably change the is_valid_apple_platform to:
is_apple_platform -> just yes/no, even for the empty string.
or rename to assert_valid_apple_platform() -> no return value, aborts if not.

An is_xxx "getter" having 3 kinds of "results": true, false, or abort; is unexpected to me.

Fri, Apr 26, 6:31 AM · Restricted Project, Restricted Project
delcypher committed rG9f59704a5d60: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms. (authored by delcypher).
[CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms.
Fri, Apr 26, 6:24 AM
delcypher committed rL359305: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple.
[CMake] Fix the value of `config.target_cflags` for non-macOS Apple
Fri, Apr 26, 6:21 AM
delcypher committed rCRT359305: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple.
[CMake] Fix the value of `config.target_cflags` for non-macOS Apple
Fri, Apr 26, 6:20 AM
delcypher closed D58578: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms..
Fri, Apr 26, 6:20 AM · Restricted Project, Restricted Project
delcypher updated the diff for D58578: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms..

No real update, just for fixing up commit message on my local machine.

Fri, Apr 26, 3:18 AM · Restricted Project, Restricted Project

Wed, Apr 24

delcypher added a comment to D60531: [asan_symbolize] Teach `asan_symbolize.py` to symbolicate using a module map.

Is there a reason to tests this on Darwin only?

Wed, Apr 24, 12:04 PM · Restricted Project, Restricted Project

Tue, Apr 23

delcypher updated the summary of D58578: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms..
Tue, Apr 23, 3:41 AM · Restricted Project, Restricted Project
delcypher added a comment to D58578: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms..

@kubamracek @yln ping.

Tue, Apr 23, 2:54 AM · Restricted Project, Restricted Project

Apr 18 2019

delcypher added a comment to D60529: [asan_symbolize] Add a simple plugin architecture.

Looks like the build broke some bots (http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-android/builds/21212). It seems the code doesn't work properly in some really old versions of Python 2. I've managed to reproduce the issue using Python 2.7.6 and I've landed a fix https://reviews.llvm.org/rL358682

Apr 18 2019, 9:26 AM · Restricted Project, Restricted Project
delcypher committed rG16c3883b9837: [asan_symbolize] Workaround bug in old Python 2 versions. (authored by delcypher).
[asan_symbolize] Workaround bug in old Python 2 versions.
Apr 18 2019, 9:21 AM
delcypher committed rL358682: [asan_symbolize] Workaround bug in old Python 2 versions..
[asan_symbolize] Workaround bug in old Python 2 versions.
Apr 18 2019, 9:21 AM
delcypher committed rCRT358682: [asan_symbolize] Workaround bug in old Python 2 versions..
[asan_symbolize] Workaround bug in old Python 2 versions.
Apr 18 2019, 9:21 AM
delcypher committed rCRT358657: [asan_symbolize] Add a simple plugin architecture.
[asan_symbolize] Add a simple plugin architecture
Apr 18 2019, 4:34 AM
delcypher committed rG403d3187a79b: [asan_symbolize] Add a simple plugin architecture (authored by delcypher).
[asan_symbolize] Add a simple plugin architecture
Apr 18 2019, 4:34 AM
delcypher committed rL358657: [asan_symbolize] Add a simple plugin architecture.
[asan_symbolize] Add a simple plugin architecture
Apr 18 2019, 4:33 AM
delcypher closed D60529: [asan_symbolize] Add a simple plugin architecture.
Apr 18 2019, 4:33 AM · Restricted Project, Restricted Project

Apr 17 2019

delcypher added inline comments to D60529: [asan_symbolize] Add a simple plugin architecture.
Apr 17 2019, 1:26 AM · Restricted Project, Restricted Project

Apr 16 2019

delcypher added inline comments to D60529: [asan_symbolize] Add a simple plugin architecture.
Apr 16 2019, 4:06 PM · Restricted Project, Restricted Project

Apr 11 2019

delcypher added a comment to D60533: [asan_symbolize] Teach `asan_symbolize.py` to symbolicate partially symbolicated ASan reports..

LGTM

Apr 11 2019, 3:15 PM · Restricted Project, Restricted Project

Apr 10 2019

delcypher updated the diff for D60533: [asan_symbolize] Teach `asan_symbolize.py` to symbolicate partially symbolicated ASan reports..
  • Use cstdlib include instead of stdlib.h
  • Remove unused assert.h include
Apr 10 2019, 4:22 PM · Restricted Project, Restricted Project
delcypher updated the diff for D60531: [asan_symbolize] Teach `asan_symbolize.py` to symbolicate using a module map.
  • Use cstdlib header rather than stdlib.h
  • Drop unused assert.h
Apr 10 2019, 2:29 PM · Restricted Project, Restricted Project
delcypher updated the diff for D60529: [asan_symbolize] Add a simple plugin architecture.

Use cstdlib rather than stdlib.h

Apr 10 2019, 2:26 PM · Restricted Project, Restricted Project
delcypher added a parent revision for D60533: [asan_symbolize] Teach `asan_symbolize.py` to symbolicate partially symbolicated ASan reports.: D60531: [asan_symbolize] Teach `asan_symbolize.py` to symbolicate using a module map.
Apr 10 2019, 12:29 PM · Restricted Project, Restricted Project
delcypher added a child revision for D60531: [asan_symbolize] Teach `asan_symbolize.py` to symbolicate using a module map: D60533: [asan_symbolize] Teach `asan_symbolize.py` to symbolicate partially symbolicated ASan reports..
Apr 10 2019, 12:29 PM · Restricted Project, Restricted Project
delcypher added a child revision for D60529: [asan_symbolize] Add a simple plugin architecture: D60531: [asan_symbolize] Teach `asan_symbolize.py` to symbolicate using a module map.
Apr 10 2019, 12:29 PM · Restricted Project, Restricted Project
delcypher added a parent revision for D60531: [asan_symbolize] Teach `asan_symbolize.py` to symbolicate using a module map: D60529: [asan_symbolize] Add a simple plugin architecture.
Apr 10 2019, 12:29 PM · Restricted Project, Restricted Project
delcypher created D60533: [asan_symbolize] Teach `asan_symbolize.py` to symbolicate partially symbolicated ASan reports..
Apr 10 2019, 12:28 PM · Restricted Project, Restricted Project
delcypher created D60531: [asan_symbolize] Teach `asan_symbolize.py` to symbolicate using a module map.
Apr 10 2019, 12:28 PM · Restricted Project, Restricted Project
delcypher created D60529: [asan_symbolize] Add a simple plugin architecture.
Apr 10 2019, 12:23 PM · Restricted Project, Restricted Project

Apr 9 2019

delcypher committed rG2316429d04c1: [asan_symbolize] Move argument parser epilog text into script doc comment. (authored by delcypher).
[asan_symbolize] Move argument parser epilog text into script doc comment.
Apr 9 2019, 1:30 AM
delcypher committed rCRT357978: [asan_symbolize] Move argument parser epilog text into script doc comment..
[asan_symbolize] Move argument parser epilog text into script doc comment.
Apr 9 2019, 1:29 AM
delcypher committed rL357978: [asan_symbolize] Move argument parser epilog text into script doc comment..
[asan_symbolize] Move argument parser epilog text into script doc comment.
Apr 9 2019, 1:29 AM
delcypher closed D60398: [asan_symbolize] Move argument parser epilog text into script doc comment..
Apr 9 2019, 1:29 AM · Restricted Project, Restricted Project

Apr 8 2019

delcypher committed rG836da99af9cb: [asan_symbolize] Use proper logging infrastructure. (authored by delcypher).
[asan_symbolize] Use proper logging infrastructure.
Apr 8 2019, 3:29 PM
delcypher committed rCRT357951: [asan_symbolize] Use proper logging infrastructure..
[asan_symbolize] Use proper logging infrastructure.
Apr 8 2019, 3:28 PM
delcypher committed rL357951: [asan_symbolize] Use proper logging infrastructure..
[asan_symbolize] Use proper logging infrastructure.
Apr 8 2019, 3:28 PM
delcypher closed D60343: [asan_symbolize] Use proper logging infrastructure..
Apr 8 2019, 3:28 PM · Restricted Project, Restricted Project
delcypher added inline comments to D60343: [asan_symbolize] Use proper logging infrastructure..
Apr 8 2019, 3:24 PM · Restricted Project, Restricted Project
delcypher added a comment to D60343: [asan_symbolize] Use proper logging infrastructure..

Could you please update the summary?

Apr 8 2019, 3:23 PM · Restricted Project, Restricted Project
delcypher updated the summary of D60343: [asan_symbolize] Use proper logging infrastructure..
Apr 8 2019, 3:20 PM · Restricted Project, Restricted Project
delcypher added a parent revision for D60398: [asan_symbolize] Move argument parser epilog text into script doc comment.: D60343: [asan_symbolize] Use proper logging infrastructure..
Apr 8 2019, 1:14 AM · Restricted Project, Restricted Project
delcypher added a child revision for D60343: [asan_symbolize] Use proper logging infrastructure.: D60398: [asan_symbolize] Move argument parser epilog text into script doc comment..
Apr 8 2019, 1:14 AM · Restricted Project, Restricted Project
delcypher created D60398: [asan_symbolize] Move argument parser epilog text into script doc comment..
Apr 8 2019, 1:14 AM · Restricted Project, Restricted Project
delcypher updated the diff for D60343: [asan_symbolize] Use proper logging infrastructure..
  • Use command line arguments instead of environment variables
  • Add tests
Apr 8 2019, 1:02 AM · Restricted Project, Restricted Project

Apr 7 2019

delcypher added inline comments to D60343: [asan_symbolize] Use proper logging infrastructure..
Apr 7 2019, 3:03 AM · Restricted Project, Restricted Project

Apr 5 2019

delcypher created D60343: [asan_symbolize] Use proper logging infrastructure..
Apr 5 2019, 3:43 PM · Restricted Project, Restricted Project

Mar 21 2019

delcypher added inline comments to D59504: [NFC][Sanitizer] Clean up GetRealFunctionAddress.
Mar 21 2019, 3:40 PM · Restricted Project, Restricted Project
delcypher committed rCRT356701: Enable `asan/TestCases/Posix/start-deactivated.cc` test for iOS..
Enable `asan/TestCases/Posix/start-deactivated.cc` test for iOS.
Mar 21 2019, 12:22 PM
delcypher committed rG5988d72243bc: Enable `asan/TestCases/Posix/start-deactivated.cc` test for iOS. (authored by delcypher).
Enable `asan/TestCases/Posix/start-deactivated.cc` test for iOS.
Mar 21 2019, 12:20 PM
delcypher committed rL356701: Enable `asan/TestCases/Posix/start-deactivated.cc` test for iOS..
Enable `asan/TestCases/Posix/start-deactivated.cc` test for iOS.
Mar 21 2019, 12:19 PM
delcypher closed D59660: Enable `asan/TestCases/Posix/start-deactivated.cc` test for iOS..
Mar 21 2019, 12:19 PM · Restricted Project, Restricted Project
delcypher created D59660: Enable `asan/TestCases/Posix/start-deactivated.cc` test for iOS..
Mar 21 2019, 11:55 AM · Restricted Project, Restricted Project
delcypher removed a reviewer for D59660: Enable `asan/TestCases/Posix/start-deactivated.cc` test for iOS.: serge-sans-paille.
Mar 21 2019, 11:55 AM · Restricted Project, Restricted Project

Mar 18 2019

delcypher added a comment to D54978: Move the SMT API to LLVM.

Would one of you be able to file a bug against Z3 to fix this? I am no longer in a position to contribute to Z3 so I can't do this.

I've opened https://github.com/Z3Prover/z3/issues/2184 .

Mar 18 2019, 8:41 AM · Restricted Project, Restricted Project

Mar 16 2019

delcypher added a comment to D54978: Move the SMT API to LLVM.

Hi all,

Sorry for the massive delay, but I just updated the FindZ3 script to retrieve the version from the lib. I changed it to use try_run instead of try_compile so we can get the version number.

I tried to use @brzycki code to get the version from the header, however, it's not working for Z3 4.8.4. In Z3 4.8.3 the FULL_VERSION is a nice "Z3 4.8.3.0" but in version 4.8.4 it's "Z3 4.8.4.10272 d6df51951f4c master z3-4.8.4" and cmake fails with the following message:

-- Could NOT find Z3: Found unsuitable version "#define Z3_FULL_VERSION    "Z3 4.8.4.10272 d6df51951f4c master z3-4.8.4"", but required is at least "4.7.1" (found /home/mgadelha/z3/bin/libz3.so)
Mar 16 2019, 6:41 AM · Restricted Project, Restricted Project
delcypher added a comment to D54978: Move the SMT API to LLVM.

The only relevant commit that I can find is https://github.com/Z3Prover/z3/commit/2cb4223979cc94e2ebc4e49a9e83adbdcd2b6979 , but it first landed in z3 4.6.0. It looks like it's specific to CMake though, so is it different if you use the python build? I haven't tried the CMake build.

Mar 16 2019, 6:33 AM · Restricted Project, Restricted Project

Mar 15 2019

delcypher committed rG0bb9b5b481b7: [CMake] Fix broken uses of `try_compile_only()` and improve the function. (authored by delcypher).
[CMake] Fix broken uses of `try_compile_only()` and improve the function.
Mar 15 2019, 1:15 PM
delcypher committed rL356295: [CMake] Fix broken uses of `try_compile_only()` and improve the function..
[CMake] Fix broken uses of `try_compile_only()` and improve the function.
Mar 15 2019, 1:15 PM
delcypher committed rCRT356295: [CMake] Fix broken uses of `try_compile_only()` and improve the function..
[CMake] Fix broken uses of `try_compile_only()` and improve the function.
Mar 15 2019, 1:15 PM
delcypher closed D59429: [CMake] Fix broken uses of `try_compile_only()` and improve the function..
Mar 15 2019, 1:15 PM · Restricted Project, Restricted Project
delcypher updated the diff for D59429: [CMake] Fix broken uses of `try_compile_only()` and improve the function..

Fix missing unused arguments checks.

Mar 15 2019, 12:49 PM · Restricted Project, Restricted Project
delcypher created D59429: [CMake] Fix broken uses of `try_compile_only()` and improve the function..
Mar 15 2019, 12:46 PM · Restricted Project, Restricted Project
delcypher added a comment to D58578: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms..

@kubamracek @yln ping.

Mar 15 2019, 6:44 AM · Restricted Project, Restricted Project

Mar 8 2019

delcypher created D59150: [CMake] Separate the detection Darwin platforms architectures for the built-ins from the rest of compiler-rt..
Mar 8 2019, 12:59 PM · Restricted Project, Restricted Project

Mar 1 2019

delcypher added inline comments to D58194: [DebugInfo] add SectionedAddress to DebugInfo interfaces..
Mar 1 2019, 5:31 AM · debug-info, Restricted Project

Feb 28 2019

delcypher added inline comments to D58194: [DebugInfo] add SectionedAddress to DebugInfo interfaces..
Feb 28 2019, 2:47 PM · debug-info, Restricted Project
delcypher committed rGd14f1b26fb41: [CMake][LibFuzzer] Match symbol visibility setting between LibFuzzer object… (authored by delcypher).
[CMake][LibFuzzer] Match symbol visibility setting between LibFuzzer object…
Feb 28 2019, 1:57 PM
delcypher committed rL355143: [CMake][LibFuzzer] Match symbol visibility setting between LibFuzzer object….
[CMake][LibFuzzer] Match symbol visibility setting between LibFuzzer object…
Feb 28 2019, 1:57 PM
delcypher committed rCRT355143: [CMake][LibFuzzer] Match symbol visibility setting between LibFuzzer object….
[CMake][LibFuzzer] Match symbol visibility setting between LibFuzzer object…
Feb 28 2019, 1:57 PM
delcypher closed D58055: [CMake][LibFuzzer] Match symbol visibility setting between LibFuzzer object files and unit tests..
Feb 28 2019, 1:57 PM · Restricted Project, Restricted Project
delcypher added a comment to D58055: [CMake][LibFuzzer] Match symbol visibility setting between LibFuzzer object files and unit tests..
In D58055#1410888, @yln wrote:

LGTM. Compiling all linker inputs with the same visibility is the right approach.

Please check my understanding:
Before r336238 the kIgnoreRemaining constant got inlined, both into libFuzzer and the unit test.

Feb 28 2019, 9:59 AM · Restricted Project, Restricted Project
delcypher added inline comments to D58194: [DebugInfo] add SectionedAddress to DebugInfo interfaces..
Feb 28 2019, 8:26 AM · debug-info, Restricted Project

Feb 26 2019

delcypher added a comment to D58055: [CMake][LibFuzzer] Match symbol visibility setting between LibFuzzer object files and unit tests..

@yln @kubamracek Ping.

Feb 26 2019, 8:14 AM · Restricted Project, Restricted Project

Feb 25 2019

delcypher added inline comments to D58578: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms..
Feb 25 2019, 10:48 AM · Restricted Project, Restricted Project

Feb 23 2019

delcypher created D58578: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms..
Feb 23 2019, 5:28 AM · Restricted Project, Restricted Project

Feb 15 2019

delcypher accepted D58209: [Sanitizer] iOS: Pull up parallelism_group handling into common.lit.config.

LGTM

Feb 15 2019, 11:19 AM · Restricted Project, Restricted Project

Feb 14 2019

delcypher added inline comments to D57535: [CMake] Use LLVM_ENABLE_PROJECTS as the "single source" of truth when used..
Feb 14 2019, 4:04 PM · Restricted Project

Feb 11 2019

delcypher created D58055: [CMake][LibFuzzer] Match symbol visibility setting between LibFuzzer object files and unit tests..
Feb 11 2019, 8:43 AM · Restricted Project, Restricted Project

Feb 7 2019

delcypher added a comment to D57535: [CMake] Use LLVM_ENABLE_PROJECTS as the "single source" of truth when used..

Could we sanitize the list of LLVM_ENABLE_PROJECTS and error for unknown entries?

Feb 7 2019, 3:50 AM · Restricted Project

Feb 6 2019

delcypher added a comment to D57279: NFC: Reduce presence of "template <typename AddressSpaceView>".

@vitalybuka Thanks for working on this.

Context for those new to the patch: We are looking at ways of converting a Allocator<LocalAddressSpaceView> into a Allocator<RemoteAddressSpaceView>. With the current design on master it is not safe to do a reinterpret_cast<>() because C++ doesn't guarantee that the two different types have the same data-layout or fields (AFAIK).

Now you can reinterpret/memcpy at base class level.

Feb 6 2019, 5:38 AM

Feb 5 2019

delcypher added a comment to D57750: [CMake] Don't add `cxx` to `LLDB_TEST_DEPS` if it doesn't exist..

Wow phabricator has made a right mess of displaying this patch. It's easier to look at as.

Feb 5 2019, 6:37 AM · Restricted Project