Page MenuHomePhabricator

delcypher (Dan Liew)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 21 2015, 4:29 PM (204 w, 2 d)

Recent Activity

Thu, Jul 18

delcypher added a comment to D59150: [CMake] Separate the detection Darwin platforms architectures for the built-ins from the rest of compiler-rt..

Ping.

Thu, Jul 18, 6:20 PM · Restricted Project, Restricted Project
delcypher added a comment to D64251: Don't depend on psutil on AIX.

@daltenty Other than the minor nit, LGTM.

Thu, Jul 18, 3:38 PM · Restricted Project, Restricted Project, Restricted Project
delcypher added inline comments to D64773: [ASan] Support `{f}puts(NULL)` on Darwin.
Thu, Jul 18, 12:55 PM · Restricted Project, Restricted Project

Wed, Jul 17

delcypher added a comment to D63674: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms. Attempt #3..

@thakis @hans Ping.

Wed, Jul 17, 10:28 AM · Restricted Project, Restricted Project

Thu, Jul 11

delcypher added inline comments to D64251: Don't depend on psutil on AIX.
Thu, Jul 11, 9:21 PM · Restricted Project, Restricted Project, Restricted Project
delcypher added a reviewer for D64251: Don't depend on psutil on AIX: delcypher.
Thu, Jul 11, 9:07 PM · Restricted Project, Restricted Project, Restricted Project

Tue, Jul 9

delcypher added inline comments to D64251: Don't depend on psutil on AIX.
Tue, Jul 9, 4:27 PM · Restricted Project, Restricted Project, Restricted Project

Fri, Jul 5

delcypher added a comment to D64240: [LIT] emit timeout error message only if timeout was reached.

@AlexeySachkov LGTM provided the lit tests continue to pass.

Fri, Jul 5, 3:55 PM · Restricted Project
delcypher added inline comments to D64251: Don't depend on psutil on AIX.
Fri, Jul 5, 1:47 PM · Restricted Project, Restricted Project, Restricted Project
delcypher added a comment to D64251: Don't depend on psutil on AIX.

@daltenty The "This removes our dependency on psutil." text sounds broader than it actually is. Looking at the implementation the removal of the dependency is only for AIX. All other platforms still depends on the psutil module. I think the commit message should be made clearer on this point.

Fri, Jul 5, 1:34 PM · Restricted Project, Restricted Project, Restricted Project

Thu, Jun 27

delcypher added a comment to D63674: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms. Attempt #3..

@thakis @hans

(FWIW our bots all do clobber builds, so this can't be it.)

Thu, Jun 27, 2:28 PM · Restricted Project, Restricted Project

Tue, Jun 25

delcypher added inline comments to D63797: Add USan+ASan and UBSan+TSan tests to shadow-memory lit parallelism group..
Tue, Jun 25, 5:56 PM · Restricted Project, Restricted Project
delcypher committed rGd38e251bf2f9: Follow up fix for r364366. (authored by delcypher).
Follow up fix for r364366.
Tue, Jun 25, 5:55 PM
delcypher committed rL364369: Follow up fix for r364366..
Follow up fix for r364366.
Tue, Jun 25, 5:54 PM
delcypher added inline comments to D63797: Add USan+ASan and UBSan+TSan tests to shadow-memory lit parallelism group..
Tue, Jun 25, 5:49 PM · Restricted Project, Restricted Project
delcypher committed rG5242fbde5a26: Add USan+ASan and UBSan+TSan tests to shadow-memory lit parallelism group. (authored by delcypher).
Add USan+ASan and UBSan+TSan tests to shadow-memory lit parallelism group.
Tue, Jun 25, 5:37 PM
delcypher committed rL364366: Add USan+ASan and UBSan+TSan tests to shadow-memory lit parallelism group..
Add USan+ASan and UBSan+TSan tests to shadow-memory lit parallelism group.
Tue, Jun 25, 5:36 PM
delcypher closed D63797: Add USan+ASan and UBSan+TSan tests to shadow-memory lit parallelism group..
Tue, Jun 25, 5:35 PM · Restricted Project, Restricted Project
delcypher created D63797: Add USan+ASan and UBSan+TSan tests to shadow-memory lit parallelism group..
Tue, Jun 25, 4:44 PM · Restricted Project, Restricted Project

Mon, Jun 24

delcypher accepted D57786: [sanitizer] Enabled getpw_getgr.cc on iOS.
Mon, Jun 24, 4:54 PM · Restricted Project, Restricted Project
delcypher added a comment to D57786: [sanitizer] Enabled getpw_getgr.cc on iOS.

@vitalybuka Sorry. I didn't see this before.

Mon, Jun 24, 4:49 PM · Restricted Project, Restricted Project
delcypher added a comment to D63674: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms. Attempt #3..

@hans

@hans @thakis Could one of you check that this patch doesn't break your build?

We don't get a CMake error anymore,

Mon, Jun 24, 3:21 PM · Restricted Project, Restricted Project

Jun 21 2019

delcypher added a comment to D63674: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms. Attempt #3..

@hans @thakis Could one of you check that this patch doesn't break your build?

Jun 21 2019, 5:02 PM · Restricted Project, Restricted Project
delcypher added a comment to D61242: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms. Attempt #2..

@hans @thakis A new version of the patch is available for review at https://reviews.llvm.org/D63674

Jun 21 2019, 2:56 PM · Restricted Project, Restricted Project
delcypher created D63674: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms. Attempt #3..
Jun 21 2019, 2:55 PM · Restricted Project, Restricted Project
delcypher accepted D63586: [ASan] Use dynamic shadow on 32-bit iOS and simulators.

LGTM.

Jun 21 2019, 1:40 PM · Restricted Project, Restricted Project
delcypher added a comment to D61242: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms. Attempt #2..

@hans @thakis Commenting out find_darwin_sdk_dir(DARWIN_iossim_SYSROOT iphonesimulator) was enough for me to reproduce the issue. There's a bug in some existing CMake code I wrote. The code for UBSan test code assumes that if COMPILER_RT_ENABLE_IOS is true that the toolchain can build for iOS and the iOS simulator. This isn't true if one or more of the SDKs are missing. I've written a fix for this and I'll submit a patch for review soon.

Jun 21 2019, 12:48 PM · Restricted Project, Restricted Project
delcypher added a comment to D61242: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms. Attempt #2..

But somehow it was still able to produce an i386 version of libclang_rt.asan_iossim_dynamic.dylib before your change.

Jun 21 2019, 10:45 AM · Restricted Project, Restricted Project

Jun 20 2019

delcypher added a comment to D61242: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms. Attempt #2..

@juliehockett Sorry I completely dropped the ball here and forgot to land this. I've rebased and committed the change. @thakis I noticed I had a merge conflict with your change. Hopefully this hasn't broken anything for you.

I don't have context here, but this change caused Chromium's clang package to stop building, failing with:

[...]
CMake Error at /work/llvm.monorepo/compiler-rt/cmake/config-ix.cmake:179 (message):

Unsupported architecture: i386

Call Stack (most recent call first):

/work/llvm.monorepo/compiler-rt/cmake/config-ix.cmake:218 (get_target_flags_for_arch)
/work/llvm.monorepo/compiler-rt/test/ubsan/CMakeLists.txt:116 (get_test_cflags_for_apple_platform)

See https://bugs.chromium.org/p/chromium/issues/detail?id=976593#c3 for the full cmake invocation and output.

I've reverted this in r363779 until it's more clear what's happening.

Jun 20 2019, 7:14 PM · Restricted Project, Restricted Project

Jun 17 2019

delcypher committed rG9216358c2117: Disable recently added Darwin symbolization tests for iOS. (authored by delcypher).
Disable recently added Darwin symbolization tests for iOS.
Jun 17 2019, 6:38 PM
delcypher committed rG745632c63a5e: [NFC] Split `Darwin/asan-symbolize-partial-report-with-module-map.cc`. (authored by delcypher).
[NFC] Split `Darwin/asan-symbolize-partial-report-with-module-map.cc`.
Jun 17 2019, 6:38 PM
delcypher committed rL363641: Disable recently added Darwin symbolization tests for iOS..
Disable recently added Darwin symbolization tests for iOS.
Jun 17 2019, 6:35 PM
delcypher committed rL363640: [NFC] Split `Darwin/asan-symbolize-partial-report-with-module-map.cc`..
[NFC] Split `Darwin/asan-symbolize-partial-report-with-module-map.cc`.
Jun 17 2019, 6:35 PM
delcypher committed rG3c9f66dccf25: [asan_symbolize] Teach `asan_symbolize.py` to symbolicate partially… (authored by delcypher).
[asan_symbolize] Teach `asan_symbolize.py` to symbolicate partially…
Jun 17 2019, 6:21 PM
delcypher committed rL363639: [asan_symbolize] Teach `asan_symbolize.py` to symbolicate partially….
[asan_symbolize] Teach `asan_symbolize.py` to symbolicate partially…
Jun 17 2019, 6:20 PM
delcypher closed D60533: [asan_symbolize] Teach `asan_symbolize.py` to symbolicate partially symbolicated ASan reports..
Jun 17 2019, 6:20 PM · Restricted Project, Restricted Project
delcypher added a comment to D60533: [asan_symbolize] Teach `asan_symbolize.py` to symbolicate partially symbolicated ASan reports..

@vitalybuka Sorry I forgot about this. I tried to make the test to work in a POSIX use case and I can't make it work. The problem is that when I use %M with stack_trace_format the module name gets stripped (i.e. an absolute path to the binary just becomes the file name of the binary) due to the call to StripModuleName(). This results in us not being able to symbolicate the report from the python script because we don't have the absolute path to the binaries we need to access to perform symbolication.

Jun 17 2019, 6:06 PM · Restricted Project, Restricted Project
delcypher updated subscribers of D61242: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms. Attempt #2..

@juliehockett Sorry I completely dropped the ball here and forgot to land this. I've rebased and committed the change. @thakis I noticed I had a merge conflict with your change. Hopefully this hasn't broken anything for you.

Jun 17 2019, 4:35 PM · Restricted Project, Restricted Project
delcypher committed rG964909e4a6f5: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms. (authored by delcypher).
[CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms.
Jun 17 2019, 4:35 PM
delcypher committed rL363633: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms..
[CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms.
Jun 17 2019, 4:35 PM
delcypher closed D61242: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms. Attempt #2..
Jun 17 2019, 4:35 PM · Restricted Project, Restricted Project
delcypher updated the diff for D61242: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms. Attempt #2..

Rebase.

Jun 17 2019, 4:35 PM · Restricted Project, Restricted Project

Jun 11 2019

delcypher accepted D63096: [Sanitizers] Add case MACOS_VERSION_CATALINA.
Jun 11 2019, 2:44 PM · Restricted Project, Restricted Project
delcypher added a comment to D63096: [Sanitizers] Add case MACOS_VERSION_CATALINA.

LGTM

Jun 11 2019, 2:44 PM · Restricted Project, Restricted Project
delcypher added inline comments to D63102: Fix some lit test ResourceWarnings on Windows.
Jun 11 2019, 10:25 AM · Restricted Project

Apr 28 2019

delcypher added a comment to D61242: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms. Attempt #2..

@juliehockett @phosek This is a new version of https://reviews.llvm.org/D58578 . Would you be able to test it in your set up? I'd prefer to have the confidence of knowing it doesn't break your set up before landing this.

Apr 28 2019, 9:32 AM · Restricted Project, Restricted Project
delcypher created D61242: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms. Attempt #2..
Apr 28 2019, 9:31 AM · Restricted Project, Restricted Project
delcypher committed rCRT359394: [CMake] Don't modify `FUZZER_SUPPORTED_ARCH` is place..
[CMake] Don't modify `FUZZER_SUPPORTED_ARCH` is place.
Apr 28 2019, 2:45 AM
delcypher committed rG8651edf89854: [CMake] Don't modify `FUZZER_SUPPORTED_ARCH` is place. (authored by delcypher).
[CMake] Don't modify `FUZZER_SUPPORTED_ARCH` is place.
Apr 28 2019, 2:44 AM
delcypher committed rL359394: [CMake] Don't modify `FUZZER_SUPPORTED_ARCH` is place..
[CMake] Don't modify `FUZZER_SUPPORTED_ARCH` is place.
Apr 28 2019, 2:44 AM

Apr 27 2019

delcypher added a comment to D58578: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms..

Sure -- to clarify, it's not a test failure, it's a build one. The error was triggered during the CMake configuration step for host runtimes, where we have OSX supported arches: x86_64 only. test/tsan/CMakeLists.txt:78 now calls into the new function on the arm64 case, which down the line triggers a CMake assert that arm64 is in the list of supported arches when it isn't.

Seems like prior to this change, the lit tests were being configured without doing any checks on that list of supported arches. I'm not as familiar with how this code is set up, so I can't really say if it's a problem with this patch or if this patch is exposing another bug. Thanks for taking a look!

Apr 27 2019, 4:16 AM · Restricted Project, Restricted Project
delcypher added a comment to D58578: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms..

To clarify, this is failing when building runtimes for Darwin so shouldn't be Fuchsia specific, but it could be affected by some of the Clang defaults we set in our CMake build. We use lld as the default linker for Fuchsia but not for Darwin where use the system linker.

Apr 27 2019, 4:06 AM · Restricted Project, Restricted Project

Apr 26 2019

delcypher added a comment to D58578: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms..

Sorry about this. I'll revert the patch now and I'll take a look at re-landing it when time permits.

Apr 26 2019, 11:01 AM · Restricted Project, Restricted Project
delcypher committed rG18bc87240545: Revert "[CMake] Fix the value of `config.target_cflags` for non-macOS Apple" (authored by delcypher).
Revert "[CMake] Fix the value of `config.target_cflags` for non-macOS Apple"
Apr 26 2019, 10:53 AM
delcypher committed rCRT359327: Revert "[CMake] Fix the value of `config.target_cflags` for non-macOS Apple".
Revert "[CMake] Fix the value of `config.target_cflags` for non-macOS Apple"
Apr 26 2019, 10:52 AM
delcypher committed rL359327: Revert "[CMake] Fix the value of `config.target_cflags` for non-macOS Apple".
Revert "[CMake] Fix the value of `config.target_cflags` for non-macOS Apple"
Apr 26 2019, 10:52 AM
delcypher added a comment to D58578: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms..

This patch has broken our bots -- when it's building the osx host runtime, it's now triggering an assert on the tsan arm64 test case that wasn't being triggered before. Would you be able to take a look?

Error:

CMake Error at /b/s/w/ir/k/llvm-project/compiler-rt/cmake/config-ix.cmake:177 (message):
  Unsupported architecture: arm64
Call Stack (most recent call first):
  /b/s/w/ir/k/llvm-project/compiler-rt/cmake/config-ix.cmake:216 (get_target_flags_for_arch)
  /b/s/w/ir/k/llvm-project/compiler-rt/test/tsan/CMakeLists.txt:78 (get_test_cflags_for_apple_platform)

Full log: https://logs.chromium.org/logs/fuchsia/buildbucket/cr-buildbucket.appspot.com/8915104112618242800/+/steps/clang/0/steps/build/0/stdout

Apr 26 2019, 10:45 AM · Restricted Project, Restricted Project
delcypher added a comment to D60533: [asan_symbolize] Teach `asan_symbolize.py` to symbolicate partially symbolicated ASan reports..

Can you make the tests Posix?

Apr 26 2019, 10:01 AM · Restricted Project, Restricted Project
delcypher committed rG60f5df948b0d: [asan_symbolize] Teach `asan_symbolize.py` to symbolicate using a module map (authored by delcypher).
[asan_symbolize] Teach `asan_symbolize.py` to symbolicate using a module map
Apr 26 2019, 9:53 AM
delcypher committed rCRT359322: [asan_symbolize] Teach `asan_symbolize.py` to symbolicate using a module map.
[asan_symbolize] Teach `asan_symbolize.py` to symbolicate using a module map
Apr 26 2019, 9:53 AM
delcypher committed rL359322: [asan_symbolize] Teach `asan_symbolize.py` to symbolicate using a module map.
[asan_symbolize] Teach `asan_symbolize.py` to symbolicate using a module map
Apr 26 2019, 9:52 AM
delcypher closed D60531: [asan_symbolize] Teach `asan_symbolize.py` to symbolicate using a module map.
Apr 26 2019, 9:52 AM · Restricted Project, Restricted Project
delcypher added a comment to D60531: [asan_symbolize] Teach `asan_symbolize.py` to symbolicate using a module map.

Thanks for explanation

Apr 26 2019, 9:52 AM · Restricted Project, Restricted Project
delcypher added a comment to D58578: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms..
In D58578#1475863, @yln wrote:

Overall changes: LGTM, thanks!

As already noted, I would probably change the is_valid_apple_platform to:
is_apple_platform -> just yes/no, even for the empty string.
or rename to assert_valid_apple_platform() -> no return value, aborts if not.

An is_xxx "getter" having 3 kinds of "results": true, false, or abort; is unexpected to me.

Apr 26 2019, 6:31 AM · Restricted Project, Restricted Project
delcypher committed rG9f59704a5d60: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms. (authored by delcypher).
[CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms.
Apr 26 2019, 6:24 AM
delcypher committed rL359305: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple.
[CMake] Fix the value of `config.target_cflags` for non-macOS Apple
Apr 26 2019, 6:21 AM
delcypher committed rCRT359305: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple.
[CMake] Fix the value of `config.target_cflags` for non-macOS Apple
Apr 26 2019, 6:20 AM
delcypher closed D58578: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms..
Apr 26 2019, 6:20 AM · Restricted Project, Restricted Project
delcypher updated the diff for D58578: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms..

No real update, just for fixing up commit message on my local machine.

Apr 26 2019, 3:18 AM · Restricted Project, Restricted Project

Apr 24 2019

delcypher added a comment to D60531: [asan_symbolize] Teach `asan_symbolize.py` to symbolicate using a module map.

Is there a reason to tests this on Darwin only?

Apr 24 2019, 12:04 PM · Restricted Project, Restricted Project

Apr 23 2019

delcypher updated the summary of D58578: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms..
Apr 23 2019, 3:41 AM · Restricted Project, Restricted Project
delcypher added a comment to D58578: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms..

@kubamracek @yln ping.

Apr 23 2019, 2:54 AM · Restricted Project, Restricted Project

Apr 18 2019

delcypher added a comment to D60529: [asan_symbolize] Add a simple plugin architecture.

Looks like the build broke some bots (http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-android/builds/21212). It seems the code doesn't work properly in some really old versions of Python 2. I've managed to reproduce the issue using Python 2.7.6 and I've landed a fix https://reviews.llvm.org/rL358682

Apr 18 2019, 9:26 AM · Restricted Project, Restricted Project
delcypher committed rG16c3883b9837: [asan_symbolize] Workaround bug in old Python 2 versions. (authored by delcypher).
[asan_symbolize] Workaround bug in old Python 2 versions.
Apr 18 2019, 9:21 AM
delcypher committed rL358682: [asan_symbolize] Workaround bug in old Python 2 versions..
[asan_symbolize] Workaround bug in old Python 2 versions.
Apr 18 2019, 9:21 AM
delcypher committed rCRT358682: [asan_symbolize] Workaround bug in old Python 2 versions..
[asan_symbolize] Workaround bug in old Python 2 versions.
Apr 18 2019, 9:21 AM
delcypher committed rCRT358657: [asan_symbolize] Add a simple plugin architecture.
[asan_symbolize] Add a simple plugin architecture
Apr 18 2019, 4:34 AM
delcypher committed rG403d3187a79b: [asan_symbolize] Add a simple plugin architecture (authored by delcypher).
[asan_symbolize] Add a simple plugin architecture
Apr 18 2019, 4:34 AM
delcypher committed rL358657: [asan_symbolize] Add a simple plugin architecture.
[asan_symbolize] Add a simple plugin architecture
Apr 18 2019, 4:33 AM
delcypher closed D60529: [asan_symbolize] Add a simple plugin architecture.
Apr 18 2019, 4:33 AM · Restricted Project, Restricted Project

Apr 17 2019

delcypher added inline comments to D60529: [asan_symbolize] Add a simple plugin architecture.
Apr 17 2019, 1:26 AM · Restricted Project, Restricted Project

Apr 16 2019

delcypher added inline comments to D60529: [asan_symbolize] Add a simple plugin architecture.
Apr 16 2019, 4:06 PM · Restricted Project, Restricted Project

Apr 11 2019

delcypher added a comment to D60533: [asan_symbolize] Teach `asan_symbolize.py` to symbolicate partially symbolicated ASan reports..

LGTM

Apr 11 2019, 3:15 PM · Restricted Project, Restricted Project

Apr 10 2019

delcypher updated the diff for D60533: [asan_symbolize] Teach `asan_symbolize.py` to symbolicate partially symbolicated ASan reports..
  • Use cstdlib include instead of stdlib.h
  • Remove unused assert.h include
Apr 10 2019, 4:22 PM · Restricted Project, Restricted Project
delcypher updated the diff for D60531: [asan_symbolize] Teach `asan_symbolize.py` to symbolicate using a module map.
  • Use cstdlib header rather than stdlib.h
  • Drop unused assert.h
Apr 10 2019, 2:29 PM · Restricted Project, Restricted Project
delcypher updated the diff for D60529: [asan_symbolize] Add a simple plugin architecture.

Use cstdlib rather than stdlib.h

Apr 10 2019, 2:26 PM · Restricted Project, Restricted Project
delcypher added a parent revision for D60533: [asan_symbolize] Teach `asan_symbolize.py` to symbolicate partially symbolicated ASan reports.: D60531: [asan_symbolize] Teach `asan_symbolize.py` to symbolicate using a module map.
Apr 10 2019, 12:29 PM · Restricted Project, Restricted Project
delcypher added a child revision for D60531: [asan_symbolize] Teach `asan_symbolize.py` to symbolicate using a module map: D60533: [asan_symbolize] Teach `asan_symbolize.py` to symbolicate partially symbolicated ASan reports..
Apr 10 2019, 12:29 PM · Restricted Project, Restricted Project
delcypher added a child revision for D60529: [asan_symbolize] Add a simple plugin architecture: D60531: [asan_symbolize] Teach `asan_symbolize.py` to symbolicate using a module map.
Apr 10 2019, 12:29 PM · Restricted Project, Restricted Project
delcypher added a parent revision for D60531: [asan_symbolize] Teach `asan_symbolize.py` to symbolicate using a module map: D60529: [asan_symbolize] Add a simple plugin architecture.
Apr 10 2019, 12:29 PM · Restricted Project, Restricted Project
delcypher created D60533: [asan_symbolize] Teach `asan_symbolize.py` to symbolicate partially symbolicated ASan reports..
Apr 10 2019, 12:28 PM · Restricted Project, Restricted Project
delcypher created D60531: [asan_symbolize] Teach `asan_symbolize.py` to symbolicate using a module map.
Apr 10 2019, 12:28 PM · Restricted Project, Restricted Project
delcypher created D60529: [asan_symbolize] Add a simple plugin architecture.
Apr 10 2019, 12:23 PM · Restricted Project, Restricted Project

Apr 9 2019

delcypher committed rG2316429d04c1: [asan_symbolize] Move argument parser epilog text into script doc comment. (authored by delcypher).
[asan_symbolize] Move argument parser epilog text into script doc comment.
Apr 9 2019, 1:30 AM
delcypher committed rCRT357978: [asan_symbolize] Move argument parser epilog text into script doc comment..
[asan_symbolize] Move argument parser epilog text into script doc comment.
Apr 9 2019, 1:29 AM
delcypher committed rL357978: [asan_symbolize] Move argument parser epilog text into script doc comment..
[asan_symbolize] Move argument parser epilog text into script doc comment.
Apr 9 2019, 1:29 AM
delcypher closed D60398: [asan_symbolize] Move argument parser epilog text into script doc comment..
Apr 9 2019, 1:29 AM · Restricted Project, Restricted Project

Apr 8 2019

delcypher committed rG836da99af9cb: [asan_symbolize] Use proper logging infrastructure. (authored by delcypher).
[asan_symbolize] Use proper logging infrastructure.
Apr 8 2019, 3:29 PM
delcypher committed rCRT357951: [asan_symbolize] Use proper logging infrastructure..
[asan_symbolize] Use proper logging infrastructure.
Apr 8 2019, 3:28 PM
delcypher committed rL357951: [asan_symbolize] Use proper logging infrastructure..
[asan_symbolize] Use proper logging infrastructure.
Apr 8 2019, 3:28 PM