Page MenuHomePhabricator

delcypher (Dan Liew)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 21 2015, 4:29 PM (241 w, 4 d)

Recent Activity

Today

delcypher added inline comments to D77623: [Darwin] Fix a bug where the symbolizer would examine the wrong process..
Tue, Apr 7, 12:31 PM · Restricted Project

Yesterday

delcypher added a parent revision for D77623: [Darwin] Fix a bug where the symbolizer would examine the wrong process.: D77622: [Sanitizer Common] Show command used to launch symbolizer process at high verbosity level..
Mon, Apr 6, 7:38 PM · Restricted Project
delcypher added a child revision for D77622: [Sanitizer Common] Show command used to launch symbolizer process at high verbosity level.: D77623: [Darwin] Fix a bug where the symbolizer would examine the wrong process..
Mon, Apr 6, 7:38 PM · Restricted Project
delcypher created D77622: [Sanitizer Common] Show command used to launch symbolizer process at high verbosity level..
Mon, Apr 6, 7:38 PM · Restricted Project
delcypher created D77623: [Darwin] Fix a bug where the symbolizer would examine the wrong process..
Mon, Apr 6, 7:38 PM · Restricted Project
delcypher accepted D77415: [lit] Move the recursiveExpansionLimit setting to TestingConfig.

LGTM

Mon, Apr 6, 11:25 AM · Restricted Project, Restricted Project

Mon, Mar 30

delcypher accepted D77026: Add manually overriding of the darwin SDK version.

@vchuravy LGTM. Just to note an alternative to this patch would be to implement a "barebones" version of xcrun that implements enough functionality to report the SDK to CMake. I think the compromise we came to is fine for now. If this patch becomes a maintenance burden in the future then we may need to revisit this.

Mon, Mar 30, 11:56 AM · Restricted Project

Sun, Mar 29

delcypher added inline comments to D77026: Add manually overriding of the darwin SDK version.
Sun, Mar 29, 7:15 PM · Restricted Project
delcypher requested changes to D77026: Add manually overriding of the darwin SDK version.
Sun, Mar 29, 7:15 PM · Restricted Project

Fri, Mar 27

delcypher added a comment to D76829: [lit] Introduce setup and teardown routines.
In D76829#1946422, @yln wrote:

LGTM. @delcypher @rnk: what do you think?

Fri, Mar 27, 7:51 PM · Restricted Project
delcypher added inline comments to D76829: [lit] Introduce setup and teardown routines.
Fri, Mar 27, 7:51 PM · Restricted Project
delcypher committed rG853a1e6942c8: Only add `darwin_log_cmd` lit shell test feature when the log can be queried. (authored by delcypher).
Only add `darwin_log_cmd` lit shell test feature when the log can be queried.
Fri, Mar 27, 11:30 AM
delcypher closed D76899: Only add `darwin_log_cmd` lit shell test feature when the log can be queried..
Fri, Mar 27, 11:30 AM · Restricted Project
delcypher added a comment to D76899: Only add `darwin_log_cmd` lit shell test feature when the log can be queried..

@yln Thanks for the review!

Fri, Mar 27, 11:28 AM · Restricted Project

Thu, Mar 26

delcypher accepted D76178: [lit] Recursively apply substitutions.

LGTM.

Thu, Mar 26, 8:07 PM · Restricted Project
delcypher created D76899: Only add `darwin_log_cmd` lit shell test feature when the log can be queried..
Thu, Mar 26, 6:30 PM · Restricted Project
delcypher added inline comments to D76178: [lit] Recursively apply substitutions.
Thu, Mar 26, 11:25 AM · Restricted Project
delcypher added a comment to D76178: [lit] Recursively apply substitutions.

@ldionne Thanks for addressing my comments. The patch looks like its in very good shape. I have a minor nit about the documentation. Other than that LGTM.

Thu, Mar 26, 11:25 AM · Restricted Project
delcypher committed rG445b810fbd4f: [ASan] Fix issue where system log buffer was not cleared after reporting an… (authored by delcypher).
[ASan] Fix issue where system log buffer was not cleared after reporting an…
Thu, Mar 26, 11:24 AM
delcypher closed D76749: [ASan] Fix issue where system log buffer was not cleared after reporting an issue..
Thu, Mar 26, 11:23 AM · Restricted Project

Wed, Mar 25

delcypher updated the diff for D76749: [ASan] Fix issue where system log buffer was not cleared after reporting an issue..

Clear error_message_buffer unconditionally.

Wed, Mar 25, 9:07 PM · Restricted Project
delcypher added inline comments to D76749: [ASan] Fix issue where system log buffer was not cleared after reporting an issue..
Wed, Mar 25, 9:07 PM · Restricted Project
delcypher added inline comments to D76178: [lit] Recursively apply substitutions.
Wed, Mar 25, 6:58 PM · Restricted Project
delcypher added a comment to D76749: [ASan] Fix issue where system log buffer was not cleared after reporting an issue..

@vitalybuka Thanks for the initial review. I've tried to address your comments. Please let me know if there's anything else you'd like to change.

Wed, Mar 25, 4:16 PM · Restricted Project
delcypher updated the diff for D76749: [ASan] Fix issue where system log buffer was not cleared after reporting an issue..

Address review feedback

Wed, Mar 25, 4:16 PM · Restricted Project
delcypher added inline comments to D76749: [ASan] Fix issue where system log buffer was not cleared after reporting an issue..
Wed, Mar 25, 3:44 PM · Restricted Project

Tue, Mar 24

delcypher created D76749: [ASan] Fix issue where system log buffer was not cleared after reporting an issue..
Tue, Mar 24, 7:52 PM · Restricted Project
delcypher committed rGb684c1a50f70: Add a `Symbolizer::GetEnvP()` method that allows symbolizer implementations to… (authored by delcypher).
Add a `Symbolizer::GetEnvP()` method that allows symbolizer implementations to…
Tue, Mar 24, 4:38 PM
delcypher closed D76666: Add a `Symbolizer::GetEnvP()` method that allows symbolizer implementations to customise the environment of the symbolizer binary..
Tue, Mar 24, 4:37 PM · Restricted Project
delcypher added a comment to D76666: Add a `Symbolizer::GetEnvP()` method that allows symbolizer implementations to customise the environment of the symbolizer binary..

@vitalybuka Thanks for the review. I just discovered that GetEnvP() needs to be protected rather than private so it can be called by subclass implementations so I've updated this patch to do that. If you're happy with this could you approve again?

Tue, Mar 24, 12:53 PM · Restricted Project
delcypher updated the diff for D76666: Add a `Symbolizer::GetEnvP()` method that allows symbolizer implementations to customise the environment of the symbolizer binary..

Make GetEnvP() protected rather private so sub-class implementation can call the parent function.

Tue, Mar 24, 12:21 PM · Restricted Project
delcypher accepted D76290: [lit] Allow passing extra commands to executeShTest.
Tue, Mar 24, 12:21 PM · Restricted Project
delcypher updated the summary of D76666: Add a `Symbolizer::GetEnvP()` method that allows symbolizer implementations to customise the environment of the symbolizer binary..
Tue, Mar 24, 11:16 AM · Restricted Project

Mon, Mar 23

delcypher created D76666: Add a `Symbolizer::GetEnvP()` method that allows symbolizer implementations to customise the environment of the symbolizer binary..
Mon, Mar 23, 9:13 PM · Restricted Project

Fri, Mar 20

delcypher added inline comments to D76290: [lit] Allow passing extra commands to executeShTest.
Fri, Mar 20, 5:55 PM · Restricted Project

Thu, Mar 19

delcypher requested changes to D76290: [lit] Allow passing extra commands to executeShTest.
Thu, Mar 19, 11:59 AM · Restricted Project
delcypher added inline comments to D76290: [lit] Allow passing extra commands to executeShTest.
Thu, Mar 19, 11:59 AM · Restricted Project
delcypher added a comment to D76178: [lit] Recursively apply substitutions.
  • The feature isn't documented.

Where can I document it? I'm happy to do that.

Thu, Mar 19, 11:27 AM · Restricted Project

Tue, Mar 17

delcypher added a comment to D76178: [lit] Recursively apply substitutions.

While I can see the appeal of this I need convincing that this actually needed. I see too many downsides

  • Possibility of non-termination being introduced that we'll have to check for which is a cost that will have to be paid every time we execute a test.

I agree we should check for this, however it's not clear to me this is going to make a noticeable perf difference in practice. The tests we run involve executing processes and doing things that are a lot more expensive than the simple lit substitution, even if we check for non-terminating substitutions. I think it should be possible to make it fairly quick in the usual case where full substitution happens after exactly one substitution.

Tue, Mar 17, 7:27 PM · Restricted Project

Sat, Mar 14

delcypher added a comment to D76178: [lit] Recursively apply substitutions.

While I can see the appeal of this I need convincing that this actually needed. I see too many downsides

Sat, Mar 14, 11:15 AM · Restricted Project
delcypher requested changes to D76178: [lit] Recursively apply substitutions.
Sat, Mar 14, 11:15 AM · Restricted Project
delcypher added reviewers for D76178: [lit] Recursively apply substitutions: jdenny, yln.
Sat, Mar 14, 10:43 AM · Restricted Project

Mar 5 2020

delcypher accepted D72875: [clang][cmake] Include generated rst files in html built by docs-clang-html target.

LGTM. Thanks for addressing all the issues I raised.

Mar 5 2020, 4:26 PM · Restricted Project, Restricted Project

Feb 26 2020

delcypher accepted D74501: [TSan] Add CMake check for minimal SDK requirements on Darwin.

LGTM.

Feb 26 2020, 10:54 AM · Restricted Project, Restricted Project

Feb 23 2020

delcypher requested changes to D73980: [lit] add multi-cfgd test suite discovery.

@ychen I need convincing that this feature is actually needed. Today the problem of multiple configurations is solved at the CMake level in compiler-rt where we have CMake generate multiple config directories that point to the same source tree. Each config is generated differently depending on the use case. Why isn't that sufficient for the problem you are trying to solve.

Feb 23 2020, 6:48 PM · Restricted Project
delcypher accepted D73577: [compiler-rt] Build all alias in builtin as private external on Darwin.

Seems okay but I think you should check with @kledzik before landing.

Feb 23 2020, 5:54 PM · Restricted Project, Restricted Project

Feb 19 2020

delcypher committed rG562c6b801922: Add a `%darwin_min_target_with_tls_support` lit substitution. (authored by delcypher).
Add a `%darwin_min_target_with_tls_support` lit substitution.
Feb 19 2020, 3:45 PM
delcypher closed D74802: Add a `%darwin_min_target_with_tls_support` lit substitution..
Feb 19 2020, 3:45 PM · Restricted Project, Restricted Project
delcypher committed rGddd2257f48a8: [TSan] Fix incorrect expansion of `%deflake` lit substitution. (authored by delcypher).
[TSan] Fix incorrect expansion of `%deflake` lit substitution.
Feb 19 2020, 1:30 PM
delcypher added inline comments to D73707: [TSAN] Parameterize the hard-coded threshold of deflake in tsan test.
Feb 19 2020, 1:29 PM · Restricted Project, Restricted Project
delcypher added inline comments to D73707: [TSAN] Parameterize the hard-coded threshold of deflake in tsan test.
Feb 19 2020, 11:46 AM · Restricted Project, Restricted Project
delcypher accepted D74826: [compiler-rt] [builtins] Fix logb / logbl tests.

LGTM.

Feb 19 2020, 9:03 AM · Restricted Project, Restricted Project

Feb 18 2020

delcypher created D74802: Add a `%darwin_min_target_with_tls_support` lit substitution..
Feb 18 2020, 3:53 PM · Restricted Project, Restricted Project

Feb 17 2020

delcypher requested changes to D74501: [TSan] Add CMake check for minimal SDK requirements on Darwin.
Feb 17 2020, 6:48 PM · Restricted Project, Restricted Project

Feb 14 2020

delcypher committed rGf4141367d00d: [compiler-rt] Make various Apple lit substitutions work correctly for other… (authored by delcypher).
[compiler-rt] Make various Apple lit substitutions work correctly for other…
Feb 14 2020, 2:02 PM
delcypher committed rGa7018e8a2edf: [compiler-rt] Disable building LibFuzzer for WatchOS and the corresponding… (authored by delcypher).
[compiler-rt] Disable building LibFuzzer for WatchOS and the corresponding…
Feb 14 2020, 2:02 PM
delcypher committed rGf5951bdc3a26: [compiler-rt] Provide a lit config variable that defines the minimum deployment… (authored by delcypher).
[compiler-rt] Provide a lit config variable that defines the minimum deployment…
Feb 14 2020, 2:02 PM
delcypher committed rG8337fb00e603: [compiler-rt] Add `DARWIN_osx_MIN_VER_FLAG` variable to match the other Apple… (authored by delcypher).
[compiler-rt] Add `DARWIN_osx_MIN_VER_FLAG` variable to match the other Apple…
Feb 14 2020, 2:02 PM
delcypher committed rG86dceb9bcd9f: [compiler-rt] Use the correct minimum version flag for simulators on Apple… (authored by delcypher).
[compiler-rt] Use the correct minimum version flag for simulators on Apple…
Feb 14 2020, 2:02 PM

Feb 11 2020

delcypher requested changes to D72875: [clang][cmake] Include generated rst files in html built by docs-clang-html target.
Feb 11 2020, 1:18 PM · Restricted Project, Restricted Project

Feb 4 2020

delcypher added a comment to D71491: [ubsan] Check implicit casts in ObjC for-in statements.

@vsk The compiler-rt side seems fine to me but I'm not very familiar with the Clang side of things. @arphaman @jfb @rjmccall any thoughts?

Feb 4 2020, 12:33 PM · Restricted Project

Jan 31 2020

delcypher added a comment to D73577: [compiler-rt] Build all alias in builtin as private external on Darwin.

@steven_wu Thanks for fixing the text.

Jan 31 2020, 11:03 AM · Restricted Project, Restricted Project

Jan 28 2020

delcypher added a comment to D73577: [compiler-rt] Build all alias in builtin as private external on Darwin.

@steven_wu Please fix the description and commit message to address my questions. I don't think the original is clear enough.

Jan 28 2020, 3:02 PM · Restricted Project, Restricted Project
delcypher added a comment to D73577: [compiler-rt] Build all alias in builtin as private external on Darwin.

@steven_wu I'm having difficultly understanding the description.

Jan 28 2020, 1:45 PM · Restricted Project, Restricted Project

Jan 24 2020

delcypher added a comment to D70759: [llvm-symbolizer] Support debug file lookup using build ID.
In D70759#1839133, @vsk wrote:

Hey @phosek, @delcypher and I noticed that a Swift+ASan test is failing due to llvm-symbolizer crashing like this:

Jan 24 2020, 9:46 AM · Restricted Project

Jan 23 2020

delcypher committed rG9d9b470e69ac: [CMake] Refactor iOS simulator/device test configuration generation code for… (authored by delcypher).
[CMake] Refactor iOS simulator/device test configuration generation code for…
Jan 23 2020, 12:48 PM
delcypher committed rG06569361d018: [CMake][NFC] Refactor iOS simulator/device test configuration generation code… (authored by delcypher).
[CMake][NFC] Refactor iOS simulator/device test configuration generation code…
Jan 23 2020, 12:48 PM
delcypher closed D73243: [CMake] Refactor iOS simulator/device test configuration generation code for LibFuzzer..
Jan 23 2020, 12:47 PM · Restricted Project, Restricted Project
delcypher committed rG12627450609c: [CMake][NFC] Refactor iOS simulator/device test configuration generation code… (authored by delcypher).
[CMake][NFC] Refactor iOS simulator/device test configuration generation code…
Jan 23 2020, 12:47 PM
delcypher closed D73238: [CMake][NFC] Refactor iOS simulator/device test configuration generation code for TSan..
Jan 23 2020, 12:46 PM · Restricted Project, Restricted Project
delcypher closed D73232: [CMake][NFC] Refactor iOS simulator/device test configuration generation code for ASan..
Jan 23 2020, 12:46 PM · Restricted Project, Restricted Project
delcypher updated the summary of D73243: [CMake] Refactor iOS simulator/device test configuration generation code for LibFuzzer..
Jan 23 2020, 8:43 AM · Restricted Project, Restricted Project
delcypher updated the diff for D73243: [CMake] Refactor iOS simulator/device test configuration generation code for LibFuzzer..

Explicitly define LIBFUZZER_TEST_COMPILER

Jan 23 2020, 8:37 AM · Restricted Project, Restricted Project

Jan 22 2020

delcypher updated the diff for D73238: [CMake][NFC] Refactor iOS simulator/device test configuration generation code for TSan..
  • Delete FIXME
  • space tweak
Jan 22 2020, 4:46 PM · Restricted Project, Restricted Project
delcypher added a parent revision for D73243: [CMake] Refactor iOS simulator/device test configuration generation code for LibFuzzer.: D73238: [CMake][NFC] Refactor iOS simulator/device test configuration generation code for TSan..
Jan 22 2020, 4:46 PM · Restricted Project, Restricted Project
delcypher added a child revision for D73232: [CMake][NFC] Refactor iOS simulator/device test configuration generation code for ASan.: D73238: [CMake][NFC] Refactor iOS simulator/device test configuration generation code for TSan..
Jan 22 2020, 4:46 PM · Restricted Project, Restricted Project
delcypher added a child revision for D73238: [CMake][NFC] Refactor iOS simulator/device test configuration generation code for TSan.: D73243: [CMake] Refactor iOS simulator/device test configuration generation code for LibFuzzer..
Jan 22 2020, 4:46 PM · Restricted Project, Restricted Project
delcypher added a parent revision for D73238: [CMake][NFC] Refactor iOS simulator/device test configuration generation code for TSan.: D73232: [CMake][NFC] Refactor iOS simulator/device test configuration generation code for ASan..
Jan 22 2020, 4:46 PM · Restricted Project, Restricted Project
delcypher created D73243: [CMake] Refactor iOS simulator/device test configuration generation code for LibFuzzer..
Jan 22 2020, 4:37 PM · Restricted Project, Restricted Project
delcypher created D73238: [CMake][NFC] Refactor iOS simulator/device test configuration generation code for TSan..
Jan 22 2020, 3:21 PM · Restricted Project, Restricted Project
delcypher retitled D73232: [CMake][NFC] Refactor iOS simulator/device test configuration generation code for ASan. from [CMake] Refactor iOS simulator/device test configuration generation code for ASan. to [CMake][NFC] Refactor iOS simulator/device test configuration generation code for ASan..
Jan 22 2020, 3:12 PM · Restricted Project, Restricted Project
delcypher updated the diff for D73232: [CMake][NFC] Refactor iOS simulator/device test configuration generation code for ASan..

Make change NFC by not changing directory or lit test prefix.

Jan 22 2020, 3:12 PM · Restricted Project, Restricted Project
delcypher added a comment to D73232: [CMake][NFC] Refactor iOS simulator/device test configuration generation code for ASan..

@yln @kubamracek I changed my mind. I'm going to make this a NFC. It's probably a bad idea to couple the naming change with the refactor.

Jan 22 2020, 3:02 PM · Restricted Project, Restricted Project
delcypher created D73232: [CMake][NFC] Refactor iOS simulator/device test configuration generation code for ASan..
Jan 22 2020, 2:31 PM · Restricted Project, Restricted Project

Jan 17 2020

delcypher added inline comments to D72875: [clang][cmake] Include generated rst files in html built by docs-clang-html target.
Jan 17 2020, 3:02 PM · Restricted Project, Restricted Project

Jan 10 2020

delcypher added inline comments to D72305: [TSan] The "thread_terminate" event is delivered on the terminating thread.
Jan 10 2020, 10:12 AM · Restricted Project, Restricted Project
delcypher added a comment to D72305: [TSan] The "thread_terminate" event is delivered on the terminating thread.

@yln The description of this change needs improving. The title probably ought to be "[TSan] The "thread_terminate" event is always delivered on the terminating thread" and then that should be followed with a brief justification along with a radar number (if there is one).

Jan 10 2020, 9:37 AM · Restricted Project, Restricted Project

Dec 20 2019

delcypher added inline comments to D71491: [ubsan] Check implicit casts in ObjC for-in statements.
Dec 20 2019, 2:18 PM · Restricted Project
delcypher accepted D71449: [iOS sim] Ensure simulator device is booted in iossim_prepare.py.

LGTM

Dec 20 2019, 1:25 PM · Restricted Project, Restricted Project
delcypher committed rG03512b267d9a: [NFC][Driver] Add dummy compiler-rt sanitizer dylibs for Darwin. (authored by delcypher).
[NFC][Driver] Add dummy compiler-rt sanitizer dylibs for Darwin.
Dec 20 2019, 11:33 AM

Dec 16 2019

delcypher added inline comments to D71491: [ubsan] Check implicit casts in ObjC for-in statements.
Dec 16 2019, 5:21 PM · Restricted Project
delcypher committed rGe2bcc33b50f6: Change `asan/TestCases/Darwin/malloc_zone-protected.cpp` to call abort so that… (authored by delcypher).
Change `asan/TestCases/Darwin/malloc_zone-protected.cpp` to call abort so that…
Dec 16 2019, 4:44 PM
delcypher closed D71573: Change `asan/TestCases/Darwin/malloc_zone-protected.cpp` to call abort so that it **always crashes**..
Dec 16 2019, 4:44 PM · Restricted Project, Restricted Project
delcypher created D71573: Change `asan/TestCases/Darwin/malloc_zone-protected.cpp` to call abort so that it **always crashes**..
Dec 16 2019, 2:30 PM · Restricted Project, Restricted Project
delcypher added inline comments to D71449: [iOS sim] Ensure simulator device is booted in iossim_prepare.py.
Dec 16 2019, 10:25 AM · Restricted Project, Restricted Project
delcypher requested changes to D71449: [iOS sim] Ensure simulator device is booted in iossim_prepare.py.
Dec 16 2019, 9:20 AM · Restricted Project, Restricted Project
delcypher added a comment to D71449: [iOS sim] Ensure simulator device is booted in iossim_prepare.py.

LGTM except the possible improvement to the error message.

Dec 16 2019, 9:20 AM · Restricted Project, Restricted Project

Dec 13 2019

delcypher added inline comments to D71491: [ubsan] Check implicit casts in ObjC for-in statements.
Dec 13 2019, 10:03 PM · Restricted Project
delcypher added inline comments to D71491: [ubsan] Check implicit casts in ObjC for-in statements.
Dec 13 2019, 9:27 PM · Restricted Project

Dec 12 2019

delcypher committed rGdcaf932b992f: [Symbolizers] On Darwin compute function offset when possible. (authored by delcypher).
[Symbolizers] On Darwin compute function offset when possible.
Dec 12 2019, 3:54 PM