delcypher (Dan Liew)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 21 2015, 4:29 PM (164 w, 3 d)

Recent Activity

Fri, Oct 12

delcypher accepted D53239: [python] [tests] Disable python binding tests when building with LLVM_USE_SANITIZER=Address.

LGTM. But then I would say that because I wrote the patch 😛...

Fri, Oct 12, 7:25 PM
delcypher committed rCRT344434: [lit] Support the `%shared_libasan` lit substitution on Apple platforms..
[lit] Support the `%shared_libasan` lit substitution on Apple platforms.
Fri, Oct 12, 4:38 PM
delcypher committed rL344434: [lit] Support the `%shared_libasan` lit substitution on Apple platforms..
[lit] Support the `%shared_libasan` lit substitution on Apple platforms.
Fri, Oct 12, 4:38 PM
delcypher closed D53111: [lit] Support the `%shared_libasan` lit substitution on Apple platforms..
Fri, Oct 12, 4:38 PM
delcypher added a comment to D53111: [lit] Support the `%shared_libasan` lit substitution on Apple platforms..

I think this might break android which runs tests at a different absolute path.

Fri, Oct 12, 9:54 AM

Thu, Oct 11

delcypher updated the summary of D53111: [lit] Support the `%shared_libasan` lit substitution on Apple platforms..
Thu, Oct 11, 7:48 PM
delcypher added a comment to D53111: [lit] Support the `%shared_libasan` lit substitution on Apple platforms..

LGTM

Thu, Oct 11, 7:47 PM
delcypher committed rL344324: Fix bug where `config.asan_dynamic` in generated ASan `lit.site.cfg` files was….
Fix bug where `config.asan_dynamic` in generated ASan `lit.site.cfg` files was…
Thu, Oct 11, 7:38 PM
delcypher committed rCRT344324: Fix bug where `config.asan_dynamic` in generated ASan `lit.site.cfg` files was….
Fix bug where `config.asan_dynamic` in generated ASan `lit.site.cfg` files was…
Thu, Oct 11, 7:38 PM
delcypher closed D53183: Fix bug where `config.asan_dynamic` in generated ASan `lit.site.cfg` files was set to `False` for macOS. It should actually be `True` because dylibs are the only supported form of the ASan runtime on Apple platforms..
Thu, Oct 11, 7:38 PM
delcypher created D53183: Fix bug where `config.asan_dynamic` in generated ASan `lit.site.cfg` files was set to `False` for macOS. It should actually be `True` because dylibs are the only supported form of the ASan runtime on Apple platforms..
Thu, Oct 11, 6:49 PM
delcypher updated the diff for D53111: [lit] Support the `%shared_libasan` lit substitution on Apple platforms..
  • Try to fix formatting
  • Use absolute path on Linux too
  • Emit a warning for other platforms when config.asan_dynamic is true.
  • Only set substitution when config.asan_dynamic is true.
Thu, Oct 11, 6:36 PM
delcypher added a comment to D53111: [lit] Support the `%shared_libasan` lit substitution on Apple platforms..

What breaks if we switch to the absolute path on Linux?

I'm not sure. I will test and report back.

Thu, Oct 11, 6:11 PM
delcypher requested changes to D53171: [tsan] Bring Dispatch support to Linux.

This looks very promising. However I have some minor nits and some concerns regarding the use of system header files.

Thu, Oct 11, 3:48 PM · Restricted Project
delcypher accepted D53167: [interception] Switch to _type suffix instead of _f, NFC..

LGTM. Although I do agree with @george.karpenkov 's point.

Thu, Oct 11, 2:49 PM · Restricted Project
delcypher added a comment to D53111: [lit] Support the `%shared_libasan` lit substitution on Apple platforms..

What breaks if we switch to the absolute path on Linux?

Thu, Oct 11, 1:08 PM

Wed, Oct 10

delcypher created D53111: [lit] Support the `%shared_libasan` lit substitution on Apple platforms..
Wed, Oct 10, 2:44 PM

Tue, Oct 9

delcypher added a comment to D50330: [RFC] Implement out-of-process allocator enumeration for macOS.

@kcc ping.

Tue, Oct 9, 11:57 AM · Restricted Project

Fri, Oct 5

delcypher requested changes to D52199: [profile] Install headers for custom runtime maintainers.

@vsk I'm not entirely convinced this is correct but this might be because I don't understand how these header files are meant to be consumed.

Fri, Oct 5, 2:13 AM

Thu, Oct 4

delcypher added inline comments to D50330: [RFC] Implement out-of-process allocator enumeration for macOS.
Thu, Oct 4, 5:47 AM · Restricted Project

Tue, Oct 2

delcypher added a comment to D50330: [RFC] Implement out-of-process allocator enumeration for macOS.
In D50330#1214896, @kcc wrote:

ForEachChunkOutOfProcess needs access to internal structures of the allocator.

That's exactly why I proposed to consider implementing a public API instead.
It might be hard, but I'd like to know why before we proceed with the current change.

Tue, Oct 2, 11:47 AM · Restricted Project
delcypher updated the diff for D50330: [RFC] Implement out-of-process allocator enumeration for macOS.
  • Implement SizeClassAllocator32 out-of-process enumeration
  • Split implementation of out-of-process functions into their own header files. These can be included by the platforms that actually need this functionality.
  • Remove ProcessVMReaderContext::ReadErrorTy and use bool instead.
  • Move declaration of the ProcessHandle into sanitizer_internal_defs.h.
Tue, Oct 2, 11:25 AM · Restricted Project

Mon, Oct 1

delcypher committed rCRT343496: [NFC] Fix `-Wcast-qual` warnings in Darwin `internal_sysctl(...)`….
[NFC] Fix `-Wcast-qual` warnings in Darwin `internal_sysctl(...)`…
Mon, Oct 1, 9:57 AM
delcypher committed rL343496: [NFC] Fix `-Wcast-qual` warnings in Darwin `internal_sysctl(...)`….
[NFC] Fix `-Wcast-qual` warnings in Darwin `internal_sysctl(...)`…
Mon, Oct 1, 9:54 AM
delcypher closed D52717: [NFC] Fix `-Wcast-qual` warnings in Darwin `internal_sysctl(...)` implementation..
Mon, Oct 1, 9:54 AM
delcypher added a comment to D52717: [NFC] Fix `-Wcast-qual` warnings in Darwin `internal_sysctl(...)` implementation..

@krytarowski Thanks for the quick review. I'll wait for @kubamracek or @george.karpenkov to also review before landing.

Mon, Oct 1, 4:24 AM
delcypher created D52717: [NFC] Fix `-Wcast-qual` warnings in Darwin `internal_sysctl(...)` implementation..
Mon, Oct 1, 4:17 AM

Mon, Sep 24

delcypher committed rCRT342868: Fix the configuration of the Primary allocator for Darwin ARM64 by.
Fix the configuration of the Primary allocator for Darwin ARM64 by
Mon, Sep 24, 7:25 AM
delcypher committed rCRT342869: When running the ios/iossim prepare script show the script output when it….
When running the ios/iossim prepare script show the script output when it…
Mon, Sep 24, 7:25 AM
delcypher committed rL342868: Fix the configuration of the Primary allocator for Darwin ARM64 by.
Fix the configuration of the Primary allocator for Darwin ARM64 by
Mon, Sep 24, 7:24 AM
delcypher committed rL342869: When running the ios/iossim prepare script show the script output when it….
When running the ios/iossim prepare script show the script output when it…
Mon, Sep 24, 7:24 AM
delcypher closed D51173: Fix the configuration of the Primary allocator for Darwin ARM64.
Mon, Sep 24, 7:24 AM
delcypher closed D52350: When running the ios/iossim prepare script show the script output when it returns with a non-zero exit code..
Mon, Sep 24, 7:24 AM
delcypher added a comment to D52350: When running the ios/iossim prepare script show the script output when it returns with a non-zero exit code..

@kubamracek Thanks for the review. Landing this now.

Mon, Sep 24, 7:19 AM

Fri, Sep 21

delcypher created D52350: When running the ios/iossim prepare script show the script output when it returns with a non-zero exit code..
Fri, Sep 21, 3:50 AM

Wed, Sep 19

delcypher committed rCRT342553: [UBSan] Fix typo in CMake conditional that checked if the architecture.
[UBSan] Fix typo in CMake conditional that checked if the architecture
Wed, Sep 19, 8:28 AM
delcypher committed rL342553: [UBSan] Fix typo in CMake conditional that checked if the architecture.
[UBSan] Fix typo in CMake conditional that checked if the architecture
Wed, Sep 19, 8:28 AM

Mon, Sep 17

delcypher added inline comments to D51648: [UBSan] Partially fix `test/ubsan/TestCases/Misc/log-path_test.cc` so that it can run on devices..
Mon, Sep 17, 6:38 AM
delcypher committed rCRT342391: [UBSan] Partially fix `test/ubsan/TestCases/Misc/log-path_test.cc` so that it….
[UBSan] Partially fix `test/ubsan/TestCases/Misc/log-path_test.cc` so that it…
Mon, Sep 17, 6:35 AM
delcypher committed rL342391: [UBSan] Partially fix `test/ubsan/TestCases/Misc/log-path_test.cc` so that it….
[UBSan] Partially fix `test/ubsan/TestCases/Misc/log-path_test.cc` so that it…
Mon, Sep 17, 6:35 AM
delcypher closed D51648: [UBSan] Partially fix `test/ubsan/TestCases/Misc/log-path_test.cc` so that it can run on devices..
Mon, Sep 17, 6:35 AM

Sep 12 2018

delcypher added a comment to D51648: [UBSan] Partially fix `test/ubsan/TestCases/Misc/log-path_test.cc` so that it can run on devices..

@filcab Is this new version of the patch better?

Sep 12 2018, 7:26 AM
delcypher updated the diff for D51648: [UBSan] Partially fix `test/ubsan/TestCases/Misc/log-path_test.cc` so that it can run on devices..

Use %device_rm instead of %run rm.

Sep 12 2018, 7:26 AM

Sep 11 2018

delcypher added a comment to D51648: [UBSan] Partially fix `test/ubsan/TestCases/Misc/log-path_test.cc` so that it can run on devices..

For the iOS simulator the host and the device file system are the same so no work is required. For iOS devices the scripts handle this by copying back the log file to the host when they detect log_path= was in ASAN_OPTIONS/TSAN_OPTIONS/UBSAN_OPTIONS.

This made me curious: Why don't the scripts delete the file after copying it to the host?

Sep 11 2018, 7:40 AM

Sep 5 2018

delcypher added a comment to D51648: [UBSan] Partially fix `test/ubsan/TestCases/Misc/log-path_test.cc` so that it can run on devices..

I don't think this is acceptable.
We have no guarantees we even have a shell on the devices. The run script might be doing all sort of things for commands to run on the device.

Sep 5 2018, 9:39 AM
delcypher added a reviewer for D51648: [UBSan] Partially fix `test/ubsan/TestCases/Misc/log-path_test.cc` so that it can run on devices.: hfinkel.
Sep 5 2018, 5:37 AM
delcypher updated the diff for D51648: [UBSan] Partially fix `test/ubsan/TestCases/Misc/log-path_test.cc` so that it can run on devices..

Use shell=True mode of subprocess.call(...).

Sep 5 2018, 3:13 AM

Sep 4 2018

delcypher added inline comments to D51648: [UBSan] Partially fix `test/ubsan/TestCases/Misc/log-path_test.cc` so that it can run on devices..
Sep 4 2018, 3:31 PM
delcypher created D51648: [UBSan] Partially fix `test/ubsan/TestCases/Misc/log-path_test.cc` so that it can run on devices..
Sep 4 2018, 11:20 AM

Sep 3 2018

delcypher committed rL341307: [asan] Clean up some confusing code in.
[asan] Clean up some confusing code in
Sep 3 2018, 3:35 AM
delcypher committed rCRT341307: [asan] Clean up some confusing code in.
[asan] Clean up some confusing code in
Sep 3 2018, 3:35 AM
delcypher closed D44579: [asan] Clean up some confusing code in `test/asan/TestCases/Darwin/segv_read_write.c` .
Sep 3 2018, 3:35 AM
delcypher committed rL341306: [UBSan] Add CMake and lit support for configuring and running UBSan.
[UBSan] Add CMake and lit support for configuring and running UBSan
Sep 3 2018, 3:31 AM
delcypher committed rCRT341306: [UBSan] Add CMake and lit support for configuring and running UBSan.
[UBSan] Add CMake and lit support for configuring and running UBSan
Sep 3 2018, 3:31 AM
delcypher closed D51270: [UBSan] Add CMake and lit support for configuring and running UBSan tests for ios, watchos, tvos, and their simulator counterparts..
Sep 3 2018, 3:31 AM
delcypher updated the diff for D51270: [UBSan] Add CMake and lit support for configuring and running UBSan tests for ios, watchos, tvos, and their simulator counterparts..
  • Move EXCLUDE_FROM_ALL setting out of macro to make the macro more general.
  • Minor comment tweak.
Sep 3 2018, 3:29 AM
delcypher committed rCRT341300: Give a better error message when trying to run the iossim tests and….
Give a better error message when trying to run the iossim tests and…
Sep 3 2018, 1:41 AM
delcypher committed rL341300: Give a better error message when trying to run the iossim tests and….
Give a better error message when trying to run the iossim tests and…
Sep 3 2018, 1:41 AM
delcypher closed D51272: Give a better error message when trying to run the iossim tests and `SANITIZER_IOSSIM_TEST_DEVICE_IDENTIFIER` is not set in the environment..
Sep 3 2018, 1:41 AM
delcypher committed rCRT341299: [UBSan] Propagate `UBSAN_OPTIONS` environment variable when running ios….
[UBSan] Propagate `UBSAN_OPTIONS` environment variable when running ios…
Sep 3 2018, 1:38 AM
delcypher committed rL341299: [UBSan] Propagate `UBSAN_OPTIONS` environment variable when running ios….
[UBSan] Propagate `UBSAN_OPTIONS` environment variable when running ios…
Sep 3 2018, 1:38 AM
delcypher closed D51273: [UBSan] Propagate `UBSAN_OPTIONS` environment variable when running ios simulator tests..
Sep 3 2018, 1:38 AM
delcypher committed rCRT341298: [UBSan] Add missing `%run` prefixes to Pointer tests..
[UBSan] Add missing `%run` prefixes to Pointer tests.
Sep 3 2018, 1:36 AM
delcypher committed rL341298: [UBSan] Add missing `%run` prefixes to Pointer tests..
[UBSan] Add missing `%run` prefixes to Pointer tests.
Sep 3 2018, 1:34 AM
delcypher closed D51271: [UBSan] Add missing `%run` prefixes to Pointer tests..
Sep 3 2018, 1:34 AM

Aug 28 2018

delcypher added a comment to D51326: [lit, shtest-timeout] Always use an internal shell for the shtest-timeout to diagnose buildbot failures.

@ stella.stamenova Thanks for taking a look at fixing. Provided that this change isn't permanent then this change is probably okay.

Aug 28 2018, 2:23 PM
delcypher accepted D51239: [ubsan] Enable -fsanitize=vptr on Apple devices and simulators.

LGTM.

Aug 28 2018, 10:13 AM

Aug 26 2018

delcypher requested changes to D51239: [ubsan] Enable -fsanitize=vptr on Apple devices and simulators.
Aug 26 2018, 3:57 PM
delcypher added a reviewer for D51270: [UBSan] Add CMake and lit support for configuring and running UBSan tests for ios, watchos, tvos, and their simulator counterparts.: george.karpenkov.
Aug 26 2018, 3:51 PM
delcypher added a reviewer for D51271: [UBSan] Add missing `%run` prefixes to Pointer tests.: george.karpenkov.
Aug 26 2018, 3:51 PM
delcypher created D51273: [UBSan] Propagate `UBSAN_OPTIONS` environment variable when running ios simulator tests..
Aug 26 2018, 3:47 PM
delcypher created D51272: Give a better error message when trying to run the iossim tests and `SANITIZER_IOSSIM_TEST_DEVICE_IDENTIFIER` is not set in the environment..
Aug 26 2018, 3:45 PM
delcypher created D51271: [UBSan] Add missing `%run` prefixes to Pointer tests..
Aug 26 2018, 3:41 PM
delcypher created D51270: [UBSan] Add CMake and lit support for configuring and running UBSan tests for ios, watchos, tvos, and their simulator counterparts..
Aug 26 2018, 3:37 PM

Aug 23 2018

delcypher updated the diff for D51173: Fix the configuration of the Primary allocator for Darwin ARM64.

Fix indentation of macros

Aug 23 2018, 2:24 PM
delcypher added a comment to D51173: Fix the configuration of the Primary allocator for Darwin ARM64.

LGTM with a nit.
Additional question but that doesn't require changes to the CL: if you have a ByteMap it means you are using the SizeClassAllocator32 in 64-bit mode (it's gated by a define, look for SANITIZER_CAN_USE_ALLOCATOR64).
Have you tried using the SizeClassAllocator64?

Aug 23 2018, 1:58 PM
delcypher created D51173: Fix the configuration of the Primary allocator for Darwin ARM64.
Aug 23 2018, 10:13 AM

Aug 22 2018

delcypher added inline comments to D51064: [tsan] Adjust setjmp/longjmp handling on Darwin for macOS Mojave.
Aug 22 2018, 4:29 PM · Restricted Project
delcypher added a comment to D50330: [RFC] Implement out-of-process allocator enumeration for macOS.
In D50330#1206984, @kcc wrote:

I've looked at the code once more and I am really afraid of this extra complexity in the core of asan that is never needed outside of OSX/iOS.
It would be much better to hide this into Mac-specific code that would use allocator's public APIs.
It's fine to add some public APIs to the allocator for that purpose, as long as they are testable.
Is that possible?

Aug 22 2018, 4:03 AM · Restricted Project
delcypher accepted D48445: [sanitizer] Use "fast mmap" kernel flag for shadow memory on macOS 10.13.4+.

Other than the kXnuFastMmapFd declaration. LGTM.

Aug 22 2018, 1:44 AM · Restricted Project
delcypher added inline comments to D50388: Respect PYTHONPATH.
Aug 22 2018, 1:27 AM
delcypher added a comment to D50388: Respect PYTHONPATH.

@greened This seems reasonable but I'm wondering under what scenario psutil is installed in a non-standard location which requires the use of PYTHONPATH. The usual way to handle installing a python package that you don't want system wide is to use virtualenv and then run pip install psutil in that environment.

Aug 22 2018, 1:24 AM

Aug 21 2018

delcypher requested changes to D50920: [tsan] Avoid calling Block_copy in the "sync" GCD interceptors.
Aug 21 2018, 12:27 PM · Restricted Project
delcypher added a comment to D50920: [tsan] Avoid calling Block_copy in the "sync" GCD interceptors.

Seems fine but with some minor nits.

Aug 21 2018, 12:27 PM · Restricted Project
delcypher added a comment to D50818: [analyzer] Improved cmake configuration for Z3.

@delcypher @ddcc @mikhail.ramalho Actually, I was thinking about another way of configuring Z3 without CMake entirely, and I would like to hear thoughts on how crazy that is.
What if we

  • Remove all CMake checks
  • Define the headers we need in the analyzer
  • When initializing Z3 objects (done when Z3-visitor or Z3-solver is enabled), we would try to open the dylib, check it's version, and fail if the dylib is not found or the version does not match.

    This is less clean, but would give us a humongous advantage of just being able to drop Z3 dylib into a resource directory (or modifying the Clang rpath) in order to enable Z3, with no recompilation needed. This would be a huge benefit for those who don't recompile the compiler regularly.
Aug 21 2018, 3:54 AM · Restricted Project

Aug 17 2018

delcypher added a comment to D50330: [RFC] Implement out-of-process allocator enumeration for macOS.

@kcc

In D50330#1203010, @kcc wrote:

[sorry for delay, I've been OOO]
Ouch. That's really a lot of code in the core parts of *san, which adds quite a bit of maintenance tax.
Two questions before we start reviewing the code:

  • is it possible to move more of the logic into Mac-specific files?
Aug 17 2018, 3:21 AM · Restricted Project

Aug 16 2018

delcypher added inline comments to D50818: [analyzer] Improved cmake configuration for Z3.
Aug 16 2018, 2:31 PM · Restricted Project

Aug 13 2018

delcypher committed rCRT339559: [CMake] Fix bug in `add_weak_symbols()` function..
[CMake] Fix bug in `add_weak_symbols()` function.
Aug 13 2018, 6:02 AM
delcypher added a comment to D50059: [CMake] Fix bug in `add_weak_symbols()` function..

@george.karpenkov Thanks for the review.

Aug 13 2018, 6:00 AM
delcypher committed rL339559: [CMake] Fix bug in `add_weak_symbols()` function..
[CMake] Fix bug in `add_weak_symbols()` function.
Aug 13 2018, 6:00 AM
delcypher closed D50059: [CMake] Fix bug in `add_weak_symbols()` function..
Aug 13 2018, 6:00 AM

Aug 6 2018

delcypher requested changes to D50275: [sanitizer] When setting up shadow memory on iOS, fix handling the return value of task_info on older OS versions.
Aug 6 2018, 6:26 AM · Restricted Project
delcypher created D50330: [RFC] Implement out-of-process allocator enumeration for macOS.
Aug 6 2018, 6:10 AM · Restricted Project

Jul 31 2018

delcypher created D50059: [CMake] Fix bug in `add_weak_symbols()` function..
Jul 31 2018, 6:24 AM

Jul 26 2018

delcypher added inline comments to D48445: [sanitizer] Use "fast mmap" kernel flag for shadow memory on macOS 10.13.4+.
Jul 26 2018, 3:56 AM · Restricted Project

Jul 25 2018

delcypher added inline comments to D48445: [sanitizer] Use "fast mmap" kernel flag for shadow memory on macOS 10.13.4+.
Jul 25 2018, 8:38 AM · Restricted Project

Jul 24 2018

delcypher accepted D49707: [tsan] Fix crash in objc_sync_enter/objc_sync_exit when using an Obj-C tagged pointer.

Other than minor suggestions the basic idea seems okay for now.

Jul 24 2018, 8:26 AM · Restricted Project

Jul 20 2018

delcypher accepted D15225: [Driver] Sanitizer support based on runtime library presence.
Jul 20 2018, 3:34 PM
delcypher added a comment to D15225: [Driver] Sanitizer support based on runtime library presence.

@george.karpenkov Other than the comment that probably needs updating, LGTM.

Jul 20 2018, 3:34 PM
delcypher added inline comments to D15225: [Driver] Sanitizer support based on runtime library presence.
Jul 20 2018, 3:34 PM