Page MenuHomePhabricator

delcypher (Dan Liew)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 21 2015, 4:29 PM (212 w, 6 d)

Recent Activity

Fri, Sep 13

delcypher accepted D66984: compiler-rt/builtins: Make check-builtins run tests on macOS..
Fri, Sep 13, 5:30 PM · Restricted Project
delcypher added a comment to D66984: compiler-rt/builtins: Make check-builtins run tests on macOS..

@thakis I gave this patch a try. It seems to work apart from the i386 tests that will not work on macOS Catalina. We can deal with that later though.

Fri, Sep 13, 5:30 PM · Restricted Project
delcypher added a comment to D66984: compiler-rt/builtins: Make check-builtins run tests on macOS..

@thakis Sorry for the delay on this. I should have some time this afternoon to try this out.

Fri, Sep 13, 10:53 AM · Restricted Project
delcypher committed rG713da8db39bb: Fix bug in `darwin_test_archs()` when the cache variable is set but empty. (authored by delcypher).
Fix bug in `darwin_test_archs()` when the cache variable is set but empty.
Fri, Sep 13, 10:35 AM
delcypher committed rGef163f5a20dc: [CMake] Separate the detection Darwin platforms architectures for the built-ins… (authored by delcypher).
[CMake] Separate the detection Darwin platforms architectures for the built-ins…
Fri, Sep 13, 10:35 AM
delcypher committed rL371872: Fix bug in `darwin_test_archs()` when the cache variable is set but empty..
Fix bug in `darwin_test_archs()` when the cache variable is set but empty.
Fri, Sep 13, 10:34 AM
delcypher closed D67530: Fix bug in `darwin_test_archs()` when the cache variable is set but empty..
Fri, Sep 13, 10:33 AM · Restricted Project, Restricted Project
delcypher committed rL371871: [CMake] Separate the detection Darwin platforms architectures for the.
[CMake] Separate the detection Darwin platforms architectures for the
Fri, Sep 13, 10:33 AM
delcypher added a comment to D67530: Fix bug in `darwin_test_archs()` when the cache variable is set but empty..

@vsk Thanks for the review.

Fri, Sep 13, 10:33 AM · Restricted Project, Restricted Project
delcypher added a comment to D59150: [CMake] Separate the detection Darwin platforms architectures for the built-ins from the rest of compiler-rt..

@vsk Thanks for the review.

Fri, Sep 13, 10:33 AM · Restricted Project, Restricted Project

Thu, Sep 12

delcypher created D67530: Fix bug in `darwin_test_archs()` when the cache variable is set but empty..
Thu, Sep 12, 5:42 PM · Restricted Project, Restricted Project
delcypher added a comment to D59150: [CMake] Separate the detection Darwin platforms architectures for the built-ins from the rest of compiler-rt..

@vsk @arphaman Is it okay to land this?

Thu, Sep 12, 5:33 PM · Restricted Project, Restricted Project
delcypher updated the diff for D59150: [CMake] Separate the detection Darwin platforms architectures for the built-ins from the rest of compiler-rt..

Pass -w when calling try_compile_only(...) to make architecture detection more robust.

Thu, Sep 12, 5:33 PM · Restricted Project, Restricted Project
delcypher added a reviewer for D59150: [CMake] Separate the detection Darwin platforms architectures for the built-ins from the rest of compiler-rt.: vsk.
Thu, Sep 12, 5:11 PM · Restricted Project, Restricted Project

Thu, Sep 5

delcypher updated subscribers of D66984: compiler-rt/builtins: Make check-builtins run tests on macOS..

@thakis This looks like a reasonable start but I'd like to test this before landing it. @arphaman might have opinions too.

Thu, Sep 5, 6:50 PM · Restricted Project
delcypher committed rL371152: Request commit access for delcypher.
Request commit access for delcypher
Thu, Sep 5, 5:15 PM

Aug 12 2019

delcypher committed rGc3b93bed2992: [asan_symbolize] Fix bug where the frame counter was not incremented. (authored by delcypher).
[asan_symbolize] Fix bug where the frame counter was not incremented.
Aug 12 2019, 11:52 AM
delcypher committed rL368603: [asan_symbolize] Fix bug where the frame counter was not incremented..
[asan_symbolize] Fix bug where the frame counter was not incremented.
Aug 12 2019, 11:51 AM

Aug 8 2019

delcypher committed rG52a36fae2a3f: [asan_symbolize] Fix bug where the frame counter was not incremented. (authored by delcypher).
[asan_symbolize] Fix bug where the frame counter was not incremented.
Aug 8 2019, 5:52 PM
delcypher committed rL368373: [asan_symbolize] Fix bug where the frame counter was not incremented..
[asan_symbolize] Fix bug where the frame counter was not incremented.
Aug 8 2019, 5:51 PM
delcypher closed D65495: [asan_symbolize] Fix bug where the frame counter was not incremented..
Aug 8 2019, 5:51 PM · Restricted Project, Restricted Project
delcypher added a comment to D65495: [asan_symbolize] Fix bug where the frame counter was not incremented..

@vitalybuka Thanks for the review!

Aug 8 2019, 5:04 PM · Restricted Project, Restricted Project

Aug 1 2019

delcypher added inline comments to D60531: [asan_symbolize] Teach `asan_symbolize.py` to symbolicate using a module map.
Aug 1 2019, 2:20 PM · Restricted Project, Restricted Project

Jul 31 2019

delcypher added a comment to D63674: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms. Attempt #3..

I think the way forward is for us to just make sure we have the full xcode available when building our clang package. But we need to figure out how to coax our infrastructure into making that happen..

Jul 31 2019, 2:31 PM · Restricted Project, Restricted Project

Jul 30 2019

delcypher created D65495: [asan_symbolize] Fix bug where the frame counter was not incremented..
Jul 30 2019, 6:10 PM · Restricted Project, Restricted Project
delcypher committed rG62a87287506c: [asan_symbolize] More debugging output (authored by delcypher).
[asan_symbolize] More debugging output
Jul 30 2019, 6:04 PM
delcypher committed rG51b1d858d3ed: [asan_symbolize] Add `--skip-uuid-validation` option to `ModuleMapPlugIn`. (authored by delcypher).
[asan_symbolize] Add `--skip-uuid-validation` option to `ModuleMapPlugIn`.
Jul 30 2019, 6:04 PM
delcypher committed rG23fd828d4e31: [asan_symbolize] Provide better error message when extracting the UUID of a… (authored by delcypher).
[asan_symbolize] Provide better error message when extracting the UUID of a…
Jul 30 2019, 6:04 PM
delcypher committed rL367380: [asan_symbolize] More debugging output.
[asan_symbolize] More debugging output
Jul 30 2019, 6:04 PM
delcypher committed rL367379: [asan_symbolize] Add `--skip-uuid-validation` option to `ModuleMapPlugIn`..
[asan_symbolize] Add `--skip-uuid-validation` option to `ModuleMapPlugIn`.
Jul 30 2019, 6:04 PM
delcypher committed rL367378: [asan_symbolize] Provide better error message when extracting the UUID of a….
[asan_symbolize] Provide better error message when extracting the UUID of a…
Jul 30 2019, 6:04 PM

Jul 29 2019

delcypher added a comment to D65421: Make lit.py abort_now() kill the worker process more precisely.

@porglezomp Just to add a little more context here killing processes in lit has been a source of trouble for me and is part of why I never landed https://reviews.llvm.org/D47210 . We don't have a mechanism for tracking all the processes spawned during tests and when I implemented the --timeout flag I had to implement a hack where we try walk the process tree to kill all the processes spawned by a shell test.
Multiprocessing seems to complicate things because the parent process will just re-spawn a worker process if it's killed.

Jul 29 2019, 4:01 PM · Restricted Project
delcypher requested changes to D65421: Make lit.py abort_now() kill the worker process more precisely.
Jul 29 2019, 3:51 PM · Restricted Project
delcypher added a reviewer for D65421: Make lit.py abort_now() kill the worker process more precisely: delcypher.
Jul 29 2019, 3:51 PM · Restricted Project
delcypher added a comment to D47210: [lit] Fix the `--max-time` flag feature which was completely broken..

Is there any plan to fix this patch and land it? We use --max-time in our tests and intermittently run into the Python assertion. We can work around the problem by killing lit.py with another timer, but then we lose the report that lit.py produces at the end of the run.

Jul 29 2019, 3:51 PM
delcypher added a comment to D65421: Make lit.py abort_now() kill the worker process more precisely.

@porglezomp I think killing the process group is the intention. Shell tests can spawn many child processes and we want to make sure they get killed when abort_now() gets called. If you just kill the worker process you won't kill the child processes spawned by shell tests. This could cause zombie processes to be left lying around. For this reason I don't think we can land this patch.

Jul 29 2019, 3:51 PM · Restricted Project

Jul 24 2019

delcypher accepted D65252: [sanitizer_common] Allow customization of StartSymbolizerSubprocess.

LGTM but I don't own this code so please allow time for the owners to speak up in case they object.

Jul 24 2019, 4:55 PM · Restricted Project, Restricted Project

Jul 23 2019

delcypher accepted D64251: Don't depend on psutil on AIX.

@davide While I agree with sentiment of fixing psutil, the use of psutil was never meant to be permanent. As the owner of this code I don't mind making accommodations for other platforms provided we keep implementation details well contained as this patch now does.

Jul 23 2019, 1:40 PM · Restricted Project, Restricted Project, Restricted Project

Jul 18 2019

delcypher added a comment to D59150: [CMake] Separate the detection Darwin platforms architectures for the built-ins from the rest of compiler-rt..

Ping.

Jul 18 2019, 6:20 PM · Restricted Project, Restricted Project
delcypher added a comment to D64251: Don't depend on psutil on AIX.

@daltenty Other than the minor nit, LGTM.

Jul 18 2019, 3:38 PM · Restricted Project, Restricted Project, Restricted Project
delcypher added inline comments to D64773: [ASan] Support `{f}puts(NULL)` on Darwin.
Jul 18 2019, 12:55 PM · Restricted Project, Restricted Project

Jul 17 2019

delcypher added a comment to D63674: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms. Attempt #3..

@thakis @hans Ping.

Jul 17 2019, 10:28 AM · Restricted Project, Restricted Project

Jul 11 2019

delcypher added inline comments to D64251: Don't depend on psutil on AIX.
Jul 11 2019, 9:21 PM · Restricted Project, Restricted Project, Restricted Project
delcypher added a reviewer for D64251: Don't depend on psutil on AIX: delcypher.
Jul 11 2019, 9:07 PM · Restricted Project, Restricted Project, Restricted Project

Jul 9 2019

delcypher added inline comments to D64251: Don't depend on psutil on AIX.
Jul 9 2019, 4:27 PM · Restricted Project, Restricted Project, Restricted Project

Jul 5 2019

delcypher added a comment to D64240: [LIT] emit timeout error message only if timeout was reached.

@AlexeySachkov LGTM provided the lit tests continue to pass.

Jul 5 2019, 3:55 PM · Restricted Project
delcypher added inline comments to D64251: Don't depend on psutil on AIX.
Jul 5 2019, 1:47 PM · Restricted Project, Restricted Project, Restricted Project
delcypher added a comment to D64251: Don't depend on psutil on AIX.

@daltenty The "This removes our dependency on psutil." text sounds broader than it actually is. Looking at the implementation the removal of the dependency is only for AIX. All other platforms still depends on the psutil module. I think the commit message should be made clearer on this point.

Jul 5 2019, 1:34 PM · Restricted Project, Restricted Project, Restricted Project

Jun 27 2019

delcypher added a comment to D63674: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms. Attempt #3..

@thakis @hans

(FWIW our bots all do clobber builds, so this can't be it.)

Jun 27 2019, 2:28 PM · Restricted Project, Restricted Project

Jun 25 2019

delcypher added inline comments to D63797: Add USan+ASan and UBSan+TSan tests to shadow-memory lit parallelism group..
Jun 25 2019, 5:56 PM · Restricted Project, Restricted Project
delcypher committed rGd38e251bf2f9: Follow up fix for r364366. (authored by delcypher).
Follow up fix for r364366.
Jun 25 2019, 5:55 PM
delcypher committed rL364369: Follow up fix for r364366..
Follow up fix for r364366.
Jun 25 2019, 5:54 PM
delcypher added inline comments to D63797: Add USan+ASan and UBSan+TSan tests to shadow-memory lit parallelism group..
Jun 25 2019, 5:49 PM · Restricted Project, Restricted Project
delcypher committed rG5242fbde5a26: Add USan+ASan and UBSan+TSan tests to shadow-memory lit parallelism group. (authored by delcypher).
Add USan+ASan and UBSan+TSan tests to shadow-memory lit parallelism group.
Jun 25 2019, 5:37 PM
delcypher committed rL364366: Add USan+ASan and UBSan+TSan tests to shadow-memory lit parallelism group..
Add USan+ASan and UBSan+TSan tests to shadow-memory lit parallelism group.
Jun 25 2019, 5:36 PM
delcypher closed D63797: Add USan+ASan and UBSan+TSan tests to shadow-memory lit parallelism group..
Jun 25 2019, 5:35 PM · Restricted Project, Restricted Project
delcypher created D63797: Add USan+ASan and UBSan+TSan tests to shadow-memory lit parallelism group..
Jun 25 2019, 4:44 PM · Restricted Project, Restricted Project

Jun 24 2019

delcypher accepted D57786: [sanitizer] Enabled getpw_getgr.cc on iOS.
Jun 24 2019, 4:54 PM · Restricted Project, Restricted Project
delcypher added a comment to D57786: [sanitizer] Enabled getpw_getgr.cc on iOS.

@vitalybuka Sorry. I didn't see this before.

Jun 24 2019, 4:49 PM · Restricted Project, Restricted Project
delcypher added a comment to D63674: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms. Attempt #3..

@hans

@hans @thakis Could one of you check that this patch doesn't break your build?

We don't get a CMake error anymore,

Jun 24 2019, 3:21 PM · Restricted Project, Restricted Project

Jun 21 2019

delcypher added a comment to D63674: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms. Attempt #3..

@hans @thakis Could one of you check that this patch doesn't break your build?

Jun 21 2019, 5:02 PM · Restricted Project, Restricted Project
delcypher added a comment to D61242: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms. Attempt #2..

@hans @thakis A new version of the patch is available for review at https://reviews.llvm.org/D63674

Jun 21 2019, 2:56 PM · Restricted Project, Restricted Project
delcypher created D63674: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms. Attempt #3..
Jun 21 2019, 2:55 PM · Restricted Project, Restricted Project
delcypher accepted D63586: [ASan] Use dynamic shadow on 32-bit iOS and simulators.

LGTM.

Jun 21 2019, 1:40 PM · Restricted Project, Restricted Project
delcypher added a comment to D61242: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms. Attempt #2..

@hans @thakis Commenting out find_darwin_sdk_dir(DARWIN_iossim_SYSROOT iphonesimulator) was enough for me to reproduce the issue. There's a bug in some existing CMake code I wrote. The code for UBSan test code assumes that if COMPILER_RT_ENABLE_IOS is true that the toolchain can build for iOS and the iOS simulator. This isn't true if one or more of the SDKs are missing. I've written a fix for this and I'll submit a patch for review soon.

Jun 21 2019, 12:48 PM · Restricted Project, Restricted Project
delcypher added a comment to D61242: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms. Attempt #2..

But somehow it was still able to produce an i386 version of libclang_rt.asan_iossim_dynamic.dylib before your change.

Jun 21 2019, 10:45 AM · Restricted Project, Restricted Project

Jun 20 2019

delcypher added a comment to D61242: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms. Attempt #2..

@juliehockett Sorry I completely dropped the ball here and forgot to land this. I've rebased and committed the change. @thakis I noticed I had a merge conflict with your change. Hopefully this hasn't broken anything for you.

I don't have context here, but this change caused Chromium's clang package to stop building, failing with:

[...]
CMake Error at /work/llvm.monorepo/compiler-rt/cmake/config-ix.cmake:179 (message):

Unsupported architecture: i386

Call Stack (most recent call first):

/work/llvm.monorepo/compiler-rt/cmake/config-ix.cmake:218 (get_target_flags_for_arch)
/work/llvm.monorepo/compiler-rt/test/ubsan/CMakeLists.txt:116 (get_test_cflags_for_apple_platform)

See https://bugs.chromium.org/p/chromium/issues/detail?id=976593#c3 for the full cmake invocation and output.

I've reverted this in r363779 until it's more clear what's happening.

Jun 20 2019, 7:14 PM · Restricted Project, Restricted Project

Jun 17 2019

delcypher committed rG9216358c2117: Disable recently added Darwin symbolization tests for iOS. (authored by delcypher).
Disable recently added Darwin symbolization tests for iOS.
Jun 17 2019, 6:38 PM
delcypher committed rG745632c63a5e: [NFC] Split `Darwin/asan-symbolize-partial-report-with-module-map.cc`. (authored by delcypher).
[NFC] Split `Darwin/asan-symbolize-partial-report-with-module-map.cc`.
Jun 17 2019, 6:38 PM
delcypher committed rL363641: Disable recently added Darwin symbolization tests for iOS..
Disable recently added Darwin symbolization tests for iOS.
Jun 17 2019, 6:35 PM
delcypher committed rL363640: [NFC] Split `Darwin/asan-symbolize-partial-report-with-module-map.cc`..
[NFC] Split `Darwin/asan-symbolize-partial-report-with-module-map.cc`.
Jun 17 2019, 6:35 PM
delcypher committed rG3c9f66dccf25: [asan_symbolize] Teach `asan_symbolize.py` to symbolicate partially… (authored by delcypher).
[asan_symbolize] Teach `asan_symbolize.py` to symbolicate partially…
Jun 17 2019, 6:21 PM
delcypher committed rL363639: [asan_symbolize] Teach `asan_symbolize.py` to symbolicate partially….
[asan_symbolize] Teach `asan_symbolize.py` to symbolicate partially…
Jun 17 2019, 6:20 PM
delcypher closed D60533: [asan_symbolize] Teach `asan_symbolize.py` to symbolicate partially symbolicated ASan reports..
Jun 17 2019, 6:20 PM · Restricted Project, Restricted Project
delcypher added a comment to D60533: [asan_symbolize] Teach `asan_symbolize.py` to symbolicate partially symbolicated ASan reports..

@vitalybuka Sorry I forgot about this. I tried to make the test to work in a POSIX use case and I can't make it work. The problem is that when I use %M with stack_trace_format the module name gets stripped (i.e. an absolute path to the binary just becomes the file name of the binary) due to the call to StripModuleName(). This results in us not being able to symbolicate the report from the python script because we don't have the absolute path to the binaries we need to access to perform symbolication.

Jun 17 2019, 6:06 PM · Restricted Project, Restricted Project
delcypher updated subscribers of D61242: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms. Attempt #2..

@juliehockett Sorry I completely dropped the ball here and forgot to land this. I've rebased and committed the change. @thakis I noticed I had a merge conflict with your change. Hopefully this hasn't broken anything for you.

Jun 17 2019, 4:35 PM · Restricted Project, Restricted Project
delcypher committed rG964909e4a6f5: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms. (authored by delcypher).
[CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms.
Jun 17 2019, 4:35 PM
delcypher committed rL363633: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms..
[CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms.
Jun 17 2019, 4:35 PM
delcypher closed D61242: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms. Attempt #2..
Jun 17 2019, 4:35 PM · Restricted Project, Restricted Project
delcypher updated the diff for D61242: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms. Attempt #2..

Rebase.

Jun 17 2019, 4:35 PM · Restricted Project, Restricted Project

Jun 11 2019

delcypher accepted D63096: [Sanitizers] Add case MACOS_VERSION_CATALINA.
Jun 11 2019, 2:44 PM · Restricted Project, Restricted Project
delcypher added a comment to D63096: [Sanitizers] Add case MACOS_VERSION_CATALINA.

LGTM

Jun 11 2019, 2:44 PM · Restricted Project, Restricted Project
delcypher added inline comments to D63102: Fix some lit test ResourceWarnings on Windows.
Jun 11 2019, 10:25 AM · Restricted Project

Apr 28 2019

delcypher added a comment to D61242: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms. Attempt #2..

@juliehockett @phosek This is a new version of https://reviews.llvm.org/D58578 . Would you be able to test it in your set up? I'd prefer to have the confidence of knowing it doesn't break your set up before landing this.

Apr 28 2019, 9:32 AM · Restricted Project, Restricted Project
delcypher created D61242: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms. Attempt #2..
Apr 28 2019, 9:31 AM · Restricted Project, Restricted Project
delcypher committed rCRT359394: [CMake] Don't modify `FUZZER_SUPPORTED_ARCH` is place..
[CMake] Don't modify `FUZZER_SUPPORTED_ARCH` is place.
Apr 28 2019, 2:45 AM
delcypher committed rG8651edf89854: [CMake] Don't modify `FUZZER_SUPPORTED_ARCH` is place. (authored by delcypher).
[CMake] Don't modify `FUZZER_SUPPORTED_ARCH` is place.
Apr 28 2019, 2:44 AM
delcypher committed rL359394: [CMake] Don't modify `FUZZER_SUPPORTED_ARCH` is place..
[CMake] Don't modify `FUZZER_SUPPORTED_ARCH` is place.
Apr 28 2019, 2:44 AM

Apr 27 2019

delcypher added a comment to D58578: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms..

Sure -- to clarify, it's not a test failure, it's a build one. The error was triggered during the CMake configuration step for host runtimes, where we have OSX supported arches: x86_64 only. test/tsan/CMakeLists.txt:78 now calls into the new function on the arm64 case, which down the line triggers a CMake assert that arm64 is in the list of supported arches when it isn't.

Seems like prior to this change, the lit tests were being configured without doing any checks on that list of supported arches. I'm not as familiar with how this code is set up, so I can't really say if it's a problem with this patch or if this patch is exposing another bug. Thanks for taking a look!

Apr 27 2019, 4:16 AM · Restricted Project, Restricted Project
delcypher added a comment to D58578: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms..

To clarify, this is failing when building runtimes for Darwin so shouldn't be Fuchsia specific, but it could be affected by some of the Clang defaults we set in our CMake build. We use lld as the default linker for Fuchsia but not for Darwin where use the system linker.

Apr 27 2019, 4:06 AM · Restricted Project, Restricted Project

Apr 26 2019

delcypher added a comment to D58578: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms..

Sorry about this. I'll revert the patch now and I'll take a look at re-landing it when time permits.

Apr 26 2019, 11:01 AM · Restricted Project, Restricted Project
delcypher committed rG18bc87240545: Revert "[CMake] Fix the value of `config.target_cflags` for non-macOS Apple" (authored by delcypher).
Revert "[CMake] Fix the value of `config.target_cflags` for non-macOS Apple"
Apr 26 2019, 10:53 AM
delcypher committed rCRT359327: Revert "[CMake] Fix the value of `config.target_cflags` for non-macOS Apple".
Revert "[CMake] Fix the value of `config.target_cflags` for non-macOS Apple"
Apr 26 2019, 10:52 AM
delcypher committed rL359327: Revert "[CMake] Fix the value of `config.target_cflags` for non-macOS Apple".
Revert "[CMake] Fix the value of `config.target_cflags` for non-macOS Apple"
Apr 26 2019, 10:52 AM
delcypher added a comment to D58578: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms..

This patch has broken our bots -- when it's building the osx host runtime, it's now triggering an assert on the tsan arm64 test case that wasn't being triggered before. Would you be able to take a look?

Error:

CMake Error at /b/s/w/ir/k/llvm-project/compiler-rt/cmake/config-ix.cmake:177 (message):
  Unsupported architecture: arm64
Call Stack (most recent call first):
  /b/s/w/ir/k/llvm-project/compiler-rt/cmake/config-ix.cmake:216 (get_target_flags_for_arch)
  /b/s/w/ir/k/llvm-project/compiler-rt/test/tsan/CMakeLists.txt:78 (get_test_cflags_for_apple_platform)

Full log: https://logs.chromium.org/logs/fuchsia/buildbucket/cr-buildbucket.appspot.com/8915104112618242800/+/steps/clang/0/steps/build/0/stdout

Apr 26 2019, 10:45 AM · Restricted Project, Restricted Project
delcypher added a comment to D60533: [asan_symbolize] Teach `asan_symbolize.py` to symbolicate partially symbolicated ASan reports..

Can you make the tests Posix?

Apr 26 2019, 10:01 AM · Restricted Project, Restricted Project
delcypher committed rG60f5df948b0d: [asan_symbolize] Teach `asan_symbolize.py` to symbolicate using a module map (authored by delcypher).
[asan_symbolize] Teach `asan_symbolize.py` to symbolicate using a module map
Apr 26 2019, 9:53 AM
delcypher committed rCRT359322: [asan_symbolize] Teach `asan_symbolize.py` to symbolicate using a module map.
[asan_symbolize] Teach `asan_symbolize.py` to symbolicate using a module map
Apr 26 2019, 9:53 AM
delcypher committed rL359322: [asan_symbolize] Teach `asan_symbolize.py` to symbolicate using a module map.
[asan_symbolize] Teach `asan_symbolize.py` to symbolicate using a module map
Apr 26 2019, 9:52 AM
delcypher closed D60531: [asan_symbolize] Teach `asan_symbolize.py` to symbolicate using a module map.
Apr 26 2019, 9:52 AM · Restricted Project, Restricted Project