Page MenuHomePhabricator

delcypher (Dan Liew)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 21 2015, 4:29 PM (230 w, 14 h)

Recent Activity

Yesterday

delcypher added inline comments to D72875: [clang][cmake] Include generated rst files in html built by docs-clang-html target.
Fri, Jan 17, 3:02 PM · Restricted Project, Restricted Project

Fri, Jan 10

delcypher added inline comments to D72305: [TSan] The "thread_terminate" event is delivered on the terminating thread.
Fri, Jan 10, 10:12 AM · Restricted Project, Restricted Project
delcypher added a comment to D72305: [TSan] The "thread_terminate" event is delivered on the terminating thread.

@yln The description of this change needs improving. The title probably ought to be "[TSan] The "thread_terminate" event is always delivered on the terminating thread" and then that should be followed with a brief justification along with a radar number (if there is one).

Fri, Jan 10, 9:37 AM · Restricted Project, Restricted Project

Fri, Dec 20

delcypher added inline comments to D71491: [ubsan] Check implicit casts in ObjC for-in statements.
Fri, Dec 20, 2:18 PM · Restricted Project
delcypher accepted D71449: [iOS sim] Ensure simulator device is booted in iossim_prepare.py.

LGTM

Fri, Dec 20, 1:25 PM · Restricted Project, Restricted Project
delcypher committed rG03512b267d9a: [NFC][Driver] Add dummy compiler-rt sanitizer dylibs for Darwin. (authored by delcypher).
[NFC][Driver] Add dummy compiler-rt sanitizer dylibs for Darwin.
Fri, Dec 20, 11:33 AM

Dec 16 2019

delcypher added inline comments to D71491: [ubsan] Check implicit casts in ObjC for-in statements.
Dec 16 2019, 5:21 PM · Restricted Project
delcypher committed rGe2bcc33b50f6: Change `asan/TestCases/Darwin/malloc_zone-protected.cpp` to call abort so that… (authored by delcypher).
Change `asan/TestCases/Darwin/malloc_zone-protected.cpp` to call abort so that…
Dec 16 2019, 4:44 PM
delcypher closed D71573: Change `asan/TestCases/Darwin/malloc_zone-protected.cpp` to call abort so that it **always crashes**..
Dec 16 2019, 4:44 PM · Restricted Project, Restricted Project
delcypher created D71573: Change `asan/TestCases/Darwin/malloc_zone-protected.cpp` to call abort so that it **always crashes**..
Dec 16 2019, 2:30 PM · Restricted Project, Restricted Project
delcypher added inline comments to D71449: [iOS sim] Ensure simulator device is booted in iossim_prepare.py.
Dec 16 2019, 10:25 AM · Restricted Project, Restricted Project
delcypher requested changes to D71449: [iOS sim] Ensure simulator device is booted in iossim_prepare.py.
Dec 16 2019, 9:20 AM · Restricted Project, Restricted Project
delcypher added a comment to D71449: [iOS sim] Ensure simulator device is booted in iossim_prepare.py.

LGTM except the possible improvement to the error message.

Dec 16 2019, 9:20 AM · Restricted Project, Restricted Project

Dec 13 2019

delcypher added inline comments to D71491: [ubsan] Check implicit casts in ObjC for-in statements.
Dec 13 2019, 10:03 PM · Restricted Project
delcypher added inline comments to D71491: [ubsan] Check implicit casts in ObjC for-in statements.
Dec 13 2019, 9:27 PM · Restricted Project

Dec 12 2019

delcypher committed rGdcaf932b992f: [Symbolizers] On Darwin compute function offset when possible. (authored by delcypher).
[Symbolizers] On Darwin compute function offset when possible.
Dec 12 2019, 3:54 PM
delcypher committed rG213cff779e20: Rename `tsan/race_range_pc.cc` to `test/tsan/race_range_pc.cpp`. (authored by delcypher).
Rename `tsan/race_range_pc.cc` to `test/tsan/race_range_pc.cpp`.
Dec 12 2019, 3:54 PM
delcypher committed rG54dc36f2c55e: [SanitizerCommon] Print the current value of options when printing out help. (authored by delcypher).
[SanitizerCommon] Print the current value of options when printing out help.
Dec 12 2019, 3:53 PM
delcypher committed rG9e328fe90994: Disable LSan sanitizer_common tests due to AppleClang not supporting LSan (rdar… (authored by delcypher).
Disable LSan sanitizer_common tests due to AppleClang not supporting LSan (rdar…
Dec 12 2019, 12:43 PM
delcypher committed rGe4e8e1341d39: Disable running LSan tests on Darwin due the recent changes to the Clang driver… (authored by delcypher).
Disable running LSan tests on Darwin due the recent changes to the Clang driver…
Dec 12 2019, 12:30 PM
delcypher committed rGe3b514ecea4f: Disable using `-fsanitize=leak` from the Clang Driver. (authored by delcypher).
Disable using `-fsanitize=leak` from the Clang Driver.
Dec 12 2019, 12:29 PM

Dec 3 2019

delcypher added a comment to D70151: Add `%match_min_os_deployment_version_to_target` lit substitution..

@yln @kubamracek Ping.

Dec 3 2019, 1:11 PM · Restricted Project, Restricted Project
delcypher committed rG96c8024e2eb0: Rename `tsan/race_range_pc.cc` to `test/tsan/race_range_pc.cpp`. (authored by delcypher).
Rename `tsan/race_range_pc.cc` to `test/tsan/race_range_pc.cpp`.
Dec 3 2019, 9:56 AM

Nov 29 2019

delcypher accepted D69323: Add discussion of git-format-patch to Phabricator.html.
Nov 29 2019, 10:17 AM · Restricted Project
delcypher added a comment to D69323: Add discussion of git-format-patch to Phabricator.html.

The only thing I'm not sure about is whether to create a new subsection for it, or just leave it as inline text and link to the paragraph directly (which is what I did).

Nov 29 2019, 10:17 AM · Restricted Project

Nov 22 2019

delcypher added a comment to D70612: [lit] Be more explicit about the state of tests.

@yln It's still useful to know which tests are marked as UNSUPPORTED without actually running the tests. Does this change break that workflow?

Nov 22 2019, 1:38 PM · Restricted Project

Nov 19 2019

delcypher added a comment to D70151: Add `%match_min_os_deployment_version_to_target` lit substitution..

@yln ping.

Nov 19 2019, 10:43 AM · Restricted Project, Restricted Project
delcypher added a comment to D69549: [Symbolizers] On Darwin compute function offset when possible..

@yln Thanks for the review. Committed in b9a92206b6ef8b369dc266d8cb70553ebef293bd

Nov 19 2019, 10:06 AM · Restricted Project, Restricted Project
delcypher committed rGb9a92206b6ef: [Symbolizers] On Darwin compute function offset when possible. (authored by delcypher).
[Symbolizers] On Darwin compute function offset when possible.
Nov 19 2019, 10:06 AM
delcypher closed D69549: [Symbolizers] On Darwin compute function offset when possible..
Nov 19 2019, 10:06 AM · Restricted Project, Restricted Project

Nov 18 2019

delcypher added a comment to D69549: [Symbolizers] On Darwin compute function offset when possible..

@yln I've done another pass over this. Hopefully there are no remaining issues.

Nov 18 2019, 9:22 PM · Restricted Project, Restricted Project
delcypher updated the diff for D69549: [Symbolizers] On Darwin compute function offset when possible..
  • Update some test comments.
  • Use more sophisticated regex so we can drop separate 0x0 bad address check.
Nov 18 2019, 9:17 PM · Restricted Project, Restricted Project

Nov 15 2019

delcypher added a comment to D70288: [ADT][Expensive checks] Create a /dev/random seed only once when shuffling the range before sorting it to avoid bot timeouts.

@arphaman Nice catch!

Nov 15 2019, 4:00 PM · Restricted Project
delcypher added inline comments to D69549: [Symbolizers] On Darwin compute function offset when possible..
Nov 15 2019, 3:25 PM · Restricted Project, Restricted Project
delcypher added inline comments to D69549: [Symbolizers] On Darwin compute function offset when possible..
Nov 15 2019, 3:25 PM · Restricted Project, Restricted Project

Nov 14 2019

delcypher committed rG4c39f341996c: [SanitizerCommon] Print the current value of options when printing out help. (authored by delcypher).
[SanitizerCommon] Print the current value of options when printing out help.
Nov 14 2019, 2:07 PM
delcypher closed D69546: [SanitizerCommon] Print the current value of options when printing out help..
Nov 14 2019, 2:07 PM · Restricted Project, Restricted Project
delcypher added inline comments to D69549: [Symbolizers] On Darwin compute function offset when possible..
Nov 14 2019, 2:07 PM · Restricted Project, Restricted Project
delcypher added inline comments to D69549: [Symbolizers] On Darwin compute function offset when possible..
Nov 14 2019, 2:07 PM · Restricted Project, Restricted Project
delcypher updated the diff for D69546: [SanitizerCommon] Print the current value of options when printing out help..
  • Drop some comments. There are comments on internal_snprintf that explain the same thing.
  • Use internal_snprintf in FormatString. It handles the nullptr case already.
Nov 14 2019, 11:30 AM · Restricted Project, Restricted Project

Nov 13 2019

delcypher updated the diff for D69549: [Symbolizers] On Darwin compute function offset when possible..
  • Fix line length violation.
  • Fix broken test.
Nov 13 2019, 10:34 PM · Restricted Project, Restricted Project
delcypher added a comment to D69549: [Symbolizers] On Darwin compute function offset when possible..

@yln I've re-worked this patch addressing everything I could.

Nov 13 2019, 3:18 PM · Restricted Project, Restricted Project
delcypher updated the diff for D69549: [Symbolizers] On Darwin compute function offset when possible..
  • Rework test to use a single binary
  • Rework logic to only set function_offset when a useful value was found.
Nov 13 2019, 3:18 PM · Restricted Project, Restricted Project
delcypher added inline comments to D69549: [Symbolizers] On Darwin compute function offset when possible..
Nov 13 2019, 3:08 PM · Restricted Project, Restricted Project
delcypher added inline comments to D69549: [Symbolizers] On Darwin compute function offset when possible..
Nov 13 2019, 2:40 PM · Restricted Project, Restricted Project
delcypher updated the diff for D69546: [SanitizerCommon] Print the current value of options when printing out help..
  • Clean up test case to not use compiled in default options.
  • Adopt a few testing tweaks suggested by @yln offline.
  • Refactor string printing code into helper method to reduce code duplication.
Nov 13 2019, 1:37 PM · Restricted Project, Restricted Project

Nov 12 2019

delcypher created D70152: [Darwin] Add lit features for comparison against target OS version..
Nov 12 2019, 5:40 PM · Restricted Project, Restricted Project
delcypher added a parent revision for D70152: [Darwin] Add lit features for comparison against target OS version.: D70151: Add `%match_min_os_deployment_version_to_target` lit substitution..
Nov 12 2019, 5:40 PM · Restricted Project, Restricted Project
delcypher added a child revision for D70151: Add `%match_min_os_deployment_version_to_target` lit substitution.: D70152: [Darwin] Add lit features for comparison against target OS version..
Nov 12 2019, 5:40 PM · Restricted Project, Restricted Project
delcypher created D70151: Add `%match_min_os_deployment_version_to_target` lit substitution..
Nov 12 2019, 5:31 PM · Restricted Project, Restricted Project
delcypher added a comment to D69546: [SanitizerCommon] Print the current value of options when printing out help..

@yln ping.

Nov 12 2019, 4:54 PM · Restricted Project, Restricted Project

Nov 11 2019

delcypher updated the diff for D69546: [SanitizerCommon] Print the current value of options when printing out help..
  • Fix MSan compilation error.
Nov 11 2019, 2:19 PM · Restricted Project, Restricted Project
delcypher added inline comments to D69546: [SanitizerCommon] Print the current value of options when printing out help..
Nov 11 2019, 1:25 PM · Restricted Project, Restricted Project

Nov 7 2019

delcypher updated the diff for D69546: [SanitizerCommon] Print the current value of options when printing out help..

Put in a proper defensive check rather than "defensive programming" so that we crash if someone screws up.

Nov 7 2019, 5:05 PM · Restricted Project, Restricted Project
delcypher added inline comments to D69549: [Symbolizers] On Darwin compute function offset when possible..
Nov 7 2019, 4:37 PM · Restricted Project, Restricted Project
delcypher added inline comments to D69549: [Symbolizers] On Darwin compute function offset when possible..
Nov 7 2019, 4:37 PM · Restricted Project, Restricted Project
delcypher updated the diff for D69546: [SanitizerCommon] Print the current value of options when printing out help..
  • Go back to a small buffer for printing values. Mmap is probably overkill here.
  • Remove defensive check.
Nov 7 2019, 4:28 PM · Restricted Project, Restricted Project
delcypher added a comment to D69546: [SanitizerCommon] Print the current value of options when printing out help..

@yln @eugenis Good to go?

Nov 7 2019, 3:23 PM · Restricted Project, Restricted Project
delcypher added a comment to D69546: [SanitizerCommon] Print the current value of options when printing out help..
In D69546#1731024, @yln wrote:

I thought that might be ambiguous (Is ... part of the string or is the string truncated?).

Do you anticipate this to be an issue? My feeling is that truncation would only happen with file paths?! I have a slight preference towards the other because it seems simpler (simple, not easy), but I am not blocking on this.

Nov 7 2019, 3:14 PM · Restricted Project, Restricted Project
delcypher updated the diff for D69546: [SanitizerCommon] Print the current value of options when printing out help..
  • Add trunation test.
  • Style clean up in FlagHandler<const char *>::Format(char *buffer, uptr size).
  • Style clean up in FlagHandlerKeepGoing.
Nov 7 2019, 3:14 PM · Restricted Project, Restricted Project

Nov 6 2019

delcypher added inline comments to D69546: [SanitizerCommon] Print the current value of options when printing out help..
Nov 6 2019, 11:13 AM · Restricted Project, Restricted Project

Nov 5 2019

delcypher added a comment to D69546: [SanitizerCommon] Print the current value of options when printing out help..

@yln @eugenis This ready for another round of review.

Nov 5 2019, 2:38 PM · Restricted Project, Restricted Project
delcypher updated the diff for D69546: [SanitizerCommon] Print the current value of options when printing out help..
  • Change path name in test.
Nov 5 2019, 2:29 PM · Restricted Project, Restricted Project
delcypher updated the diff for D69546: [SanitizerCommon] Print the current value of options when printing out help..
  • Rename CurrentValueAsString to Format.
  • Implement support for FlagHandlerKeepGoing.
  • Use Mmap to allocate memory for string representation of option value.
  • Switch to using internal_strlcpy instead of internal_strncpy.
  • Remove separate test for include_if_exists
Nov 5 2019, 2:29 PM · Restricted Project, Restricted Project

Nov 2 2019

delcypher added inline comments to D69546: [SanitizerCommon] Print the current value of options when printing out help..
Nov 2 2019, 11:52 AM · Restricted Project, Restricted Project
delcypher added inline comments to D69546: [SanitizerCommon] Print the current value of options when printing out help..
Nov 2 2019, 11:43 AM · Restricted Project, Restricted Project

Nov 1 2019

delcypher added a comment to D69546: [SanitizerCommon] Print the current value of options when printing out help..

@yln @eugenis Can we do another round of review? I made some slightly different design choices to what was previously discussed. Here's my reasoning:

Nov 1 2019, 2:04 PM · Restricted Project, Restricted Project
delcypher updated the diff for D69546: [SanitizerCommon] Print the current value of options when printing out help..
  • CurrentValueAsString return code now indicates truncation
  • Print "Truncated" if printed current value was truncated.
  • Clean up CurrentValueAsString implementations.
  • Add Support in FlagHandlerInclude for showing current value (not quite right but good enough).
Nov 1 2019, 2:04 PM · Restricted Project, Restricted Project
delcypher added a comment to D69688: [builtins] Move X86 common files to a subdirectory.

@kongyi Hmm we have both x86_common/floatdixf.c and x86_64/floatdixf.c. I think both x86_64h_SOURCES and x86_64_SOURCES will end up with both x86_common/floatdixf.c and x86_64/floatdixf.c due to...

Nov 1 2019, 1:37 PM · Restricted Project, Restricted Project

Oct 31 2019

delcypher accepted D69610: Fix compiler-rt build on macOS without XCode.

LGTM. Thanks for the patch.

Oct 31 2019, 1:45 PM · Restricted Project, Restricted Project

Oct 30 2019

delcypher requested changes to D69610: Fix compiler-rt build on macOS without XCode.
Oct 30 2019, 4:32 PM · Restricted Project, Restricted Project
delcypher added a comment to D69610: Fix compiler-rt build on macOS without XCode.
In D69610#1727552, @yln wrote:

@delcypher: would xcrun --sdk ${sdk_name} --show-sdk-version work in all cases? If yes, we could use it instead of xcodebuild.

LGTM otherwise.

Oct 30 2019, 4:32 PM · Restricted Project, Restricted Project
delcypher committed rG23a33d450b9a: Revert "[Builtins] Downgrade duplicate source file warning from a fatal error… (authored by delcypher).
Revert "[Builtins] Downgrade duplicate source file warning from a fatal error…
Oct 30 2019, 4:26 PM
delcypher added a reverting change for rGdc748816e2ae: [Builtins] Downgrade duplicate source file warning from a fatal error to a…: rG23a33d450b9a: Revert "[Builtins] Downgrade duplicate source file warning from a fatal error….
Oct 30 2019, 4:26 PM
delcypher committed rG8ea148dc0cbf: [Builtins] Fix bug where powerpc builtins specializations didn't remove generic… (authored by delcypher).
[Builtins] Fix bug where powerpc builtins specializations didn't remove generic…
Oct 30 2019, 4:23 PM
delcypher closed D69189: [Builtins] Fix bug where powerpc builtins specializations didn't remove generic implementations..
Oct 30 2019, 4:23 PM · Restricted Project, Restricted Project
delcypher updated the summary of D69189: [Builtins] Fix bug where powerpc builtins specializations didn't remove generic implementations..
Oct 30 2019, 4:23 PM · Restricted Project, Restricted Project
delcypher added a comment to D69189: [Builtins] Fix bug where powerpc builtins specializations didn't remove generic implementations..

Thanks for the review committed as 8ea148dc0cbff33ac3c80cf4273991465479a01e

Oct 30 2019, 4:23 PM · Restricted Project, Restricted Project

Oct 29 2019

delcypher added a comment to D69189: [Builtins] Fix bug where powerpc builtins specializations didn't remove generic implementations..

One of us here at IBM would gladly try this out on ppc64/ppc64le if that is desired. We are certainly interested in helping to ensure our target does not put undue burden on the community, but I don't think anyone here has much CMake expertise.
So if you let us know if you'd like us to test something out for PPC, we'll be happy to do it.

Oct 29 2019, 5:14 PM · Restricted Project, Restricted Project
delcypher added inline comments to D69546: [SanitizerCommon] Print the current value of options when printing out help..
Oct 29 2019, 11:13 AM · Restricted Project, Restricted Project
delcypher added inline comments to D69546: [SanitizerCommon] Print the current value of options when printing out help..
Oct 29 2019, 11:13 AM · Restricted Project, Restricted Project
delcypher added a comment to D69546: [SanitizerCommon] Print the current value of options when printing out help..

Note there is a way to modify this patch so that it does actually show the defaults in the .inc files. This would require adding storage for the default values and assigning to it in CommonFlags::SetDefaults() (and all other similar sanitizer flag parsers). Then the CurrentValueAsString() functions could be renamed to DefaultValueAsString() and could be modified to read the default value rather than the current value.

Oct 29 2019, 10:54 AM · Restricted Project, Restricted Project

Oct 28 2019

delcypher committed rG8678afce2c8c: [Symbolizers] On Darwin compute function offset when possible. (authored by delcypher).
[Symbolizers] On Darwin compute function offset when possible.
Oct 28 2019, 11:42 PM
delcypher created D69549: [Symbolizers] On Darwin compute function offset when possible..
Oct 28 2019, 11:41 PM · Restricted Project, Restricted Project
delcypher created D69546: [SanitizerCommon] Print the current value of options when printing out help..
Oct 28 2019, 7:17 PM · Restricted Project, Restricted Project
delcypher added a comment to D69189: [Builtins] Fix bug where powerpc builtins specializations didn't remove generic implementations..

@phosek @amyk : ping

Oct 28 2019, 2:37 PM · Restricted Project, Restricted Project

Oct 25 2019

delcypher requested changes to D69323: Add discussion of git-format-patch to Phabricator.html.

Thanks for the patch. I didn't know that this information was missing from our docs!

Oct 25 2019, 10:34 AM · Restricted Project

Oct 23 2019

delcypher added a comment to D69189: [Builtins] Fix bug where powerpc builtins specializations didn't remove generic implementations..

Ping.

Oct 23 2019, 6:06 PM · Restricted Project, Restricted Project
delcypher updated the diff for D69189: [Builtins] Fix bug where powerpc builtins specializations didn't remove generic implementations..

Comment update.

Oct 23 2019, 6:01 PM · Restricted Project, Restricted Project

Oct 18 2019

delcypher added a comment to D68064: [Builtins] Provide a mechanism to selectively disable tests based on whether an implementation is provided by a builtin library..

Fix for powerpc issue is now up for review: https://reviews.llvm.org/D69189

Oct 18 2019, 11:53 AM · Restricted Project, Restricted Project
delcypher created D69189: [Builtins] Fix bug where powerpc builtins specializations didn't remove generic implementations..
Oct 18 2019, 11:44 AM · Restricted Project, Restricted Project
delcypher added a comment to D68064: [Builtins] Provide a mechanism to selectively disable tests based on whether an implementation is provided by a builtin library..

Okay I figured out the issue. The problem is with the filtering code. It assumes that architecture specific specializations have a filepath like <arch>/filename. The problem here is that for powerpc64 the <arch> is powerpc64 but the directory name used is actually ppc. I've got a fix for this which should prevent people from making the same mistake in the future.

Oct 18 2019, 10:58 AM · Restricted Project, Restricted Project

Oct 17 2019

delcypher added a comment to D68064: [Builtins] Provide a mechanism to selectively disable tests based on whether an implementation is provided by a builtin library..

Hmm this code looks a little dubious. It's modifying a list while iterating over it and I'm not sure that regex is right.

Oct 17 2019, 1:50 PM · Restricted Project, Restricted Project
delcypher added a comment to D68064: [Builtins] Provide a mechanism to selectively disable tests based on whether an implementation is provided by a builtin library..

and then later

Oct 17 2019, 1:22 PM · Restricted Project, Restricted Project
delcypher committed rGdc748816e2ae: [Builtins] Downgrade duplicate source file warning from a fatal error to a… (authored by delcypher).
[Builtins] Downgrade duplicate source file warning from a fatal error to a…
Oct 17 2019, 1:13 PM
delcypher committed rL375162: [Builtins] Downgrade duplicate source file warning from a fatal error to a….
[Builtins] Downgrade duplicate source file warning from a fatal error to a…
Oct 17 2019, 1:13 PM
delcypher added a comment to D68064: [Builtins] Provide a mechanism to selectively disable tests based on whether an implementation is provided by a builtin library..

Landed workaround to downgrade fatal error to warning in r375162.

Oct 17 2019, 1:13 PM · Restricted Project, Restricted Project
delcypher updated subscribers of D68064: [Builtins] Provide a mechanism to selectively disable tests based on whether an implementation is provided by a builtin library..

Damn looks like something is broken for linux powerpc

Oct 17 2019, 1:04 PM · Restricted Project, Restricted Project
delcypher committed rL375150: [Builtins] Provide a mechanism to selectively disable tests based on whether an….
[Builtins] Provide a mechanism to selectively disable tests based on whether an…
Oct 17 2019, 11:12 AM
delcypher committed rG5be7eb3ab4da: [Builtins] Provide a mechanism to selectively disable tests based on whether an… (authored by delcypher).
[Builtins] Provide a mechanism to selectively disable tests based on whether an…
Oct 17 2019, 11:12 AM