This is an archive of the discontinued LLVM Phabricator instance.

Differential D68196

[llvm-readobj/llvm-readelf] Delete --arm-attributes (alias for --arch-specific)
ClosedPublic

Authored by MaskRay on Sep 29 2019, 10:13 PM.

Details

Reviewers
atanasyan
compnerd
kongyi
peter.smith
rupprecht
Commits
rG2d92c8844e57: [llvm-readobj/llvm-readelf] Delete --arm-attributes (alias for --arch-specific)
rL373291: [llvm-readobj/llvm-readelf] Delete --arm-attributes (alias for --arch-specific)
Summary

D68110 added --arch-specific (supported by GNU readelf) and made
--arm-attributes an alias for it. The tests were later migrated to use
--arch-specific.

Note, llvm-readelf --arch-specific currently just uses llvm-readobj
style output for ARM attributes. The readelf-style output is not
implemented.

Diff Detail

Repository
rL LLVM

Event Timeline

MaskRay created this revision.Sep 29 2019, 10:13 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 29 2019, 10:13 PM
Herald added subscribers: llvm-commits, seiya, kristof.beyls. · View Herald Transcript
Harbormaster completed remote builds in B38723: Diff 222344.Sep 29 2019, 10:14 PM
kongyi accepted this revision.Sep 29 2019, 10:36 PM
This revision is now accepted and ready to land.Sep 29 2019, 10:36 PM
rupprecht accepted this revision.Sep 30 2019, 10:30 AM
compnerd accepted this revision.Sep 30 2019, 1:12 PM

Thanks for cleaning this up

Closed by commit rL373291: [llvm-readobj/llvm-readelf] Delete --arm-attributes (alias for --arch-specific) (authored by MaskRay). · Explain WhySep 30 2019, 6:29 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
trunk/
docs/
CommandGuide/
4 lines
4 lines
test/
tools/
llvm-readobj/
ARM/
2 lines
2 lines
tools/
llvm-readobj/
2 lines

Diff 222535

llvm/trunk/docs/CommandGuide/llvm-readelf.rst

Show All 22 Lines
.. option:: --all .. option:: --all
Equivalent to specifying all the main display options. Equivalent to specifying all the main display options.
.. option:: --addrsig .. option:: --addrsig
Display the address-significance table. Display the address-significance table.
.. option:: --arm-attributes .. option:: --arch-specific, -A
Display the ARM attributes section. Only applicable for ARM architectures. Display architecture-specific information, e.g. the ARM attributes section on ARM.
.. option:: --color .. option:: --color
Use colors in the output for warnings and errors. Use colors in the output for warnings and errors.
.. option:: --demangle, -C .. option:: --demangle, -C
Display demangled symbol names in the output. Display demangled symbol names in the output.
▲ Show 20 Lines • Show All 162 Lines • Show Last 20 Lines

llvm/trunk/docs/CommandGuide/llvm-readobj.rst

Show First 20 Lines • Show All 138 Lines • ▼ Show 20 Lines
Read command-line options from response file `<FILE>`. Read command-line options from response file `<FILE>`.
ELF SPECIFIC OPTIONS ELF SPECIFIC OPTIONS
-------------------- --------------------
The following options are implemented only for the ELF file format. The following options are implemented only for the ELF file format.
.. option:: --arm-attributes .. option:: --arch-specific, -A
Display the ARM attributes section. Only applicable for ARM architectures. Display architecture-specific information, e.g. the ARM attributes section on ARM.
.. option:: --demangle, -C .. option:: --demangle, -C
Display demangled symbol names in the output. Display demangled symbol names in the output.
.. option:: --dyn-relocations .. option:: --dyn-relocations
Display the dynamic relocation entries. Display the dynamic relocation entries.
▲ Show 20 Lines • Show All 157 Lines • Show Last 20 Lines

llvm/trunk/test/tools/llvm-readobj/ARM/attribute-conformance-1.s

@ RUN: llvm-mc -triple armv7-elf -filetype asm -o - %s | FileCheck %s @ RUN: llvm-mc -triple armv7-elf -filetype asm -o - %s | FileCheck %s
@ RUN: llvm-mc -triple armv7-eabi -filetype obj -o - %s \ @ RUN: llvm-mc -triple armv7-eabi -filetype obj -o - %s \
@ RUN: | llvm-readobj --arch-specific - | FileCheck %s --check-prefix=CHECK-OBJ @ RUN: | llvm-readobj --arch-specific - | FileCheck %s --check-prefix=CHECK-OBJ
@ RUN: llvm-mc -triple armv7-eabi -filetype obj -o - %s \ @ RUN: llvm-mc -triple armv7-eabi -filetype obj -o - %s \
@ RUN: | llvm-readobj -A - | FileCheck %s --check-prefix=CHECK-OBJ @ RUN: | llvm-readobj -A - | FileCheck %s --check-prefix=CHECK-OBJ
@ RUN: llvm-mc -triple armv7-eabi -filetype obj -o - %s \
@ RUN: | llvm-readobj --arm-attributes - | FileCheck %s --check-prefix=CHECK-OBJ
.eabi_attribute Tag_conformance, "0" .eabi_attribute Tag_conformance, "0"
@CHECK: .eabi_attribute 67, "0" @CHECK: .eabi_attribute 67, "0"
@CHECK-OBJ: Tag: 67 @CHECK-OBJ: Tag: 67
@CHECK-OBJ-NEXT: TagName: conformance @CHECK-OBJ-NEXT: TagName: conformance
@CHECK-OBJ-NEXT: Value: 0 @CHECK-OBJ-NEXT: Value: 0

llvm/trunk/test/tools/llvm-readobj/ARM/attribute-conformance-2.s

@ RUN: llvm-mc -triple armv7-elf -filetype asm -o - %s | FileCheck %s @ RUN: llvm-mc -triple armv7-elf -filetype asm -o - %s | FileCheck %s
@ RUN: llvm-mc -triple armv7-eabi -filetype obj -o - %s \ @ RUN: llvm-mc -triple armv7-eabi -filetype obj -o - %s \
@ RUN: | llvm-readobj --arch-specific - | FileCheck %s --check-prefix=CHECK-OBJ @ RUN: | llvm-readobj --arch-specific - | FileCheck %s --check-prefix=CHECK-OBJ
@ RUN: llvm-mc -triple armv7-eabi -filetype obj -o - %s \ @ RUN: llvm-mc -triple armv7-eabi -filetype obj -o - %s \
@ RUN: | llvm-readobj -A - | FileCheck %s --check-prefix=CHECK-OBJ @ RUN: | llvm-readobj -A - | FileCheck %s --check-prefix=CHECK-OBJ
@ RUN: llvm-mc -triple armv7-eabi -filetype obj -o - %s \
@ RUN: | llvm-readobj --arm-attributes - | FileCheck %s --check-prefix=CHECK-OBJ
.eabi_attribute Tag_conformance, "A.long--non numeric oddity...!!" .eabi_attribute Tag_conformance, "A.long--non numeric oddity...!!"
@CHECK: .eabi_attribute 67, "A.long--non numeric oddity...!!" @CHECK: .eabi_attribute 67, "A.long--non numeric oddity...!!"
@CHECK-OBJ: Tag: 67 @CHECK-OBJ: Tag: 67
@CHECK-OBJ-NEXT: TagName: conformance @CHECK-OBJ-NEXT: TagName: conformance
@CHECK-OBJ-NEXT: Value: A.long--non numeric oddity...!! @CHECK-OBJ-NEXT: Value: A.long--non numeric oddity...!!

llvm/trunk/tools/llvm-readobj/llvm-readobj.cpp

Show First 20 Lines • Show All 230 Lines • ▼ Show 20 Lines cl::opt<bool> CodeViewSubsectionBytes(
"codeview-subsection-bytes", "codeview-subsection-bytes",
cl::desc("Dump raw contents of codeview debug sections and records")); cl::desc("Dump raw contents of codeview debug sections and records"));
// --arch-specific // --arch-specific
cl::opt<bool> ArchSpecificInfo("arch-specific", cl::opt<bool> ArchSpecificInfo("arch-specific",
cl::desc("Displays architecture-specific information, if there is any.")); cl::desc("Displays architecture-specific information, if there is any."));
cl::alias ArchSpecifcInfoShort("A", cl::desc("Alias for --arch-specific"), cl::alias ArchSpecifcInfoShort("A", cl::desc("Alias for --arch-specific"),
cl::aliasopt(ArchSpecificInfo), cl::NotHidden); cl::aliasopt(ArchSpecificInfo), cl::NotHidden);
cl::alias ARMAttributes("arm-attributes", cl::desc("Alias for --arch-specific"),
cl::aliasopt(ArchSpecificInfo), cl::Hidden);
// --mips-plt-got // --mips-plt-got
cl::opt<bool> cl::opt<bool>
MipsPLTGOT("mips-plt-got", MipsPLTGOT("mips-plt-got",
cl::desc("Display the MIPS GOT and PLT GOT sections")); cl::desc("Display the MIPS GOT and PLT GOT sections"));
// --mips-abi-flags // --mips-abi-flags
cl::opt<bool> MipsABIFlags("mips-abi-flags", cl::opt<bool> MipsABIFlags("mips-abi-flags",
▲ Show 20 Lines • Show All 515 Lines • Show Last 20 Lines