Page MenuHomePhabricator

[llvm-readobj] Rename --arm-attributes to --arch-specific
ClosedPublic

Authored by kongyi on Sep 26 2019, 5:04 PM.

Details

Summary

This is for compatibility with GNU readobj. "--arm-attributes" option is left as a hidden alias due to large number of tests using it.

Diff Detail

Repository
rL LLVM

Event Timeline

kongyi created this revision.Sep 26 2019, 5:04 PM

Looks good to me. GNU readelf --arch-specific also handles MIPS .MIPS.abiflags, PowerPC specific tags, RISC-V specific tags, etc, which llvm-readobj does not support now but these targets are supported by LLVM. CC some people for more opinions.

atanasyan accepted this revision.Sep 27 2019, 3:03 AM

LGTM. Later I will include under this option all existing MIPS specific "dumpers": printMipsPLTGOT, printMipsABIFlags, etc.

This revision is now accepted and ready to land.Sep 27 2019, 3:03 AM
peter.smith accepted this revision.Sep 27 2019, 9:20 AM

LGTM too, thanks for the patch.

This revision was automatically updated to reflect the committed changes.