Page MenuHomePhabricator

kongyi (Yi Kong)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 23 2014, 2:03 AM (422 w, 2 d)

Recent Activity

Apr 12 2022

kongyi committed rG7d7771f34d14: [BOLT] Compact legacy profiles (authored by kongyi).
[BOLT] Compact legacy profiles
Apr 12 2022, 1:43 AM · Restricted Project
kongyi closed D123513: [BOLT] Compact legacy profiles.
Apr 12 2022, 1:43 AM · Restricted Project, Restricted Project

Apr 11 2022

kongyi added a comment to D123513: [BOLT] Compact legacy profiles.

Could you please share before and after numbers you are seeing?

Apr 11 2022, 4:50 PM · Restricted Project, Restricted Project
kongyi updated the diff for D123513: [BOLT] Compact legacy profiles.
Apr 11 2022, 4:48 PM · Restricted Project, Restricted Project
kongyi requested review of D123513: [BOLT] Compact legacy profiles.
Apr 11 2022, 7:05 AM · Restricted Project, Restricted Project

Mar 17 2022

kongyi added a reverting change for rGba59476515cf: Revert "[clang][driver] Emit a warning if -xc/-xc++ is after the last input…: rGe2a1f8ec27b8: Reland "[clang][driver] Emit a warning if -xc/-xc++ is after the last input….
Mar 17 2022, 1:33 AM · Restricted Project
kongyi committed rGe2a1f8ec27b8: Reland "[clang][driver] Emit a warning if -xc/-xc++ is after the last input… (authored by kongyi).
Reland "[clang][driver] Emit a warning if -xc/-xc++ is after the last input…
Mar 17 2022, 1:33 AM · Restricted Project

Mar 15 2022

kongyi added a reverting change for rG1c1a4b9556db: [clang][driver] Emit a warning if -xc/-xc++ is after the last input file: rGba59476515cf: Revert "[clang][driver] Emit a warning if -xc/-xc++ is after the last input….
Mar 15 2022, 10:19 AM · Restricted Project
kongyi committed rGba59476515cf: Revert "[clang][driver] Emit a warning if -xc/-xc++ is after the last input… (authored by kongyi).
Revert "[clang][driver] Emit a warning if -xc/-xc++ is after the last input…
Mar 15 2022, 10:19 AM · Restricted Project
kongyi added a reverting change for D121683: Emit a warning if -xc/-xc++ is after the last input file: rGba59476515cf: Revert "[clang][driver] Emit a warning if -xc/-xc++ is after the last input….
Mar 15 2022, 10:19 AM · Restricted Project, Restricted Project
kongyi committed rG1c1a4b9556db: [clang][driver] Emit a warning if -xc/-xc++ is after the last input file (authored by kongyi).
[clang][driver] Emit a warning if -xc/-xc++ is after the last input file
Mar 15 2022, 10:08 AM · Restricted Project
kongyi closed D121683: Emit a warning if -xc/-xc++ is after the last input file.
Mar 15 2022, 10:08 AM · Restricted Project, Restricted Project
kongyi added reviewers for D121683: Emit a warning if -xc/-xc++ is after the last input file: srhines, MaskRay.
Mar 15 2022, 3:57 AM · Restricted Project, Restricted Project
kongyi requested review of D121683: Emit a warning if -xc/-xc++ is after the last input file.
Mar 15 2022, 3:54 AM · Restricted Project, Restricted Project

Mar 7 2022

kongyi added a reverting change for rGd8f4d5466417: Add CMake option not to build BOLT tests: rG8142ace0a749: Revert "Add CMake option not to build BOLT tests".
Mar 7 2022, 10:02 AM · Restricted Project
kongyi committed rG8142ace0a749: Revert "Add CMake option not to build BOLT tests" (authored by kongyi).
Revert "Add CMake option not to build BOLT tests"
Mar 7 2022, 10:02 AM · Restricted Project
kongyi committed rGbc1f8b6b9b1e: Fix the comment for EnableNoundefAttrs, NFC (authored by kongyi).
Fix the comment for EnableNoundefAttrs, NFC
Mar 7 2022, 10:00 AM · Restricted Project
kongyi committed rGd8f4d5466417: Add CMake option not to build BOLT tests (authored by kongyi).
Add CMake option not to build BOLT tests
Mar 7 2022, 10:00 AM · Restricted Project

Mar 2 2022

kongyi added a comment to D120808: Add CMake option not to build BOLT tests.

Can you please elaborate the goal? BOLT tests are disabled if LLVM tests are disabled (LLVM_INCLUDE_TESTS=OFF), or if prerequisites are not met (clang/lld are not built or not specified via BOLT_{CLANG,LLD}_EXE). Likewise, they are enabled if LLVM_INCLUDE_TESTS is on.
If the goal is to control BOLT tests independent from LLVM tests, can you please confirm by specifying LLVM_INCLUDE_TESTS=ON and BOLT_INCLUDE_TESTS=OFF and vice versa.

BOLT_INCLUDE_TESTS also controls whether merge-fdata gets built with relocation. My goal is to build LLVM with tests but without relocation for merge-fdata.

Makes sense. Although why is building with relocs a problem? (It might be a problem with gold linker that doesn't accept -emit-relocs together with -icf or -gc-sections)

Mar 2 2022, 10:09 PM · Restricted Project
kongyi added a comment to D120808: Add CMake option not to build BOLT tests.

Can you please elaborate the goal? BOLT tests are disabled if LLVM tests are disabled (LLVM_INCLUDE_TESTS=OFF), or if prerequisites are not met (clang/lld are not built or not specified via BOLT_{CLANG,LLD}_EXE). Likewise, they are enabled if LLVM_INCLUDE_TESTS is on.
If the goal is to control BOLT tests independent from LLVM tests, can you please confirm by specifying LLVM_INCLUDE_TESTS=ON and BOLT_INCLUDE_TESTS=OFF and vice versa.

Mar 2 2022, 11:27 AM · Restricted Project
kongyi updated the diff for D120808: Add CMake option not to build BOLT tests.
Mar 2 2022, 8:44 AM · Restricted Project
kongyi updated the diff for D120808: Add CMake option not to build BOLT tests.
Mar 2 2022, 8:38 AM · Restricted Project
kongyi requested review of D120808: Add CMake option not to build BOLT tests.
Mar 2 2022, 4:58 AM · Restricted Project

Nov 3 2021

kongyi committed rG803d4f8a35ca: [ARM][AsmParser] Don't emit "deprecated instruction in IT block" warning if… (authored by kongyi).
[ARM][AsmParser] Don't emit "deprecated instruction in IT block" warning if…
Nov 3 2021, 2:21 AM
kongyi closed D112993: Don't emit "deprecated instruction in IT block" warning if requested.
Nov 3 2021, 2:21 AM · Restricted Project

Nov 2 2021

kongyi updated subscribers of D112993: Don't emit "deprecated instruction in IT block" warning if requested.
Nov 2 2021, 2:54 AM · Restricted Project
kongyi updated the diff for D112993: Don't emit "deprecated instruction in IT block" warning if requested.
Nov 2 2021, 2:53 AM · Restricted Project
kongyi added a reviewer for D112993: Don't emit "deprecated instruction in IT block" warning if requested: echristo.
Nov 2 2021, 2:38 AM · Restricted Project
Herald added a project to D27219: Add MCNoDeprecatedASM into MC ASMParser TargetOption to have an option to disable deprecate warning in asm: Restricted Project.
Nov 2 2021, 2:37 AM · Restricted Project
kongyi requested review of D112993: Don't emit "deprecated instruction in IT block" warning if requested.
Nov 2 2021, 2:27 AM · Restricted Project

Nov 1 2021

kongyi committed rGc060457ec6ed: Revert "[opt-viewer] Use safe yaml load_all" (authored by kongyi).
Revert "[opt-viewer] Use safe yaml load_all"
Nov 1 2021, 2:19 AM
kongyi added a reverting change for rG1123e03a9d94: [opt-viewer] Use safe yaml load_all: rGc060457ec6ed: Revert "[opt-viewer] Use safe yaml load_all".
Nov 1 2021, 2:19 AM
kongyi added a comment to D112075: Use safe yaml load_all.

Reverted, commit c060457ec6eda640ae75e48d99500712fabe1c42

Nov 1 2021, 2:19 AM · Restricted Project
kongyi added a reverting change for D112075: Use safe yaml load_all: rGc060457ec6ed: Revert "[opt-viewer] Use safe yaml load_all".
Nov 1 2021, 2:19 AM · Restricted Project
kongyi added a comment to D112075: Use safe yaml load_all.

Hi @kongyi , this breaks opt-viewer.py usage on the AIX platform.

opt-viewer/opt-viewer.py  test.opt.yaml --demangler cat
For faster parsing, you may want to install libYAML for PyYAML
Reading YAML files...
        1 of 1multiprocessing.pool.RemoteTraceback: 
"""
Traceback (most recent call last):
  File "/opt/freeware/lib64/python3.7/multiprocessing/pool.py", line 121, in worker
    result = (True, func(*args, **kwds))
  File "/opt/freeware/lib64/python3.7/multiprocessing/pool.py", line 44, in mapstar
    return list(map(*args))
  File "/home/czhengsz/llvm/dev/llvm-project/llvm/tools/opt-viewer/optpmap.py", line 25, in _wrapped_func
    return func(argument, filter_)
  File "/home/czhengsz/llvm/dev/llvm-project/llvm/tools/opt-viewer/optrecord.py", line 277, in get_remarks
    docs = yaml.safe_load_all(f, Loader=Loader)
TypeError: safe_load_all() got an unexpected keyword argument 'Loader'
"""

Can you try removing the second argument (Loader=Loader) and check if it works?

No, still fails.

Traceback (most recent call last):
  File "/opt/freeware/lib64/python3.7/multiprocessing/pool.py", line 121, in worker
    result = (True, func(*args, **kwds))
  File "/opt/freeware/lib64/python3.7/multiprocessing/pool.py", line 44, in mapstar
    return list(map(*args))
  File "/home/czhengsz/llvm/dev/llvm-project/llvm/tools/opt-viewer/optpmap.py", line 25, in _wrapped_func
    return func(argument, filter_)
  File "/home/czhengsz/llvm/dev/llvm-project/llvm/tools/opt-viewer/optrecord.py", line 282, in get_remarks
    for remark in docs:
  File "/home/czhengsz/test/optviewer/optviewer_env/lib64/python3.7/site-packages/yaml/__init__.py", line 93, in load_all
    yield loader.get_data()
  File "/home/czhengsz/test/optviewer/optviewer_env/lib64/python3.7/site-packages/yaml/constructor.py", line 45, in get_data
    return self.construct_document(self.get_node())
  File "/home/czhengsz/test/optviewer/optviewer_env/lib64/python3.7/site-packages/yaml/constructor.py", line 55, in construct_document
    data = self.construct_object(node)
  File "/home/czhengsz/test/optviewer/optviewer_env/lib64/python3.7/site-packages/yaml/constructor.py", line 100, in construct_object
    data = constructor(self, node)
  File "/home/czhengsz/test/optviewer/optviewer_env/lib64/python3.7/site-packages/yaml/constructor.py", line 429, in construct_undefined
    node.start_mark)
yaml.constructor.ConstructorError: could not determine a constructor for the tag '!Missed'
Nov 1 2021, 2:14 AM · Restricted Project
kongyi added a comment to D112075: Use safe yaml load_all.

Hi @kongyi , this breaks opt-viewer.py usage on the AIX platform.

opt-viewer/opt-viewer.py  test.opt.yaml --demangler cat
For faster parsing, you may want to install libYAML for PyYAML
Reading YAML files...
        1 of 1multiprocessing.pool.RemoteTraceback: 
"""
Traceback (most recent call last):
  File "/opt/freeware/lib64/python3.7/multiprocessing/pool.py", line 121, in worker
    result = (True, func(*args, **kwds))
  File "/opt/freeware/lib64/python3.7/multiprocessing/pool.py", line 44, in mapstar
    return list(map(*args))
  File "/home/czhengsz/llvm/dev/llvm-project/llvm/tools/opt-viewer/optpmap.py", line 25, in _wrapped_func
    return func(argument, filter_)
  File "/home/czhengsz/llvm/dev/llvm-project/llvm/tools/opt-viewer/optrecord.py", line 277, in get_remarks
    docs = yaml.safe_load_all(f, Loader=Loader)
TypeError: safe_load_all() got an unexpected keyword argument 'Loader'
"""
Nov 1 2021, 1:36 AM · Restricted Project

Oct 20 2021

kongyi committed rG1123e03a9d94: [opt-viewer] Use safe yaml load_all (authored by kongyi).
[opt-viewer] Use safe yaml load_all
Oct 20 2021, 11:00 PM
kongyi closed D112075: Use safe yaml load_all.
Oct 20 2021, 11:00 PM · Restricted Project
kongyi added a comment to D112075: Use safe yaml load_all.

LGTM, I wonder what triggered that change?

Oct 20 2021, 10:55 PM · Restricted Project
kongyi added a reviewer for D112075: Use safe yaml load_all: serge-sans-paille.
Oct 20 2021, 5:24 PM · Restricted Project

Oct 19 2021

kongyi requested review of D112075: Use safe yaml load_all.
Oct 19 2021, 7:21 AM · Restricted Project

Oct 16 2021

kongyi abandoned D110522: Add build option to specify profdata type.
Oct 16 2021, 9:31 PM · Restricted Project

Sep 27 2021

kongyi added reviewers for D110522: Add build option to specify profdata type: vsk, davidxl.
Sep 27 2021, 12:02 AM · Restricted Project

Sep 26 2021

kongyi requested review of D110522: Add build option to specify profdata type.
Sep 26 2021, 11:59 PM · Restricted Project

Sep 22 2021

kongyi closed D110225: Don't fold (select C, (gep Ptr, Idx), Ptr) if C is vector but Idx is scalar.

Landed d0746f2e9bbf08f52196ae12f25d0ef7edcbbe4c (forgot to add the Phabricator link)

Sep 22 2021, 3:13 AM · Restricted Project
kongyi committed rGd0746f2e9bbf: Don't fold (select C, (gep Ptr, Idx), Ptr) if C is vector but Idx is scalar (authored by kongyi).
Don't fold (select C, (gep Ptr, Idx), Ptr) if C is vector but Idx is scalar
Sep 22 2021, 3:12 AM
kongyi added reviewers for D110225: Don't fold (select C, (gep Ptr, Idx), Ptr) if C is vector but Idx is scalar: reames, lebedev.ri.
Sep 22 2021, 1:34 AM · Restricted Project
kongyi requested review of D110225: Don't fold (select C, (gep Ptr, Idx), Ptr) if C is vector but Idx is scalar.
Sep 22 2021, 1:06 AM · Restricted Project

Aug 25 2021

kongyi committed rG5fc4828aa6c6: [clang] Don't generate warn-stack-size when the warning is ignored (authored by kongyi).
[clang] Don't generate warn-stack-size when the warning is ignored
Aug 25 2021, 12:01 AM
kongyi closed D108686: [clang] Don't generate warn-stack-size when the warning is ignored.
Aug 25 2021, 12:01 AM · Restricted Project

Aug 24 2021

kongyi updated the diff for D108686: [clang] Don't generate warn-stack-size when the warning is ignored.
Aug 24 2021, 11:20 PM · Restricted Project
kongyi requested review of D108686: [clang] Don't generate warn-stack-size when the warning is ignored.
Aug 24 2021, 11:01 PM · Restricted Project

Aug 19 2021

kongyi committed rGca6d5813d175: [clang] Do not warn unused -enable-trivial-auto-var-init-zero-knowing-it-will… (authored by kongyi).
[clang] Do not warn unused -enable-trivial-auto-var-init-zero-knowing-it-will…
Aug 19 2021, 9:38 AM
kongyi closed D108278: [clang] Do not warn unused -enable-trivial-auto-var-init-zero-knowing-it-will-be-removed-from-clang.
Aug 19 2021, 9:38 AM · Restricted Project

Aug 18 2021

kongyi updated the summary of D108278: [clang] Do not warn unused -enable-trivial-auto-var-init-zero-knowing-it-will-be-removed-from-clang.
Aug 18 2021, 1:38 AM · Restricted Project
kongyi added reviewers for D108278: [clang] Do not warn unused -enable-trivial-auto-var-init-zero-knowing-it-will-be-removed-from-clang: jfb, glider.
Aug 18 2021, 1:37 AM · Restricted Project
kongyi requested review of D108278: [clang] Do not warn unused -enable-trivial-auto-var-init-zero-knowing-it-will-be-removed-from-clang.
Aug 18 2021, 1:35 AM · Restricted Project

Jun 3 2021

kongyi committed rGdcd7664f92d3: Add -fno-visibility-inlines-hidden option (authored by kongyi).
Add -fno-visibility-inlines-hidden option
Jun 3 2021, 2:09 AM
kongyi closed D103537: [clang][driver] Add -fno-visibility-inlines-hidden option.
Jun 3 2021, 2:09 AM · Restricted Project
kongyi updated the diff for D103537: [clang][driver] Add -fno-visibility-inlines-hidden option.
Jun 3 2021, 12:36 AM · Restricted Project
kongyi updated the diff for D103537: [clang][driver] Add -fno-visibility-inlines-hidden option.
Jun 3 2021, 12:12 AM · Restricted Project
kongyi updated the diff for D103537: [clang][driver] Add -fno-visibility-inlines-hidden option.
Jun 3 2021, 12:06 AM · Restricted Project

Jun 2 2021

kongyi requested review of D103537: [clang][driver] Add -fno-visibility-inlines-hidden option.
Jun 2 2021, 10:13 AM · Restricted Project

Mar 11 2021

kongyi accepted D98353: [builtins] Fix value of ARM_INEXACT.
Mar 11 2021, 5:45 AM · Restricted Project
kongyi added a comment to D98353: [builtins] Fix value of ARM_INEXACT.

IIRC, Android test suite was expecting this bit to be set, maybe the test is incorrect. Let me check...

Mar 11 2021, 12:43 AM · Restricted Project

Nov 23 2020

kongyi added a comment to D88252: z_Linux_asm.S modifications for arm64 (AARCH64) for Darwin/macOS.

@Michael_Pique Can this be merged? We need this change to support ARM64 Darwin.

Nov 23 2020, 6:19 AM · Restricted Project, Restricted Project

May 26 2020

kongyi committed rGc1c9eb0ab7d2: [Transforms] Check validity of profile reader before invoking it (authored by kongyi).
[Transforms] Check validity of profile reader before invoking it
May 26 2020, 5:22 AM
kongyi abandoned D80541: Terminate early for DS_Error.
May 26 2020, 4:17 AM · Restricted Project
kongyi created D80541: Terminate early for DS_Error.
May 26 2020, 2:39 AM · Restricted Project

May 18 2020

kongyi added a comment to D79470: [Compiler-rt] Emit error if builtins library cannot be found.

Because when building the builtins themselves, we can't expect to find builtins, right? (Alternatively the check against clang_rt.builtins could be moved down to the NOTFOUND case.)

May 18 2020, 1:01 AM · Restricted Project

May 16 2020

kongyi committed rG2fe66bdb2e5f: [Compiler-rt] Emit error if builtins library cannot be found (authored by kongyi).
[Compiler-rt] Emit error if builtins library cannot be found
May 16 2020, 8:09 PM
kongyi closed D79470: [Compiler-rt] Emit error if builtins library cannot be found.
May 16 2020, 8:08 PM · Restricted Project

May 15 2020

kongyi updated the diff for D79470: [Compiler-rt] Emit error if builtins library cannot be found.
May 15 2020, 9:11 PM · Restricted Project

May 5 2020

kongyi created D79470: [Compiler-rt] Emit error if builtins library cannot be found.
May 5 2020, 11:25 PM · Restricted Project

Apr 20 2020

kongyi added a comment to D76675: [llvm-objcopy] Match GNU behaviour regarding file symbols.

Looks like this breaks tests everywhere, e.g http://45.33.8.238/linux/15764/step_12.txt

Please take a look and revert if it takes a while to investigate.

Apr 20 2020, 9:40 PM · Restricted Project
kongyi committed rG37a1c2eda54a: Revert "[llvm-objcopy] Match GNU behaviour regarding file symbols" (authored by kongyi).
Revert "[llvm-objcopy] Match GNU behaviour regarding file symbols"
Apr 20 2020, 9:09 PM
kongyi added a reverting change for rG7c65e88d0bc8: [llvm-objcopy] Match GNU behaviour regarding file symbols: rG37a1c2eda54a: Revert "[llvm-objcopy] Match GNU behaviour regarding file symbols".
Apr 20 2020, 9:09 PM
kongyi committed rG7c65e88d0bc8: [llvm-objcopy] Match GNU behaviour regarding file symbols (authored by kongyi).
[llvm-objcopy] Match GNU behaviour regarding file symbols
Apr 20 2020, 8:37 PM
kongyi closed D76675: [llvm-objcopy] Match GNU behaviour regarding file symbols.
Apr 20 2020, 8:36 PM · Restricted Project
kongyi updated the diff for D76675: [llvm-objcopy] Match GNU behaviour regarding file symbols.
Apr 20 2020, 1:34 AM · Restricted Project

Apr 17 2020

kongyi updated the diff for D76675: [llvm-objcopy] Match GNU behaviour regarding file symbols.
Apr 17 2020, 10:46 AM · Restricted Project

Mar 26 2020

kongyi accepted D76757: Fix typo, targetFeature should be lowercase..
Mar 26 2020, 9:11 AM · Restricted Project, Restricted Project

Mar 25 2020

kongyi updated the diff for D76675: [llvm-objcopy] Match GNU behaviour regarding file symbols.
Mar 25 2020, 2:08 AM · Restricted Project
kongyi added inline comments to D76675: [llvm-objcopy] Match GNU behaviour regarding file symbols.
Mar 25 2020, 2:08 AM · Restricted Project

Mar 24 2020

kongyi created D76675: [llvm-objcopy] Match GNU behaviour regarding file symbols.
Mar 24 2020, 1:03 AM · Restricted Project
kongyi updated subscribers of D76675: [llvm-objcopy] Match GNU behaviour regarding file symbols.
Mar 24 2020, 1:03 AM · Restricted Project

Mar 17 2020

kongyi added a comment to D74755: [llvm-objcopy] Attribute an empty section to a segment ending at its address.

Gentle ping... We need this change for Android.

Mar 17 2020, 5:43 AM · Restricted Project

Mar 5 2020

kongyi accepted D75719: [clang][Headers] Use __has_builtin instead of _MSC_VER..
Mar 5 2020, 8:11 PM · Restricted Project

Jan 20 2020

kongyi committed rG01bfb366acf3: [llvm-profdata] Fix hint message since argument format has changed (authored by kongyi).
[llvm-profdata] Fix hint message since argument format has changed
Jan 20 2020, 5:03 AM

Jan 6 2020

kongyi accepted D72198: tools/timeit.sh: be flexible while parsing perf-stat output.
Jan 6 2020, 4:22 PM · Restricted Project

Dec 2 2019

kongyi raised a concern with rG2da205d43eeb: Reland "b19ec1eb3d0c [BPI] Improve unreachable/ColdCall heurstics to handle….

You committed your local file "DIFF" in this change.

Dec 2 2019, 1:15 PM

Nov 27 2019

kongyi committed rGacc79aa0e747: Revert "Revert 1689ad27af5 "[builtins] Implement rounding mode support for… (authored by kongyi).
Revert "Revert 1689ad27af5 "[builtins] Implement rounding mode support for…
Nov 27 2019, 5:44 PM
kongyi added a reverting change for rG1689ad27af5c: [builtins] Implement rounding mode support for i386/x86_64: rGacc79aa0e747: Revert "Revert 1689ad27af5 "[builtins] Implement rounding mode support for….
Nov 27 2019, 5:44 PM
kongyi added a reverting change for rGa19f0eec94e1: Revert 1689ad27af5 "[builtins] Implement rounding mode support for i386/x86_64": rGacc79aa0e747: Revert "Revert 1689ad27af5 "[builtins] Implement rounding mode support for….
Nov 27 2019, 5:44 PM

Nov 18 2019

kongyi added inline comments to D69870: [builtins] Implement rounding mode support for i386/x86_64.
Nov 18 2019, 3:40 PM · Restricted Project, Restricted Project
kongyi committed rG1689ad27af5c: [builtins] Implement rounding mode support for i386/x86_64 (authored by kongyi).
[builtins] Implement rounding mode support for i386/x86_64
Nov 18 2019, 10:41 AM
kongyi closed D69870: [builtins] Implement rounding mode support for i386/x86_64.
Nov 18 2019, 10:40 AM · Restricted Project, Restricted Project

Nov 15 2019

kongyi updated the diff for D69870: [builtins] Implement rounding mode support for i386/x86_64.

Remove unused include

Nov 15 2019, 2:15 PM · Restricted Project, Restricted Project
kongyi updated the diff for D69870: [builtins] Implement rounding mode support for i386/x86_64.
Nov 15 2019, 2:15 PM · Restricted Project, Restricted Project

Nov 13 2019

kongyi added a comment to D69870: [builtins] Implement rounding mode support for i386/x86_64.

Would it be better to just do a dummy inexact division operation to trigger than inexact exception instead of manipulating the environment?

Nov 13 2019, 3:27 PM · Restricted Project, Restricted Project