Page MenuHomePhabricator

kongyi (Yi Kong)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 23 2014, 2:03 AM (338 w, 5 d)

Recent Activity

May 26 2020

kongyi committed rGc1c9eb0ab7d2: [Transforms] Check validity of profile reader before invoking it (authored by kongyi).
[Transforms] Check validity of profile reader before invoking it
May 26 2020, 5:22 AM
kongyi abandoned D80541: Terminate early for DS_Error.
May 26 2020, 4:17 AM · Restricted Project
kongyi created D80541: Terminate early for DS_Error.
May 26 2020, 2:39 AM · Restricted Project

May 18 2020

kongyi added a comment to D79470: [Compiler-rt] Emit error if builtins library cannot be found.

Because when building the builtins themselves, we can't expect to find builtins, right? (Alternatively the check against clang_rt.builtins could be moved down to the NOTFOUND case.)

May 18 2020, 1:01 AM · Restricted Project

May 16 2020

kongyi committed rG2fe66bdb2e5f: [Compiler-rt] Emit error if builtins library cannot be found (authored by kongyi).
[Compiler-rt] Emit error if builtins library cannot be found
May 16 2020, 8:09 PM
kongyi closed D79470: [Compiler-rt] Emit error if builtins library cannot be found.
May 16 2020, 8:08 PM · Restricted Project

May 15 2020

kongyi updated the diff for D79470: [Compiler-rt] Emit error if builtins library cannot be found.
May 15 2020, 9:11 PM · Restricted Project

May 5 2020

kongyi created D79470: [Compiler-rt] Emit error if builtins library cannot be found.
May 5 2020, 11:25 PM · Restricted Project

Apr 20 2020

kongyi added a comment to D76675: [llvm-objcopy] Match GNU behaviour regarding file symbols.

Looks like this breaks tests everywhere, e.g http://45.33.8.238/linux/15764/step_12.txt

Please take a look and revert if it takes a while to investigate.

Apr 20 2020, 9:40 PM · Restricted Project
kongyi committed rG37a1c2eda54a: Revert "[llvm-objcopy] Match GNU behaviour regarding file symbols" (authored by kongyi).
Revert "[llvm-objcopy] Match GNU behaviour regarding file symbols"
Apr 20 2020, 9:09 PM
kongyi added a reverting change for rG7c65e88d0bc8: [llvm-objcopy] Match GNU behaviour regarding file symbols: rG37a1c2eda54a: Revert "[llvm-objcopy] Match GNU behaviour regarding file symbols".
Apr 20 2020, 9:09 PM
kongyi committed rG7c65e88d0bc8: [llvm-objcopy] Match GNU behaviour regarding file symbols (authored by kongyi).
[llvm-objcopy] Match GNU behaviour regarding file symbols
Apr 20 2020, 8:37 PM
kongyi closed D76675: [llvm-objcopy] Match GNU behaviour regarding file symbols.
Apr 20 2020, 8:36 PM · Restricted Project
kongyi updated the diff for D76675: [llvm-objcopy] Match GNU behaviour regarding file symbols.
Apr 20 2020, 1:34 AM · Restricted Project

Apr 17 2020

kongyi updated the diff for D76675: [llvm-objcopy] Match GNU behaviour regarding file symbols.
Apr 17 2020, 10:46 AM · Restricted Project

Mar 26 2020

kongyi accepted D76757: Fix typo, targetFeature should be lowercase..
Mar 26 2020, 9:11 AM · Restricted Project, Restricted Project

Mar 25 2020

kongyi updated the diff for D76675: [llvm-objcopy] Match GNU behaviour regarding file symbols.
Mar 25 2020, 2:08 AM · Restricted Project
kongyi added inline comments to D76675: [llvm-objcopy] Match GNU behaviour regarding file symbols.
Mar 25 2020, 2:08 AM · Restricted Project

Mar 24 2020

kongyi created D76675: [llvm-objcopy] Match GNU behaviour regarding file symbols.
Mar 24 2020, 1:03 AM · Restricted Project
kongyi updated subscribers of D76675: [llvm-objcopy] Match GNU behaviour regarding file symbols.
Mar 24 2020, 1:03 AM · Restricted Project

Mar 17 2020

kongyi added a comment to D74755: [llvm-objcopy] Attribute an empty section to a segment ending at its address.

Gentle ping... We need this change for Android.

Mar 17 2020, 5:43 AM · Restricted Project

Mar 5 2020

kongyi accepted D75719: [clang][Headers] Use __has_builtin instead of _MSC_VER..
Mar 5 2020, 8:11 PM · Restricted Project

Jan 20 2020

kongyi committed rG01bfb366acf3: [llvm-profdata] Fix hint message since argument format has changed (authored by kongyi).
[llvm-profdata] Fix hint message since argument format has changed
Jan 20 2020, 5:03 AM

Jan 6 2020

kongyi accepted D72198: tools/timeit.sh: be flexible while parsing perf-stat output.
Jan 6 2020, 4:22 PM · Restricted Project

Dec 2 2019

kongyi raised a concern with rG2da205d43eeb: Reland "b19ec1eb3d0c [BPI] Improve unreachable/ColdCall heurstics to handle….

You committed your local file "DIFF" in this change.

Dec 2 2019, 1:15 PM

Nov 27 2019

kongyi committed rGacc79aa0e747: Revert "Revert 1689ad27af5 "[builtins] Implement rounding mode support for… (authored by kongyi).
Revert "Revert 1689ad27af5 "[builtins] Implement rounding mode support for…
Nov 27 2019, 5:44 PM
kongyi added a reverting change for rG1689ad27af5c: [builtins] Implement rounding mode support for i386/x86_64: rGacc79aa0e747: Revert "Revert 1689ad27af5 "[builtins] Implement rounding mode support for….
Nov 27 2019, 5:44 PM
kongyi added a reverting change for rGa19f0eec94e1: Revert 1689ad27af5 "[builtins] Implement rounding mode support for i386/x86_64": rGacc79aa0e747: Revert "Revert 1689ad27af5 "[builtins] Implement rounding mode support for….
Nov 27 2019, 5:44 PM

Nov 18 2019

kongyi added inline comments to D69870: [builtins] Implement rounding mode support for i386/x86_64.
Nov 18 2019, 3:40 PM · Restricted Project, Restricted Project
kongyi committed rG1689ad27af5c: [builtins] Implement rounding mode support for i386/x86_64 (authored by kongyi).
[builtins] Implement rounding mode support for i386/x86_64
Nov 18 2019, 10:41 AM
kongyi closed D69870: [builtins] Implement rounding mode support for i386/x86_64.
Nov 18 2019, 10:40 AM · Restricted Project, Restricted Project

Nov 15 2019

kongyi updated the diff for D69870: [builtins] Implement rounding mode support for i386/x86_64.

Remove unused include

Nov 15 2019, 2:15 PM · Restricted Project, Restricted Project
kongyi updated the diff for D69870: [builtins] Implement rounding mode support for i386/x86_64.
Nov 15 2019, 2:15 PM · Restricted Project, Restricted Project

Nov 13 2019

kongyi added a comment to D69870: [builtins] Implement rounding mode support for i386/x86_64.

Would it be better to just do a dummy inexact division operation to trigger than inexact exception instead of manipulating the environment?

Nov 13 2019, 3:27 PM · Restricted Project, Restricted Project

Nov 12 2019

kongyi added inline comments to D69870: [builtins] Implement rounding mode support for i386/x86_64.
Nov 12 2019, 2:31 PM · Restricted Project, Restricted Project
kongyi updated the diff for D69870: [builtins] Implement rounding mode support for i386/x86_64.
Nov 12 2019, 2:31 PM · Restricted Project, Restricted Project

Nov 11 2019

kongyi added a comment to D69870: [builtins] Implement rounding mode support for i386/x86_64.

gentle ping...

Nov 11 2019, 7:21 PM · Restricted Project, Restricted Project

Nov 6 2019

kongyi accepted D69911: [llvm-ar] Support verbose mode for operation 'x'.
Nov 6 2019, 11:25 AM · Restricted Project
kongyi updated the diff for D69870: [builtins] Implement rounding mode support for i386/x86_64.
Nov 6 2019, 11:23 AM · Restricted Project, Restricted Project
kongyi added inline comments to D69870: [builtins] Implement rounding mode support for i386/x86_64.
Nov 6 2019, 11:23 AM · Restricted Project, Restricted Project
kongyi added a comment to D69418: [llvm-ar] Add output option for extract operation.

I'll create a separate patch to address the argument ordering comment.

Nov 6 2019, 7:50 AM · Restricted Project

Nov 5 2019

kongyi updated subscribers of D69870: [builtins] Implement rounding mode support for i386/x86_64.
Nov 5 2019, 11:01 PM · Restricted Project, Restricted Project
kongyi created D69870: [builtins] Implement rounding mode support for i386/x86_64.
Nov 5 2019, 4:00 PM · Restricted Project, Restricted Project

Nov 1 2019

kongyi added a comment to D69688: [builtins] Move X86 common files to a subdirectory.

@kongyi Hmm we have both x86_common/floatdixf.c and x86_64/floatdixf.c. I think both x86_64h_SOURCES and x86_64_SOURCES will end up with both x86_common/floatdixf.c and x86_64/floatdixf.c due to...

set(x86_64h_SOURCES ${x86_64h_SOURCES} ${x86_ARCH_SOURCES})
set(x86_64_SOURCES ${x86_64_SOURCES} ${x86_ARCH_SOURCES})

I don't think the filtering algorithm (removing generic builtin implementations in favour of architecture specific implementations) handles this case. Due to both sources being in sub directories they are considered to both be architecture specific implementations.
If I'm right it should mean that with this patch running ninja check-builtins should result in an error due to me relanding 23a33d450b9a426eae7094b16472f8a51fb5488a, i.e. when lit runs we should detect that there is more than one implementation of floatdixf.

Could you check this?

Nov 1 2019, 2:04 PM · Restricted Project, Restricted Project

Oct 31 2019

kongyi created D69688: [builtins] Move X86 common files to a subdirectory.
Oct 31 2019, 3:11 PM · Restricted Project, Restricted Project

Oct 30 2019

kongyi accepted D69189: [Builtins] Fix bug where powerpc builtins specializations didn't remove generic implementations..

Thanks for the patch! I'm developing something for X86 that happens to also need this feature.

Oct 30 2019, 3:57 PM · Restricted Project, Restricted Project
kongyi added inline comments to D69418: [llvm-ar] Add output option for extract operation.
Oct 30 2019, 12:10 PM · Restricted Project

Oct 26 2019

kongyi updated the diff for D69418: [llvm-ar] Add output option for extract operation.
Oct 26 2019, 2:13 AM · Restricted Project

Oct 25 2019

kongyi added a comment to D69418: [llvm-ar] Add output option for extract operation.

Can you say more about the use case? A possible counter argument for the presented use case would be that if you need to extract your archive to a different directory, you should have just fetched it to the right place to begin with.

Oct 25 2019, 11:02 AM · Restricted Project

Oct 24 2019

kongyi updated the diff for D69418: [llvm-ar] Add output option for extract operation.
Oct 24 2019, 5:34 PM · Restricted Project
kongyi created D69418: [llvm-ar] Add output option for extract operation.
Oct 24 2019, 5:22 PM · Restricted Project

Oct 3 2019

kongyi accepted D68385: [llvm-readobj] Replace arch-specific ObjDumper methods by the single `printArchSpecificInfo`.
Oct 3 2019, 7:56 PM · Restricted Project

Sep 30 2019

kongyi created D68249: [llvm-objdump] Don't throw error for empty dynamic section.
Sep 30 2019, 3:52 PM · Restricted Project

Sep 29 2019

kongyi accepted D68196: [llvm-readobj/llvm-readelf] Delete --arm-attributes (alias for --arch-specific).
Sep 29 2019, 10:36 PM · Restricted Project

Sep 27 2019

kongyi committed rG121ef04f04ae: [llvm-readobj] Rename --arm-attributes to --arch-specific (authored by kongyi).
[llvm-readobj] Rename --arm-attributes to --arch-specific
Sep 27 2019, 1:43 PM
kongyi committed rL373125: [llvm-readobj] Rename --arm-attributes to --arch-specific.
[llvm-readobj] Rename --arm-attributes to --arch-specific
Sep 27 2019, 1:43 PM
kongyi closed D68110: [llvm-readobj] Rename --arm-attributes to --arch-specific.
Sep 27 2019, 1:43 PM · Restricted Project

Sep 26 2019

kongyi created D68110: [llvm-readobj] Rename --arm-attributes to --arch-specific.
Sep 26 2019, 5:04 PM · Restricted Project

Sep 9 2019

kongyi committed rL371464: Request commit access for kongyi.
Request commit access for kongyi
Sep 9 2019, 3:36 PM

Sep 5 2019

kongyi added inline comments to rL371003: Revert "Revert "[builtins] Rounding mode support for addxf3/subxf3"".
Sep 5 2019, 10:40 AM

Sep 4 2019

kongyi committed rG33b8a55329b9: Revert "Revert "[builtins] Rounding mode support for addxf3/subxf3"" (authored by kongyi).
Revert "Revert "[builtins] Rounding mode support for addxf3/subxf3""
Sep 4 2019, 6:05 PM
kongyi added a reverting change for rGe204d244badb: Revert "[builtins] Rounding mode support for addxf3/subxf3": rG33b8a55329b9: Revert "Revert "[builtins] Rounding mode support for addxf3/subxf3"".
Sep 4 2019, 6:05 PM
kongyi committed rL371003: Revert "Revert "[builtins] Rounding mode support for addxf3/subxf3"".
Revert "Revert "[builtins] Rounding mode support for addxf3/subxf3""
Sep 4 2019, 6:04 PM

Aug 27 2019

kongyi committed rGb9d87b952802: [llvm-objdump] Add the missing ARMv8 subarch detection (authored by kongyi).
[llvm-objdump] Add the missing ARMv8 subarch detection
Aug 27 2019, 11:39 PM
kongyi committed rL370163: [llvm-objdump] Add the missing ARMv8 subarch detection.
[llvm-objdump] Add the missing ARMv8 subarch detection
Aug 27 2019, 11:39 PM
kongyi closed D66849: [llvm-objdump] Add the missing ARMv8 subarch detection.
Aug 27 2019, 11:39 PM · Restricted Project
kongyi added a comment to D66849: [llvm-objdump] Add the missing ARMv8 subarch detection.

I don't know what new instructions are introduced only in v8.1m-main, omitted the tests (it's not that interesting anyway).

Aug 27 2019, 8:53 PM · Restricted Project
kongyi updated the diff for D66849: [llvm-objdump] Add the missing ARMv8 subarch detection.
Aug 27 2019, 8:47 PM · Restricted Project
kongyi added a reviewer for D66849: [llvm-objdump] Add the missing ARMv8 subarch detection: samparker.
Aug 27 2019, 6:20 PM · Restricted Project
kongyi created D66849: [llvm-objdump] Add the missing ARMv8 subarch detection.
Aug 27 2019, 5:37 PM · Restricted Project

Aug 7 2019

kongyi updated subscribers of D63807: [llvm-objcopy] Add --only-keep-debug for ELF.
Aug 7 2019, 3:54 PM · Restricted Project

Aug 5 2019

kongyi committed rG295d4b7727ca: Build libfuzzer libcxx-static with PIC (authored by kongyi).
Build libfuzzer libcxx-static with PIC
Aug 5 2019, 3:56 PM
kongyi committed rL367943: Build libfuzzer libcxx-static with PIC.
Build libfuzzer libcxx-static with PIC
Aug 5 2019, 3:56 PM
kongyi closed D65773: Build libfuzzer libcxx-static with PIC.
Aug 5 2019, 3:56 PM · Restricted Project, Restricted Project
kongyi created D65773: Build libfuzzer libcxx-static with PIC.
Aug 5 2019, 1:33 PM · Restricted Project, Restricted Project

Jul 25 2019

kongyi committed rG1755abe1fb5c: Fix macOS build after r358716 (authored by kongyi).
Fix macOS build after r358716
Jul 25 2019, 10:19 PM
kongyi committed rL367084: Fix macOS build after r358716.
Fix macOS build after r358716
Jul 25 2019, 10:19 PM
kongyi closed D65317: Fix macOS build after r358716.
Jul 25 2019, 10:19 PM · Restricted Project
kongyi created D65317: Fix macOS build after r358716.
Jul 25 2019, 9:59 PM · Restricted Project
kongyi updated subscribers of D65317: Fix macOS build after r358716.
Jul 25 2019, 9:59 PM · Restricted Project
kongyi committed rG3d21a3af8716: [openmp] Workaround bug in old Android pthread_attr_setstacksize (authored by kongyi).
[openmp] Workaround bug in old Android pthread_attr_setstacksize
Jul 25 2019, 3:30 PM
kongyi committed rL367070: [openmp] Workaround bug in old Android pthread_attr_setstacksize.
[openmp] Workaround bug in old Android pthread_attr_setstacksize
Jul 25 2019, 3:29 PM
kwk awarded D60054: [llvm-objcopy] Add --keep-symbols option a Love token.
Jul 25 2019, 1:25 AM · Restricted Project

Jul 23 2019

kongyi committed rG78b5e9bc2597: Fix gold-plugin Windows build (authored by kongyi).
Fix gold-plugin Windows build
Jul 23 2019, 12:44 AM
kongyi committed rL366786: Fix gold-plugin Windows build.
Fix gold-plugin Windows build
Jul 23 2019, 12:44 AM

Jul 22 2019

kongyi committed rGd8bdb9225ce3: [runtimes] Don't depend on libpthread on Android (authored by kongyi).
[runtimes] Don't depend on libpthread on Android
Jul 22 2019, 1:42 PM
kongyi committed rL366734: [runtimes] Don't depend on libpthread on Android.
[runtimes] Don't depend on libpthread on Android
Jul 22 2019, 1:41 PM
kongyi closed D65098: [runtimes] Do not depend on libpthread on Android.
Jul 22 2019, 1:41 PM · Restricted Project
kongyi created D65098: [runtimes] Do not depend on libpthread on Android.
Jul 22 2019, 9:27 AM · Restricted Project

Jul 18 2019

kongyi committed rGc12f29948deb: [libFuzzer] Set Android specific ALL_FUZZER_SUPPORTED_ARCH (authored by kongyi).
[libFuzzer] Set Android specific ALL_FUZZER_SUPPORTED_ARCH
Jul 18 2019, 7:09 PM
kongyi committed rL366525: [libFuzzer] Set Android specific ALL_FUZZER_SUPPORTED_ARCH.
[libFuzzer] Set Android specific ALL_FUZZER_SUPPORTED_ARCH
Jul 18 2019, 7:07 PM

Jun 13 2019

kongyi accepted D63105: Add --print-supported-cpus flag for clang..

LGTM.

Jun 13 2019, 9:19 PM · Restricted Project

Jun 12 2019

kongyi added a comment to D63034: Slightly increase LastCallToStaticBonus for cold callsites.

Ping...

Jun 12 2019, 4:51 PM · Restricted Project
kongyi added inline comments to D63105: Add --print-supported-cpus flag for clang..
Jun 12 2019, 1:36 PM · Restricted Project

Jun 10 2019

kongyi committed rG432f48fcd4c0: [AArch64] Add more CPUs to host detection (authored by kongyi).
[AArch64] Add more CPUs to host detection
Jun 10 2019, 5:05 PM
kongyi committed rL363013: [AArch64] Add more CPUs to host detection.
[AArch64] Add more CPUs to host detection
Jun 10 2019, 5:05 PM
kongyi closed D63099: [AArch64] Add more CPUs to host detection.
Jun 10 2019, 5:05 PM · Restricted Project
kongyi added a comment to D63105: Add --print-supported-cpus flag for clang..

Please include diff context. https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface

Jun 10 2019, 4:15 PM · Restricted Project
kongyi updated the diff for D63099: [AArch64] Add more CPUs to host detection.
Jun 10 2019, 3:38 PM · Restricted Project
kongyi created D63099: [AArch64] Add more CPUs to host detection.
Jun 10 2019, 3:17 PM · Restricted Project