Page MenuHomePhabricator

Use getTargetConstant for BLENDI, and add a test to catch it.
AbandonedPublic

Authored by saugustine on Thu, Sep 19, 6:55 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

saugustine created this revision.Thu, Sep 19, 6:55 PM
echristo accepted this revision.Thu, Sep 19, 7:01 PM

The x86isellowering change is great, see if you can't remove some of the branches before committing?

This revision is now accepted and ready to land.Thu, Sep 19, 7:01 PM
MaskRay added inline comments.
llvm/test/CodeGen/AMDGPU/GlobalISel/isel-blendi-gettargetconstant.ll
1 ↗(On Diff #220932)

This can be removed.

66 ↗(On Diff #220932)

llvm.ident can be removed.

  • Tighten up the test case.
saugustine marked an inline comment as done.Thu, Sep 19, 7:26 PM

The x86isellowering change is great, see if you can't remove some of the branches before committing?

Done.

echristo accepted this revision.Thu, Sep 19, 7:27 PM

Sweet.

Committed as r372366.

This revision was automatically updated to reflect the committed changes.

In the description of the git commit:

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D67785

Tighten up the test case.     <---- stray comment

(I usually also delete the Subscribers: and Tags: #llvm lines before committing. I feel they just occupy space.)

RKSimon reopened this revision.Fri, Sep 20, 3:54 AM
RKSimon added reviewers: craig.topper, RKSimon.
RKSimon added a subscriber: RKSimon.
RKSimon added inline comments.
llvm/trunk/test/CodeGen/AMDGPU/GlobalISel/isel-blendi-gettargetconstant.ll
3

The test file needs a lot of improvement - its missing a RUN line so isn't actually tested, most of the attributes/metadata can probably be ditched, and surely it should be in test/CodeGen/X86/GlobalIsel ?

This revision is now accepted and ready to land.Fri, Sep 20, 3:54 AM
RKSimon requested changes to this revision.Fri, Sep 20, 3:54 AM
This revision now requires changes to proceed.Fri, Sep 20, 3:54 AM

Reverted in r372383 for now, to unbreak the bots.

arsenm added inline comments.Fri, Sep 20, 8:55 AM
llvm/trunk/test/CodeGen/AMDGPU/GlobalISel/isel-blendi-gettargetconstant.ll
3

This belongs in test/CodeGen/X86 (no GlobalISel)

14

Probably don't need most of these