Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
- Build Status
Buildable 39146 Build 39156: arc lint + arc unit
Event Timeline
llvm/tools/llvm-objcopy/MachO/MachOObjcopy.cpp | ||
---|---|---|
49 | Can you skip the const_cast here and add a mutable getSymbolByIndex overload so you can remove the const modifiers elsewhere? | |
53–57 | For ELF files, --strip-all seems to strip all symbols regardless of whether they're referenced by relocations, is that not true for MachO files? | |
86 | Marking symbols should be behind whatever flags require it, so we don't needlessly traverse symbols |
Addressed review comments.
llvm/tools/llvm-objcopy/MachO/MachOObjcopy.cpp | ||
---|---|---|
53–57 | We can't remove all symbols. Symbols referenced in the indirect symbol table are necessary for dynamic linking (i.e., there're no separate sections just like .dynsym and .dynstr). |
@seyia, sorry about the delays with code review, does this particular diff have any unreviewed dependencies ?
You need a comment at the start of this test explaining what the test does.