Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Paths

Table of Contentst

Differential D65540

[llvm-objcopy][MachO] Fix method names. NFC.
ClosedPublic
Actions

Authored by seiya on Jul 31 2019, 2:39 PM.

Tags

Subscribers

Details

Reviewers

alexander-shaposhnikov
rupprecht
jhenderson

Commits

rG36848ff8dfb3: [llvm-objcopy][MachO] Fix method names. NFC.
rL369346: [llvm-objcopy][MachO] Fix method names. NFC.

Diff Detail

Repository: rL LLVM

Event Timeline

seiya created this revision.Jul 31 2019, 2:39 PM

Herald added a reviewer: alexander-shaposhnikov. · View Herald TranscriptJul 31 2019, 2:39 PM

Herald added a reviewer: rupprecht. · View Herald Transcript

Herald added a reviewer: jhenderson. · View Herald Transcript

Herald added a project: Restricted Project. · View Herald Transcript

Herald added subscribers: llvm-commits, abrachet, jakehehrlich. · View Herald Transcript

Harbormaster completed remote builds in B35916: Diff 212666.Jul 31 2019, 2:39 PM

seiya retitled this revision from [llvm-objcopy][MachO] Fix method names. NFCI. to [llvm-objcopy][MachO] Fix method names. NFC..Jul 31 2019, 2:40 PM

seiya added a parent revision: D65539: [llvm-objcopy][MachO] Implement a layout algorithm for executables.

seiya added a child revision: D65541: [llvm-objcopy][MachO] Implement --only-section.

rupprecht accepted this revision.Jul 31 2019, 4:39 PM

This revision is now accepted and ready to land.Jul 31 2019, 4:39 PM

alexander-shaposhnikov accepted this revision.Jul 31 2019, 4:41 PM

seiya added a child revision: D65799: [yaml2obj/obj2yaml][MachO] Allow setting custom section data.Aug 6 2019, 4:33 AM

seiya removed a child revision: D65541: [llvm-objcopy][MachO] Implement --only-section.

@seiya i think this diff is safe to commit (if it has not been committed yet)

In D65540#1632664, @alexshap wrote:

@seiya i think this diff is safe to commit (if it has not been committed yet)

Thank you for the ping! I'll commit this patch along with other accepted patches by Monday. (I use arc patch to apply patches but it seems that arc requires applying the parent patches (D63395/D65539) before.)

Rebase for the sake of arc patch.

Rebase for the sake of arc patch.

Harbormaster completed remote builds in B36932: Diff 215821.Aug 18 2019, 10:35 PM

Harbormaster completed remote builds in B36933: Diff 215822.

Closed by commit rL369346: [llvm-objcopy][MachO] Fix method names. NFC. (authored by seiya). · Explain WhyAug 20 2019, 1:36 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

llvm/

trunk/

tools/

llvm-objcopy/

MachO/

MachOWriter.cpp

4 lines

Diff 216070

llvm/trunk/tools/llvm-objcopy/MachO/MachOWriter.cpp

Loading...