Page MenuHomePhabricator

[llvm-objcopy][MachO] Support indirect symbol table
Needs ReviewPublic

Authored by seiya on Aug 15 2019, 2:36 AM.

Details

Summary

Parse the indirect symbol table and update the indexes of
symbol entries in the table in the writer in case they have
been changed.

Event Timeline

seiya created this revision.Aug 15 2019, 2:36 AM
seiya planned changes to this revision.Aug 15 2019, 3:06 AM

I'll upload a test for this later.

rupprecht added inline comments.Aug 15 2019, 2:04 PM
llvm/tools/llvm-objcopy/MachO/MachOReader.cpp
261–263

Can this be simplified to a bitmask check? e.g.:

if (Index & (MachO::INDIRECT_SYMBOL_LOCAL | MachO::INDIRECT_SYMBOL_ABS) != 0)
seiya updated this revision to Diff 215816.Sun, Aug 18, 10:05 PM
seiya marked an inline comment as done.
  • Addressed a review comment.
  • Added a test.
seiya updated this revision to Diff 215817.Sun, Aug 18, 10:06 PM
  • Updated the test.
Harbormaster completed remote builds in B36929: Diff 215817.