Page MenuHomePhabricator

Switch LLVM to use 64-bit offsets (2/5)
ClosedPublic

Authored by ikudrin on Aug 2 2019, 1:57 AM.

Details

Summary

This updates all libraries and tools in LLVM Core to use 64-bit offsets which directly or indirectly come to DataExtractor.

Diff Detail

Repository
rL LLVM

Event Timeline

ikudrin created this revision.Aug 2 2019, 1:57 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a subscriber: arphaman. · View Herald Transcript

I know this is huge. Locally, I have 20+ separate patches covering that, but I am not sure if it is simpler to look at one big patch or lots of smaller patches.

dblaikie accepted this revision.Aug 5 2019, 2:21 PM

Looks reasonable to me at a glance - individual changes would be easier to review, but may not be worth separating out.

This revision is now accepted and ready to land.Aug 5 2019, 2:21 PM
This revision was automatically updated to reflect the committed changes.

You missed one that got added very recently! See the FIXME introduced in rL367942.

Thanks! I'll remove that code in the cleanup patch.