Page MenuHomePhabricator

[AMDGPU] Update NumUserSGPRs and NumSystemSGPRs in MIR parsing.
AbandonedPublic

Authored by hliao on Jul 3 2019, 10:21 AM.

Details

Reviewers
arsenm
rampitec

Event Timeline

hliao created this revision.Jul 3 2019, 10:21 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 3 2019, 10:21 AM
hliao added a comment.Jul 3 2019, 10:21 AM

NumUserSGPRs and NumSystemSGPRs need updating during the parsing argument info.

arsenm added a comment.Jul 3 2019, 7:39 PM

Test? I’m also note sure we get much value by tracking these here. I don’t think they are accurate for shaders

hliao added a comment.Jul 4 2019, 11:29 AM

Test? I’m also note sure we get much value by tracking these here. I don’t think they are accurate for shaders

There are several places behaving slightly differently by checking getNumPreloadedSGPRs, which is the sum of NumUserSGPRs and NumSystemSGRPs. The test in https://reviews.llvm.org/D64145 relies on that to avoid assigning a preloaded register again.

hliao abandoned this revision.Thu, Jul 25, 6:34 AM