Page MenuHomePhabricator

[AMDGPU] Add the adjusted FP as a livein register.
ClosedPublic

Authored by hliao on Jul 3 2019, 10:26 AM.

Diff Detail

Event Timeline

hliao created this revision.Jul 3 2019, 10:26 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 3 2019, 10:26 AM
arsenm added inline comments.Jul 3 2019, 7:47 PM
llvm/test/CodeGen/AMDGPU/frame-lowering-fp-adjusted.mir
13

You can at least drop the attributes, and probably the whole IR section

26

Shouldn’t need so many stack objects?

hliao updated this revision to Diff 210088.Jul 16 2019, 6:45 AM

revise the test case

arsenm accepted this revision.Jul 16 2019, 8:46 AM

LGTM with nit

llvm/test/CodeGen/AMDGPU/frame-lowering-fp-adjusted.mir
13

These are the legacy attributes You should uses frame-pointer=all

This revision is now accepted and ready to land.Jul 16 2019, 8:46 AM
hliao added a comment.Jul 16 2019, 8:56 AM

LGTM with nit

Thanks!

This revision was automatically updated to reflect the committed changes.