I'm not familiar with the ExecutionEngine at all. A thorough review would be appreciated.
Also, it isn't clear to me how the tests verify functionality. Am I missing something?
Paths
| Differential D62881
[ExecutionEngine] Add UnaryOperator visitor to the interpreter ClosedPublic Authored by cameron.mcinally on Jun 4 2019, 2:46 PM.
Details Summary I'm not familiar with the ExecutionEngine at all. A thorough review would be appreciated. Also, it isn't clear to me how the tests verify functionality. Am I missing something?
Diff Detail Event TimelineThis revision is now accepted and ready to land.Jun 7 2019, 3:23 PM Closed by commit rL362941: [ExecutionEngine] Add UnaryOperator visitor to the interpreter (authored by mcinally). · Explain WhyJun 10 2019, 7:36 AM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 203618 llvm/lib/ExecutionEngine/Interpreter/Execution.cpp
llvm/lib/ExecutionEngine/Interpreter/Interpreter.h
llvm/test/ExecutionEngine/test-interp-vec-arithm_float.ll
|
Just move the string into the unreachable? Losing the instruction isn't a huge loss