[ExecutionEngine] Add UnaryOperator visitor to the interpreter

[cameron.mcinally]

Summary

I'm not familiar with the ExecutionEngine at all. A thorough review would be appreciated.

Also, it isn't clear to me how the tests verify functionality. Am I missing something?

[arsenm]

llvm/lib/ExecutionEngine/Interpreter/Execution.cpp

73–74

Just move the string into the unreachable? Losing the instruction isn't a huge loss

84–85

Ditto

92–93

Ditto

[cameron.mcinally]

Update llvm_unreachable strings...

[arsenm]

LGTM

llvm/lib/ExecutionEngine/Interpreter/Execution.cpp

 //                     Various Helper Functions
 //===----------------------------------------------------------------------===//
 
 static void SetValue(Value *V, GenericValue Val, ExecutionContext &SF) {
   SF.Values[V] = Val;
 }
 
 //===----------------------------------------------------------------------===//
+//                    Unary Instruction Implementations
+//===----------------------------------------------------------------------===//
+
+static void executeFNegInst(GenericValue &Dest, GenericValue Src, Type *Ty) {
+  switch (Ty->getTypeID()) {
+  case Type::FloatTyID:
+    Dest.FloatVal = -Src.FloatVal;
+  case Type::DoubleTyID:
+    Dest.DoubleVal = -Src.DoubleVal;
+  default:
+    dbgs() << "Unhandled type for FNeg instruction: " << *Ty << "\n";
+    llvm_unreachable(nullptr);
+  }
+}
+
+void Interpreter::visitUnaryOperator(UnaryOperator &I) {
+  ExecutionContext &SF = ECStack.back();
+  Type *Ty = I.getOperand(0)->getType();
+  GenericValue Src = getOperandValue(I.getOperand(0), SF);
+  GenericValue R; // Result
+
+  // First process vector operation
+  if (Ty->isVectorTy()) {
+    R.AggregateVal.resize(Src.AggregateVal.size());
+
+    switch(I.getOpcode()) {
+    default:
+      dbgs() << "Don't know how to handle this unary operator!\n-->" << I;
+      llvm_unreachable(nullptr);
+      break;
+    case Instruction::FNeg:
+      if (cast<VectorType>(Ty)->getElementType()->isFloatTy()) {
+        for (unsigned i = 0; i < R.AggregateVal.size(); ++i)
+          R.AggregateVal[i].FloatVal = -Src.AggregateVal[i].FloatVal;
+      } else if (cast<VectorType>(Ty)->getElementType()->isDoubleTy()) {
+        for (unsigned i = 0; i < R.AggregateVal.size(); ++i)
+          R.AggregateVal[i].DoubleVal = -Src.AggregateVal[i].DoubleVal;
+      } else {
+        dbgs() << "Unhandled type for OP instruction: " << *Ty << "\n";
+        llvm_unreachable(0);
+      }
+      break;
+    }
+  } else {
+    switch (I.getOpcode()) {
+    default:
+      dbgs() << "Don't know how to handle this unary operator!\n-->" << I;
+      llvm_unreachable(nullptr);
+      break;
+    case Instruction::FNeg: executeFNegInst(R, Src, Ty); break;
+    }
+  }
+  SetValue(&I, R, SF);
+}
+
+//===----------------------------------------------------------------------===//
 //                    Binary Instruction Implementations
 //===----------------------------------------------------------------------===//
 
 #define IMPLEMENT_BINARY_OPERATOR(OP, TY) \
    case Type::TY##TyID: \
      Dest.TY##Val = Src1.TY##Val OP Src2.TY##Val; \
      break
 

llvm/lib/ExecutionEngine/Interpreter/Interpreter.h

public:
   void run();                // Execute instructions until nothing left to do
 
   // Opcode Implementations
   void visitReturnInst(ReturnInst &I);
   void visitBranchInst(BranchInst &I);
   void visitSwitchInst(SwitchInst &I);
   void visitIndirectBrInst(IndirectBrInst &I);
 
+  void visitUnaryOperator(UnaryOperator &I);
   void visitBinaryOperator(BinaryOperator &I);
   void visitICmpInst(ICmpInst &I);
   void visitFCmpInst(FCmpInst &I);
   void visitAllocaInst(AllocaInst &I);
   void visitLoadInst(LoadInst &I);
   void visitStoreInst(StoreInst &I);
   void visitGetElementPtrInst(GetElementPtrInst &I);
   void visitPHINode(PHINode &PN) {

llvm/test/ExecutionEngine/test-interp-vec-arithm_float.ll

 ; RUN: %lli %s > /dev/null
 
 
 define i32 @main() {
 
     %A_float = fadd <4 x float> <float 0.0, float 11.0, float 22.0, float 33.0>, <float 44.0, float 55.0, float 66.0, float 77.0>
     %B_float = fsub <4 x float> %A_float, <float 88.0, float 99.0, float 100.0, float 111.0>
     %C_float = fmul <4 x float> %B_float, %B_float
     %D_float = fdiv <4 x float> %C_float, %B_float
     %E_float = frem <4 x float> %D_float, %A_float
+    %F_float = fneg <4 x float> %E_float
 
 
     %A_double = fadd <3 x double> <double 0.0, double 111.0, double 222.0>, <double 444.0, double 555.0, double 665.0>
     %B_double = fsub <3 x double> %A_double, <double 888.0, double 999.0, double 1001.0>
     %C_double = fmul <3 x double> %B_double, %B_double
     %D_double = fdiv <3 x double> %C_double, %B_double
     %E_double = frem <3 x double> %D_double, %A_double
+    %F_double = fneg <3 x double> %E_double
 
     ret i32 0
 }