Page MenuHomePhabricator

[ExecutionEngine] Add UnaryOperator visitor to the interpreter
ClosedPublic

Authored by cameron.mcinally on Jun 4 2019, 2:46 PM.

Details

Summary

I'm not familiar with the ExecutionEngine at all. A thorough review would be appreciated.

Also, it isn't clear to me how the tests verify functionality. Am I missing something?

Diff Detail

Repository
rL LLVM

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptJun 4 2019, 2:46 PM
arsenm added inline comments.Jun 7 2019, 1:36 PM
llvm/lib/ExecutionEngine/Interpreter/Execution.cpp
73–74 ↗(On Diff #203028)

Just move the string into the unreachable? Losing the instruction isn't a huge loss

84–85 ↗(On Diff #203028)

Ditto

92–93 ↗(On Diff #203028)

Ditto

Update llvm_unreachable strings...

arsenm accepted this revision.Jun 7 2019, 3:23 PM

LGTM

This revision is now accepted and ready to land.Jun 7 2019, 3:23 PM
This revision was automatically updated to reflect the committed changes.