This is an archive of the discontinued LLVM Phabricator instance.

[AArch64] check for INLINEASM_BR along w/ INLINEASM
ClosedPublic

Authored by nickdesaulniers on May 24 2019, 9:25 AM.

Details

Summary

It looks like since INLINEASM_BR was created off of INLINEASM, a few
checks for INLINEASM needed to be updated to check for either case.

pr/41999

Event Timeline

peter.smith accepted this revision.May 24 2019, 9:30 AM

LGTM. Unlike with the ARM constant pools, I've no idea how to write a test case to trigger an error here.

This revision is now accepted and ready to land.May 24 2019, 9:30 AM
This revision was automatically updated to reflect the committed changes.

There are two ways you could write a testcase: you could construct a test with an out of range "tbz" (if BranchRelaxation fails to trigger when it should), or you could write a testcase with a jump table entry that doesn't fit (if AArch64CompressJumpTables compresses a jump table too much).